René's URL Explorer Experiment


Title: fix: use sufficient computational effort for password hash by jsjoeio · Pull Request #3422 · coder/code-server · GitHub

Open Graph Title: fix: use sufficient computational effort for password hash by jsjoeio · Pull Request #3422 · coder/code-server

X Title: fix: use sufficient computational effort for password hash by jsjoeio · Pull Request #3422 · coder/code-server

Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.

Open Graph Description: This PR modifies the underlying algorithm used in the hash function to use sufficient computational effort. Changes refactor to use argon2 instead of sha256 add unit tests for hash and helper func...

X Description: This PR modifies the underlying algorithm used in the hash function to use sufficient computational effort. Changes refactor to use argon2 instead of sha256 add unit tests for hash and helper func...

Opengraph URL: https://github.com/coder/code-server/pull/3422

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:9c3e8621-ffdb-e575-a7fa-4a5ca50752fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8B2:E9D16:2485978:2E561ED:6B01BE6F
html-safe-nonce3296522c04a86d20486d752868652472a6b5701b4ac719b8ff19ddcc60a10077
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEIyOkU5RDE2OjI0ODU5Nzg6MkU1NjFFRDo2QjAxQkU2RiIsInZpc2l0b3JfaWQiOiI4NDI5NjQ1MTc3MzU3OTc1MTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7c49e2ba9acb0da2e7c7b2730859b3fe4dfd24446df1a7e535680d6cffb5d551
hovercard-subject-tagpull_request:647935273
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/coder/code-server/pull/3422/commits
twitter:imagehttps://opengraph.githubassets.com/7f6dcfff2c73407162eec3d2b2fcafed332c4cc2d5a6ef81b26774106bb6fca9/coder/code-server/pull/3422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f6dcfff2c73407162eec3d2b2fcafed332c4cc2d5a6ef81b26774106bb6fca9/coder/code-server/pull/3422
og:image:altThis PR modifies the underlying algorithm used in the hash function to use sufficient computational effort. Changes refactor to use argon2 instead of sha256 add unit tests for hash and helper func...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejsjoeio
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/coder/code-server/pull/3422/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F3422%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F3422%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/3422/commits
Reloadhttps://github.com/coder/code-server/pull/3422/commits
Reloadhttps://github.com/coder/code-server/pull/3422/commits
coderhttps://github.com/coder
code-serverhttps://github.com/coder/code-server
Codehttps://github.com/coder/code-server
Issues147 (147)https://github.com/coder/code-server/issues
Pull requests17 (17)https://github.com/coder/code-server/pulls
Discussionshttps://github.com/coder/code-server/discussions
Actionshttps://github.com/coder/code-server/actions
Projectshttps://github.com/coder/code-server/projects
Security and quality3 (3)https://github.com/coder/code-server/security
Insightshttps://github.com/coder/code-server/insights
https://github.com/coder/code-server
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/fix-password-hashhttps://github.com/coder/code-server/tree/jsjoeio/fix-password-hash
Conversationhttps://github.com/coder/code-server/pull/3422
Commits27 (27)https://github.com/coder/code-server/pull/3422/commits
Checkshttps://github.com/coder/code-server/pull/3422/checks
Files changedhttps://github.com/coder/code-server/pull/3422/files
fix: use sufficient computational effort for password hashhttps://github.com/coder/code-server/pull/3422/commits#top
jsjoeiohttps://github.com/jsjoeio
mainhttps://github.com/coder/code-server/tree/main
jsjoeio/fix-password-hashhttps://github.com/coder/code-server/tree/jsjoeio/fix-password-hash
chore: update CHANGELOGhttps://github.com/coder/code-server/pull/3422/commits/dd2cb1649a870e44c63f5fe3554517cae2192412
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
dd2cb16https://github.com/coder/code-server/pull/3422/commits/dd2cb1649a870e44c63f5fe3554517cae2192412
https://github.com/coder/code-server/tree/dd2cb1649a870e44c63f5fe3554517cae2192412
refactor: use bcrypt in hash functionhttps://github.com/coder/code-server/pull/3422/commits/cac667317ef03020130aa57ab88480a7ded09bdb
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
cac6673https://github.com/coder/code-server/pull/3422/commits/cac667317ef03020130aa57ab88480a7ded09bdb
https://github.com/coder/code-server/tree/cac667317ef03020130aa57ab88480a7ded09bdb
refactor: use bcrypt in e2e setuphttps://github.com/coder/code-server/pull/3422/commits/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
17be8c5https://github.com/coder/code-server/pull/3422/commits/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a
https://github.com/coder/code-server/tree/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a
feat: add unit test for hash functionhttps://github.com/coder/code-server/pull/3422/commits/f35120c0a346b2a85903fef35c78cab778846876
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
f35120chttps://github.com/coder/code-server/pull/3422/commits/f35120c0a346b2a85903fef35c78cab778846876
https://github.com/coder/code-server/tree/f35120c0a346b2a85903fef35c78cab778846876
refactor: add functions to check hash passwordhttps://github.com/coder/code-server/pull/3422/commits/aaf044728f6db2cbbad44d453c98dfc957dd4571
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
aaf0447https://github.com/coder/code-server/pull/3422/commits/aaf044728f6db2cbbad44d453c98dfc957dd4571
https://github.com/coder/code-server/tree/aaf044728f6db2cbbad44d453c98dfc957dd4571
feat: add tests using real hasheshttps://github.com/coder/code-server/pull/3422/commits/fc3326f1f2ce6cd2f176e941a3615128639f3ce4
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
fc3326fhttps://github.com/coder/code-server/pull/3422/commits/fc3326f1f2ce6cd2f176e941a3615128639f3ce4
https://github.com/coder/code-server/tree/fc3326f1f2ce6cd2f176e941a3615128639f3ce4
chore: add argon2 packagehttps://github.com/coder/code-server/pull/3422/commits/dc2db5c62d006432ae4ad161b2308ee4afab0dd4
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
dc2db5chttps://github.com/coder/code-server/pull/3422/commits/dc2db5c62d006432ae4ad161b2308ee4afab0dd4
https://github.com/coder/code-server/tree/dc2db5c62d006432ae4ad161b2308ee4afab0dd4
chore: update to argon2 in testhttps://github.com/coder/code-server/pull/3422/commits/51f8341959c1a6066ff6755602b9ae43dfba257a
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
51f8341https://github.com/coder/code-server/pull/3422/commits/51f8341959c1a6066ff6755602b9ae43dfba257a
https://github.com/coder/code-server/tree/51f8341959c1a6066ff6755602b9ae43dfba257a
refactor: use argon2 instead of bcrypthttps://github.com/coder/code-server/pull/3422/commits/70197bb2a514cd8dfc1115233c94b385aed9afa7
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
70197bbhttps://github.com/coder/code-server/pull/3422/commits/70197bb2a514cd8dfc1115233c94b385aed9afa7
https://github.com/coder/code-server/tree/70197bb2a514cd8dfc1115233c94b385aed9afa7
refactor: update unit tests for hash fnshttps://github.com/coder/code-server/pull/3422/commits/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
fd3cb6chttps://github.com/coder/code-server/pull/3422/commits/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a
https://github.com/coder/code-server/tree/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a
refactor: update login logic with new async hashinghttps://github.com/coder/code-server/pull/3422/commits/fcc3f0d951954159c711f79e145b6c0f973b8370
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
fcc3f0dhttps://github.com/coder/code-server/pull/3422/commits/fcc3f0d951954159c711f79e145b6c0f973b8370
https://github.com/coder/code-server/tree/fcc3f0d951954159c711f79e145b6c0f973b8370
refactor: make authenticated async everywherehttps://github.com/coder/code-server/pull/3422/commits/0cdbd33b46e8e0446450fe0d5121a75b53242e70
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
0cdbd33https://github.com/coder/code-server/pull/3422/commits/0cdbd33b46e8e0446450fe0d5121a75b53242e70
https://github.com/coder/code-server/tree/0cdbd33b46e8e0446450fe0d5121a75b53242e70
refactor: make ensureAuthenticated asynchttps://github.com/coder/code-server/pull/3422/commits/91303d4e40465a82f9652210992fd48b7e89b27d
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
91303d4https://github.com/coder/code-server/pull/3422/commits/91303d4e40465a82f9652210992fd48b7e89b27d
https://github.com/coder/code-server/tree/91303d4e40465a82f9652210992fd48b7e89b27d
refactor: make wsProxy asynchttps://github.com/coder/code-server/pull/3422/commits/1134780b8b89c96aa99a621008f06cafee8deda4
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
1134780https://github.com/coder/code-server/pull/3422/commits/1134780b8b89c96aa99a621008f06cafee8deda4
https://github.com/coder/code-server/tree/1134780b8b89c96aa99a621008f06cafee8deda4
refactor: update hash fn in test confighttps://github.com/coder/code-server/pull/3422/commits/788b958e200708348f575e5c8076a367c1133f6f
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
788b958https://github.com/coder/code-server/pull/3422/commits/788b958e200708348f575e5c8076a367c1133f6f
https://github.com/coder/code-server/tree/788b958e200708348f575e5c8076a367c1133f6f
feat: update cli and test for hashed-passwordhttps://github.com/coder/code-server/pull/3422/commits/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
ffa5c16https://github.com/coder/code-server/pull/3422/commits/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592
https://github.com/coder/code-server/tree/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592
feat: add getPasswordMethod & test for ithttps://github.com/coder/code-server/pull/3422/commits/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
7ff4117https://github.com/coder/code-server/pull/3422/commits/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0
https://github.com/coder/code-server/tree/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0
feat: add handlePasswordValidation + testshttps://github.com/coder/code-server/pull/3422/commits/a14ea39c4af09e322b0cd75c78068422919bb557
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
a14ea39https://github.com/coder/code-server/pull/3422/commits/a14ea39c4af09e322b0cd75c78068422919bb557
https://github.com/coder/code-server/tree/a14ea39c4af09e322b0cd75c78068422919bb557
refactor: rewrite password logic at /loginhttps://github.com/coder/code-server/pull/3422/commits/409b473c82e12cebc59bf6b1e34b1f432c46d5e6
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
409b473https://github.com/coder/code-server/pull/3422/commits/409b473c82e12cebc59bf6b1e34b1f432c46d5e6
https://github.com/coder/code-server/tree/409b473c82e12cebc59bf6b1e34b1f432c46d5e6
feat: add isCookieValid function and testshttps://github.com/coder/code-server/pull/3422/commits/6020480b308d359f6f6ee0b55038f6ef9e1bc673
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
6020480https://github.com/coder/code-server/pull/3422/commits/6020480b308d359f6f6ee0b55038f6ef9e1bc673
https://github.com/coder/code-server/tree/6020480b308d359f6f6ee0b55038f6ef9e1bc673
refactor: password logic in http w/ isCookieValidhttps://github.com/coder/code-server/pull/3422/commits/923761cd78cfb9de374691203bc3b325839d2d40
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
923761chttps://github.com/coder/code-server/pull/3422/commits/923761cd78cfb9de374691203bc3b325839d2d40
https://github.com/coder/code-server/tree/923761cd78cfb9de374691203bc3b325839d2d40
docs: update FAQ with new hashing instructionshttps://github.com/coder/code-server/pull/3422/commits/517aaf71c5f3fb377e6f9f047833eb027cb002d1
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
517aaf7https://github.com/coder/code-server/pull/3422/commits/517aaf71c5f3fb377e6f9f047833eb027cb002d1
https://github.com/coder/code-server/tree/517aaf71c5f3fb377e6f9f047833eb027cb002d1
feat: add splitOnFirstEquals functionhttps://github.com/coder/code-server/pull/3422/commits/531b7c0c257a2b97169eed7f602fc9b498db2bef
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
531b7c0https://github.com/coder/code-server/pull/3422/commits/531b7c0c257a2b97169eed7f602fc9b498db2bef
https://github.com/coder/code-server/tree/531b7c0c257a2b97169eed7f602fc9b498db2bef
refactor: parse options with multiple = in clihttps://github.com/coder/code-server/pull/3422/commits/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
8c2bb61https://github.com/coder/code-server/pull/3422/commits/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6
https://github.com/coder/code-server/tree/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6
feat: add npm_config_build_from_source to build scriptshttps://github.com/coder/code-server/pull/3422/commits/deaa2242caea82d5a125e9e3b67a4066ccb32b78
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
deaa224https://github.com/coder/code-server/pull/3422/commits/deaa2242caea82d5a125e9e3b67a4066ccb32b78
https://github.com/coder/code-server/tree/deaa2242caea82d5a125e9e3b67a4066ccb32b78
fix: sanitize password and cookie keyhttps://github.com/coder/code-server/pull/3422/commits/3b50bfc17d031661c83a0a029bdb22a7b391e7b0
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
3b50bfchttps://github.com/coder/code-server/pull/3422/commits/3b50bfc17d031661c83a0a029bdb22a7b391e7b0
https://github.com/coder/code-server/tree/3b50bfc17d031661c83a0a029bdb22a7b391e7b0
feat: check for empty str in isHashMatchhttps://github.com/coder/code-server/pull/3422/commits/1e55a648a5572e0985620032971f5cddeea10bbf
https://github.com/jsjoeio
jsjoeiohttps://github.com/coder/code-server/commits?author=jsjoeio
1e55a64https://github.com/coder/code-server/pull/3422/commits/1e55a648a5572e0985620032971f5cddeea10bbf
https://github.com/coder/code-server/tree/1e55a648a5572e0985620032971f5cddeea10bbf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.