| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:9c3e8621-ffdb-e575-a7fa-4a5ca50752fc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8B2:E9D16:2485978:2E561ED:6B01BE6F |
| html-safe-nonce | 3296522c04a86d20486d752868652472a6b5701b4ac719b8ff19ddcc60a10077 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEIyOkU5RDE2OjI0ODU5Nzg6MkU1NjFFRDo2QjAxQkU2RiIsInZpc2l0b3JfaWQiOiI4NDI5NjQ1MTc3MzU3OTc1MTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7c49e2ba9acb0da2e7c7b2730859b3fe4dfd24446df1a7e535680d6cffb5d551 |
| hovercard-subject-tag | pull_request:647935273 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/code-server/pull/3422/commits |
| twitter:image | https://opengraph.githubassets.com/7f6dcfff2c73407162eec3d2b2fcafed332c4cc2d5a6ef81b26774106bb6fca9/coder/code-server/pull/3422 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f6dcfff2c73407162eec3d2b2fcafed332c4cc2d5a6ef81b26774106bb6fca9/coder/code-server/pull/3422 |
| og:image:alt | This PR modifies the underlying algorithm used in the hash function to use sufficient computational effort.
Changes
refactor to use argon2 instead of sha256
add unit tests for hash and helper func... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jsjoeio |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/coder/code-server/pull/3422/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F3422%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F3422%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=coder%2Fcode-server |
| Reload | https://github.com/coder/code-server/pull/3422/commits |
| Reload | https://github.com/coder/code-server/pull/3422/commits |
| Reload | https://github.com/coder/code-server/pull/3422/commits |
| coder | https://github.com/coder |
| code-server | https://github.com/coder/code-server |
| Code | https://github.com/coder/code-server |
| Issues147 (147) | https://github.com/coder/code-server/issues |
| Pull requests17 (17) | https://github.com/coder/code-server/pulls |
| Discussions | https://github.com/coder/code-server/discussions |
| Actions | https://github.com/coder/code-server/actions |
| Projects | https://github.com/coder/code-server/projects |
| Security and quality3 (3) | https://github.com/coder/code-server/security |
| Insights | https://github.com/coder/code-server/insights |
| https://github.com/coder/code-server |
| jsjoeio | https://github.com/jsjoeio |
| main | https://github.com/coder/code-server/tree/main |
| jsjoeio/fix-password-hash | https://github.com/coder/code-server/tree/jsjoeio/fix-password-hash |
| Conversation | https://github.com/coder/code-server/pull/3422 |
| Commits27 (27) | https://github.com/coder/code-server/pull/3422/commits |
| Checks | https://github.com/coder/code-server/pull/3422/checks |
| Files changed | https://github.com/coder/code-server/pull/3422/files |
| fix: use sufficient computational effort for password hash | https://github.com/coder/code-server/pull/3422/commits#top |
| jsjoeio | https://github.com/jsjoeio |
| main | https://github.com/coder/code-server/tree/main |
| jsjoeio/fix-password-hash | https://github.com/coder/code-server/tree/jsjoeio/fix-password-hash |
| chore: update CHANGELOG | https://github.com/coder/code-server/pull/3422/commits/dd2cb1649a870e44c63f5fe3554517cae2192412 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| dd2cb16 | https://github.com/coder/code-server/pull/3422/commits/dd2cb1649a870e44c63f5fe3554517cae2192412 |
| https://github.com/coder/code-server/tree/dd2cb1649a870e44c63f5fe3554517cae2192412 |
| refactor: use bcrypt in hash function | https://github.com/coder/code-server/pull/3422/commits/cac667317ef03020130aa57ab88480a7ded09bdb |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| cac6673 | https://github.com/coder/code-server/pull/3422/commits/cac667317ef03020130aa57ab88480a7ded09bdb |
| https://github.com/coder/code-server/tree/cac667317ef03020130aa57ab88480a7ded09bdb |
| refactor: use bcrypt in e2e setup | https://github.com/coder/code-server/pull/3422/commits/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 17be8c5 | https://github.com/coder/code-server/pull/3422/commits/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a |
| https://github.com/coder/code-server/tree/17be8c5cd31c2ee036aadeeaf4cc19823c6f832a |
| feat: add unit test for hash function | https://github.com/coder/code-server/pull/3422/commits/f35120c0a346b2a85903fef35c78cab778846876 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| f35120c | https://github.com/coder/code-server/pull/3422/commits/f35120c0a346b2a85903fef35c78cab778846876 |
| https://github.com/coder/code-server/tree/f35120c0a346b2a85903fef35c78cab778846876 |
| refactor: add functions to check hash password | https://github.com/coder/code-server/pull/3422/commits/aaf044728f6db2cbbad44d453c98dfc957dd4571 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| aaf0447 | https://github.com/coder/code-server/pull/3422/commits/aaf044728f6db2cbbad44d453c98dfc957dd4571 |
| https://github.com/coder/code-server/tree/aaf044728f6db2cbbad44d453c98dfc957dd4571 |
| feat: add tests using real hashes | https://github.com/coder/code-server/pull/3422/commits/fc3326f1f2ce6cd2f176e941a3615128639f3ce4 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| fc3326f | https://github.com/coder/code-server/pull/3422/commits/fc3326f1f2ce6cd2f176e941a3615128639f3ce4 |
| https://github.com/coder/code-server/tree/fc3326f1f2ce6cd2f176e941a3615128639f3ce4 |
| chore: add argon2 package | https://github.com/coder/code-server/pull/3422/commits/dc2db5c62d006432ae4ad161b2308ee4afab0dd4 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| dc2db5c | https://github.com/coder/code-server/pull/3422/commits/dc2db5c62d006432ae4ad161b2308ee4afab0dd4 |
| https://github.com/coder/code-server/tree/dc2db5c62d006432ae4ad161b2308ee4afab0dd4 |
| chore: update to argon2 in test | https://github.com/coder/code-server/pull/3422/commits/51f8341959c1a6066ff6755602b9ae43dfba257a |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 51f8341 | https://github.com/coder/code-server/pull/3422/commits/51f8341959c1a6066ff6755602b9ae43dfba257a |
| https://github.com/coder/code-server/tree/51f8341959c1a6066ff6755602b9ae43dfba257a |
| refactor: use argon2 instead of bcrypt | https://github.com/coder/code-server/pull/3422/commits/70197bb2a514cd8dfc1115233c94b385aed9afa7 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 70197bb | https://github.com/coder/code-server/pull/3422/commits/70197bb2a514cd8dfc1115233c94b385aed9afa7 |
| https://github.com/coder/code-server/tree/70197bb2a514cd8dfc1115233c94b385aed9afa7 |
| refactor: update unit tests for hash fns | https://github.com/coder/code-server/pull/3422/commits/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| fd3cb6c | https://github.com/coder/code-server/pull/3422/commits/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a |
| https://github.com/coder/code-server/tree/fd3cb6cfa028b63c0e3600ce1283f8316cfad15a |
| refactor: update login logic with new async hashing | https://github.com/coder/code-server/pull/3422/commits/fcc3f0d951954159c711f79e145b6c0f973b8370 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| fcc3f0d | https://github.com/coder/code-server/pull/3422/commits/fcc3f0d951954159c711f79e145b6c0f973b8370 |
| https://github.com/coder/code-server/tree/fcc3f0d951954159c711f79e145b6c0f973b8370 |
| refactor: make authenticated async everywhere | https://github.com/coder/code-server/pull/3422/commits/0cdbd33b46e8e0446450fe0d5121a75b53242e70 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 0cdbd33 | https://github.com/coder/code-server/pull/3422/commits/0cdbd33b46e8e0446450fe0d5121a75b53242e70 |
| https://github.com/coder/code-server/tree/0cdbd33b46e8e0446450fe0d5121a75b53242e70 |
| refactor: make ensureAuthenticated async | https://github.com/coder/code-server/pull/3422/commits/91303d4e40465a82f9652210992fd48b7e89b27d |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 91303d4 | https://github.com/coder/code-server/pull/3422/commits/91303d4e40465a82f9652210992fd48b7e89b27d |
| https://github.com/coder/code-server/tree/91303d4e40465a82f9652210992fd48b7e89b27d |
| refactor: make wsProxy async | https://github.com/coder/code-server/pull/3422/commits/1134780b8b89c96aa99a621008f06cafee8deda4 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 1134780 | https://github.com/coder/code-server/pull/3422/commits/1134780b8b89c96aa99a621008f06cafee8deda4 |
| https://github.com/coder/code-server/tree/1134780b8b89c96aa99a621008f06cafee8deda4 |
| refactor: update hash fn in test config | https://github.com/coder/code-server/pull/3422/commits/788b958e200708348f575e5c8076a367c1133f6f |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 788b958 | https://github.com/coder/code-server/pull/3422/commits/788b958e200708348f575e5c8076a367c1133f6f |
| https://github.com/coder/code-server/tree/788b958e200708348f575e5c8076a367c1133f6f |
| feat: update cli and test for hashed-password | https://github.com/coder/code-server/pull/3422/commits/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| ffa5c16 | https://github.com/coder/code-server/pull/3422/commits/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592 |
| https://github.com/coder/code-server/tree/ffa5c16e51a5e1096d8e0a530d97edd12d8f8592 |
| feat: add getPasswordMethod & test for it | https://github.com/coder/code-server/pull/3422/commits/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 7ff4117 | https://github.com/coder/code-server/pull/3422/commits/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0 |
| https://github.com/coder/code-server/tree/7ff4117531fb2f8030e5f0e6d78fdb8f7dd2f7b0 |
| feat: add handlePasswordValidation + tests | https://github.com/coder/code-server/pull/3422/commits/a14ea39c4af09e322b0cd75c78068422919bb557 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| a14ea39 | https://github.com/coder/code-server/pull/3422/commits/a14ea39c4af09e322b0cd75c78068422919bb557 |
| https://github.com/coder/code-server/tree/a14ea39c4af09e322b0cd75c78068422919bb557 |
| refactor: rewrite password logic at /login | https://github.com/coder/code-server/pull/3422/commits/409b473c82e12cebc59bf6b1e34b1f432c46d5e6 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 409b473 | https://github.com/coder/code-server/pull/3422/commits/409b473c82e12cebc59bf6b1e34b1f432c46d5e6 |
| https://github.com/coder/code-server/tree/409b473c82e12cebc59bf6b1e34b1f432c46d5e6 |
| feat: add isCookieValid function and tests | https://github.com/coder/code-server/pull/3422/commits/6020480b308d359f6f6ee0b55038f6ef9e1bc673 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 6020480 | https://github.com/coder/code-server/pull/3422/commits/6020480b308d359f6f6ee0b55038f6ef9e1bc673 |
| https://github.com/coder/code-server/tree/6020480b308d359f6f6ee0b55038f6ef9e1bc673 |
| refactor: password logic in http w/ isCookieValid | https://github.com/coder/code-server/pull/3422/commits/923761cd78cfb9de374691203bc3b325839d2d40 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 923761c | https://github.com/coder/code-server/pull/3422/commits/923761cd78cfb9de374691203bc3b325839d2d40 |
| https://github.com/coder/code-server/tree/923761cd78cfb9de374691203bc3b325839d2d40 |
| docs: update FAQ with new hashing instructions | https://github.com/coder/code-server/pull/3422/commits/517aaf71c5f3fb377e6f9f047833eb027cb002d1 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 517aaf7 | https://github.com/coder/code-server/pull/3422/commits/517aaf71c5f3fb377e6f9f047833eb027cb002d1 |
| https://github.com/coder/code-server/tree/517aaf71c5f3fb377e6f9f047833eb027cb002d1 |
| feat: add splitOnFirstEquals function | https://github.com/coder/code-server/pull/3422/commits/531b7c0c257a2b97169eed7f602fc9b498db2bef |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 531b7c0 | https://github.com/coder/code-server/pull/3422/commits/531b7c0c257a2b97169eed7f602fc9b498db2bef |
| https://github.com/coder/code-server/tree/531b7c0c257a2b97169eed7f602fc9b498db2bef |
| refactor: parse options with multiple = in cli | https://github.com/coder/code-server/pull/3422/commits/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 8c2bb61 | https://github.com/coder/code-server/pull/3422/commits/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6 |
| https://github.com/coder/code-server/tree/8c2bb61af9ef3c7e6824a1f12e6ffbb815118bb6 |
| feat: add npm_config_build_from_source to build scripts | https://github.com/coder/code-server/pull/3422/commits/deaa2242caea82d5a125e9e3b67a4066ccb32b78 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| deaa224 | https://github.com/coder/code-server/pull/3422/commits/deaa2242caea82d5a125e9e3b67a4066ccb32b78 |
| https://github.com/coder/code-server/tree/deaa2242caea82d5a125e9e3b67a4066ccb32b78 |
| fix: sanitize password and cookie key | https://github.com/coder/code-server/pull/3422/commits/3b50bfc17d031661c83a0a029bdb22a7b391e7b0 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 3b50bfc | https://github.com/coder/code-server/pull/3422/commits/3b50bfc17d031661c83a0a029bdb22a7b391e7b0 |
| https://github.com/coder/code-server/tree/3b50bfc17d031661c83a0a029bdb22a7b391e7b0 |
| feat: check for empty str in isHashMatch | https://github.com/coder/code-server/pull/3422/commits/1e55a648a5572e0985620032971f5cddeea10bbf |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/coder/code-server/commits?author=jsjoeio |
| 1e55a64 | https://github.com/coder/code-server/pull/3422/commits/1e55a648a5572e0985620032971f5cddeea10bbf |
| https://github.com/coder/code-server/tree/1e55a648a5572e0985620032971f5cddeea10bbf |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |