| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d6414ea9-17af-27d7-d850-48d7e785785f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA04:11DFBA:1BE13E3:2334E30:6991808C |
| html-safe-nonce | 4aa8d8ff901cc1ca3b0107acf4674cb2039a6a4ad7bbe34b7f31ed170bf5c20a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTA0OjExREZCQToxQkUxM0UzOjIzMzRFMzA6Njk5MTgwOEMiLCJ2aXNpdG9yX2lkIjoiMjU5ODE0NTgzMjE3Njk0MzI0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aef38c042e5a5e7a0aa589bb0f2034a85847720d520f32381239a823491dc1a3 |
| hovercard-subject-tag | pull_request:572193967 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/code-server/2719/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2e149cbbaa52908cea3f55f975f17bcc39226cc4b7b15bb4e6b25b271913d31f/coder/code-server/pull/2719 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2e149cbbaa52908cea3f55f975f17bcc39226cc4b7b15bb4e6b25b271913d31f/coder/code-server/pull/2719 |
| og:image:alt | This PR adds a few tests for src/browser/register.ts.
Screenshot
It increases our code coverage (Lines) from 50.09% to 51.13% (↑ 1.04%).
🟩 100% Line coverage (last 100) for src/browser/register.ts... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jsjoeio |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/coder/code-server/pull/2719#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2719 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2719 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcode-server |
| Reload | https://github.com/coder/code-server/pull/2719 |
| Reload | https://github.com/coder/code-server/pull/2719 |
| Reload | https://github.com/coder/code-server/pull/2719 |
|
coder
| https://github.com/coder |
| code-server | https://github.com/coder/code-server |
|
Notifications
| https://github.com/login?return_to=%2Fcoder%2Fcode-server |
|
Fork
6.5k
| https://github.com/login?return_to=%2Fcoder%2Fcode-server |
|
Star
76.2k
| https://github.com/login?return_to=%2Fcoder%2Fcode-server |
|
Code
| https://github.com/coder/code-server |
|
Issues
167
| https://github.com/coder/code-server/issues |
|
Pull requests
8
| https://github.com/coder/code-server/pulls |
|
Discussions
| https://github.com/coder/code-server/discussions |
|
Actions
| https://github.com/coder/code-server/actions |
|
Projects
0
| https://github.com/coder/code-server/projects |
|
Security
1
| https://github.com/coder/code-server/security |
|
Insights
| https://github.com/coder/code-server/pulse |
|
Code
| https://github.com/coder/code-server |
|
Issues
| https://github.com/coder/code-server/issues |
|
Pull requests
| https://github.com/coder/code-server/pulls |
|
Discussions
| https://github.com/coder/code-server/discussions |
|
Actions
| https://github.com/coder/code-server/actions |
|
Projects
| https://github.com/coder/code-server/projects |
|
Security
| https://github.com/coder/code-server/security |
|
Insights
| https://github.com/coder/code-server/pulse |
| jsjoeio | https://github.com/jsjoeio |
| master | https://github.com/coder/code-server/tree/master |
| add-tests-register | https://github.com/coder/code-server/tree/add-tests-register |
| Conversation | https://github.com/coder/code-server/pull/2719 |
| Commits22 (22) | https://github.com/coder/code-server/pull/2719/commits |
| Checks | https://github.com/coder/code-server/pull/2719/checks |
| Files changed | https://github.com/coder/code-server/pull/2719/files |
| feat(testing): add unit tests for register | https://github.com/coder/code-server/pull/2719#top |
| jsjoeio | https://github.com/jsjoeio |
| master | https://github.com/coder/code-server/tree/master |
| add-tests-register | https://github.com/coder/code-server/tree/add-tests-register |
|
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| Feb 12, 2021 | https://github.com/coder/code-server/pull/2719#issue-806843084 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://user-images.githubusercontent.com/3806031/108921893-d40c2300-75f3-11eb-9887-358e2763f771.png |
| https://user-images.githubusercontent.com/3806031/108921721-c9518e00-75f3-11eb-8010-f57eb4f84e53.png |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| v3.8.2 | https://github.com/coder/code-server/milestone/16 |
| Feb 12, 2021 | https://github.com/coder/code-server/pull/2719#event-4322563161 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| Feb 12, 2021 | https://github.com/coder/code-server/pull/2719#event-4322563166 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 12, 2021 00:04 | https://github.com/coder/code-server/pull/2719#event-4322563975 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| code-asher | https://github.com/code-asher |
| oxy | https://github.com/oxy |
| February 12, 2021 00:04 | https://github.com/coder/code-server/pull/2719#event-4322564392 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 12, 2021 16:43 | https://github.com/coder/code-server/pull/2719#event-4325691664 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/fd91ae2f989e1cc7e3719322f51f3ec50eca1b57..6996c4582a9d3fc25071b056562b6a6dbce7f223 |
| fd91ae2 | https://github.com/coder/code-server/commit/fd91ae2f989e1cc7e3719322f51f3ec50eca1b57 |
| 6996c45 | https://github.com/coder/code-server/commit/6996c4582a9d3fc25071b056562b6a6dbce7f223 |
|
Compare
| https://github.com/coder/code-server/compare/fd91ae2f989e1cc7e3719322f51f3ec50eca1b57..6996c4582a9d3fc25071b056562b6a6dbce7f223 |
| February 12, 2021 17:09 | https://github.com/coder/code-server/pull/2719#event-4325804357 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 12, 2021 17:10 | https://github.com/coder/code-server/pull/2719#event-4325806011 |
| https://github.com/oxy |
| oxy | https://github.com/oxy |
|
Feb 12, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-589796094 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| oxy | https://github.com/oxy |
| https://github.com/coder/code-server/pull/2719#pullrequestreview-589796094 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| Feb 12, 2021 | https://github.com/coder/code-server/pull/2719#issuecomment-778460181 |
| @code-asher | https://github.com/code-asher |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| v3.9.0 | https://github.com/coder/code-server/milestone/16 |
| v3.9.1 | https://github.com/coder/code-server/milestone/17 |
| Feb 12, 2021 | https://github.com/coder/code-server/pull/2719#event-4326763716 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
|
Feb 18, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-593460252 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| test/util.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-7aca83012b206780c7a11ab5aa96f9282ea3f4677763e664a94836a97fb78219 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| src/browser/register.ts | https://github.com/coder/code-server/pull/2719/files#diff-ebd4e7a6424ac5b61162011fbde458a35e6da5c5df5ea689f299f89f18e29388 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| src/browser/register.ts | https://github.com/coder/code-server/pull/2719/files#diff-ebd4e7a6424ac5b61162011fbde458a35e6da5c5df5ea689f299f89f18e29388 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| package.json | https://github.com/coder/code-server/pull/2719/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
|
Feb 18, 2021
| https://github.com/coder/code-server/pull/2719#ref-issue-805858995 |
|
☂️ [Roadmap]: Improve Testing
#2712
| https://github.com/coder/code-server/issues/2712 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/6996c4582a9d3fc25071b056562b6a6dbce7f223..ecadf6ce0edfa2ee93987bc86560f6647c8329cb |
| 6996c45 | https://github.com/coder/code-server/commit/6996c4582a9d3fc25071b056562b6a6dbce7f223 |
| ecadf6c | https://github.com/coder/code-server/commit/ecadf6ce0edfa2ee93987bc86560f6647c8329cb |
|
Compare
| https://github.com/coder/code-server/compare/6996c4582a9d3fc25071b056562b6a6dbce7f223..ecadf6ce0edfa2ee93987bc86560f6647c8329cb |
| February 18, 2021 18:32 | https://github.com/coder/code-server/pull/2719#event-4348321188 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 18, 2021 22:17 | https://github.com/coder/code-server/pull/2719#event-4349198592 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/1896154a254158a5f04ec237d2e25e05bd9f2fa8..5e287ad9d3d93bbae6dd47a30bab4681dddffb4d |
| 1896154 | https://github.com/coder/code-server/commit/1896154a254158a5f04ec237d2e25e05bd9f2fa8 |
| 5e287ad | https://github.com/coder/code-server/commit/5e287ad9d3d93bbae6dd47a30bab4681dddffb4d |
|
Compare
| https://github.com/coder/code-server/compare/1896154a254158a5f04ec237d2e25e05bd9f2fa8..5e287ad9d3d93bbae6dd47a30bab4681dddffb4d |
| February 18, 2021 23:56 | https://github.com/coder/code-server/pull/2719#event-4349517643 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 18, 2021 23:57 | https://github.com/coder/code-server/pull/2719#event-4349518730 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
|
Feb 22, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-595550533 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| src/browser/register.ts | https://github.com/coder/code-server/pull/2719/files#diff-ebd4e7a6424ac5b61162011fbde458a35e6da5c5df5ea689f299f89f18e29388 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/emitter.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-306eb96c9205e304ffa933a5bd055bd659058e3020800e2ac3a160156950fc91 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/register.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-2ad435b7e6ce20c01c31588d7b1bc9740600bde8f17e5683af22c7dbf68d0601 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/register.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-2ad435b7e6ce20c01c31588d7b1bc9740600bde8f17e5683af22c7dbf68d0601 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/register.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-2ad435b7e6ce20c01c31588d7b1bc9740600bde8f17e5683af22c7dbf68d0601 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| src/browser/register.ts | https://github.com/coder/code-server/pull/2719/files#diff-ebd4e7a6424ac5b61162011fbde458a35e6da5c5df5ea689f299f89f18e29388 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 22, 2021 17:38 | https://github.com/coder/code-server/pull/2719#event-4361026879 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/5e287ad9d3d93bbae6dd47a30bab4681dddffb4d..325a1d8181415459a3531745bae43446252498a7 |
| 5e287ad | https://github.com/coder/code-server/commit/5e287ad9d3d93bbae6dd47a30bab4681dddffb4d |
| 325a1d8 | https://github.com/coder/code-server/commit/325a1d8181415459a3531745bae43446252498a7 |
|
Compare
| https://github.com/coder/code-server/compare/5e287ad9d3d93bbae6dd47a30bab4681dddffb4d..325a1d8181415459a3531745bae43446252498a7 |
| February 22, 2021 20:44 | https://github.com/coder/code-server/pull/2719#event-4361840867 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/3233608293999fa05e596fe20c779dc0d30d2027..3eceb07159d1990200a6b601722de1fe2be9fd6c |
| 3233608 | https://github.com/coder/code-server/commit/3233608293999fa05e596fe20c779dc0d30d2027 |
| 3eceb07 | https://github.com/coder/code-server/commit/3eceb07159d1990200a6b601722de1fe2be9fd6c |
|
Compare
| https://github.com/coder/code-server/compare/3233608293999fa05e596fe20c779dc0d30d2027..3eceb07159d1990200a6b601722de1fe2be9fd6c |
| February 22, 2021 20:47 | https://github.com/coder/code-server/pull/2719#event-4361852552 |
| February 23, 2021 17:02 | https://github.com/coder/code-server/pull/2719#event-4366326013 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/14ad29a221f66e9569a4703b3d5344dbc37e6741..909d4254e21bacf1d6971357a2c8072bce73e624 |
| 14ad29a | https://github.com/coder/code-server/commit/14ad29a221f66e9569a4703b3d5344dbc37e6741 |
| 909d425 | https://github.com/coder/code-server/commit/909d4254e21bacf1d6971357a2c8072bce73e624 |
|
Compare
| https://github.com/coder/code-server/compare/14ad29a221f66e9569a4703b3d5344dbc37e6741..909d4254e21bacf1d6971357a2c8072bce73e624 |
| February 23, 2021 23:03 | https://github.com/coder/code-server/pull/2719#event-4367828117 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 23, 2021 23:27 | https://github.com/coder/code-server/pull/2719#event-4367902929 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/9e59e786dea86f24b8c3c832fcf6c727ee10637d..294b3d3cd1b6af68def324b7f8df6772807b63dc |
| 9e59e78 | https://github.com/coder/code-server/commit/9e59e786dea86f24b8c3c832fcf6c727ee10637d |
| 294b3d3 | https://github.com/coder/code-server/commit/294b3d3cd1b6af68def324b7f8df6772807b63dc |
|
Compare
| https://github.com/coder/code-server/compare/9e59e786dea86f24b8c3c832fcf6c727ee10637d..294b3d3cd1b6af68def324b7f8df6772807b63dc |
| February 23, 2021 23:28 | https://github.com/coder/code-server/pull/2719#event-4367906665 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
|
Feb 23, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-596897515 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| test/helpers.ts | https://github.com/coder/code-server/pull/2719/files#diff-e3f0df6a33fd6a2082695b9931fab724c841271a073b54fbe69aabe54d54fb52 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/register.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-2ad435b7e6ce20c01c31588d7b1bc9740600bde8f17e5683af22c7dbf68d0601 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| code-asher | https://github.com/code-asher |
| February 23, 2021 23:31 | https://github.com/coder/code-server/pull/2719#event-4367919635 |
| jsjoeio | https://github.com/jsjoeio |
| February 26, 2021 11:51 | https://github.com/coder/code-server/pull/2719#commits-pushed-06aeca0 |
|
| https://github.com/jsjoeio |
| feat(testing): add register test | https://github.com/coder/code-server/pull/2719/commits/06aeca0a83b67a96f4f6c6b44c9c23c84d1876e3 |
| 06aeca0 | https://github.com/coder/code-server/pull/2719/commits/06aeca0a83b67a96f4f6c6b44c9c23c84d1876e3 |
|
| https://github.com/jsjoeio |
| refactor: use logger in serviceworker | https://github.com/coder/code-server/pull/2719/commits/a9f88affa98642ab611340b0517d7ee1c18d264a |
| a9f88af | https://github.com/coder/code-server/pull/2719/commits/a9f88affa98642ab611340b0517d7ee1c18d264a |
|
| https://github.com/jsjoeio |
| feat: test failure to register service worker | https://github.com/coder/code-server/pull/2719/commits/44b9874fbe19caa9ef8e546dd6624c67794b1d8e |
| 44b9874 | https://github.com/coder/code-server/pull/2719/commits/44b9874fbe19caa9ef8e546dd6624c67794b1d8e |
|
| https://github.com/jsjoeio |
| refactor: add handleRegisterServiceWorker fn | https://github.com/coder/code-server/pull/2719/commits/21f577d471e3e90785b45ae5b02521214493e48e |
| 21f577d | https://github.com/coder/code-server/pull/2719/commits/21f577d471e3e90785b45ae5b02521214493e48e |
|
| https://github.com/jsjoeio |
| feat(test): add test handleRegisterServiceWorker | https://github.com/coder/code-server/pull/2719/commits/38891de0d9e9b4962a9beb949faa9369e55d395c |
| 38891de | https://github.com/coder/code-server/pull/2719/commits/38891de0d9e9b4962a9beb949faa9369e55d395c |
|
| https://github.com/jsjoeio |
| refactor(register): use logError instead of logger | https://github.com/coder/code-server/pull/2719/commits/7ef630f7a48d16bc9f2bef0f83bc2587d310926f |
| 7ef630f | https://github.com/coder/code-server/pull/2719/commits/7ef630f7a48d16bc9f2bef0f83bc2587d310926f |
|
| https://github.com/jsjoeio |
| refactor: use same syntax as logger spy | https://github.com/coder/code-server/pull/2719/commits/a44a51462cad9919d59393549dca60199d29f972 |
| a44a514 | https://github.com/coder/code-server/pull/2719/commits/a44a51462cad9919d59393549dca60199d29f972 |
|
| https://github.com/jsjoeio |
| refactor: use LogModule from Asher in tests | https://github.com/coder/code-server/pull/2719/commits/027e8e5adfa973b1986df50b8aaef07b0b45b99d |
| 027e8e5 | https://github.com/coder/code-server/pull/2719/commits/027e8e5adfa973b1986df50b8aaef07b0b45b99d |
|
| https://github.com/jsjoeio |
| refactor: move loggerModule into helpers | https://github.com/coder/code-server/pull/2719/commits/711abd8d840e40c19e9ca5ba1cb8996c4ce2f6e7 |
| 711abd8 | https://github.com/coder/code-server/pull/2719/commits/711abd8d840e40c19e9ca5ba1cb8996c4ce2f6e7 |
|
| https://github.com/jsjoeio |
| refactor: dont use actual logger in helper | https://github.com/coder/code-server/pull/2719/commits/1470ff203a53d9f9b20f916424c4c038ea577009 |
| 1470ff2 | https://github.com/coder/code-server/pull/2719/commits/1470ff203a53d9f9b20f916424c4c038ea577009 |
|
| https://github.com/jsjoeio |
| refactor: hoist jest.mock in constants | https://github.com/coder/code-server/pull/2719/commits/1c737f1f938871e37fbc34450d2dcc0f36336e94 |
| 1c737f1 | https://github.com/coder/code-server/pull/2719/commits/1c737f1f938871e37fbc34450d2dcc0f36336e94 |
|
| https://github.com/jsjoeio |
| refactor: use loggerModule in util | https://github.com/coder/code-server/pull/2719/commits/cb4185b360af0058e3730d9b502f7db5b605247c |
| cb4185b | https://github.com/coder/code-server/pull/2719/commits/cb4185b360af0058e3730d9b502f7db5b605247c |
|
| https://github.com/jsjoeio |
| refactor: update mocking logger in register test | https://github.com/coder/code-server/pull/2719/commits/e6a324b48410b33471fc874f97efa85cd7380c57 |
| e6a324b | https://github.com/coder/code-server/pull/2719/commits/e6a324b48410b33471fc874f97efa85cd7380c57 |
|
| https://github.com/jsjoeio |
| feat(register): add test when navigator undefined | https://github.com/coder/code-server/pull/2719/commits/b232dcbd4a2bd38d2515ad12fbbd3863ac2b172b |
| b232dcb | https://github.com/coder/code-server/pull/2719/commits/b232dcbd4a2bd38d2515ad12fbbd3863ac2b172b |
|
| https://github.com/jsjoeio |
| feat: add test for catching errors in Emitter | https://github.com/coder/code-server/pull/2719/commits/80a180079e47c6c0b28a95d2b33e677a640bea77 |
| 80a1800 | https://github.com/coder/code-server/pull/2719/commits/80a180079e47c6c0b28a95d2b33e677a640bea77 |
|
| https://github.com/jsjoeio |
| chore(testing): add service-worker-mock | https://github.com/coder/code-server/pull/2719/commits/46226ea26b1d9bfb2d46cc982fb1b1d0d0f0d3a9 |
| 46226ea | https://github.com/coder/code-server/pull/2719/commits/46226ea26b1d9bfb2d46cc982fb1b1d0d0f0d3a9 |
|
| https://github.com/jsjoeio |
| feat: add logs to serviceWorker | https://github.com/coder/code-server/pull/2719/commits/ee0973c05a545bc1495aed63727d453f8b81e7c1 |
| ee0973c | https://github.com/coder/code-server/pull/2719/commits/ee0973c05a545bc1495aed63727d453f8b81e7c1 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/54ea107ba34927fec1272ceb863c5b80aec142e1..41d0794112c8feb9826968692fcfc3f41819518a |
| 54ea107 | https://github.com/coder/code-server/commit/54ea107ba34927fec1272ceb863c5b80aec142e1 |
| 41d0794 | https://github.com/coder/code-server/commit/41d0794112c8feb9826968692fcfc3f41819518a |
|
Compare
| https://github.com/coder/code-server/compare/54ea107ba34927fec1272ceb863c5b80aec142e1..41d0794112c8feb9826968692fcfc3f41819518a |
| February 26, 2021 19:04 | https://github.com/coder/code-server/pull/2719#event-4383331263 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| code owner | https://github.com/coder/code-server/blob/63733c31e95fe587243840386dfdb3f13ead7fb2/.github/CODEOWNERS#L1 |
| February 26, 2021 19:04 | https://github.com/coder/code-server/pull/2719#event-4383331268 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
|
Feb 26, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-599881639 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| test/emitter.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-306eb96c9205e304ffa933a5bd055bd659058e3020800e2ac3a160156950fc91 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
|
| https://github.com/jsjoeio |
| feat(testing): add serviceWorker tests | https://github.com/coder/code-server/pull/2719/commits/6b56e6572d028eecf7d10d8b7293b1185518e912 |
| 6b56e65 | https://github.com/coder/code-server/pull/2719/commits/6b56e6572d028eecf7d10d8b7293b1185518e912 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/41d0794112c8feb9826968692fcfc3f41819518a..66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab |
| 41d0794 | https://github.com/coder/code-server/commit/41d0794112c8feb9826968692fcfc3f41819518a |
| 66bb010 | https://github.com/coder/code-server/commit/66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab |
|
Compare
| https://github.com/coder/code-server/compare/41d0794112c8feb9826968692fcfc3f41819518a..66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab |
| February 26, 2021 23:00 | https://github.com/coder/code-server/pull/2719#event-4384123365 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| code-asher | https://github.com/code-asher |
| February 26, 2021 23:00 | https://github.com/coder/code-server/pull/2719#event-4384124141 |
| https://github.com/code-asher |
| code-asher | https://github.com/code-asher |
|
Feb 26, 2021
| https://github.com/coder/code-server/pull/2719#pullrequestreview-600015734 |
|
View reviewed changes
| https://github.com/coder/code-server/pull/2719/files |
| code-asher | https://github.com/code-asher |
| https://github.com/coder/code-server/pull/2719#pullrequestreview-600015734 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| test/register.test.ts | https://github.com/coder/code-server/pull/2719/files#diff-2ad435b7e6ce20c01c31588d7b1bc9740600bde8f17e5683af22c7dbf68d0601 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
|
| https://github.com/jsjoeio |
| refactor: add custom mock for serviceWorker test | https://github.com/coder/code-server/pull/2719/commits/8c14799797f3ef67bbececccb0de15c527ce27cf |
| 8c14799 | https://github.com/coder/code-server/pull/2719/commits/8c14799797f3ef67bbececccb0de15c527ce27cf |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| force-pushed | https://github.com/coder/code-server/compare/66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab..8c14799797f3ef67bbececccb0de15c527ce27cf |
| 66bb010 | https://github.com/coder/code-server/commit/66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab |
| 8c14799 | https://github.com/coder/code-server/commit/8c14799797f3ef67bbececccb0de15c527ce27cf |
|
Compare
| https://github.com/coder/code-server/compare/66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab..8c14799797f3ef67bbececccb0de15c527ce27cf |
| February 26, 2021 23:05 | https://github.com/coder/code-server/pull/2719#event-4384143782 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| Feb 26, 2021 | https://github.com/coder/code-server/pull/2719#issuecomment-786953483 |
| #2480 | https://github.com/coder/code-server/issues/2480 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| 726f694 | https://github.com/coder/code-server/commit/726f694268407b46a3df803c356250690f11aadf |
| Feb 26, 2021 | https://github.com/coder/code-server/pull/2719#event-4384231648 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
| February 26, 2021 23:47 | https://github.com/coder/code-server/pull/2719#event-4384231681 |
| https://github.com/jsjoeio |
| jsjoeio | https://github.com/jsjoeio |
|
testing
| https://github.com/coder/code-server/issues?q=state%3Aopen%20label%3Atesting |
| May 14, 2021 | https://github.com/coder/code-server/pull/2719#event-4747988700 |
| https://github.co/hiddenchars |
| https://github.com/coder/code-server/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2719 |
|
| https://github.com/code-asher |
|
code-asher
| https://github.com/code-asher |
|
| https://github.com/coder/code-server/pull/2719/files/66bb0105bf3a91cc4cfbf43d7a31d5cd48839eab |
|
| https://github.com/oxy |
|
oxy
| https://github.com/oxy |
|
| https://github.com/coder/code-server/pull/2719/files/6996c4582a9d3fc25071b056562b6a6dbce7f223 |
|
| https://github.com/jsjoeio |
|
jsjoeio
| https://github.com/jsjoeio |
|
testing
| https://github.com/coder/code-server/issues?q=state%3Aopen%20label%3Atesting |
|
v3.9.1
| https://github.com/coder/code-server/milestone/17 |
| Please reload this page | https://github.com/coder/code-server/pull/2719 |
|
| https://github.com/jsjoeio |
|
| https://github.com/oxy |
|
| https://github.com/code-asher |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |