René's URL Explorer Experiment


Title: Fix exthost error and warn logging by code-asher · Pull Request #2366 · coder/code-server · GitHub

Open Graph Title: Fix exthost error and warn logging by code-asher · Pull Request #2366 · coder/code-server

X Title: Fix exthost error and warn logging by code-asher · Pull Request #2366 · coder/code-server

Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.

Open Graph Description: Previously anything that wasn't "log" such as "warn" would end up doing logger[logger.warn]. Would have caught this if I hadn't used any... Fixes #2364.

X Description: Previously anything that wasn't "log" such as "warn" would end up doing logger[logger.warn]. Would have caught this if I hadn't used any... Fixes #2364.

Opengraph URL: https://github.com/coder/code-server/pull/2366

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ccb1f8f5-ba0f-c2ef-eb09-e6303e850251
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ECA:3931C6:119C29D:16B15C9:699078A7
html-safe-nonce0f7e1ecaf4c62dc15c02d31680d4b4a09dfda8905a5852e0379e3a9f301e7c31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUNBOjM5MzFDNjoxMTlDMjlEOjE2QjE1Qzk6Njk5MDc4QTciLCJ2aXNpdG9yX2lkIjoiNTgwMDA0ODM3MDg2NjIyMzI3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebef48e6eb002bd131d19fbc81a7165ec7a4aa1ca63699eda0e9bfc12a2ad4cf
hovercard-subject-tagpull_request:527614056
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/coder/code-server/2366/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2f951598313dd8ea758eadd7656429bf17404e841b514016485c78c786fb46fe/coder/code-server/pull/2366
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2f951598313dd8ea758eadd7656429bf17404e841b514016485c78c786fb46fe/coder/code-server/pull/2366
og:image:altPreviously anything that wasn't "log" such as "warn" would end up doing logger[logger.warn]. Would have caught this if I hadn't used any... Fixes #2364.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecode-asher
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/coder/code-server git https://github.com/coder/code-server.git
octolytics-dimension-user_id95932066
octolytics-dimension-user_logincoder
octolytics-dimension-repository_id172953845
octolytics-dimension-repository_nwocoder/code-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id172953845
octolytics-dimension-repository_network_root_nwocoder/code-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/coder/code-server/pull/2366#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2366
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2366
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=coder%2Fcode-server
Reloadhttps://github.com/coder/code-server/pull/2366
Reloadhttps://github.com/coder/code-server/pull/2366
Reloadhttps://github.com/coder/code-server/pull/2366
coder https://github.com/coder
code-serverhttps://github.com/coder/code-server
Notifications https://github.com/login?return_to=%2Fcoder%2Fcode-server
Fork 6.5k https://github.com/login?return_to=%2Fcoder%2Fcode-server
Star 76.2k https://github.com/login?return_to=%2Fcoder%2Fcode-server
Code https://github.com/coder/code-server
Issues 167 https://github.com/coder/code-server/issues
Pull requests 8 https://github.com/coder/code-server/pulls
Discussions https://github.com/coder/code-server/discussions
Actions https://github.com/coder/code-server/actions
Projects 0 https://github.com/coder/code-server/projects
Security 1 https://github.com/coder/code-server/security
Insights https://github.com/coder/code-server/pulse
Code https://github.com/coder/code-server
Issues https://github.com/coder/code-server/issues
Pull requests https://github.com/coder/code-server/pulls
Discussions https://github.com/coder/code-server/discussions
Actions https://github.com/coder/code-server/actions
Projects https://github.com/coder/code-server/projects
Security https://github.com/coder/code-server/security
Insights https://github.com/coder/code-server/pulse
nhooyrhttps://github.com/nhooyr
masterhttps://github.com/coder/code-server/tree/master
exthost-loggerhttps://github.com/coder/code-server/tree/exthost-logger
Conversationhttps://github.com/coder/code-server/pull/2366
Commits1 (1)https://github.com/coder/code-server/pull/2366/commits
Checkshttps://github.com/coder/code-server/pull/2366/checks
Files changedhttps://github.com/coder/code-server/pull/2366/files
Fix exthost error and warn logginghttps://github.com/coder/code-server/pull/2366#top
nhooyrhttps://github.com/nhooyr
masterhttps://github.com/coder/code-server/tree/master
exthost-loggerhttps://github.com/coder/code-server/tree/exthost-logger
https://github.com/code-asher
code-asherhttps://github.com/code-asher
Nov 25, 2020https://github.com/coder/code-server/pull/2366#issue-751021389
#2364https://github.com/coder/code-server/issues/2364
Please reload this pagehttps://github.com/coder/code-server/pull/2366
https://github.com/code-asher
Fix exthost error and warn logginghttps://github.com/coder/code-server/pull/2366/commits/f26aeb066756441f06f80d8e0349e7e1a152a2b2
f26aeb0https://github.com/coder/code-server/pull/2366/commits/f26aeb066756441f06f80d8e0349e7e1a152a2b2
#2364https://github.com/coder/code-server/issues/2364
https://github.com/code-asher
code-asherhttps://github.com/code-asher
nhooyrhttps://github.com/nhooyr
code ownerhttps://github.com/coder/code-server/blob/eca444887719bae5bfe1f5a86b6817ce4abb24ab/.github/CODEOWNERS#L1
November 25, 2020 18:03https://github.com/coder/code-server/pull/2366#event-4039289511
https://github.com/nhooyr
nhooyrhttps://github.com/nhooyr
Nov 26, 2020https://github.com/coder/code-server/pull/2366#issuecomment-734501645
Please reload this pagehttps://github.com/coder/code-server/pull/2366
https://github.com/nhooyr
nhooyrhttps://github.com/nhooyr
Nov 26, 2020 https://github.com/coder/code-server/pull/2366#pullrequestreview-539572779
View reviewed changes https://github.com/coder/code-server/pull/2366/files/f26aeb066756441f06f80d8e0349e7e1a152a2b2
ci/dev/vscode.patchhttps://github.com/coder/code-server/pull/2366/files/f26aeb066756441f06f80d8e0349e7e1a152a2b2#diff-9e295724ddcc33de1e1e16290c98d43f43e5ce542612dd015d982853be82493c
nhooyrhttps://github.com/nhooyr
Nov 26, 2020https://github.com/coder/code-server/pull/2366#discussion_r531247380
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/coder/code-server/pull/2366
https://github.com/nhooyr
nhooyrhttps://github.com/nhooyr
ae65c83https://github.com/coder/code-server/commit/ae65c83cbdb6851335c9a5f01d7629434f6b0972
Nov 26, 2020https://github.com/coder/code-server/pull/2366#event-4044026788
https://github.com/nhooyr
nhooyrhttps://github.com/nhooyr
v3.7.4https://github.com/coder/code-server/milestone/14
Nov 30, 2020https://github.com/coder/code-server/pull/2366#event-4050537359
https://github.com/code-asher
code-asherhttps://github.com/code-asher
November 30, 2020 16:41https://github.com/coder/code-server/pull/2366#event-4052897471
nhooyrhttps://github.com/nhooyr
Dec 4, 2020 https://github.com/coder/code-server/pull/2366#ref-commit-5c5adb5
https://github.com/nhooyr
vscode: Fix exthost logginghttps://github.com/coder/code-server/commit/5c5adb533bf15a3f5f941ab325806b03175aa1b7
5c5adb5https://github.com/coder/code-server/commit/5c5adb533bf15a3f5f941ab325806b03175aa1b7
#2364https://github.com/coder/code-server/issues/2364
#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
nhooyrhttps://github.com/nhooyr
Dec 4, 2020 https://github.com/coder/code-server/pull/2366#ref-commit-d2f3e6c
https://github.com/nhooyr
vscode: Fix exthost logginghttps://github.com/coder/code-server/commit/d2f3e6cea287e889ca28abfe6e0906450f45e4ef
d2f3e6chttps://github.com/coder/code-server/commit/d2f3e6cea287e889ca28abfe6e0906450f45e4ef
#2364https://github.com/coder/code-server/issues/2364
#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
nhooyrhttps://github.com/nhooyr
Dec 4, 2020 https://github.com/coder/code-server/pull/2366#ref-commit-ad7fb7b
https://github.com/nhooyr
vscode: Fix exthost logginghttps://github.com/coder/code-server/commit/ad7fb7b03980114d08a38d43084687302a7c260e
ad7fb7bhttps://github.com/coder/code-server/commit/ad7fb7b03980114d08a38d43084687302a7c260e
#2364https://github.com/coder/code-server/issues/2364
#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
nhooyrhttps://github.com/nhooyr
Dec 4, 2020 https://github.com/coder/code-server/pull/2366#ref-commit-961b74b
https://github.com/nhooyr
vscode: Fix exthost logginghttps://github.com/coder/code-server/commit/961b74b9726ad4526236b092e752ed6db519ad7a
961b74bhttps://github.com/coder/code-server/commit/961b74b9726ad4526236b092e752ed6db519ad7a
#2364https://github.com/coder/code-server/issues/2364
#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
nhooyrhttps://github.com/nhooyr
Dec 4, 2020 https://github.com/coder/code-server/pull/2366#ref-commit-c15b526
https://github.com/nhooyr
vscode: Fix exthost logginghttps://github.com/coder/code-server/commit/c15b526eff193039c49fd119aac72a93495b732e
c15b526https://github.com/coder/code-server/commit/c15b526eff193039c49fd119aac72a93495b732e
#2364https://github.com/coder/code-server/issues/2364
#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
theereecheehttps://github.com/theereechee
Jan 12, 2021 https://github.com/coder/code-server/pull/2366#ref-commit-c21b72a
https://github.com/theereechee
https://github.com/nhooyr
https://github.com/bpmct
https://github.com/Matthew-Beckett
https://github.com/code-asher
https://github.com/piousdeer
https://github.com/jw-12138
https://github.com/mgmachado
https://github.com/JammSpread
https://github.com/bgv2
https://github.com/csaska
https://github.com/AckerApple
https://github.com/jsjoeio
https://github.com/SPGoding
https://github.com/mayanxoni
https://github.com/lenhof
https://github.com/scsmithr
sync with upstream (https://github.com/theereechee/code-server/commit/c21b72a9a4405fff329351a67e4f0a4c87778ca6
#1https://github.com/theereechee/code-server/pull/1
)https://github.com/theereechee/code-server/commit/c21b72a9a4405fff329351a67e4f0a4c87778ca6
c21b72ahttps://github.com/theereechee/code-server/commit/c21b72a9a4405fff329351a67e4f0a4c87778ca6
eugef/node-mocks-http#225https://github.com/eugef/node-mocks-http/issues/225
coder#2282https://github.com/coder/code-server/pull/2282
coder#2297https://github.com/coder/code-server/issues/2297
@sreyahttps://github.com/sreya
coder#2311https://github.com/coder/code-server/pull/2311
coder#2310https://github.com/coder/code-server/issues/2310
coder#2331https://github.com/coder/code-server/pull/2331
coder#2333https://github.com/coder/code-server/pull/2333
coder#2327https://github.com/coder/code-server/issues/2327
coder#2316https://github.com/coder/code-server/issues/2316
coder#2113https://github.com/coder/code-server/discussions/2113
f79bb21https://github.com/theereechee/code-server/commit/f79bb210ec6e78c135db7b006ae447f37be4ca7e
coder#2247https://github.com/coder/code-server/issues/2247
coder#2335https://github.com/coder/code-server/pull/2335
coder#2208https://github.com/coder/code-server/issues/2208
coder#2231https://github.com/coder/code-server/issues/2231
coder#2279https://github.com/coder/code-server/issues/2279
coder#2274https://github.com/coder/code-server/issues/2274
coder#2328https://github.com/coder/code-server/issues/2328
coder#1652https://github.com/coder/code-server/issues/1652
coder#2221https://github.com/coder/code-server/issues/2221
coder#2359https://github.com/coder/code-server/issues/2359
coder#2366https://github.com/coder/code-server/pull/2366
coder#2364https://github.com/coder/code-server/issues/2364
coder#2359https://github.com/coder/code-server/issues/2359
@mgmachadohttps://github.com/mgmachado
coder#1791https://github.com/coder/code-server/issues/1791
coder#2358 (comment)https://github.com/coder/code-server/pull/2358#discussion_r529858749
coder#2361https://github.com/coder/code-server/issues/2361
coder#2382https://github.com/coder/code-server/pull/2382
coder#2356https://github.com/coder/code-server/issues/2356
coder#2383https://github.com/coder/code-server/pull/2383
coder#2307https://github.com/coder/code-server/issues/2307
coder#2398https://github.com/coder/code-server/pull/2398
coder#124https://github.com/coder/code-server/issues/124
coder#2401https://github.com/coder/code-server/pull/2401
coder#2383 (comment)https://github.com/coder/code-server/pull/2383#issuecomment-738024951
coder#2389https://github.com/coder/code-server/pull/2389
coder#2https://github.com/coder/code-server/pull/2
coder#2364https://github.com/coder/code-server/issues/2364
coder#2366https://github.com/coder/code-server/pull/2366
@code-asherhttps://github.com/code-asher
coder#2125https://github.com/coder/code-server/pull/2125
@AckerApplehttps://github.com/AckerApple
@nhooyrhttps://github.com/nhooyr
coder#2409https://github.com/coder/code-server/pull/2409
coder#2225https://github.com/coder/code-server/issues/2225
https://myname.coder-cloud.comhttps://myname.coder-cloud.com
@JammSpreadhttps://github.com/JammSpread
coder#2405https://github.com/coder/code-server/pull/2405
coder#2396https://github.com/coder/code-server/issues/2396
coder#2453https://github.com/coder/code-server/pull/2453
coder#2451https://github.com/coder/code-server/issues/2451
coder#2456https://github.com/coder/code-server/pull/2456
coder#2458https://github.com/coder/code-server/pull/2458
coder#2267https://github.com/coder/code-server/issues/2267
coder#2423https://github.com/coder/code-server/pull/2423
coder#2457https://github.com/coder/code-server/pull/2457
coder#2410https://github.com/coder/code-server/discussions/2410
coder#2455https://github.com/coder/code-server/pull/2455
coder#2434https://github.com/coder/code-server/pull/2434
coder#1951https://github.com/coder/code-server/issues/1951
e5a624bhttps://github.com/theereechee/code-server/commit/e5a624b788d92b8d34d1392e4c4d9789406efe8f
e5a624bhttps://github.com/theereechee/code-server/commit/e5a624b788d92b8d34d1392e4c4d9789406efe8f
coder#2197https://github.com/coder/code-server/issues/2197
https://golang.org/pkg/net/http/#ProxyFromEnvironmenthttps://golang.org/pkg/net/http/#ProxyFromEnvironment
@jsjoeiohttps://github.com/jsjoeio
coder#2349https://github.com/coder/code-server/issues/2349
coder#2454https://github.com/coder/code-server/pull/2454
@code-asherhttps://github.com/code-asher
coder#2439https://github.com/coder/code-server/pull/2439
coder#2462https://github.com/coder/code-server/pull/2462
coder#2479https://github.com/coder/code-server/pull/2479
coder#2544https://github.com/coder/code-server/pull/2544
coder#2538https://github.com/coder/code-server/issues/2538
https://github.co/hiddenchars
https://github.com/coder/code-server/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcoder%2Fcode-server%2Fpull%2F2366
https://github.com/nhooyr
nhooyr https://github.com/nhooyr
https://github.com/coder/code-server/pull/2366/files/f26aeb066756441f06f80d8e0349e7e1a152a2b2
v3.7.4 https://github.com/coder/code-server/milestone/14
Please reload this pagehttps://github.com/coder/code-server/pull/2366
https://github.com/code-asher
https://github.com/nhooyr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.