Title: [Fix]: Better output when installing with NPM · Issue #5537 · coder/code-server · GitHub
Open Graph Title: [Fix]: Better output when installing with NPM · Issue #5537 · coder/code-server
X Title: [Fix]: Better output when installing with NPM · Issue #5537 · coder/code-server
Description: Why do you want this feature? In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code As reported in #5530 (and more in #5533), installs were passing but ...
Open Graph Description: Why do you want this feature? In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code As reported in #5530 (and mo...
X Description: Why do you want this feature? In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code As reported in #5530 (and mo...
Opengraph URL: https://github.com/coder/code-server/issues/5537
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Fix]: Better output when installing with NPM","articleBody":"## Why do you want this feature?\r\n\r\nIn the `postinstall.sh` script that is used when installing with `npm`, we use nested commands to install `vscode` and its extensions - [see code](https://github.com/coder/code-server/blob/main/ci/build/npm-postinstall.sh#L156)\r\n\r\nAs reported in https://github.com/coder/code-server/issues/5530 (and more in https://github.com/coder/code-server/pull/5533), installs were passing but actually failing - and only was seen during runtime.\r\n\r\nThe nested installs were failing, but the errors weren't being bubbled-up... Was only seen when using `--foreground-scripts`.\r\n\r\n## What is your suggestion?\r\n* NPM 8 needs to be passed `--foreground-scripts` to actually see the output of the nested. We should update the doc to show that as a troubleshooting step in here: https://coder.com/docs/code-server/latest/npm#debugging-install-issues-with-npm\r\n* I would expect the overall script to have a non-0 exit code if any of the nested scripts failed (i.e. they themselves had a non-0 exit code) which would make the overall `npm install` fail. Need to investigate that.\r\n\r\n## Are there any workarounds to get this functionality today?\r\n* Pass `--foreground-scripts` and read carefully :(\r\n\r\n## Are you interested in submitting a PR for this?\r\nYes","author":{"url":"https://github.com/edvincent","@type":"Person","name":"edvincent"},"datePublished":"2022-09-06T16:34:18Z","url":"https://github.com/coder/code-server/issues/5537"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7516aa00-91bd-38a1-47d8-9704ec8eb09f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8E30:38E318:29A22BB:34B80BB:6B01D980 |
| html-safe-nonce | a5c7523b91b60a95f0172fb662df0619b9a9c8bc18ff872a6cc97373f095f91d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTMwOjM4RTMxODoyOUEyMkJCOjM0QjgwQkI6NkIwMUQ5ODAiLCJ2aXNpdG9yX2lkIjoiNDg5NzIwNzU5NDg2MDUzNDE0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cbed10d14d43449dcc9b1ff714e559ca0b9d5f92e103d2914e0509f9a1b7b927 |
| hovercard-subject-tag | issue:1363545168 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/code-server/5537/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ae5cd4edb47c70f008e283f6f33ff06781dbd89aaa465b8e2d54a68255c046de/coder/code-server/issues/5537 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ae5cd4edb47c70f008e283f6f33ff06781dbd89aaa465b8e2d54a68255c046de/coder/code-server/issues/5537 |
| og:image:alt | Why do you want this feature? In the postinstall.sh script that is used when installing with npm, we use nested commands to install vscode and its extensions - see code As reported in #5530 (and mo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edvincent |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width