Title: [Fix]: Figure out next steps with keytar/libsecret · Issue #5536 · coder/code-server · GitHub
Open Graph Title: [Fix]: Figure out next steps with keytar/libsecret · Issue #5536 · coder/code-server
X Title: [Fix]: Figure out next steps with keytar/libsecret · Issue #5536 · coder/code-server
Description: Why do you want this feature? Right now, following the guide from https://coder.com/docs/code-server/latest/npm, it doesn't specify that libsecret needs to be installed - which can cause confusions and issues as seen in #5533 libsecret i...
Open Graph Description: Why do you want this feature? Right now, following the guide from https://coder.com/docs/code-server/latest/npm, it doesn't specify that libsecret needs to be installed - which can cause confusions...
X Description: Why do you want this feature? Right now, following the guide from https://coder.com/docs/code-server/latest/npm, it doesn't specify that libsecret needs to be installed - which can cause confus...
Opengraph URL: https://github.com/coder/code-server/issues/5536
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Fix]: Figure out next steps with keytar/libsecret","articleBody":"## Why do you want this feature?\r\n\r\nRight now, following the guide from https://coder.com/docs/code-server/latest/npm, it doesn't specify that `libsecret` needs to be installed - which can cause confusions and issues as seen in https://github.com/coder/code-server/pull/5533\r\n\r\n`libsecret` is needed because `keytar` is a dependency of `vscode` - and it's used to store secrets.\r\n\r\nHOWEVER, there's a fallback if it can't store creds in the OS store (what `libsecret` is used for) - that uses memory. It shows a log message in the console, but `code-server` (and `vscode`) are fully functional without it, thanks to that fallback built-in into `vscode`.\r\n\r\nSee https://github.com/microsoft/vscode/blob/1fb94816f2d40bdc77536eac44eada91a9a9e8ac/src/vs/platform/credentials/node/credentialsMainService.ts#L44-L48 for that `catch` that means there's a fallback.\r\n\r\n## What is your suggestion?\r\nNeed to figure out/agree what is the state of the need for `libsecret` when running `code-server`. Some ideas:\r\n* Try to get `vscode` to add `keytar` as an `optionalDependency`, as that's what it effectively is\r\n* Bring back the \"hack\" that was removed in https://github.com/coder/code-server/pull/5040/commits/4ae5e26ce7ed96a31c92211fc3026e1403725e3f, which moves it to an `optionalDependency` on our side\r\n* Update the install doc to make `libsecret` part of the packages installed - https://coder.com/docs/code-server/latest/npm\r\n\r\n## Are you interested in submitting a PR for this?\r\nYes","author":{"url":"https://github.com/edvincent","@type":"Person","name":"edvincent"},"datePublished":"2022-09-06T16:11:50Z","url":"https://github.com/coder/code-server/issues/5536"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1a690c80-0325-a3fd-c6fe-8eedbce95170 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9820:1FAE:653331:8BA0F9:6B01D985 |
| html-safe-nonce | f172535e0e2c93a995435a61da732d9678a9d39e36e1e1797cde2514fba6709e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODIwOjFGQUU6NjUzMzMxOjhCQTBGOTo2QjAxRDk4NSIsInZpc2l0b3JfaWQiOiI1ODcyMTkwNTgwMDc5MDU3Mjg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e2a57d56d3ea9e632769aeebfa950b6c19e897a32c6fadcaf4ae5858e6434901 |
| hovercard-subject-tag | issue:1363519322 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/code-server/5536/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ed69f84dac5639460a41785ecbbe27760e9a5cad18e9b51f5fce2feaa6a43c26/coder/code-server/issues/5536 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ed69f84dac5639460a41785ecbbe27760e9a5cad18e9b51f5fce2feaa6a43c26/coder/code-server/issues/5536 |
| og:image:alt | Why do you want this feature? Right now, following the guide from https://coder.com/docs/code-server/latest/npm, it doesn't specify that libsecret needs to be installed - which can cause confusions... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | edvincent |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width