Title: [Feat]: Add option to disable "Show Local" while saving · Issue #5118 · coder/code-server · GitHub
Open Graph Title: [Feat]: Add option to disable "Show Local" while saving · Issue #5118 · coder/code-server
X Title: [Feat]: Add option to disable "Show Local" while saving · Issue #5118 · coder/code-server
Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.
Open Graph Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.
X Description: VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub.
Opengraph URL: https://github.com/coder/code-server
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Feat]: Add option to disable \"Show Local\" while saving","articleBody":"## What is your suggestion?\r\nReuse the option `--disable-file-downloads` recently implemented on #5055 to remove the `Show Local` button when using the `Save As` option. This option allows the users to save the current file on their local machine.\r\n\r\nExample:\r\n\u003cimg width=\"650\" alt=\"Screenshot 2022-04-19 at 14 53 51\" src=\"https://user-images.githubusercontent.com/60617140/164008630-787c9cbd-9dd4-4b18-998e-3a8a9e39e44f.png\">\r\n\r\n## Why do you want this feature?\r\nOne could argue that having the option to save the file locally makes the download as accessible as having the `Download` button when right clicking the file name. As mentioned in the comments on the issue #1386, some industries have concerns about downloading files from the IDE.\r\n\r\n## Are there any workarounds to get this functionality today?\r\nNot that I'm aware of.\r\n\r\n## How this feature could be implemented?\r\nWe could extend the code implemented on #5055. The value of the option `--disable-file-downloads` could be used within a condition that will either add the \"Show Local\" button or not. As I understand, the button is added on [simpleFileDialog.ts L279](https://github.com/microsoft/vscode/blob/12f99e06d005e5d871a1b1b264719e12ae107353/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts#L279). _Disclaimer, I'm not familiar with the code base, neither TypeScript, so there might be more places we will need patch._\r\n\r\n## Are you interested in submitting a PR for this?\r\nYes, but I might need some guidance setting up the environment.","author":{"url":"https://github.com/avsthiago-kbc","@type":"Person","name":"avsthiago-kbc"},"datePublished":"2022-04-19T12:59:47Z","url":"https://github.com/coder/code-server/issues/5118"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/issues/:id(.:format) |
| route-controller | issues |
| route-action | show |
| fetch-nonce | v2:8209a3d8-7a50-e977-bead-94267851cc09 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C792:2E5652:35857F7:4438B4F:6B01E79D |
| html-safe-nonce | 41078acecf9528b4775478055be95c015a24b876142f8a4760bf70be61552c9f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzkyOjJFNTY1MjozNTg1N0Y3OjQ0MzhCNEY6NkIwMUU3OUQiLCJ2aXNpdG9yX2lkIjoiNjY0OTQxMDM4MzEwOTAyMzY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | aab473ef9f00289c351e6e7b57e3e65cde6810cfec73056f09daf57980eb86f9 |
| hovercard-subject-tag | repository:172953845 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/coder/code-server/issues/5118 |
| twitter:image | https://opengraph.githubassets.com/24abbd8876f4c78c7f3403bd4f912fd663c2de3c21ac6ccf687df09847126864/coder/code-server |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/24abbd8876f4c78c7f3403bd4f912fd663c2de3c21ac6ccf687df09847126864/coder/code-server |
| og:image:alt | VS Code in the browser. Contribute to coder/code-server development by creating an account on GitHub. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width