Title: fix release-prep script replacing dependencies versions in package.json · Issue #4679 · coder/code-server · GitHub
Open Graph Title: fix release-prep script replacing dependencies versions in package.json · Issue #4679 · coder/code-server
X Title: fix release-prep script replacing dependencies versions in package.json · Issue #4679 · coder/code-server
Description: Problem When we prep a release, we run a script locally called release-prep.sh. In it, there is a line that uses rg and sd to bump the version across the project (i.e. 4.0.0 -> 4.0.1). Unfortunately, this means if there is a dependency w...
Open Graph Description: Problem When we prep a release, we run a script locally called release-prep.sh. In it, there is a line that uses rg and sd to bump the version across the project (i.e. 4.0.0 -> 4.0.1). Unfortunatel...
X Description: Problem When we prep a release, we run a script locally called release-prep.sh. In it, there is a line that uses rg and sd to bump the version across the project (i.e. 4.0.0 -> 4.0.1). Unfortuna...
Opengraph URL: https://github.com/coder/code-server/issues/4679
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fix release-prep script replacing dependencies versions in package.json","articleBody":"## Problem\r\nWhen we prep a release, we run a script locally called [`release-prep.sh`](https://github.com/coder/code-server/blob/main/ci/build/release-prep.sh).\r\n\r\nIn it, there is a line that uses `rg` and `sd` to bump the version across the project (i.e. 4.0.0 -> 4.0.1). \r\n\r\nUnfortunately, this means if there is a dependency with the same version we're bumping, it will bump that too 😅\r\n\r\nHere is the exact line where we do this:\r\nhttps://github.com/coder/code-server/blob/main/ci/build/release-prep.sh#L84\r\n\r\n## Example\r\n\r\n\r\n## Solution\r\nIt might be worth breaking this into two lines:\r\n1. first `rg` -> `sd` replaces the first instance in `package.json`\r\n2. ignores `package.json` but updates the other files (i.e. markdown)\r\n\r\nTo summarize, we should split the current functionality into two calls:\r\n- update the `package.json` (only first string it finds)\r\n- update the markdown files\r\n","author":{"url":"https://github.com/jsjoeio","@type":"Person","name":"jsjoeio"},"datePublished":"2022-01-04T17:37:00Z","url":"https://github.com/coder/code-server/issues/4679"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:472c530d-ef24-c5bf-8286-6e6c4aba0bdf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A8E4:ADA9D:36EC941:466F9CF:6B01E2E9 |
| html-safe-nonce | db7c11d4ae15a3ea73652972e3e23f4a5c4a25b9409635e8f90447aec988e937 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEU0OkFEQTlEOjM2RUM5NDE6NDY2RjlDRjo2QjAxRTJFOSIsInZpc2l0b3JfaWQiOiI1NDg5NjU0MjE5NzM0NjM5MzM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 119aeac43ca86e2eec0cb9f2b3ce633701cf56c1e738bb0a4c58ae3a4dd105de |
| hovercard-subject-tag | issue:1093606868 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/code-server/4679/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9ece8b0f9fe76079014867de4d42758fe617c847971e7a34c0bfef010020b9ed/coder/code-server/issues/4679 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9ece8b0f9fe76079014867de4d42758fe617c847971e7a34c0bfef010020b9ed/coder/code-server/issues/4679 |
| og:image:alt | Problem When we prep a release, we run a script locally called release-prep.sh. In it, there is a line that uses rg and sd to bump the version across the project (i.e. 4.0.0 -> 4.0.1). Unfortunatel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jsjoeio |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width