Title: Replacing hashing password scheme with something more robust · Issue #3576 · coder/code-server · GitHub
Open Graph Title: Replacing hashing password scheme with something more robust · Issue #3576 · coder/code-server
X Title: Replacing hashing password scheme with something more robust · Issue #3576 · coder/code-server
Description: While hashing is a major step forward, the problem with this approach is that it still allows attackers who have access to the hash to just submit it as-is and gain access to code-server - effectively not very different from storing it i...
Open Graph Description: While hashing is a major step forward, the problem with this approach is that it still allows attackers who have access to the hash to just submit it as-is and gain access to code-server - effectiv...
X Description: While hashing is a major step forward, the problem with this approach is that it still allows attackers who have access to the hash to just submit it as-is and gain access to code-server - effectiv...
Opengraph URL: https://github.com/coder/code-server/issues/3576
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replacing hashing password scheme with something more robust","articleBody":"> While hashing is a major step forward, the problem with this approach is that it still allows attackers who have access to the hash to just submit it as-is and gain access to code-server - effectively not very different from storing it in plaintext.\r\n\r\n> We should definitely look into replacing this with something more robust so that password hashing isn't just a placebo.\r\n\r\nAs security expert @oxy points out, our current approach for hashing the password and storing it in a cookie is more like a placebo-effect than a real security approach.\r\n\r\nhttps://github.com/cdr/code-server/pull/3422#discussion_r647773585\r\n\r\nRelated:\r\n- https://github.com/cdr/code-server/pull/3422\r\n- https://github.com/cdr/code-server/issues/3560\r\n","author":{"url":"https://github.com/jsjoeio","@type":"Person","name":"jsjoeio"},"datePublished":"2021-06-08T21:21:42Z","url":"https://github.com/coder/code-server/issues/3576"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c9e9df4d-9501-45b5-6b41-020e7407982d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C4F0:38C5CF:341B347:42108B4:6B01BE16 |
| html-safe-nonce | d7a4c9ac43f5ea6c2bd19cacd7e7080b1d6532b5cfe34f6c4bc6632e70b5aa97 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNEYwOjM4QzVDRjozNDFCMzQ3OjQyMTA4QjQ6NkIwMUJFMTYiLCJ2aXNpdG9yX2lkIjoiOTA0NDY2NzM0MDA0NTc5NDgzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6a5b8c952dc30f669b47ab14c7be84cea5fbb51956ed0898b174cbe27f189827 |
| hovercard-subject-tag | issue:915526477 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/coder/code-server/3576/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0de59f82a79112169e8bffdf7db1551e48ab3f3c5d1b95a151c0d7ae942f74ed/coder/code-server/issues/3576 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0de59f82a79112169e8bffdf7db1551e48ab3f3c5d1b95a151c0d7ae942f74ed/coder/code-server/issues/3576 |
| og:image:alt | While hashing is a major step forward, the problem with this approach is that it still allows attackers who have access to the hash to just submit it as-is and gain access to code-server - effectiv... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jsjoeio |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/coder/code-server git https://github.com/coder/code-server.git |
| octolytics-dimension-user_id | 95932066 |
| octolytics-dimension-user_login | coder |
| octolytics-dimension-repository_id | 172953845 |
| octolytics-dimension-repository_nwo | coder/code-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 172953845 |
| octolytics-dimension-repository_network_root_nwo | coder/code-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width