Title: Fix issue 132 and refactor entry point detection logic. by rahlk · Pull Request #133 · codellm-devkit/codeanalyzer-java · GitHub
Open Graph Title: Fix issue 132 and refactor entry point detection logic. by rahlk · Pull Request #133 · codellm-devkit/codeanalyzer-java
X Title: Fix issue 132 and refactor entry point detection logic. by rahlk · Pull Request #133 · codellm-devkit/codeanalyzer-java
Description: Motivation and Context This change addresses Issue #132, which reported that codeanalyzer fails to detect certain JakartaEE methods (e.g., doPost(...)) as valid entrypoints even though the surrounding class is correctly recognized as an entrypoint class. The root cause was a flawed heuristic in the isEntrypointMethod(...) implementation that required both: the presence of request/response parameters, and an annotation containing the string "Override". Since methods like doPost(...) override HttpServlet methods but may not explicitly include the @Override annotation (which is optional in Java), the AND condition resulted in false negatives. This PR removes the faulty annotation check and ensures servlet entrypoints are correctly discovered. Additionally, this change refactors discovery logic to leverage a new EntrypointFinderFactory, improving modularity and extensibility for multi-framework support. How Has This Been Tested? Ran the updated codeanalyzer against a JakartaEE sample application with HttpServlet subclasses. Verified that doPost(...), doGet(...), and similar methods are now correctly marked as entrypoints. Confirmed no regressions in Spring or JAX-RS entrypoint detection. Breaking Changes No breaking changes. This is a non-breaking behavioral fix that improves the correctness of entrypoint detection in JakartaEE applications. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the Codellm-Devkit Documentation My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context The use of EntrypointFinderFactory now cleanly supports framework-specific entrypoint logic (e.g., Spring, JAX-RS, Jakarta). This abstraction will make future enhancements (e.g., Struts, Camel) easier to plug in. Minor cleanups also improve maintainability by localizing entrypoint logic to its respective finder class.
Open Graph Description: Motivation and Context This change addresses Issue #132, which reported that codeanalyzer fails to detect certain JakartaEE methods (e.g., doPost(...)) as valid entrypoints even though the surround...
X Description: Motivation and Context This change addresses Issue #132, which reported that codeanalyzer fails to detect certain JakartaEE methods (e.g., doPost(...)) as valid entrypoints even though the surround...
Opengraph URL: https://github.com/codellm-devkit/codeanalyzer-java/pull/133
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:66bdfa00-e728-c307-d0f6-e182a3a95655 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 950E:6EBCD:1139DE4:1634570:698FD889 |
| html-safe-nonce | c74d264d3bcac114e241906929635c8a61ed2b966836f057eec56f6fb0330fea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTBFOjZFQkNEOjExMzlERTQ6MTYzNDU3MDo2OThGRDg4OSIsInZpc2l0b3JfaWQiOiI0NjQzNzk1Nzg4NDA4ODA1NTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b8f1e2e4923bf9e9fd775467448fcd44163e8da36668fd8f399f6b8497d486c4 |
| hovercard-subject-tag | pull_request:2464176147 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/codellm-devkit/codeanalyzer-java/pull/133/files |
| twitter:image | https://avatars.githubusercontent.com/u/1433964?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1433964?s=400&v=4 |
| og:image:alt | Motivation and Context This change addresses Issue #132, which reported that codeanalyzer fails to detect certain JakartaEE methods (e.g., doPost(...)) as valid entrypoints even though the surround... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/codellm-devkit/codeanalyzer-java git https://github.com/codellm-devkit/codeanalyzer-java.git |
| octolytics-dimension-user_id | 197800760 |
| octolytics-dimension-user_login | codellm-devkit |
| octolytics-dimension-repository_id | 731300153 |
| octolytics-dimension-repository_nwo | codellm-devkit/codeanalyzer-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 731300153 |
| octolytics-dimension-repository_network_root_nwo | codellm-devkit/codeanalyzer-java |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d320682233dfd4d28c0b30554a564c2fcd229032 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width