Title: Remove `"system_dependency_graph"` key from `analysis.json` by rahlk · Pull Request #130 · codellm-devkit/codeanalyzer-java · GitHub
Open Graph Title: Remove `"system_dependency_graph"` key from `analysis.json` by rahlk · Pull Request #130 · codellm-devkit/codeanalyzer-java
X Title: Remove `"system_dependency_graph"` key from `analysis.json` by rahlk · Pull Request #130 · codellm-devkit/codeanalyzer-java
Description: This PR removes the misnamed system_dependency_graph key from the output analysis.json file, keeping only the call_graph key which accurately represents the data. Motivation and Context The key system_dependency_graph in the output analysis.json is a misnomer that doesn't accurately reflect the data it contains. This can lead to confusion for users who expect this key to represent something different than what it actually contains. Standardizing on the more accurate call_graph terminology improves clarity and consistency in the codebase. How Has This Been Tested? The change has been tested by running the analysis tool on multiple codebases and verifying that: The output analysis.json file only contains the call_graph key No data is lost during the removal of the duplicate system_dependency_graph key All regression tests now run. > Task :checkKotlinGradlePluginConfigurationErrors SKIPPED > Task :compileKotlin NO-SOURCE > Task :compileJava UP-TO-DATE > Task :processResources UP-TO-DATE > Task :classes UP-TO-DATE > Task :jar UP-TO-DATE > Task :compileTestKotlin NO-SOURCE > Task :compileTestJava UP-TO-DATE > Task :processTestResources UP-TO-DATE > Task :testClasses UP-TO-DATE > Task :test [Test worker] INFO org.testcontainers.images.PullPolicy - Image pull policy will be performed by: DefaultPullPolicy() [Test worker] INFO org.testcontainers.utility.ImageNameSubstitutor - Image name substitution will be performed by: DefaultImageNameSubstitutor (composite of 'ConfigurationFileImageNameSubstitutor' and 'PrefixingImageNameSubstitutor') [Test worker] INFO org.testcontainers.dockerclient.DockerClientProviderStrategy - Loaded org.testcontainers.dockerclient.UnixSocketClientProviderStrategy from ~/.testcontainers.properties, will try it first [Test worker] INFO org.testcontainers.dockerclient.DockerClientProviderStrategy - Found Docker environment with local Unix socket (unix:///var/run/docker.sock) [Test worker] INFO org.testcontainers.DockerClientFactory - Docker host IP address is localhost [Test worker] INFO org.testcontainers.DockerClientFactory - Connected to docker: Server Version: 4.9.4 API Version: 1.41 Operating System: fedora Total Memory: 7916 MB [Test worker] INFO tc.testcontainers/ryuk:0.5.1 - Creating container for image: testcontainers/ryuk:0.5.1 [Test worker] INFO tc.testcontainers/ryuk:0.5.1 - Container testcontainers/ryuk:0.5.1 is starting: 524070d435b85c16af92feee810ee9ad7ce48d1a331b5574cd8619c6606f617b [Test worker] INFO tc.testcontainers/ryuk:0.5.1 - Container testcontainers/ryuk:0.5.1 started in PT0.286901S [Test worker] INFO org.testcontainers.utility.RyukResourceReaper - Ryuk started - will monitor and terminate Testcontainers containers on JVM exit [Test worker] INFO org.testcontainers.DockerClientFactory - Checking the system... [Test worker] INFO org.testcontainers.DockerClientFactory - ✔︎ Docker server version should be at least 1.6.0 [Test worker] INFO tc.ubuntu:latest - Creating container for image: ubuntu:latest [Test worker] INFO tc.ubuntu:latest - Container ubuntu:latest is starting: dfed64a194163b251ee448907fbd4b76d557ee7da2eee43342160609269e2a7d [Test worker] INFO tc.ubuntu:latest - Container ubuntu:latest started in PT1.18194S [Test worker] INFO tc.maven:3.8.3-openjdk-17 - Creating container for image: maven:3.8.3-openjdk-17 [Test worker] INFO tc.maven:3.8.3-openjdk-17 - Container maven:3.8.3-openjdk-17 is starting: 0781ec074737cc582fcad9f33eb02930e6f7357ef8bd26685b8a49a9d9c9d850 [Test worker] INFO tc.maven:3.8.3-openjdk-17 - Container maven:3.8.3-openjdk-17 started in PT0.776211S Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. For more on this, please refer to https://docs.gradle.org/8.9/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation. BUILD SUCCESSFUL in 3m 1s 6 actionable tasks: 1 executed, 5 up-to-date 5:53:09 PM: Execution finished ':test --tests "com.ibm.cldk.CodeAnalyzerIntegrationTest"'. Breaking Changes This is a breaking change for any users or tools that specifically reference the system_dependency_graph key in the analysis.json file. They will need to update their code to use call_graph instead. Types of changes Bug fix (non-breaking change which fixes an issue) New feature (non-breaking change which adds functionality) Breaking change (fix or feature that would cause existing functionality to change) Documentation update Checklist I have read the [Codellm-Devkit Documentation](https://codellm-devkit.info) My code follows the repository's style guidelines New and existing tests pass locally I have added appropriate error handling I have added or updated documentation as needed Additional context This change is part of an effort to improve naming consistency throughout the codebase. Any documentation that references the old key name has also been updated to reflect this change.
Open Graph Description: This PR removes the misnamed system_dependency_graph key from the output analysis.json file, keeping only the call_graph key which accurately represents the data. Motivation and Context The key sy...
X Description: This PR removes the misnamed system_dependency_graph key from the output analysis.json file, keeping only the call_graph key which accurately represents the data. Motivation and Context The key sy...
Opengraph URL: https://github.com/codellm-devkit/codeanalyzer-java/pull/130
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:3db5179c-ebb0-5e42-bfd7-5d7f01dc5142 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C654:15579C:12A3554:188BFCC:698ED160 |
| html-safe-nonce | a0a278fc1879f6f244e7790174c492453cf1d0b1638342fc927b83e9ad78b4ad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjU0OjE1NTc5QzoxMkEzNTU0OjE4OEJGQ0M6Njk4RUQxNjAiLCJ2aXNpdG9yX2lkIjoiMzI1NTc5NjI2NjgzMTg5MjgzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8dab0a49980fe4eeb598c65418c0ae396fc21a6b4e34a942ce8fc966f13173f0 |
| hovercard-subject-tag | pull_request:2389296857 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/codellm-devkit/codeanalyzer-java/pull/130/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1433964?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1433964?s=400&v=4 |
| og:image:alt | This PR removes the misnamed system_dependency_graph key from the output analysis.json file, keeping only the call_graph key which accurately represents the data. Motivation and Context The key sy... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb2828a801ee6b7be618f3ac76fbf55def35bbc30f053a9c41bf90210b8b72ba |
| turbo-cache-control | no-preview |
| go-import | github.com/codellm-devkit/codeanalyzer-java git https://github.com/codellm-devkit/codeanalyzer-java.git |
| octolytics-dimension-user_id | 197800760 |
| octolytics-dimension-user_login | codellm-devkit |
| octolytics-dimension-repository_id | 731300153 |
| octolytics-dimension-repository_nwo | codellm-devkit/codeanalyzer-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 731300153 |
| octolytics-dimension-repository_network_root_nwo | codellm-devkit/codeanalyzer-java |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6b91a7e6e46287d26887e3fb7a4161657bab8f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width