Title: Ignore blank and null entries in PATH search for mvn/gradle execs by scottkurz · Pull Request #127 · codellm-devkit/codeanalyzer-java · GitHub
Open Graph Title: Ignore blank and null entries in PATH search for mvn/gradle execs by scottkurz · Pull Request #127 · codellm-devkit/codeanalyzer-java
X Title: Ignore blank and null entries in PATH search for mvn/gradle execs by scottkurz · Pull Request #127 · codellm-devkit/codeanalyzer-java
Description: Motivation and Context With a null PATH entry on Windows finding the mvn command resolves to absolute path: "C:\mvn.cmd" which does not exist for me, so the dependency lib download fails. Error log msgs like: �[36m2025-02-25T10:27:24.866896�[0m�[31m [ERROR] �[0mCould not verify that C:\mvn.cmd exists �[36m2025-02-25T10:27:24.932447400�[0m�[33m [WARN] �[0mFailed to download library dependencies of project I noticed this on v1.1.0 but looking at the code it appears to exist in the main branch as well. How Has This Been Tested? Tested with an empty PATH entry on Windows Breaking Changes No Types of changes Bug fix (non-breaking change which fixes an issue) Checklist Haven't tested Additional context I did a bit of searching to try to understand if an empty PATH entry should be considered meaningful, and found some leads suggesting it should mean the current directory. I didn't follow up on this though. We wouldn't want to use map(File::getAbsolutePath) if we wanted to find something in the current directory, so that would require a different solution. It might still be better to filter this case out until/unless it is clear we want to include it.
Open Graph Description: Motivation and Context With a null PATH entry on Windows finding the mvn command resolves to absolute path: "C:\mvn.cmd" which does not exist for me, so the dependency lib download fails....
X Description: Motivation and Context With a null PATH entry on Windows finding the mvn command resolves to absolute path: "C:\mvn.cmd" which does not exist for me, so the dependency lib downloa...
Opengraph URL: https://github.com/codellm-devkit/codeanalyzer-java/pull/127
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3afa8059-b27f-20ec-5a4d-42ae11938b5b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB2A:1ED7E7:BFED7D:F69ACE:6990BC91 |
| html-safe-nonce | 6a4b1cb1816f4bce79d2b1c8852652816333c0150e4f4972122ff85b3e228391 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjJBOjFFRDdFNzpCRkVEN0Q6RjY5QUNFOjY5OTBCQzkxIiwidmlzaXRvcl9pZCI6IjI5Nzc2NDc3MTUyODIyNzk4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dda33ad56a247cd87776158aff4bf2c72d77364228fcfcbf0185fb147fd6673f |
| hovercard-subject-tag | pull_request:2356985707 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/codellm-devkit/codeanalyzer-java/pull/127/files |
| twitter:image | https://avatars.githubusercontent.com/u/4081634?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4081634?s=400&v=4 |
| og:image:alt | Motivation and Context With a null PATH entry on Windows finding the mvn command resolves to absolute path: "C:\mvn.cmd" which does not exist for me, so the dependency lib download fails.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/codellm-devkit/codeanalyzer-java git https://github.com/codellm-devkit/codeanalyzer-java.git |
| octolytics-dimension-user_id | 197800760 |
| octolytics-dimension-user_login | codellm-devkit |
| octolytics-dimension-repository_id | 731300153 |
| octolytics-dimension-repository_nwo | codellm-devkit/codeanalyzer-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 731300153 |
| octolytics-dimension-repository_network_root_nwo | codellm-devkit/codeanalyzer-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width