René's URL Explorer Experiment

Title: hg identify call fails because it uses a `|`, but try_to_run() is missing shell=True · Issue #284 · codecov/codecov-python · GitHub

Open Graph Title: hg identify call fails because it uses a `|`, but try_to_run() is missing shell=True · Issue #284 · codecov/codecov-python

X Title: hg identify call fails because it uses a `|`, but try_to_run() is missing shell=True · Issue #284 · codecov/codecov-python

Description: Noticed by browsing somebody else's CI output: hg identify: option -d not recognized But, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L865 the command's intent is to provide -d n...

Open Graph Description: Noticed by browsing somebody else's CI output: hg identify: option -d not recognized But, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L865...

X Description: Noticed by browsing somebody else's CI output: hg identify: option -d not recognized But, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#...

Opengraph URL: https://github.com/codecov/codecov-python/issues/284

X: @github

direct link

Domain: github.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"hg identify call fails because it uses a `|`, but try_to_run() is missing shell=True","articleBody":"Noticed by browsing somebody else's CI output:\r\n```\r\n hg identify: option -d not recognized\r\n```\r\n\r\nBut, as you can see in this file: https://github.com/codecov/codecov-python/blob/master/codecov/__init__.py#L865 the command's intent is to provide `-d` not to `hg id`, but to `tr`. It doesn't work because by default `shell` argument of `try_to_run()` is False.\r\n\r\nThe fix could be to just provide shell=True to that function, but I suggest to replace the whole call with `try_to_run(['hg', 'log', '-r', '.', '-T', '{node}'])`.\r\n\r\nThank you for supporting Mercurial. If you have any questions, feel free to ping me.","author":{"url":"https://github.com/antonv6","@type":"Person","name":"antonv6"},"datePublished":"2020-07-04T16:18:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/284/codecov-python/issues/284"}

Links:

Viewport: width=device-width