René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Passing JSON value other than an object in request body results in 500 Internal Server Error","articleBody":"When the client sends a POST request that consists of any other JSON value besides a JSON object, e.g, a string or an array, the endpoints framework returns with 500 Internal Server Error. Would expert a 400 Bad Request error for parsing ProtoRPC request.\r\n\r\nTo reproduce, e.g., use [the echo example](https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/appengine/standard/endpoints-frameworks-v2/echo).\r\nExample queries returning 500:\r\n\r\n`curl https://\u003cYOUR-PROJECT-ID\u003e.appspot.com/_ah/api/echo/v1/echo -H \"Content-Type: application/json\" -d '\"hello world\"'`\r\n\r\n`curl https://\u003cYOUR-PROJECT-ID\u003e.appspot.com/_ah/api/echo/v1/echo -H \"Content-Type: application/json\" -d '[\"hello\", \"world\"]'`\r\n\r\nLog message:\r\n```\r\nTraceback (most recent call last):\r\n  File \"/base/alloc/tmpfs/dynamic_runtimes/python27g/7679791231c143f9/python27/python27_lib/versions/1/google/appengine/runtime/wsgi.py\", line 267, in Handle\r\n    result = handler(dict(self._environ), self._StartResponse)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints_management/control/wsgi.py\", line 166, in __call__\r\n    return self.wsgi_backend(environ, start_response)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints_management/control/wsgi.py\", line 278, in __call__\r\n    return self._application(environ, start_response)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints_management/control/wsgi.py\", line 723, in __call__\r\n    return self._application(environ, start_response)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints_management/control/wsgi.py\", line 415, in __call__\r\n    result = b''.join(result)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 147, in __call__\r\n    yield self.dispatch(request, start_response)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 170, in dispatch\r\n    return self.call_backend(request, start_response)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 337, in call_backend\r\n    orig_request, params, method_config)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 510, in transform_request\r\n    request = self.transform_rest_request(orig_request, params, method_params)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 641, in transform_rest_request\r\n    self._update_from_body(body_json, request.body_json)\r\n  File \"/base/data/home/apps/s~peeter-sandbox/20190418t084040.417569099234297404/lib/endpoints/endpoints_dispatcher.py\", line 552, in _update_from_body\r\n    for key, value in source.iteritems():\r\nAttributeError: 'unicode' object has no attribute 'iteritems'\"\r\n```\r\n\r\nFor me it seems, that in the `endpoints_dispatcher.py`, `_update_from_body` functions just assumes that the given `request.body_json` is a dict without providing a graceful fallback.","author":{"url":"https://github.com/ppik","@type":"Person","name":"ppik"},"datePublished":"2019-04-18T10:35:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/192/endpoints-python/issues/192"}