René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should a `nil` `:ns-prefix` be allowed in `codegen/write-namespace!`?","articleBody":"Hi,\r\n\r\nI was using `codegen/write-namespace!` and found that using a `nil` `:ns-prefix` results in a generated namespace that starts with a `.`. This makes the generated namespace an illegal Java class name.\r\n\r\nI was wondering if a `nil` `:ns-prefix` would be an allowed? This would allow the same namespace patterns between Clojure and Python, making interop seem more \"seamless\".\r\n\r\nA possible implementation would be the `ns-symbol` binding in `codegen/write-namespace!` ignoring a `nil` or blank `:ns-prefix`, e.g.,\r\n\r\n```diff\r\n(defn write-namespace! \r\n  ...\r\n  (let [...\r\n-       ns-symbol (or ns-symbol (symbol (str ns-prefix \".\" py-mod-or-cls)))]\r\n+       ns-symbol (or ns-symbol (symbol (str (when-not (s/blank? ns-prefix) (str ns-prefix \".\"))\r\n+                                            py-mod-or-cls)))]\r\n\r\n```    \r\n\r\nI see that we can already define `:ns-symbol` directly to achieve a `nil` `:ns-prefix`, so this may already be allowed behaviour.\r\n\r\nFor your kind consideration. \r\n\r\nMany thanks for this excellent library!","author":{"url":"https://github.com/harishmohanadas","@type":"Person","name":"harishmohanadas"},"datePublished":"2022-08-02T06:18:06.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/211/libpython-clj/issues/211"}