René's URL Explorer Experiment


Title: Bugfix: Retention period is being sent to the API as 0 by greggroth · Pull Request #5706 · cli/cli · GitHub

Open Graph Title: Bugfix: Retention period is being sent to the API as 0 by greggroth · Pull Request #5706 · cli/cli

X Title: Bugfix: Retention period is being sent to the API as 0 by greggroth · Pull Request #5706 · cli/cli

Description: GitHub’s official command line tool. Contribute to cli/cli development by creating an account on GitHub.

Open Graph Description: The initialized value of time.Duration is 0. There is support for nil retention period at the API interface, but we missed support for this at the parameters. Thus, the API request is being made wi...

X Description: The initialized value of time.Duration is 0. There is support for nil retention period at the API interface, but we missed support for this at the parameters. Thus, the API request is being made wi...

Opengraph URL: https://github.com/cli/cli/pull/5706

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9502fb55-3793-545b-27db-a40498677663
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id992E:21C9D6:17B488C:1F7026A:6A543D2B
html-safe-nonce84d825b6b451ee680a13b7551d034be2c76f1192e394d8a59527c40b1ae6d4d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTJFOjIxQzlENjoxN0I0ODhDOjFGNzAyNkE6NkE1NDNEMkIiLCJ2aXNpdG9yX2lkIjoiMzM0MjkxNDE4OTQ3NTk4NjczMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8e0247fd085569ecebe9e67e9747371272c48dfff19b1e15ff4b8401aad5ed7e
hovercard-subject-tagpull_request:946029066
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cli/cli/5706/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0f84f694fcec618445e015fc021638f9e82d553b48e1dc3e1d7cfb43c3518073/cli/cli/pull/5706
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0f84f694fcec618445e015fc021638f9e82d553b48e1dc3e1d7cfb43c3518073/cli/cli/pull/5706
og:image:altThe initialized value of time.Duration is 0. There is support for nil retention period at the API interface, but we missed support for this at the parameters. Thus, the API request is being made wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegreggroth
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/cli/cli git https://github.com/cli/cli.git
octolytics-dimension-user_id59704711
octolytics-dimension-user_logincli
octolytics-dimension-repository_id212613049
octolytics-dimension-repository_nwocli/cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id212613049
octolytics-dimension-repository_network_root_nwocli/cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/cli/cli/pull/5706#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcli%2Fcli%2Fpull%2F5706
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcli%2Fcli%2Fpull%2F5706
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cli%2Fcli
Reloadhttps://github.com/cli/cli/pull/5706
Reloadhttps://github.com/cli/cli/pull/5706
Reloadhttps://github.com/cli/cli/pull/5706
Please reload this pagehttps://github.com/cli/cli/pull/5706
cli https://github.com/cli
clihttps://github.com/cli/cli
Notifications https://github.com/login?return_to=%2Fcli%2Fcli
Fork 8.7k https://github.com/login?return_to=%2Fcli%2Fcli
Star 45.3k https://github.com/login?return_to=%2Fcli%2Fcli
Code https://github.com/cli/cli
Issues 967 https://github.com/cli/cli/issues
Pull requests 57 https://github.com/cli/cli/pulls
Discussions https://github.com/cli/cli/discussions
Actions https://github.com/cli/cli/actions
Projects https://github.com/cli/cli/projects
Models https://github.com/cli/cli/models
Security and quality 8 https://github.com/cli/cli/security
Insights https://github.com/cli/cli/pulse
Code https://github.com/cli/cli
Issues https://github.com/cli/cli/issues
Pull requests https://github.com/cli/cli/pulls
Discussions https://github.com/cli/cli/discussions
Actions https://github.com/cli/cli/actions
Projects https://github.com/cli/cli/projects
Models https://github.com/cli/cli/models
Security and quality https://github.com/cli/cli/security
Insights https://github.com/cli/cli/pulse
mislavhttps://github.com/mislav
cli:trunkhttps://github.com/cli/cli/tree/trunk
greggroth:gregg/zero-retentionhttps://github.com/greggroth/cli/tree/gregg/zero-retention
Conversationhttps://github.com/cli/cli/pull/5706
Commits6 (6)https://github.com/cli/cli/pull/5706/commits
Checkshttps://github.com/cli/cli/pull/5706/checks
Files changedhttps://github.com/cli/cli/pull/5706/files
Bugfix: Retention period is being sent to the API as 0https://github.com/cli/cli/pull/5706#top
mislavhttps://github.com/mislav
cli:trunkhttps://github.com/cli/cli/tree/trunk
greggroth:gregg/zero-retentionhttps://github.com/greggroth/cli/tree/gregg/zero-retention
https://github.com/greggroth
greggrothhttps://github.com/greggroth
May 24, 2022https://github.com/cli/cli/pull/5706#issue-1247007924
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/greggroth
Improve test failure messaginghttps://github.com/cli/cli/pull/5706/commits/64cd7e00ec95030960b1e08af434b3a06f566577
64cd7e0https://github.com/cli/cli/pull/5706/commits/64cd7e00ec95030960b1e08af434b3a06f566577
https://github.com/greggroth
greggrothhttps://github.com/greggroth
code ownerhttps://github.com/cli/cli/blob/ec12d27db5925c1f99193518252a971372acb71f/CODEOWNERS#L3
May 24, 2022 19:03https://github.com/cli/cli/pull/5706#event-6671676640
https://github.com/cliAutomation
cliAutomationhttps://github.com/cliAutomation
external https://github.com/cli/cli/issues?q=state%3Aopen%20label%3Aexternal
May 24, 2022https://github.com/cli/cli/pull/5706#event-6671678090
https://github.com/cliAutomation
cliAutomationhttps://github.com/cliAutomation
May 24, 2022https://github.com/cli/cli/pull/5706#issuecomment-1136327904
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/markphelps
markphelpshttps://github.com/markphelps
May 24, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-983732093
View reviewed changes https://github.com/cli/cli/pull/5706/files
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
markphelpshttps://github.com/markphelps
May 24, 2022https://github.com/cli/cli/pull/5706#discussion_r880864336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cli/cli/pull/5706
greggrothhttps://github.com/greggroth
May 24, 2022https://github.com/cli/cli/pull/5706#discussion_r880911171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
DurationVar from the pflag library https://pkg.go.dev/github.com/spf13/pflag#DurationVar
Please reload this pagehttps://github.com/cli/cli/pull/5706
reybardhttps://github.com/reybard
May 24, 2022https://github.com/cli/cli/pull/5706#discussion_r880993278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://pkg.go.dev/github.com/spf13/pflag#Varhttps://pkg.go.dev/github.com/spf13/pflag#Var
https://pkg.go.dev/github.com/spf13/pflag#Valuehttps://pkg.go.dev/github.com/spf13/pflag#Value
Please reload this pagehttps://github.com/cli/cli/pull/5706
mislavhttps://github.com/mislav
May 25, 2022https://github.com/cli/cli/pull/5706#discussion_r881536114
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
cli/pkg/cmdutil/flags.gohttps://github.com/cli/cli/blob/ec12d27db5925c1f99193518252a971372acb71f/pkg/cmdutil/flags.go#L12-L16
ec12d27https://github.com/cli/cli/commit/ec12d27db5925c1f99193518252a971372acb71f
@reybardhttps://github.com/reybard
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/markphelps
markphelpshttps://github.com/markphelps
May 24, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-983733548
View reviewed changes https://github.com/cli/cli/pull/5706/files
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/greggroth
greggrothhttps://github.com/greggroth
force-pushedhttps://github.com/cli/cli/compare/a3124a76691a5449979105e0769308e135351246..ac4265605862141a138ff1083884e8477d54adb8
a3124a7https://github.com/cli/cli/commit/a3124a76691a5449979105e0769308e135351246
ac42656https://github.com/cli/cli/commit/ac4265605862141a138ff1083884e8477d54adb8
Compare https://github.com/cli/cli/compare/a3124a76691a5449979105e0769308e135351246..ac4265605862141a138ff1083884e8477d54adb8
May 24, 2022 19:25https://github.com/cli/cli/pull/5706#event-6671806869
https://github.com/greggroth
Switch retention-period flag to stringhttps://github.com/cli/cli/pull/5706/commits/8b4c859761c2bafe18542599d3e431dd5f93ce7e
8b4c859https://github.com/cli/cli/pull/5706/commits/8b4c859761c2bafe18542599d3e431dd5f93ce7e
https://github.com/greggroth
greggrothhttps://github.com/greggroth
force-pushedhttps://github.com/cli/cli/compare/ac4265605862141a138ff1083884e8477d54adb8..8b4c859761c2bafe18542599d3e431dd5f93ce7e
ac42656https://github.com/cli/cli/commit/ac4265605862141a138ff1083884e8477d54adb8
8b4c859https://github.com/cli/cli/commit/8b4c859761c2bafe18542599d3e431dd5f93ce7e
Compare https://github.com/cli/cli/compare/ac4265605862141a138ff1083884e8477d54adb8..8b4c859761c2bafe18542599d3e431dd5f93ce7e
May 24, 2022 20:13https://github.com/cli/cli/pull/5706#event-6672072544
https://github.com/greggroth
Use custom NullableDuration type rather than Stringhttps://github.com/cli/cli/pull/5706/commits/493e85c6fd613fafd29ea3512de41859df741253
493e85chttps://github.com/cli/cli/pull/5706/commits/493e85c6fd613fafd29ea3512de41859df741253
https://github.com/reybard
reybardhttps://github.com/reybard
May 24, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-983947401
View reviewed changes https://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253
reybardhttps://github.com/reybard
https://github.com/cli/cli/pull/5706#pullrequestreview-983947401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/markphelps
markphelpshttps://github.com/markphelps
May 24, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-983952662
View reviewed changes https://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/josebalius
josebaliushttps://github.com/josebalius
May 25, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-984691619
View reviewed changes https://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
Please reload this pagehttps://github.com/cli/cli/pull/5706
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
josebaliushttps://github.com/josebalius
May 25, 2022https://github.com/cli/cli/pull/5706#discussion_r881568796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/cli/cli/pull/5706
greggrothhttps://github.com/greggroth
May 25, 2022https://github.com/cli/cli/pull/5706#discussion_r881782008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Value interfacehttps://pkg.go.dev/github.com/spf13/pflag#Value
Please reload this pagehttps://github.com/cli/cli/pull/5706
pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253#diff-3f7912b8f46094a19631987437a373da8950df75b008c34d8bd612fcf190c564
Please reload this pagehttps://github.com/cli/cli/pull/5706
greggrothhttps://github.com/greggroth
May 25, 2022 08:13https://github.com/cli/cli/pull/5706#commits-pushed-441426c
https://github.com/greggroth
https://github.com/josebalius
Update pkg/cmd/codespace/create.gohttps://github.com/cli/cli/pull/5706/commits/441426c5ef54f3f567c2cff1b1b6481eacee0a44
441426chttps://github.com/cli/cli/pull/5706/commits/441426c5ef54f3f567c2cff1b1b6481eacee0a44
https://github.com/greggroth
Move Duration->Minutes function to NullableDurationhttps://github.com/cli/cli/pull/5706/commits/d40a05a87327189a436ddfb3ea03dd82ad8793e1
d40a05ahttps://github.com/cli/cli/pull/5706/commits/d40a05a87327189a436ddfb3ea03dd82ad8793e1
https://github.com/greggroth
Fix flag descriptionhttps://github.com/cli/cli/pull/5706/commits/e8ce811252de402a52c7d7d25dc6589ba0239f28
e8ce811https://github.com/cli/cli/pull/5706/commits/e8ce811252de402a52c7d7d25dc6589ba0239f28
https://github.com/markphelps
markphelpshttps://github.com/markphelps
May 25, 2022 https://github.com/cli/cli/pull/5706#pullrequestreview-985026439
View reviewed changes https://github.com/cli/cli/pull/5706/files/e8ce811252de402a52c7d7d25dc6589ba0239f28
https://github.com/mislav
mislavhttps://github.com/mislav
77507cdhttps://github.com/cli/cli/commit/77507cd94ccafcf568f8560cfecde965fcfa63e7
May 25, 2022https://github.com/cli/cli/pull/5706#event-6678924851
https://github.com/greggroth
greggrothhttps://github.com/greggroth
May 25, 2022 15:54https://github.com/cli/cli/pull/5706#event-6679069243
https://github.co/hiddenchars
https://github.com/cli/cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcli%2Fcli%2Fpull%2F5706
https://github.com/mislav
mislav https://github.com/mislav
https://github.com/cli/cli/pull/5706/files/aef595ac0be3273d2a369baa719aa6826423f151
https://github.com/josebalius
josebalius https://github.com/josebalius
https://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253
https://github.com/markphelps
markphelps https://github.com/markphelps
https://github.com/cli/cli/pull/5706/files/e8ce811252de402a52c7d7d25dc6589ba0239f28
https://github.com/reybard
reybard https://github.com/reybard
https://github.com/cli/cli/pull/5706/files/493e85c6fd613fafd29ea3512de41859df741253
external https://github.com/cli/cli/issues?q=state%3Aopen%20label%3Aexternal
Please reload this pagehttps://github.com/cli/cli/pull/5706
https://github.com/greggroth
https://github.com/cliAutomation
https://github.com/mislav
https://github.com/markphelps
https://github.com/josebalius
https://github.com/reybard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.