| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:74d81bf0-64a4-ef70-9d42-39bc893b031f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A99C:63A32:73F872:A3E431:6AFB6915 |
| html-safe-nonce | da6267d94a9f91758e1e8fc6f5954b9dc685b13d8e73f84433059b4de0bcf82b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTlDOjYzQTMyOjczRjg3MjpBM0U0MzE6NkFGQjY5MTUiLCJ2aXNpdG9yX2lkIjoiODI0NzA1MjgxMTc5NTkxNzA3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 202ee59bc4ef0591d0e116f0036db6aed5a8d4bea6f70b3854af0fe7c3dc5676 |
| hovercard-subject-tag | pull_request:1545527121 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/1838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eb146b4c1353d8a535d6667adf5d3c8682bfbc28be2bf910e304e5c6fd4b1263/clerk/javascript/pull/1838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eb146b4c1353d8a535d6667adf5d3c8682bfbc28be2bf910e304e5c6fd4b1263/clerk/javascript/pull/1838 |
| og:image:alt | Description
This PR fixes layout shift that is happening when Social block button is in loading state.
Before:
CleanShot.2023-10-09.at.17.06.33.mp4
After:
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | octoper |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerkinc/javascript/pull/1838#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F1838 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F1838 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerkinc/javascript/pull/1838 |
| Reload | https://github.com/clerkinc/javascript/pull/1838 |
| Reload | https://github.com/clerkinc/javascript/pull/1838 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues45 (45) | https://github.com/clerk/javascript/issues |
| Pull requests110 (110) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| nikosdouvlis | https://github.com/nikosdouvlis |
| main | https://github.com/clerk/javascript/tree/main |
| vaggelis/js-792-layout-shift-still-happening-for-social-button | https://github.com/clerk/javascript/tree/vaggelis/js-792-layout-shift-still-happening-for-social-button |
| Conversation | https://github.com/clerk/javascript/pull/1838 |
| Commits5 (5) | https://github.com/clerk/javascript/pull/1838/commits |
| Checks | https://github.com/clerk/javascript/pull/1838/checks |
| Files changed | https://github.com/clerk/javascript/pull/1838/files |
| fix(clerk-js): Fix layout shift for Social block buttons | https://github.com/clerkinc/javascript/pull/1838#top |
| nikosdouvlis | https://github.com/nikosdouvlis |
| main | https://github.com/clerk/javascript/tree/main |
| vaggelis/js-792-layout-shift-still-happening-for-social-button | https://github.com/clerk/javascript/tree/vaggelis/js-792-layout-shift-still-happening-for-social-button |
|
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| Oct 6, 2023 | https://github.com/clerkinc/javascript/pull/1838#issue-1930378309 |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerkinc/clerk-docs |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Oct 6, 2023 | https://github.com/clerkinc/javascript/pull/1838#issuecomment-1750842486 |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| 9efbefb | https://github.com/clerk/javascript/commit/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerkinc/javascript/new/vaggelis/js-792-layout-shift-still-happening-for-social-button?filename=.changeset/clever-starfishes-hammer.md&value=---%0A%22%40clerk%2Fclerk-js%22%3A%20patch%0A---%0A%0Afix(clerk-js)%3A%20Fix%20layout%20shift%20for%20Social%20block%20buttons%0A |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Oct 6, 2023 | https://github.com/clerkinc/javascript/pull/1838#event-10576391713 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| Oct 6, 2023 | https://github.com/clerkinc/javascript/pull/1838#event-10579211848 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| Oct 6, 2023 | https://github.com/clerkinc/javascript/pull/1838#event-10579215483 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| force-pushed | https://github.com/clerk/javascript/compare/731b4deb4a1f9a1ea337c0ccd8951991de4608f4..b1fe1f54e3a01d260fd59e77bbecfa1f09848872 |
| 731b4de | https://github.com/clerk/javascript/commit/731b4deb4a1f9a1ea337c0ccd8951991de4608f4 |
| b1fe1f5 | https://github.com/clerk/javascript/commit/b1fe1f54e3a01d260fd59e77bbecfa1f09848872 |
|
Compare
| https://github.com/clerk/javascript/compare/731b4deb4a1f9a1ea337c0ccd8951991de4608f4..b1fe1f54e3a01d260fd59e77bbecfa1f09848872 |
| October 6, 2023 19:48 | https://github.com/clerkinc/javascript/pull/1838#event-10579217985 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| October 6, 2023 19:50 | https://github.com/clerkinc/javascript/pull/1838#event-10579228762 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| code owner | https://github.com/clerk/javascript/blob/bf66d73228e404a36ea04426d95c2e084d81f2e4/CODEOWNERS#L1 |
| October 6, 2023 19:50 | https://github.com/clerkinc/javascript/pull/1838#event-10579228823 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| force-pushed | https://github.com/clerk/javascript/compare/b1fe1f54e3a01d260fd59e77bbecfa1f09848872..1f884f37a5acab19e7b495f20fa4135422e7b5b8 |
| b1fe1f5 | https://github.com/clerk/javascript/commit/b1fe1f54e3a01d260fd59e77bbecfa1f09848872 |
| 1f884f3 | https://github.com/clerk/javascript/commit/1f884f37a5acab19e7b495f20fa4135422e7b5b8 |
|
Compare
| https://github.com/clerk/javascript/compare/b1fe1f54e3a01d260fd59e77bbecfa1f09848872..1f884f37a5acab19e7b495f20fa4135422e7b5b8 |
| October 6, 2023 21:47 | https://github.com/clerkinc/javascript/pull/1838#event-10579969229 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Oct 9, 2023 | https://github.com/clerkinc/javascript/pull/1838#issuecomment-1752760143 |
| @octoper | https://github.com/octoper |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| Oct 9, 2023 | https://github.com/clerkinc/javascript/pull/1838#issuecomment-1753069567 |
| @panteliselef | https://github.com/panteliselef |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| Oct 9, 2023 | https://github.com/clerkinc/javascript/pull/1838#issuecomment-1753101469 |
| @panteliselef | https://github.com/panteliselef |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| octoper | https://github.com/octoper |
| October 9, 2023 17:39 | https://github.com/clerkinc/javascript/pull/1838#commits-pushed-ef88185 |
|
| https://github.com/octoper |
| fix(clerk-js): Removed loading spinner padding and constrained the so… | https://github.com/clerk/javascript/pull/1838/commits/ef88185cd305e7898c2f45d7a0a97ccc86898867 |
| ef88185 | https://github.com/clerk/javascript/pull/1838/commits/ef88185cd305e7898c2f45d7a0a97ccc86898867 |
|
| https://github.com/octoper |
| chore(repo): Add changeset | https://github.com/clerk/javascript/pull/1838/commits/999a7dbf18319929e6b0ff1148bec71c4a8796e2 |
| 999a7db | https://github.com/clerk/javascript/pull/1838/commits/999a7dbf18319929e6b0ff1148bec71c4a8796e2 |
|
| https://github.com/octoper |
| feat(clerk-js): Added new size variant for Spinner | https://github.com/clerk/javascript/pull/1838/commits/3f597a6dc8a283fad69984c6d00e6aeafb54f3ab |
| 3f597a6 | https://github.com/clerk/javascript/pull/1838/commits/3f597a6dc8a283fad69984c6d00e6aeafb54f3ab |
|
| https://github.com/octoper |
| feat(clerk-js): Increase icon and spinner size for ArrowBlockButton c… | https://github.com/clerk/javascript/pull/1838/commits/2394bf857573f42ec014c3ad53175095ff3b2961 |
| 2394bf8 | https://github.com/clerk/javascript/pull/1838/commits/2394bf857573f42ec014c3ad53175095ff3b2961 |
| https://github.com/octoper |
| octoper | https://github.com/octoper |
| force-pushed | https://github.com/clerk/javascript/compare/d34278cddef43132b46b17ace63ef261aa7d1fe6..2394bf857573f42ec014c3ad53175095ff3b2961 |
| d34278c | https://github.com/clerk/javascript/commit/d34278cddef43132b46b17ace63ef261aa7d1fe6 |
| 2394bf8 | https://github.com/clerk/javascript/commit/2394bf857573f42ec014c3ad53175095ff3b2961 |
|
Compare
| https://github.com/clerk/javascript/compare/d34278cddef43132b46b17ace63ef261aa7d1fe6..2394bf857573f42ec014c3ad53175095ff3b2961 |
| October 9, 2023 14:47 | https://github.com/clerkinc/javascript/pull/1838#event-10592282620 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
|
Oct 10, 2023
| https://github.com/clerkinc/javascript/pull/1838#pullrequestreview-1666613289 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/1838/files/2394bf857573f42ec014c3ad53175095ff3b2961 |
| packages/clerk-js/src/ui/primitives/Spinner.tsx | https://github.com/clerk/javascript/pull/1838/files/2394bf857573f42ec014c3ad53175095ff3b2961#diff-5af6f00f2cfc9b60f2ceec8dfbfb23d04a3b86be55765907cfecd19adaefbf45 |
| panteliselef | https://github.com/panteliselef |
| Oct 10, 2023 | https://github.com/clerkinc/javascript/pull/1838#discussion_r1351772215 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| octoper | https://github.com/octoper |
| Oct 10, 2023 | https://github.com/clerkinc/javascript/pull/1838#discussion_r1351779791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
|
| https://github.com/octoper |
| fix(clerk-js): Update Spinner size | https://github.com/clerk/javascript/pull/1838/commits/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| 9efbefb | https://github.com/clerk/javascript/pull/1838/commits/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
|
Oct 10, 2023
| https://github.com/clerkinc/javascript/pull/1838#pullrequestreview-1667045013 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/1838/files/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| panteliselef | https://github.com/panteliselef |
| https://github.com/clerkinc/javascript/pull/1838#pullrequestreview-1667045013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @octoper | https://github.com/octoper |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
|
Oct 10, 2023
| https://github.com/clerkinc/javascript/pull/1838#pullrequestreview-1667165561 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/1838/files/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| nikosdouvlis | https://github.com/nikosdouvlis |
| https://github.com/clerkinc/javascript/pull/1838#pullrequestreview-1667165561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
| f20adc3 | https://github.com/clerk/javascript/commit/f20adc357cd9fd34cedb4cc7aac2df4be77fb8ea |
| Oct 10, 2023 | https://github.com/clerk/javascript/pull/1838#event-10602368929 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
| October 10, 2023 10:28 | https://github.com/clerkinc/javascript/pull/1838#event-10602369149 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Oct 10, 2023
| https://github.com/clerkinc/javascript/pull/1838#ref-pullrequest-1930967799 |
|
Version Packages
#1843
| https://github.com/clerk/javascript/pull/1843 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
| Oct 10, 2024 | https://github.com/clerkinc/javascript/pull/1838#issuecomment-2403641674 |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
| https://github.com/clerk |
| clerk | https://github.com/clerk |
| Oct 10, 2024 | https://github.com/clerkinc/javascript/pull/1838#event-14581083300 |
| https://github.co/hiddenchars |
| https://github.com/clerkinc/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F1838 |
|
| https://github.com/nikosdouvlis |
|
nikosdouvlis
| https://github.com/nikosdouvlis |
|
| https://github.com/clerk/javascript/pull/1838/files/9efbefbd581376a787c6ce745bcf951ccdaee390 |
|
| https://github.com/panteliselef |
|
panteliselef
| https://github.com/panteliselef |
|
| https://github.com/clerk/javascript/pull/1838/files/9efbefbd581376a787c6ce745bcf951ccdaee390 |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Please reload this page | https://github.com/clerkinc/javascript/pull/1838 |
|
| https://github.com/octoper |
|
| https://github.com/panteliselef |
|
| https://github.com/clerk-cookie |
|
| https://github.com/nikosdouvlis |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |