René's URL Explorer Experiment


Title: fix(ui): align dialog close icon, not its button box, with the corner inset by maxyinger · Pull Request #9429 · clerk/javascript · GitHub

Open Graph Title: fix(ui): align dialog close icon, not its button box, with the corner inset by maxyinger · Pull Request #9429 · clerk/javascript

X Title: fix(ui): align dialog close icon, not its button box, with the corner inset by maxyinger · Pull Request #9429 · clerk/javascript

Description: Official JavaScript repository for Clerk authentication - fix(ui): align dialog close icon, not its button box, with the corner inset by maxyinger · Pull Request #9429 · clerk/javascript

Open Graph Description: Description The Dialog close button is absolutely positioned at each surface's corner inset, but the inset was measured to the button's outer edge. The button is a sm circle — a 28px box wi...

X Description: Description The Dialog close button is absolutely positioned at each surface's corner inset, but the inset was measured to the button's outer edge. The button is a sm circle — a 28p...

Opengraph URL: https://github.com/clerk/javascript/pull/9429

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:241b47af-2940-95fe-1be0-549f998e66a8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA3A:90D42:1ADB31:27F9F8:6AFAD900
html-safe-noncef135a96aa4f3714700bd213c637b62e0c46b8496f031850b5158cfaf0fb795cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTNBOjkwRDQyOjFBREIzMToyN0Y5Rjg6NkFGQUQ5MDAiLCJ2aXNpdG9yX2lkIjoiNjIxMjE4MDIzNDE3OTYzMTM2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0a66808e928fdcc830efddeaaeb615eebcd56f377f66c0451bea489c4f271a4c
hovercard-subject-tagpull_request:4267628051
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/9429/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b803673c9002f51bb0b4f02a6ab036ec94d0072051ae5f20223313f66a02f582/clerk/javascript/pull/9429
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b803673c9002f51bb0b4f02a6ab036ec94d0072051ae5f20223313f66a02f582/clerk/javascript/pull/9429
og:image:altDescription The Dialog close button is absolutely positioned at each surface's corner inset, but the inset was measured to the button's outer edge. The button is a sm circle — a 28px box wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaxyinger
hostnamegithub.com
expected-hostnamegithub.com
None02f4c00e74911c7cd779fc232c3130cee49eb39fd0ed4bfe3eea3b82c7c18084
turbo-cache-controlno-cache
go-importgithub.com/clerk/javascript git https://github.com/clerk/javascript.git
octolytics-dimension-user_id49538330
octolytics-dimension-user_loginclerk
octolytics-dimension-repository_id438331492
octolytics-dimension-repository_nwoclerk/javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id438331492
octolytics-dimension-repository_network_root_nwoclerk/javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release33c41e9d150e44415272934d676dc63c57d89c3b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/clerk/javascript/pull/9429#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9429
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9429
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript
Reloadhttps://github.com/clerk/javascript/pull/9429
Reloadhttps://github.com/clerk/javascript/pull/9429
Reloadhttps://github.com/clerk/javascript/pull/9429
clerkhttps://github.com/clerk
javascripthttps://github.com/clerk/javascript
Codehttps://github.com/clerk/javascript
Issues44 (44)https://github.com/clerk/javascript/issues
Pull requests113 (113)https://github.com/clerk/javascript/pulls
Discussionshttps://github.com/clerk/javascript/discussions
Actionshttps://github.com/clerk/javascript/actions
Security and quality6 (6)https://github.com/clerk/javascript/security
Insightshttps://github.com/clerk/javascript/pulse
https://github.com/clerk/javascript
maxyingerhttps://github.com/maxyinger
mainhttps://github.com/clerk/javascript/tree/main
max/dialog-close-icon-flushhttps://github.com/clerk/javascript/tree/max/dialog-close-icon-flush
Conversationhttps://github.com/clerk/javascript/pull/9429
Commits2 (2)https://github.com/clerk/javascript/pull/9429/commits
Checkshttps://github.com/clerk/javascript/pull/9429/checks
Files changedhttps://github.com/clerk/javascript/pull/9429/files
fix(ui): align dialog close icon, not its button box, with the corner insethttps://github.com/clerk/javascript/pull/9429#top
maxyingerhttps://github.com/maxyinger
mainhttps://github.com/clerk/javascript/tree/main
max/dialog-close-icon-flushhttps://github.com/clerk/javascript/tree/max/dialog-close-icon-flush
https://github.com/maxyinger
maxyingerhttps://github.com/maxyinger
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issue-5137246608
JSDoc commentshttps://jsdoc.app/about-getting-started.html
Documentationhttps://github.com/clerk/clerk-docs
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
maxyingerhttps://github.com/maxyinger
August 12, 2026 20:44https://github.com/clerk/javascript/pull/9429#commits-pushed-7ef5054
https://github.com/maxyinger
https://github.com/claude
fix(ui): align dialog close icon, not its button box, with the corner…https://github.com/clerk/javascript/pull/9429/commits/7ef5054a37b40714b2b94b7d29036c6d37418bd9
7ef5054https://github.com/clerk/javascript/pull/9429/commits/7ef5054a37b40714b2b94b7d29036c6d37418bd9
https://github.com/maxyinger
https://github.com/claude
chore(repo): add changesethttps://github.com/clerk/javascript/pull/9429/commits/ff0798d127777f4c5ecf6ceb235c711773c081e8
ff0798dhttps://github.com/clerk/javascript/pull/9429/commits/ff0798d127777f4c5ecf6ceb235c711773c081e8
https://github.com/apps/changeset-bot
changeset-bothttps://github.com/apps/changeset-bot
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issuecomment-5275324944
ff0798dhttps://github.com/clerk/javascript/commit/ff0798d127777f4c5ecf6ceb235c711773c081e8
Click here to learn what changesets arehttps://changesets.dev/faq
Click here if you're a maintainer who wants to add another changeset to this PRhttps://github.com/clerk/javascript/new/max/dialog-close-icon-flush?filename=.changeset/purple-days-slide.md&value=---%0A%22%40clerk%2Fui%22%3A%20patch%0A---%0A%0Afix(ui)%3A%20align%20dialog%20close%20icon%2C%20not%20its%20button%20box%2C%20with%20the%20corner%20inset%0A
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issuecomment-5275325450
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
Vercel for GitHubhttps://vercel.link/github-learn-more
https://vercel.com/clerk-production/clerk-js-sandbox
clerk-js-sandboxhttps://vercel.com/clerk-production/clerk-js-sandbox
https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667
Readyhttps://vercel.com/clerk-production/clerk-js-sandbox/Fet6fPgayHNjejKbFYSRo1Q6mhGX
Previewhttps://clerk-js-sandbox-git-max-dialog-close-icon-flush.clerkstage.dev
https://vercel.com/clerk-production/swingset
swingsethttps://vercel.com/clerk-production/swingset
https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667
Readyhttps://vercel.com/clerk-production/swingset/FoyWjKpLpDjY5h9QKKU6b9ucD7ZB
Previewhttps://swingset-git-max-dialog-close-icon-flush.clerkstage.dev
https://vercel.com/vercel-agent/request-review?owner=clerk&repo=javascript&pr=9429
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
ui https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aui
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#event-29376682205
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
deployedhttps://clerk-js-sandbox-fnis1gxp1.clerkstage.dev
Preview – clerk-js-sandboxhttps://clerk-js-sandbox-fnis1gxp1.clerkstage.dev
August 13, 2026 02:45https://github.com/clerk/javascript/pull/9429#event-29376689455
View deploymenthttps://clerk-js-sandbox-fnis1gxp1.clerkstage.dev
https://github.com/maxyinger
maxyingerhttps://github.com/maxyinger
alexcarpenterhttps://github.com/alexcarpenter
austincalvelagehttps://github.com/austincalvelage
August 13, 2026 02:46https://github.com/clerk/javascript/pull/9429#event-29376704149
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issuecomment-5275336315
https://app.coderabbit.ai/change-stack/clerk/javascript/pull/9429?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack
clerk/javascript#9388https://github.com/clerk/javascript/pull/9388
clerk/javascript#9420https://github.com/clerk/javascript/pull/9420
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 13, 2026 https://github.com/clerk/javascript/pull/9429#pullrequestreview-4922951317
View reviewed changes https://github.com/clerk/javascript/pull/9429/files/ff0798d127777f4c5ecf6ceb235c711773c081e8
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/clerk/javascript/pull/9429#pullrequestreview-4922951317
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
15711c7https://github.com/clerk/javascript/commit/15711c75e1d38c772b70cbe4666202a5cefc582c
ff0798dhttps://github.com/clerk/javascript/commit/ff0798d127777f4c5ecf6ceb235c711773c081e8
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
.changeset/dialog-close-icon-flush.mdhttps://github.com/clerk/javascript/pull/9429/files/ff0798d127777f4c5ecf6ceb235c711773c081e8#diff-8f65c7618488199203f30a8c05f49c600b4e560018926135f7659d48e3765bdb
coderabbitaihttps://github.com/apps/coderabbitai
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#discussion_r3772018183
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/apps/vercel
vercelhttps://github.com/apps/vercel
deployedhttps://swingset-mzf67oqyy.clerkstage.dev
Preview – swingsethttps://swingset-mzf67oqyy.clerkstage.dev
August 13, 2026 02:47https://github.com/clerk/javascript/pull/9429#event-29376749593
View deploymenthttps://swingset-mzf67oqyy.clerkstage.dev
https://github.com/apps/pkg-pr-new
pkg-pr-newhttps://github.com/apps/pkg-pr-new
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issuecomment-5275345153
Open in StackBlitzhttps://pkg.pr.new/template/4236bbf4-e899-44e0-bc1a-940f83529d45
ff0798dhttps://github.com/clerk/javascript/runs/94328372880
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#issuecomment-5275349349
Break Checkhttps://github.com/clerk/break-check
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/alexcarpenter
alexcarpenterhttps://github.com/alexcarpenter
Aug 13, 2026 https://github.com/clerk/javascript/pull/9429#pullrequestreview-4926870074
View reviewed changes https://github.com/clerk/javascript/pull/9429/files/ff0798d127777f4c5ecf6ceb235c711773c081e8
https://github.com/maxyinger
maxyingerhttps://github.com/maxyinger
915d390https://github.com/clerk/javascript/commit/915d390207828d7dedb71ed036878528ab5bba1e
Aug 13, 2026https://github.com/clerk/javascript/pull/9429#event-29408729214
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/maxyinger
maxyingerhttps://github.com/maxyinger
August 13, 2026 15:25https://github.com/clerk/javascript/pull/9429#event-29408731661
Deployedhttps://swingset-mzf67oqyy.clerkstage.dev
vercel[bot]https://github.com/apps/vercel
View deployment https://swingset-mzf67oqyy.clerkstage.dev
Deployedhttps://clerk-js-sandbox-fnis1gxp1.clerkstage.dev
vercel[bot]https://github.com/apps/vercel
View deployment https://clerk-js-sandbox-fnis1gxp1.clerkstage.dev
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9429
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/clerk/javascript/pull/9429/files/ff0798d127777f4c5ecf6ceb235c711773c081e8
https://github.com/alexcarpenter
alexcarpenter https://github.com/alexcarpenter
https://github.com/clerk/javascript/pull/9429/files/ff0798d127777f4c5ecf6ceb235c711773c081e8
https://github.com/austincalvelage
austincalvelage https://github.com/austincalvelage
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
ui https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aui
Please reload this pagehttps://github.com/clerk/javascript/pull/9429
https://github.com/maxyinger
https://github.com/alexcarpenter
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.