| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e28bd128-ee58-5072-3160-ccf76e50e6bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC74:258059:2CF42E2:3F864A1:6AFAD4D0 |
| html-safe-nonce | 081934d9ecf47aabcd066a2ecd9f92b8abae6cad1a2cf8db0ad6c1be228704ac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzc0OjI1ODA1OToyQ0Y0MkUyOjNGODY0QTE6NkFGQUQ0RDAiLCJ2aXNpdG9yX2lkIjoiNTkyMTI4NTAyODM4OTI0NjE2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | caa9304c9fbf6dd15f2d98dc484b032746e3eeadcfc5b1a5a61c0adfc36942a1 |
| hovercard-subject-tag | pull_request:4231689764 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/9366/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b02390261ff8ccced261d6a1abc107ccfc311e5f3e897135092cefa8a6731d75/clerk/javascript/pull/9366 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b02390261ff8ccced261d6a1abc107ccfc311e5f3e897135092cefa8a6731d75/clerk/javascript/pull/9366 |
| og:image:alt | Description
Adds closedBy to the Dialog, controlling which gestures dismiss it. Mirrors the native <dialog closedby> attribute:
Value
Escape
Outside press
Programmatic
any (default)
✅... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | maxyinger |
| hostname | github.com |
| expected-hostname | github.com |
| None | 02f4c00e74911c7cd779fc232c3130cee49eb39fd0ed4bfe3eea3b82c7c18084 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 33c41e9d150e44415272934d676dc63c57d89c3b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/9366#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9366 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9366 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/9366 |
| Reload | https://github.com/clerk/javascript/pull/9366 |
| Reload | https://github.com/clerk/javascript/pull/9366 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests112 (112) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| maxyinger | https://github.com/maxyinger |
| main | https://github.com/clerk/javascript/tree/main |
| max/dialog-updates | https://github.com/clerk/javascript/tree/max/dialog-updates |
| Conversation | https://github.com/clerk/javascript/pull/9366 |
| Commits3 (3) | https://github.com/clerk/javascript/pull/9366/commits |
| Checks | https://github.com/clerk/javascript/pull/9366/checks |
| Files changed | https://github.com/clerk/javascript/pull/9366/files |
| feat(ui): add dialog closedBy dismissal policy | https://github.com/clerk/javascript/pull/9366#top |
| maxyinger | https://github.com/maxyinger |
| main | https://github.com/clerk/javascript/tree/main |
| max/dialog-updates | https://github.com/clerk/javascript/tree/max/dialog-updates |
|
| https://github.com/maxyinger |
| maxyinger | https://github.com/maxyinger |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issue-5094036478 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
|
| https://github.com/maxyinger |
|
| https://github.com/claude |
| feat(ui): add dialog closedBy dismissal policy | https://github.com/clerk/javascript/pull/9366/commits/38e7c1f31731a88c59914ca27294ac5cee20906f |
| 38e7c1f | https://github.com/clerk/javascript/pull/9366/commits/38e7c1f31731a88c59914ca27294ac5cee20906f |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5222101140 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| Vercel for GitHub | https://vercel.link/github-learn-more |
| https://vercel.com/clerk-production/clerk-js-sandbox |
| clerk-js-sandbox | https://vercel.com/clerk-production/clerk-js-sandbox |
| https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667 |
| Ready | https://vercel.com/clerk-production/clerk-js-sandbox/6XbPRm7ms3VdnDcmP74jH3iybAUt |
| Preview | https://clerk-js-sandbox-git-max-dialog-updates.clerkstage.dev |
| https://vercel.com/clerk-production/swingset |
| swingset | https://vercel.com/clerk-production/swingset |
| https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667 |
| Ready | https://vercel.com/clerk-production/swingset/DHkBgiowrcTkFaf9hc7pEcE1MqvF |
| Preview | https://swingset-git-max-dialog-updates.clerkstage.dev |
| https://vercel.com/vercel-agent/request-review?owner=clerk&repo=javascript&pr=9366 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5222101564 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| d089e1c | https://github.com/clerk/javascript/commit/d089e1c81dfc4e82fcb5f97ee1dd0c9110c7cadc |
| Click here to learn what changesets are | https://changesets.dev/faq |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/max/dialog-updates?filename=.changeset/neat-humans-find.md&value=---%0A%22%40clerk%2Fheadless%22%3A%20patch%0A%22%40clerk%2Fswingset%22%3A%20patch%0A%22%40clerk%2Fui%22%3A%20patch%0A---%0A%0Afeat(ui)%3A%20add%20dialog%20closedBy%20dismissal%20policy%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
ui
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aui |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#event-29141152801 |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://swingset-p4ilvvjz5.clerkstage.dev |
| Preview – swingset | https://swingset-p4ilvvjz5.clerkstage.dev |
| August 7, 2026 21:19 | https://github.com/clerk/javascript/pull/9366#event-29141163530 |
| View deployment | https://swingset-p4ilvvjz5.clerkstage.dev |
| https://github.com/apps/pkg-pr-new |
| pkg-pr-new | https://github.com/apps/pkg-pr-new |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5222131073 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| Open in StackBlitz | https://pkg.pr.new/template/1dfc37c9-2c4e-4f27-9755-dc4ac93b7979 |
| d089e1c | https://github.com/clerk/javascript/runs/94237223319 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5222136811 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| Break Check | https://github.com/clerk/break-check |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Aug 7, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5222144363 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://app.coderabbit.ai/change-stack/clerk/javascript/pull/9366?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack |
| 7c1aa99 | https://github.com/clerk/javascript/commit/7c1aa996e0731eecf3f8192c7339aca202ac9cec |
| d089e1c | https://github.com/clerk/javascript/commit/d089e1c81dfc4e82fcb5f97ee1dd0c9110c7cadc |
| clerk/javascript#9388 | https://github.com/clerk/javascript/pull/9388 |
| clerk/javascript#9420 | https://github.com/clerk/javascript/pull/9420 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 7, 2026
| https://github.com/clerk/javascript/pull/9366#pullrequestreview-4886661015 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/9366/files/38e7c1f31731a88c59914ca27294ac5cee20906f |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/clerk/javascript/pull/9366#pullrequestreview-4886661015 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 6100719 | https://github.com/clerk/javascript/commit/6100719b4d958ed1d8e600e3583d0da0dcc8048a |
| 38e7c1f | https://github.com/clerk/javascript/commit/38e7c1f31731a88c59914ca27294ac5cee20906f |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| packages/headless/src/primitives/dialog/dialog-root.tsx | https://github.com/clerk/javascript/pull/9366/files/38e7c1f31731a88c59914ca27294ac5cee20906f#diff-6a29e95e502319080230f52ee8b2f2fd2db331d1e88500c41bc3f7acdeeacfe9 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 11, 2026
| https://github.com/clerk/javascript/pull/9366#ref-pullrequest-5115879887 |
|
feat(ui): rebuild the Mosaic Dialog on StyleX
#9388
| https://github.com/clerk/javascript/pull/9388 |
|
| https://github.com/maxyinger |
| Merge remote-tracking branch 'origin/main' into max/dialog-updates | https://github.com/clerk/javascript/pull/9366/commits/7c1aa996e0731eecf3f8192c7339aca202ac9cec |
| 7c1aa99 | https://github.com/clerk/javascript/pull/9366/commits/7c1aa996e0731eecf3f8192c7339aca202ac9cec |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Aug 12, 2026 | https://github.com/clerk/javascript/pull/9366#issuecomment-5270450947 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://clerk-js-sandbox-2qqi75en4.clerkstage.dev |
| Preview – clerk-js-sandbox | https://clerk-js-sandbox-2qqi75en4.clerkstage.dev |
| August 12, 2026 17:50 | https://github.com/clerk/javascript/pull/9366#event-29356264058 |
| View deployment | https://clerk-js-sandbox-2qqi75en4.clerkstage.dev |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://swingset-p5tl9fugd.clerkstage.dev |
| Preview – swingset | https://swingset-p5tl9fugd.clerkstage.dev |
| August 12, 2026 17:53 | https://github.com/clerk/javascript/pull/9366#event-29356432805 |
| View deployment | https://swingset-p5tl9fugd.clerkstage.dev |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 12, 2026
| https://github.com/clerk/javascript/pull/9366#ref-pullrequest-5134411826 |
|
Max/dialog composition apis
#9420
| https://github.com/clerk/javascript/pull/9420 |
| https://github.com/alexcarpenter |
| alexcarpenter | https://github.com/alexcarpenter |
|
Aug 12, 2026
| https://github.com/clerk/javascript/pull/9366#pullrequestreview-4920296638 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/9366/files/7c1aa996e0731eecf3f8192c7339aca202ac9cec |
|
| https://github.com/maxyinger |
| chore(repo): make the dialog closedBy changeset empty | https://github.com/clerk/javascript/pull/9366/commits/d089e1c81dfc4e82fcb5f97ee1dd0c9110c7cadc |
| d089e1c | https://github.com/clerk/javascript/pull/9366/commits/d089e1c81dfc4e82fcb5f97ee1dd0c9110c7cadc |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://clerk-js-sandbox-o03f4pabd.clerkstage.dev |
| Preview – clerk-js-sandbox | https://clerk-js-sandbox-o03f4pabd.clerkstage.dev |
| August 12, 2026 19:31 | https://github.com/clerk/javascript/pull/9366#event-29361732086 |
| View deployment | https://clerk-js-sandbox-o03f4pabd.clerkstage.dev |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://swingset-jz1szax6e.clerkstage.dev |
| Preview – swingset | https://swingset-jz1szax6e.clerkstage.dev |
| August 12, 2026 19:33 | https://github.com/clerk/javascript/pull/9366#event-29361822075 |
| View deployment | https://swingset-jz1szax6e.clerkstage.dev |
| https://github.com/maxyinger |
| maxyinger | https://github.com/maxyinger |
| dfc9c0d | https://github.com/clerk/javascript/commit/dfc9c0df1af3217bdfd7ae7e913a87b68dd953a8 |
| Aug 12, 2026 | https://github.com/clerk/javascript/pull/9366#event-29365046090 |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
| https://github.com/maxyinger |
| maxyinger | https://github.com/maxyinger |
| August 12, 2026 20:45 | https://github.com/clerk/javascript/pull/9366#event-29365047619 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Aug 12, 2026
| https://github.com/clerk/javascript/pull/9366#ref-pullrequest-5135403538 |
|
[WIP] feat(ui): sync the mobile browser chrome with the dialog scrim
#9424
| https://github.com/clerk/javascript/pull/9424 |
| https://github.com/maxyinger |
| maxyinger | https://github.com/maxyinger |
|
Aug 13, 2026
| https://github.com/clerk/javascript/pull/9366#ref-pullrequest-5144022379 |
|
refactor(ui): adopt the dialog close confirmation
#9441
| https://github.com/clerk/javascript/pull/9441 |
| Deployed | https://swingset-jz1szax6e.clerkstage.dev |
| vercel[bot] | https://github.com/apps/vercel |
|
View deployment
| https://swingset-jz1szax6e.clerkstage.dev |
| Deployed | https://clerk-js-sandbox-o03f4pabd.clerkstage.dev |
| vercel[bot] | https://github.com/apps/vercel |
|
View deployment
| https://clerk-js-sandbox-o03f4pabd.clerkstage.dev |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9366 |
|
| https://github.com/apps/coderabbitai |
|
coderabbitai[bot]
| https://github.com/apps/coderabbitai |
|
| https://github.com/clerk/javascript/pull/9366/files/38e7c1f31731a88c59914ca27294ac5cee20906f |
|
| https://github.com/alexcarpenter |
|
alexcarpenter
| https://github.com/alexcarpenter |
|
| https://github.com/clerk/javascript/pull/9366/files/7c1aa996e0731eecf3f8192c7339aca202ac9cec |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
|
ui
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aui |
| Please reload this page | https://github.com/clerk/javascript/pull/9366 |
|
| https://github.com/maxyinger |
|
| https://github.com/alexcarpenter |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |