René's URL Explorer Experiment


Title: fix(backend): Align enterprise connection create and update params with the Backend API by manovotny · Pull Request #9155 · clerk/javascript · GitHub

Open Graph Title: fix(backend): Align enterprise connection create and update params with the Backend API by manovotny · Pull Request #9155 · clerk/javascript

X Title: fix(backend): Align enterprise connection create and update params with the Backend API by manovotny · Pull Request #9155 · clerk/javascript

Description: Description Aligns CreateEnterpriseConnectionParams and UpdateEnterpriseConnectionParams with the Backend API contract (clerk_go api/bapi/v1/enterprise_connections/service.go). Folds in #9153 — the provider fix and this work are one thought: the create/update params didn't match what BAPI accepts. Every claim was verified against the Go source. Discovered while reviewing clerk/clerk#2887, where a docs code sample calling createEnterpriseConnection without provider would fail BAPI validation despite type-checking. Required provider field (from #9153) CreateEnterpriseConnectionParams was missing provider, which BAPI validates as required. Calls without it type-checked and failed at runtime. The field is typed as the OrganizationEnterpriseConnectionProvider union from @clerk/shared/types (matching the sibling SamlConnectionApi pattern), with type-level tests so it can't silently become optional or widen back to string. The tanstack-start enterprise SSO integration test was already passing provider behind an as cast to work around the missing field. The cast is removed. Required name and domains, plus deprecations name and domains are now required on create. BAPI validates both (validate:"required", min=1 on domains), so calls without them already failed at runtime — the types now catch it at compile time. Type-level tests lock each field individually. syncUserAttributes on create is deprecated. BAPI's CreateParams has no sync_user_attributes field; the JSON decoder drops it silently. It works on update, and the deprecation notice points there. provider on update is deprecated. BAPI's UpdateParams has no provider field — the provider can't be changed after creation. Missing optional params Adds the optional fields BAPI accepts that the SDK types omitted: allowOrganizationAccountLinking, customAttributes, authenticatable, disableJitProvisioning (create and update), disableAdditionalIdentifications (update only), and saml.loginHint. loginHint is a discriminated union: source is required exactly when mode is 'custom_attribute' and rejected otherwise, matching BAPI's validation. Custom attribute shapes (name and key required) match the Go structs, and all camelCase names were confirmed to snake-case to the exact wire keys. Making previously-optional fields required is a compile-time change, but only for calls that already failed BAPI validation at runtime — it converts a runtime failure into a type error. Ships as a patch for that reason. To test: pnpm --filter @clerk/backend test:node EnterpriseConnectionApi.test.ts — wire-format tests assert every field reaches the request body in snake_case, alongside the type-level assertions. Checklist pnpm test runs as expected. pnpm build runs as expected. (If applicable) JSDoc comments have been added or updated for any package exports (If applicable) Documentation has been updated Type of change 🐛 Bug fix 🌟 New feature 🔨 Breaking change 📖 Refactoring / dependency upgrade / documentation other: 🤖 Generated with Claude Code

Open Graph Description: Description Aligns CreateEnterpriseConnectionParams and UpdateEnterpriseConnectionParams with the Backend API contract (clerk_go api/bapi/v1/enterprise_connections/service.go). Folds in #9153 — the...

X Description: Description Aligns CreateEnterpriseConnectionParams and UpdateEnterpriseConnectionParams with the Backend API contract (clerk_go api/bapi/v1/enterprise_connections/service.go). Folds in #9153 — the...

Opengraph URL: https://github.com/clerk/javascript/pull/9155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9c466827-829b-f874-08ad-959cd72cdf65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9C6:22FE8E:D88097:132301A:6AFB615D
html-safe-noncebfeba773b5bba5c24b3d5577c3b30b7b3fed3781ec7af79a7f33b93225fb0ab7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUM2OjIyRkU4RTpEODgwOTc6MTMyMzAxQTo2QUZCNjE1RCIsInZpc2l0b3JfaWQiOiI2NjU1NDAyMDA0MjIwNDM2ODI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfbc91e8cffcc32840fec63f3ba40ede002d47002c3fbd7ea9ff02aa29f24ccdb
hovercard-subject-tagpull_request:4049646834
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/clerk/javascript/pull/9155/files
twitter:imagehttps://avatars.githubusercontent.com/u/446260?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/446260?s=400&v=4
og:image:altDescription Aligns CreateEnterpriseConnectionParams and UpdateEnterpriseConnectionParams with the Backend API contract (clerk_go api/bapi/v1/enterprise_connections/service.go). Folds in #9153 — the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/clerk/javascript git https://github.com/clerk/javascript.git
octolytics-dimension-user_id49538330
octolytics-dimension-user_loginclerk
octolytics-dimension-repository_id438331492
octolytics-dimension-repository_nwoclerk/javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id438331492
octolytics-dimension-repository_network_root_nwoclerk/javascript
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/clerk/javascript/pull/9155/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9155%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F9155%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=clerk%2Fjavascript
Reloadhttps://github.com/clerk/javascript/pull/9155/files
Reloadhttps://github.com/clerk/javascript/pull/9155/files
Reloadhttps://github.com/clerk/javascript/pull/9155/files
clerkhttps://github.com/clerk
javascripthttps://github.com/clerk/javascript
Codehttps://github.com/clerk/javascript
Issues45 (45)https://github.com/clerk/javascript/issues
Pull requests110 (110)https://github.com/clerk/javascript/pulls
Discussionshttps://github.com/clerk/javascript/discussions
Actionshttps://github.com/clerk/javascript/actions
Security and quality6 (6)https://github.com/clerk/javascript/security
Insightshttps://github.com/clerk/javascript/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fclerk%2Fjavascript%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fclerk%2Fjavascript%2Fissues%2Fnew%2Fchoose
manovotnyhttps://github.com/manovotny
mainhttps://github.com/clerk/javascript/tree/main
manovotny/amazing-lalande-e031c2https://github.com/clerk/javascript/tree/manovotny/amazing-lalande-e031c2
Conversation 6 https://github.com/clerk/javascript/pull/9155
Commits 6 https://github.com/clerk/javascript/pull/9155/commits
Checks 46 https://github.com/clerk/javascript/pull/9155/checks
Files changed https://github.com/clerk/javascript/pull/9155/files
Please reload this pagehttps://github.com/clerk/javascript/pull/9155/files
fix(backend): Align enterprise connection create and update params with the Backend API https://github.com/clerk/javascript/pull/9155/files#top
Show all changes 6 commits https://github.com/clerk/javascript/pull/9155/files
1fd49b8 fix(backend): Add required provider field to CreateEnterpriseConnecti… manovotny Jul 14, 2026 https://github.com/clerk/javascript/pull/9155/commits/1fd49b890c9dbc98036fed5053f3396c8b9e6153
2092c3a fix(backend): Narrow provider to supported values and lock in type co… manovotny Jul 14, 2026 https://github.com/clerk/javascript/pull/9155/commits/2092c3a2f1c1780939118560be08302638f549a7
c6348b1 fix(backend): Require name and domains when creating enterprise conne… manovotny Jul 14, 2026 https://github.com/clerk/javascript/pull/9155/commits/c6348b1e3dd3cc67a881d5b5eef35df88069142a
7b6b5c0 fix(backend): Add missing optional enterprise connection params manovotny Jul 14, 2026 https://github.com/clerk/javascript/pull/9155/commits/7b6b5c002591bfeeb6629ab5c38c54c016acc5a0
1508711 fix(backend): Enforce login hint source/mode pairing at the type level manovotny Jul 14, 2026 https://github.com/clerk/javascript/pull/9155/commits/1508711f22743a0d26cf39f2900a70432f3af8f9
95db01e Merge branch 'main' into manovotny/amazing-lalande-e031c2 wobsoriano Jul 17, 2026 https://github.com/clerk/javascript/pull/9155/commits/95db01e31333414c34d0ab54dedc20421664b99b
Clear filters https://github.com/clerk/javascript/pull/9155/files
Please reload this pagehttps://github.com/clerk/javascript/pull/9155/files
Please reload this pagehttps://github.com/clerk/javascript/pull/9155/files
heavy-melons-argue.md https://github.com/clerk/javascript/pull/9155/files#diff-5e0678bee959595ee678be7fd13ff5b08903134309d163ce295f10493849bfaa
tidy-donuts-attend.md https://github.com/clerk/javascript/pull/9155/files#diff-a52ddda267162cf28887fb02cbc7b6f029374df0f74f73fa4a0c5b4c01e8d42f
violet-planes-repeat.md https://github.com/clerk/javascript/pull/9155/files#diff-97e31f145f3c5d6f89a38d0df4866c986ba7f040b21b527a4c76179483d4da8a
enterprise-sso.test.ts https://github.com/clerk/javascript/pull/9155/files#diff-c92e4df95ba0b0a7510c56be5c7513c3f06490227e3fe46fd613302559f53bcd
EnterpriseConnectionApi.test.ts https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
EnterpriseConnectionApi.ts https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
.changeset/heavy-melons-argue.mdhttps://github.com/clerk/javascript/pull/9155/files#diff-5e0678bee959595ee678be7fd13ff5b08903134309d163ce295f10493849bfaa
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/.changeset/heavy-melons-argue.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
.changeset/tidy-donuts-attend.mdhttps://github.com/clerk/javascript/pull/9155/files#diff-a52ddda267162cf28887fb02cbc7b6f029374df0f74f73fa4a0c5b4c01e8d42f
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/.changeset/tidy-donuts-attend.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
.changeset/violet-planes-repeat.mdhttps://github.com/clerk/javascript/pull/9155/files#diff-97e31f145f3c5d6f89a38d0df4866c986ba7f040b21b527a4c76179483d4da8a
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/.changeset/violet-planes-repeat.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
integration/tests/tanstack-start/enterprise-sso.test.tshttps://github.com/clerk/javascript/pull/9155/files#diff-c92e4df95ba0b0a7510c56be5c7513c3f06490227e3fe46fd613302559f53bcd
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/integration/tests/tanstack-start/enterprise-sso.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
https://github.com/clerk/javascript/pull/9155/files#diff-c92e4df95ba0b0a7510c56be5c7513c3f06490227e3fe46fd613302559f53bcd
https://github.com/clerk/javascript/pull/9155/files#diff-c92e4df95ba0b0a7510c56be5c7513c3f06490227e3fe46fd613302559f53bcd
https://github.com/clerk/javascript/pull/9155/files#diff-c92e4df95ba0b0a7510c56be5c7513c3f06490227e3fe46fd613302559f53bcd
packages/backend/src/api/__tests__/EnterpriseConnectionApi.test.tshttps://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/packages/backend/src/api/__tests__/EnterpriseConnectionApi.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
https://github.com/clerk/javascript/pull/9155/files#diff-e591379c5c8c58d68ba137141fc0792249063d5ab147e9a62e993ede191dbecf
packages/backend/src/api/endpoints/EnterpriseConnectionApi.tshttps://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
View file https://github.com/clerk/javascript/blob/95db01e31333414c34d0ab54dedc20421664b99b/packages/backend/src/api/endpoints/EnterpriseConnectionApi.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/9155/{{ revealButtonHref }}
https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
https://github.com/clerk/javascript/pull/9155/files#diff-9999fb82ff786559361ed0e404e6e1811e42b93dbf66b388ef68a96ff6334c29
Please reload this pagehttps://github.com/clerk/javascript/pull/9155/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.