| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d07224db-0b49-5931-f10d-ef6d364c4c47 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEB6:3F93FB:28B35:3BE8E:6AFACE43 |
| html-safe-nonce | cbc95a657711e82931d162544ff6cda56d84525c18977fdfb784c9e892f47b5e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUI2OjNGOTNGQjoyOEIzNTozQkU4RTo2QUZBQ0U0MyIsInZpc2l0b3JfaWQiOiI4NjI4Mzc4ODcxODMxMTIxNDc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 62cbe0df407ce498c6af6dab1376e0f7e9a3027d79884bcba2f1c7b1d2c09973 |
| hovercard-subject-tag | pull_request:2995936150 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/7193/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f13b594caa2663ebba52ba27a70f69e36e82ef5719276ce82dc36d92c64a3a09/clerk/javascript/pull/7193 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f13b594caa2663ebba52ba27a70f69e36e82ef5719276ce82dc36d92c64a3a09/clerk/javascript/pull/7193 |
| og:image:alt | Description
This PR adds support for passing a Window to signUp.sso via the popup parameter to perform external verification via a modal window.
Checklist
pnpm test runs as expected.
pnpm build ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dstaley |
| hostname | github.com |
| expected-hostname | github.com |
| None | aa0433de2f392a016f21549c10194a963f65b58eb02faea3916953819b623290 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | be9dc02df8087c7449fb60a416e138c34108ed94 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/7193#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F7193 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F7193 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/7193 |
| Reload | https://github.com/clerk/javascript/pull/7193 |
| Reload | https://github.com/clerk/javascript/pull/7193 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests112 (112) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| dstaley | https://github.com/dstaley |
| main | https://github.com/clerk/javascript/tree/main |
| ds.feat/signals-sso-modal-signup | https://github.com/clerk/javascript/tree/ds.feat/signals-sso-modal-signup |
| Conversation | https://github.com/clerk/javascript/pull/7193 |
| Commits6 (6) | https://github.com/clerk/javascript/pull/7193/commits |
| Checks | https://github.com/clerk/javascript/pull/7193/checks |
| Files changed | https://github.com/clerk/javascript/pull/7193/files |
| feat(clerk-js,shared): Add support for modal sign-up in signals | https://github.com/clerk/javascript/pull/7193#top |
| dstaley | https://github.com/dstaley |
| main | https://github.com/clerk/javascript/tree/main |
| ds.feat/signals-sso-modal-signup | https://github.com/clerk/javascript/tree/ds.feat/signals-sso-modal-signup |
|
| https://github.com/dstaley |
| dstaley | https://github.com/dstaley |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#issue-3608768079 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| dstaley | https://github.com/dstaley |
| November 10, 2025 09:40 | https://github.com/clerk/javascript/pull/7193#commits-pushed-fdd11a3 |
|
| https://github.com/dstaley |
| feat(clerk-js,shared): Add support for modal sign-up in signals | https://github.com/clerk/javascript/pull/7193/commits/fdd11a3181590d1d670795740ce095aea9f5d237 |
| fdd11a3 | https://github.com/clerk/javascript/pull/7193/commits/fdd11a3181590d1d670795740ce095aea9f5d237 |
|
| https://github.com/dstaley |
| fix(clerk-js): actually use popup | https://github.com/clerk/javascript/pull/7193/commits/d59587c90eb393b0f1cb453b8047c50f4310ef50 |
| d59587c | https://github.com/clerk/javascript/pull/7193/commits/d59587c90eb393b0f1cb453b8047c50f4310ef50 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#issuecomment-3512672020 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| 6a54d76 | https://github.com/clerk/javascript/commit/6a54d76c8ae2db05da8241357746d2ea1c28913d |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/ds.feat/signals-sso-modal-signup?filename=.changeset/strange-beans-marry.md&value=---%0A%22%40clerk%2Fclerk-js%22%3A%20patch%0A%22%40clerk%2Fshared%22%3A%20patch%0A---%0A%0Afeat(clerk-js%2Cshared)%3A%20Add%20support%20for%20modal%20sign-up%20in%20signals%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#issuecomment-3512672136 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| Vercel for GitHub | https://vercel.link/github-learn-more |
| clerk-js-sandbox | https://vercel.com/clerk-production/clerk-js-sandbox |
| https://camo.githubusercontent.com/833ba95642364322d56bfc6cc95692affdd7a5a6ca7b50fdcc44aa7e47372d3b/68747470733a2f2f76657263656c2e636f6d2f7374617469632f7374617475732f72656164792e737667 |
| Ready | https://vercel.com/clerk-production/clerk-js-sandbox/Feub1VYrUzpkUMCjoEhCNS5B1WJB |
| Preview | https://clerk-js-sandbox-git-dsfeat-signals-sso-modal-signup.clerkstage.dev |
| Comment | https://vercel.live/open-feedback/clerk-js-sandbox-git-dsfeat-signals-sso-modal-signup.clerkstage.dev?via=pr-comment-feedback-link |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#issuecomment-3512672610 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| feat(clerk-js,types): Add support for modal SSO sign-ins #7026 | https://github.com/clerk/javascript/pull/7026 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#event-20841285343 |
| https://github.com/apps/pkg-pr-new |
| pkg-pr-new | https://github.com/apps/pkg-pr-new |
| Nov 10, 2025 | https://github.com/clerk/javascript/pull/7193#issuecomment-3512686896 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| Open in StackBlitz | https://pkg.pr.new/template/71f7a147-c1b1-4c42-8d12-a4708e4ef4cf |
| 6a54d76 | https://github.com/clerk/javascript/runs/55429669691 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
|
| https://github.com/dstaley |
| fix(clerk-js,shared): Add support for identifier in signIn.sso | https://github.com/clerk/javascript/pull/7193/commits/7c10aa810733d2b10451183c37514a7bffd185cf |
| 7c10aa8 | https://github.com/clerk/javascript/pull/7193/commits/7c10aa810733d2b10451183c37514a7bffd185cf |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://clerk-js-sandbox-n2cc4tluw.clerkstage.dev |
| Preview | https://clerk-js-sandbox-n2cc4tluw.clerkstage.dev |
| November 10, 2025 17:18 | https://github.com/clerk/javascript/pull/7193#event-20842515430 |
| View deployment | https://clerk-js-sandbox-n2cc4tluw.clerkstage.dev |
| https://github.com/alexcarpenter |
| alexcarpenter | https://github.com/alexcarpenter |
|
Nov 14, 2025
| https://github.com/clerk/javascript/pull/7193#pullrequestreview-3465184648 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/7193/files/7c10aa810733d2b10451183c37514a7bffd185cf |
|
| https://github.com/dstaley |
| Merge branch 'main' into ds.feat/signals-sso-modal-signup | https://github.com/clerk/javascript/pull/7193/commits/88d78cc462d129765fc68f2fded223aea5511c29 |
| 88d78cc | https://github.com/clerk/javascript/pull/7193/commits/88d78cc462d129765fc68f2fded223aea5511c29 |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://clerk-js-sandbox-q4wx1dhuq.clerkstage.dev |
| Preview | https://clerk-js-sandbox-q4wx1dhuq.clerkstage.dev |
| November 14, 2025 16:32 | https://github.com/clerk/javascript/pull/7193#event-20947642782 |
| View deployment | https://clerk-js-sandbox-q4wx1dhuq.clerkstage.dev |
|
| https://github.com/dstaley |
| chore(repo): Dedupe lockfile | https://github.com/clerk/javascript/pull/7193/commits/d9330d60241ca4b44ea20e195edd1fc3a95dd29b |
| d9330d6 | https://github.com/clerk/javascript/pull/7193/commits/d9330d60241ca4b44ea20e195edd1fc3a95dd29b |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| had a problem deploying | https://clerk-js-sandbox-2h1giyvil.clerkstage.dev |
| Preview | https://clerk-js-sandbox-2h1giyvil.clerkstage.dev |
| November 14, 2025 16:37 | https://github.com/clerk/javascript/pull/7193#event-20947738390 |
|
| https://github.com/dstaley |
| Merge branch 'main' into ds.feat/signals-sso-modal-signup | https://github.com/clerk/javascript/pull/7193/commits/6a54d76c8ae2db05da8241357746d2ea1c28913d |
| 6a54d76 | https://github.com/clerk/javascript/pull/7193/commits/6a54d76c8ae2db05da8241357746d2ea1c28913d |
| https://github.com/apps/vercel |
| vercel | https://github.com/apps/vercel |
| deployed | https://clerk-js-sandbox-fginqdfd5.clerkstage.dev |
| Preview | https://clerk-js-sandbox-fginqdfd5.clerkstage.dev |
| November 14, 2025 17:02 | https://github.com/clerk/javascript/pull/7193#event-20948285578 |
| View deployment | https://clerk-js-sandbox-fginqdfd5.clerkstage.dev |
| https://github.com/dstaley |
| dstaley | https://github.com/dstaley |
| aa184a4 | https://github.com/clerk/javascript/commit/aa184a46a91f9dec3fd275ec5867a8366d310469 |
| Nov 14, 2025 | https://github.com/clerk/javascript/pull/7193#event-20948489042 |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
| https://github.com/dstaley |
| dstaley | https://github.com/dstaley |
| November 14, 2025 17:12 | https://github.com/clerk/javascript/pull/7193#event-20948489646 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Nov 14, 2025
| https://github.com/clerk/javascript/pull/7193#ref-pullrequest-3618532374 |
|
ci(repo): Version packages
#7210
| https://github.com/clerk/javascript/pull/7210 |
| Deployed | https://clerk-js-sandbox-fginqdfd5.clerkstage.dev |
| vercel[bot] | https://github.com/apps/vercel |
|
View deployment
| https://clerk-js-sandbox-fginqdfd5.clerkstage.dev |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F7193 |
|
| https://github.com/alexcarpenter |
|
alexcarpenter
| https://github.com/alexcarpenter |
|
| https://github.com/clerk/javascript/pull/7193/files/7c10aa810733d2b10451183c37514a7bffd185cf |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Please reload this page | https://github.com/clerk/javascript/pull/7193 |
|
| https://github.com/dstaley |
|
| https://github.com/alexcarpenter |
|
| https://github.com/clerk-cookie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |