| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1b92f647-0306-322c-8fb1-8dcdc5d066fc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD14:387B0D:2E1028E:40E2981:6AFAD222 |
| html-safe-nonce | ebb0820f8cfc397b1e9901b8f1b813d3571caa62440f2f0dbf21e27ed6f964e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDE0OjM4N0IwRDoyRTEwMjhFOjQwRTI5ODE6NkFGQUQyMjIiLCJ2aXNpdG9yX2lkIjoiMjA1NDI3NjI2NjY5NjgyMzMzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 52b7afaddb4d1d40229949fd733fc7d743ad86e8424770a24d8bacac8e92955c |
| hovercard-subject-tag | pull_request:2023321941 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/3974/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e20e2db8f712c7ee5c113c6f63ea91ce8f9dabd67db4476a80fd96bcaf50a24/clerk/javascript/pull/3974 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e20e2db8f712c7ee5c113c6f63ea91ce8f9dabd67db4476a80fd96bcaf50a24/clerk/javascript/pull/3974 |
| og:image:alt | Description
Fix SignIn.SafeIdentifier potentially outputting an incorrect identifier when using similar multi-session sign in strategies.
Fixes: SDKI-609
Checklist
npm test runs as expected.
np... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tmilewski |
| hostname | github.com |
| expected-hostname | github.com |
| None | aa0433de2f392a016f21549c10194a963f65b58eb02faea3916953819b623290 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | be9dc02df8087c7449fb60a416e138c34108ed94 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/3974#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F3974 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F3974 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/3974 |
| Reload | https://github.com/clerk/javascript/pull/3974 |
| Reload | https://github.com/clerk/javascript/pull/3974 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests112 (112) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| tmilewski | https://github.com/tmilewski |
| main | https://github.com/clerk/javascript/tree/main |
| tm/fix-elements-safeIdentifier | https://github.com/clerk/javascript/tree/tm/fix-elements-safeIdentifier |
| Conversation | https://github.com/clerk/javascript/pull/3974 |
| Commits3 (3) | https://github.com/clerk/javascript/pull/3974/commits |
| Checks | https://github.com/clerk/javascript/pull/3974/checks |
| Files changed | https://github.com/clerk/javascript/pull/3974/files |
| fix(elements): Fix SignIn.SafeIdentifier potentially outputting an incorrect value | https://github.com/clerk/javascript/pull/3974#top |
| tmilewski | https://github.com/tmilewski |
| main | https://github.com/clerk/javascript/tree/main |
| tm/fix-elements-safeIdentifier | https://github.com/clerk/javascript/tree/tm/fix-elements-safeIdentifier |
|
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#issue-2470652822 |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| alexcarpenter | https://github.com/alexcarpenter |
| dstaley | https://github.com/dstaley |
| August 16, 2024 17:15 | https://github.com/clerk/javascript/pull/3974#event-13913309229 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#event-13913309250 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#issuecomment-2293871597 |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| 644a32c | https://github.com/clerk/javascript/commit/644a32c90d1b199d7947208302d46830d43f8221 |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/tm/fix-elements-safeIdentifier?filename=.changeset/fluffy-mails-smoke.md&value=---%0A%22%40clerk%2Felements%22%3A%20patch%0A---%0A%0Afix(elements)%3A%20Fix%20%60SignIn.SafeIdentifier%60%20potentially%20outputting%20an%20incorrect%20value%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
elements
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aelements |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#event-13913312049 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#event-13913320705 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| nme22 | https://github.com/nme22 |
| August 16, 2024 17:28 | https://github.com/clerk/javascript/pull/3974#event-13913413278 |
| https://github.com/alexcarpenter |
| alexcarpenter | https://github.com/alexcarpenter |
|
Aug 16, 2024
| https://github.com/clerk/javascript/pull/3974#pullrequestreview-2243200419 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/3974/files |
| https://github.com/dstaley |
| dstaley | https://github.com/dstaley |
|
Aug 16, 2024
| https://github.com/clerk/javascript/pull/3974#pullrequestreview-2243197665 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/3974/files |
| packages/elements/src/internals/machines/sign-in/router.selectors.ts | https://github.com/clerk/javascript/pull/3974/files#diff-6dbdda37f99d493dfcdb273306bd78235e986701d310ce2bb910f5cba24dad00 |
| dstaley | https://github.com/dstaley |
| Aug 16, 2024 | https://github.com/clerk/javascript/pull/3974#discussion_r1720132517 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://private-user-images.githubusercontent.com/88163/358665914-e3b62435-563c-49b6-8ce4-7585af4c44aa.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ4MjI5OTEsIm5iZiI6MTc5NDgyMjY5MSwicGF0aCI6Ii84ODE2My8zNTg2NjU5MTQtZTNiNjI0MzUtNTYzYy00OWI2LThjZTQtNzU4NWFmNGM0NGFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDA5NTEzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ3ODUwMDcwMWJmNmZkZGYwNmRiNDA2OTZkNmNiMDc0N2M2MzUyMGIxOTc5M2Y4Nzc0YmY5MTMxM2U5NjdhNjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.OoiLIqisJ1j61WCXtBwlAC6hXkDAIchDk-6A6gWnc58 |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| https://github.com/nme22 |
| nme22 | https://github.com/nme22 |
|
Aug 16, 2024
| https://github.com/clerk/javascript/pull/3974#pullrequestreview-2243451866 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/3974/files |
| nme22 | https://github.com/nme22 |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| https://github.com/clerk/javascript/pull/3974#pullrequestreview-2243451866 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @dstaley | https://github.com/dstaley |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
| tmilewski | https://github.com/tmilewski |
| August 26, 2024 13:41 | https://github.com/clerk/javascript/pull/3974#commits-pushed-399801a |
|
| https://github.com/tmilewski |
| fix(elements): Fix SignIn.SafeIdentifier potentially outputting an … | https://github.com/clerk/javascript/pull/3974/commits/399801ab1f94c9eb7cddd6d99ee8cdcaeb364b1d |
| 399801a | https://github.com/clerk/javascript/pull/3974/commits/399801ab1f94c9eb7cddd6d99ee8cdcaeb364b1d |
|
| https://github.com/tmilewski |
| fix(elements): Update router selectors | https://github.com/clerk/javascript/pull/3974/commits/b4f65307bfad5c88f768bbbf0a233b52d3166ca5 |
| b4f6530 | https://github.com/clerk/javascript/pull/3974/commits/b4f65307bfad5c88f768bbbf0a233b52d3166ca5 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| force-pushed | https://github.com/clerk/javascript/compare/fc288b3505628fd437ac5db83b2dfe83aa7536a0..b4f65307bfad5c88f768bbbf0a233b52d3166ca5 |
| fc288b3 | https://github.com/clerk/javascript/commit/fc288b3505628fd437ac5db83b2dfe83aa7536a0 |
| b4f6530 | https://github.com/clerk/javascript/commit/b4f65307bfad5c88f768bbbf0a233b52d3166ca5 |
|
Compare
| https://github.com/clerk/javascript/compare/fc288b3505628fd437ac5db83b2dfe83aa7536a0..b4f65307bfad5c88f768bbbf0a233b52d3166ca5 |
| August 26, 2024 20:02 | https://github.com/clerk/javascript/pull/3974#event-14018381745 |
|
| https://github.com/tmilewski |
| chore(elements): Remove commented code | https://github.com/clerk/javascript/pull/3974/commits/644a32c90d1b199d7947208302d46830d43f8221 |
| 644a32c | https://github.com/clerk/javascript/pull/3974/commits/644a32c90d1b199d7947208302d46830d43f8221 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| dstaley | https://github.com/dstaley |
| August 26, 2024 20:03 | https://github.com/clerk/javascript/pull/3974#event-14018399532 |
| https://github.com/dstaley |
| dstaley | https://github.com/dstaley |
|
Aug 26, 2024
| https://github.com/clerk/javascript/pull/3974#pullrequestreview-2261554447 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/3974/files/644a32c90d1b199d7947208302d46830d43f8221 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| a5cf6be | https://github.com/clerk/javascript/commit/a5cf6be9502f91819032aa49e9529377a2b9cc88 |
| Aug 26, 2024 | https://github.com/clerk/javascript/pull/3974#event-14018589935 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| August 26, 2024 20:19 | https://github.com/clerk/javascript/pull/3974#event-14018590339 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Aug 26, 2024
| https://github.com/clerk/javascript/pull/3974#ref-pullrequest-2481336774 |
|
ci(repo): Version packages
#4007
| https://github.com/clerk/javascript/pull/4007 |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F3974 |
|
| https://github.com/dstaley |
|
dstaley
| https://github.com/dstaley |
|
| https://github.com/clerk/javascript/pull/3974/files/644a32c90d1b199d7947208302d46830d43f8221 |
|
| https://github.com/alexcarpenter |
|
alexcarpenter
| https://github.com/alexcarpenter |
|
| https://github.com/clerk/javascript/pull/3974/files/fc288b3505628fd437ac5db83b2dfe83aa7536a0 |
|
| https://github.com/nme22 |
|
nme22
| https://github.com/nme22 |
|
| https://github.com/clerk/javascript/pull/3974/files/fc288b3505628fd437ac5db83b2dfe83aa7536a0 |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
|
| https://github.com/tmilewski |
|
tmilewski
| https://github.com/tmilewski |
|
elements
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aelements |
| Please reload this page | https://github.com/clerk/javascript/pull/3974 |
|
| https://github.com/tmilewski |
|
| https://github.com/dstaley |
|
| https://github.com/alexcarpenter |
|
| https://github.com/nme22 |
|
| https://github.com/clerk-cookie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |