| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5e133cbb-417f-6027-380f-3f60a0c60c35 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A57C:17D5C3:8F2D84:CCD371:6AFAB5C0 |
| html-safe-nonce | 1b1f9810427b15f972694934255efd3cbc324e463b278daffae7c46f4bede3bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTdDOjE3RDVDMzo4RjJEODQ6Q0NEMzcxOjZBRkFCNUMwIiwidmlzaXRvcl9pZCI6IjU0NTM1OTg5Nzg2MDE1NjM1ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3dbb2820aef97e8f876be3b71026561a3e5201d2d6728e1af0626ff48db3e1eb |
| hovercard-subject-tag | pull_request:1650305716 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/2399/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/463ac97bd359524e0f8afdd6378fbd14b993568240ff41a02edf79c851b4c617/clerk/javascript/pull/2399 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/463ac97bd359524e0f8afdd6378fbd14b993568240ff41a02edf79c851b4c617/clerk/javascript/pull/2399 |
| og:image:alt | Description
We still have a lot of places in clerk-js where we call setError(undefined) instead of clearFeedback
Checklist
npm test runs as expected.
npm run build runs as expected.
(If appli... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | panteliselef |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/2399#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2399 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2399 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/2399 |
| Reload | https://github.com/clerk/javascript/pull/2399 |
| Reload | https://github.com/clerk/javascript/pull/2399 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests112 (112) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| panteliselef | https://github.com/panteliselef |
| main | https://github.com/clerk/javascript/tree/main |
| elef/sdk-1076-slug-with-error | https://github.com/clerk/javascript/tree/elef/sdk-1076-slug-with-error |
| Conversation | https://github.com/clerk/javascript/pull/2399 |
| Commits1 (1) | https://github.com/clerk/javascript/pull/2399/commits |
| Checks | https://github.com/clerk/javascript/pull/2399/checks |
| Files changed | https://github.com/clerk/javascript/pull/2399/files |
| fix(clerk-js): Clear feedback when undefined is passed to setError | https://github.com/clerk/javascript/pull/2399#top |
| panteliselef | https://github.com/panteliselef |
| main | https://github.com/clerk/javascript/tree/main |
| elef/sdk-1076-slug-with-error | https://github.com/clerk/javascript/tree/elef/sdk-1076-slug-with-error |
|
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#issue-2048585018 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Clear feedback when undefined is passed to setError | https://github.com/clerk/javascript/pull/2399/commits/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| e5571d4 | https://github.com/clerk/javascript/pull/2399/commits/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| desiprisg | https://github.com/desiprisg |
| December 19, 2023 12:42 | https://github.com/clerk/javascript/pull/2399#event-11289219854 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#event-11289219911 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#issuecomment-1862691136 |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
| e5571d4 | https://github.com/clerk/javascript/commit/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/elef/sdk-1076-slug-with-error?filename=.changeset/fresh-windows-yell.md&value=---%0A%22%40clerk%2Fclerk-js%22%3A%20patch%0A---%0A%0Afix(clerk-js)%3A%20Clear%20feedback%20when%20%60undefined%60%20is%20passed%20to%20%60setError%60%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#event-11289221928 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| force-pushed | https://github.com/clerk/javascript/compare/a721cc82d1473203ed7da57fb950b96ea80f1072..e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| a721cc8 | https://github.com/clerk/javascript/commit/a721cc82d1473203ed7da57fb950b96ea80f1072 |
| e5571d4 | https://github.com/clerk/javascript/commit/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
|
Compare
| https://github.com/clerk/javascript/compare/a721cc82d1473203ed7da57fb950b96ea80f1072..e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| December 19, 2023 12:52 | https://github.com/clerk/javascript/pull/2399#event-11289327394 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#pullrequestreview-1788815708 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2399/files/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| dimkl | https://github.com/dimkl |
| https://github.com/clerk/javascript/pull/2399#pullrequestreview-1788815708 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#issuecomment-1862724086 |
| @dimkl | https://github.com/dimkl |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| dimkl | https://github.com/dimkl |
| December 19, 2023 13:05 | https://github.com/clerk/javascript/pull/2399#event-11289462856 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#issuecomment-1862831050 |
| @panteliselef | https://github.com/panteliselef |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#pullrequestreview-1788956908 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2399/files/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#event-11290278405 |
| bf09d18 | https://github.com/clerk/javascript/commit/bf09d18d6408ac89f8b9207d05e0f3660d27a6cf |
| Dec 19, 2023 | https://github.com/clerk/javascript/pull/2399#event-11290372979 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| December 19, 2023 14:20 | https://github.com/clerk/javascript/pull/2399#event-11290373180 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#ref-pullrequest-2048207561 |
|
Version Packages (alpha-v5)
#2397
| https://github.com/clerk/javascript/pull/2397 |
| panteliselef | https://github.com/panteliselef |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#ref-commit-c1a50f7 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Clear feedback when undefined is passed to setError ( | https://github.com/clerk/javascript/commit/c1a50f718e5e479f10645ef68e02371cb2019bff |
| c1a50f7 | https://github.com/clerk/javascript/commit/c1a50f718e5e479f10645ef68e02371cb2019bff |
| #2399 | https://github.com/clerk/javascript/pull/2399 |
| bf09d18 | https://github.com/clerk/javascript/commit/bf09d18d6408ac89f8b9207d05e0f3660d27a6cf |
| panteliselef | https://github.com/panteliselef |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#ref-commit-5f0bdb6 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Clear feedback when undefined is passed to setError ( | https://github.com/clerk/javascript/commit/5f0bdb63d81f1a0e1b3230f06783c71b5955c613 |
| 5f0bdb6 | https://github.com/clerk/javascript/commit/5f0bdb63d81f1a0e1b3230f06783c71b5955c613 |
| #2399 | https://github.com/clerk/javascript/pull/2399 |
| bf09d18 | https://github.com/clerk/javascript/commit/bf09d18d6408ac89f8b9207d05e0f3660d27a6cf |
| github-merge-queue | https://github.com/apps/github-merge-queue |
|
Dec 19, 2023
| https://github.com/clerk/javascript/pull/2399#ref-commit-98f8ec6 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Clear feedback when undefined is passed to setError ( | https://github.com/clerk/javascript/commit/98f8ec62957a10bd0e8e2b1f136351132d9ac670 |
| 98f8ec6 | https://github.com/clerk/javascript/commit/98f8ec62957a10bd0e8e2b1f136351132d9ac670 |
| #2399 | https://github.com/clerk/javascript/pull/2399 |
| #2409 | https://github.com/clerk/javascript/pull/2409 |
| bf09d18 | https://github.com/clerk/javascript/commit/bf09d18d6408ac89f8b9207d05e0f3660d27a6cf |
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
|
Mar 13, 2024
| https://github.com/clerk/javascript/pull/2399#ref-pullrequest-2183445819 |
|
fix(themes): Add tslib and @clerk/types as dependencies to @clerk/themes (#2665)
#2987
| https://github.com/clerk/javascript/pull/2987 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Mar 22, 2024
| https://github.com/clerk/javascript/pull/2399#ref-pullrequest-2200445817 |
|
Version Packages (beta)
#3027
| https://github.com/clerk/javascript/pull/3027 |
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
|
Aug 2, 2024
| https://github.com/clerk/javascript/pull/2399#ref-pullrequest-2444224984 |
|
chore(repo): Correct changeset
#3883
| https://github.com/clerk/javascript/pull/3883 |
| https://github.com/traksaw |
| traksaw | https://github.com/traksaw |
|
May 7, 2026
| https://github.com/clerk/javascript/pull/2399#ref-issue-4395246472 |
|
Re-occurrence of #3996: TypeError "e.clearFeedback is not a function" in SignUp on Safari (clerk-js@5.125.10)
#8496
| https://github.com/clerk/javascript/issues/8496 |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2399 |
|
| https://github.com/desiprisg |
|
desiprisg
| https://github.com/desiprisg |
|
| https://github.com/dimkl |
|
dimkl
| https://github.com/dimkl |
|
| https://github.com/clerk/javascript/pull/2399/files/e5571d44724abe5bed5ffa8ec89d0ac47fd4547d |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
|
| https://github.com/panteliselef |
|
panteliselef
| https://github.com/panteliselef |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Please reload this page | https://github.com/clerk/javascript/pull/2399 |
|
| https://github.com/panteliselef |
|
| https://github.com/dimkl |
|
| https://github.com/clerk-cookie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |