| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f2d6e724-f725-e13d-98f7-b9218a7cbba6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE48:3166AC:4596538:5C21D53:6AFA6737 |
| html-safe-nonce | 9eeb129f46418709d66917f747cdee371450222ece3b358e6166e88b609fa7c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTQ4OjMxNjZBQzo0NTk2NTM4OjVDMjFENTM6NkFGQTY3MzciLCJ2aXNpdG9yX2lkIjoiNTIyODA3MDQ2OTIyNjg4Mjg3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | eab42cbbdacd32f267cee4683294dc75515823a397f04a86fb89431f0559712c |
| hovercard-subject-tag | pull_request:1640443327 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/2322/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aa63599ce88c7ee60e96c336d4b8ccd682cbf211b2c0fcdbbc751ac6547b0268/clerk/javascript/pull/2322 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aa63599ce88c7ee60e96c336d4b8ccd682cbf211b2c0fcdbbc751ac6547b0268/clerk/javascript/pull/2322 |
| og:image:alt | Description
#2164 added react-dom to @clerk/shared as a peerDependency. We should also mark this peerDep as optional since @clerk/shared can also be used outside of React.
Checklist
npm test runs... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | LekoArts |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/2322#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2322 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2322 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/2322 |
| Reload | https://github.com/clerk/javascript/pull/2322 |
| Reload | https://github.com/clerk/javascript/pull/2322 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests109 (109) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| nikosdouvlis | https://github.com/nikosdouvlis |
| main | https://github.com/clerk/javascript/tree/main |
| lekoarts/sdk-1068-fix-missing-peerdependenciesmeta-in-clerkshared | https://github.com/clerk/javascript/tree/lekoarts/sdk-1068-fix-missing-peerdependenciesmeta-in-clerkshared |
| Conversation | https://github.com/clerk/javascript/pull/2322 |
| Commits2 (2) | https://github.com/clerk/javascript/pull/2322/commits |
| Checks | https://github.com/clerk/javascript/pull/2322/checks |
| Files changed | https://github.com/clerk/javascript/pull/2322/files |
| fix(shared): Add missing peerDependenciesMeta key | https://github.com/clerk/javascript/pull/2322#top |
| nikosdouvlis | https://github.com/nikosdouvlis |
| main | https://github.com/clerk/javascript/tree/main |
| lekoarts/sdk-1068-fix-missing-peerdependenciesmeta-in-clerkshared | https://github.com/clerk/javascript/tree/lekoarts/sdk-1068-fix-missing-peerdependenciesmeta-in-clerkshared |
|
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2322#issue-2037474216 |
| #2164 | https://github.com/clerk/javascript/pull/2164 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/2322 |
|
| https://github.com/LekoArts |
| fix(shared): Add missing peerDependenciesMeta key | https://github.com/clerk/javascript/pull/2322/commits/bc91c8e14505ba3064558df08247177f29145075 |
| bc91c8e | https://github.com/clerk/javascript/pull/2322/commits/bc91c8e14505ba3064558df08247177f29145075 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2322#issuecomment-1851783256 |
| Please reload this page | https://github.com/clerk/javascript/pull/2322 |
| 7687be5 | https://github.com/clerk/javascript/commit/7687be5931bde848e7e46c935f108077520f6dd2 |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/lekoarts/sdk-1068-fix-missing-peerdependenciesmeta-in-clerkshared?filename=.changeset/rotten-clouds-act.md&value=---%0A%22%40clerk%2Fshared%22%3A%20patch%0A---%0A%0Afix(shared)%3A%20Add%20missing%20peerDependenciesMeta%20key%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/2322 |
|
| https://github.com/LekoArts |
| Create chatty-beans-fix.md | https://github.com/clerk/javascript/pull/2322/commits/7687be5931bde848e7e46c935f108077520f6dd2 |
| 7687be5 | https://github.com/clerk/javascript/pull/2322/commits/7687be5931bde848e7e46c935f108077520f6dd2 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2322#pullrequestreview-1777201857 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2322/files/7687be5931bde848e7e46c935f108077520f6dd2 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
| LekoArts | https://github.com/LekoArts |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2322#event-11222237753 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2322#pullrequestreview-1777300771 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2322/files/7687be5931bde848e7e46c935f108077520f6dd2 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
| 896cb61 | https://github.com/clerk/javascript/commit/896cb610409f84c0ff7a4f502f0b4ccee1afc157 |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2322#event-11222520919 |
| https://github.com/nikosdouvlis |
| nikosdouvlis | https://github.com/nikosdouvlis |
| December 12, 2023 11:55 | https://github.com/clerk/javascript/pull/2322#event-11222521095 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2322#ref-pullrequest-2036221228 |
|
Version Packages (alpha-v5)
#2308
| https://github.com/clerk/javascript/pull/2308 |
| brkalow | https://github.com/brkalow |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2322#ref-commit-6e155bd |
|
| https://github.com/LekoArts |
|
| https://github.com/brkalow |
| fix(shared): Add missing peerDependenciesMeta key ( | https://github.com/clerk/javascript/commit/6e155bd3e8d6b0fadc987efac312b212c6e2e7ff |
| #2322 | https://github.com/clerk/javascript/pull/2322 |
| ) | https://github.com/clerk/javascript/commit/6e155bd3e8d6b0fadc987efac312b212c6e2e7ff |
| 6e155bd | https://github.com/clerk/javascript/commit/6e155bd3e8d6b0fadc987efac312b212c6e2e7ff |
| octoper | https://github.com/octoper |
|
Dec 13, 2023
| https://github.com/clerk/javascript/pull/2322#ref-commit-7191099 |
|
| https://github.com/LekoArts |
|
| https://github.com/octoper |
| fix(shared): Add missing peerDependenciesMeta key ( | https://github.com/clerk/javascript/commit/71910997376fc19927e30a079c4be1712d9c8cb3 |
| #2322 | https://github.com/clerk/javascript/pull/2322 |
| ) | https://github.com/clerk/javascript/commit/71910997376fc19927e30a079c4be1712d9c8cb3 |
| 7191099 | https://github.com/clerk/javascript/commit/71910997376fc19927e30a079c4be1712d9c8cb3 |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2322 |
|
| https://github.com/nikosdouvlis |
|
nikosdouvlis
| https://github.com/nikosdouvlis |
|
| https://github.com/clerk/javascript/pull/2322/files/7687be5931bde848e7e46c935f108077520f6dd2 |
|
| https://github.com/dimkl |
|
dimkl
| https://github.com/dimkl |
|
| https://github.com/clerk/javascript/pull/2322/files/7687be5931bde848e7e46c935f108077520f6dd2 |
| Please reload this page | https://github.com/clerk/javascript/pull/2322 |
|
| https://github.com/LekoArts |
|
LekoArts
| https://github.com/LekoArts |
| Please reload this page | https://github.com/clerk/javascript/pull/2322 |
|
| https://github.com/LekoArts |
|
| https://github.com/nikosdouvlis |
|
| https://github.com/dimkl |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |