| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d76f756f-f4f4-4810-e677-5155644bcb2f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC94:FA343:330A0E:44D438:6AFA70E0 |
| html-safe-nonce | 8089499bc2869f9ba0bd9c1b94454efc73f18c06c1ba30d9daf95babd4e1e168 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzk0OkZBMzQzOjMzMEEwRTo0NEQ0Mzg6NkFGQTcwRTAiLCJ2aXNpdG9yX2lkIjoiMzMxOTk3MDM0OTYzNzU5NTM2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 63fb53d64b576ac5cf1262efd547d1c03adced69a575f7512e496f24f127a4fb |
| hovercard-subject-tag | pull_request:1639759978 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/2314/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/071e4fe9c348ff5891ee9d051c27c2ec5231da33c285b8ea62669a6616578807/clerk/javascript/pull/2314 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/071e4fe9c348ff5891ee9d051c27c2ec5231da33c285b8ea62669a6616578807/clerk/javascript/pull/2314 |
| og:image:alt | Description
Fixes the following type issues when host application is using Typescript v5
Before
After
Checklist
npm test runs as expected.
npm run build runs as expected.
(If applicable) ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | panteliselef |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/2314#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2314 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2314 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/2314 |
| Reload | https://github.com/clerk/javascript/pull/2314 |
| Reload | https://github.com/clerk/javascript/pull/2314 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests109 (109) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| brkalow | https://github.com/brkalow |
| main | https://github.com/clerk/javascript/tree/main |
| elef/fix-custom-types-for-ts-v5 | https://github.com/clerk/javascript/tree/elef/fix-custom-types-for-ts-v5 |
| Conversation | https://github.com/clerk/javascript/pull/2314 |
| Commits1 (1) | https://github.com/clerk/javascript/pull/2314/commits |
| Checks | https://github.com/clerk/javascript/pull/2314/checks |
| Files changed | https://github.com/clerk/javascript/pull/2314/files |
| fix(types): Typescript v5 cannot infer custom role types correctly | https://github.com/clerk/javascript/pull/2314#top |
| brkalow | https://github.com/brkalow |
| main | https://github.com/clerk/javascript/tree/main |
| elef/fix-custom-types-for-ts-v5 | https://github.com/clerk/javascript/tree/elef/fix-custom-types-for-ts-v5 |
|
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 11, 2023 | https://github.com/clerk/javascript/pull/2314#issue-2036698450 |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
| https://private-user-images.githubusercontent.com/19269911/289698166-c9cb66b5-1535-497e-8305-47c00d802d61.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTgwOTIsIm5iZiI6MTc5NDc5Nzc5MiwicGF0aCI6Ii8xOTI2OTkxMS8yODk2OTgxNjYtYzljYjY2YjUtMTUzNS00OTdlLTgzMDUtNDdjMDBkODAyZDYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyNTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY5MzNmYzMwODA0NWZjYzljNjU4YzY4YThkYmEyNDc4MTZjZjc3OGMzOTI5Mjk4MDI1NDY4MTA4MDZhNTEzMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.lD4W7Zn0ZRIBqG7s0J1cCaQhbjB77VWW7JZAtI7_Eno |
| https://private-user-images.githubusercontent.com/19269911/289698176-09481bea-56e1-416d-9e78-9146e5c918c9.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTgwOTIsIm5iZiI6MTc5NDc5Nzc5MiwicGF0aCI6Ii8xOTI2OTkxMS8yODk2OTgxNzYtMDk0ODFiZWEtNTZlMS00MTZkLTllNzgtOTE0NmU1YzkxOGM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyNTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyYmQwZjMzZDZjYTQxNTY5OTQxNzc5OTE2YzMzMGRiZDU3MDM1M2NiNmUzOTIzY2FhZGUzNDc1MzZkNjJlNGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.mNakpdFPiYB-1c-ysCZ1aL8N1Nueu8butMRJimsULNY |
| https://private-user-images.githubusercontent.com/19269911/289698717-0b2875db-9dcf-4b0e-a10b-a02cbddd3803.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTgwOTIsIm5iZiI6MTc5NDc5Nzc5MiwicGF0aCI6Ii8xOTI2OTkxMS8yODk2OTg3MTctMGIyODc1ZGItOWRjZi00YjBlLWExMGItYTAyY2JkZGQzODAzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyNTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWVlMDM2YjU2NjkzMWFmYzEwMTVhNzFlYzgxMmQwMjM2ODY5YjNlMmE0OTJlNjIzMWEyYzlkYmEyMWVlYTZjZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.JRcDUuzWukRqjbgiyAJ24Dwbnhwo0T1SP7dxcGIz9T8 |
| https://private-user-images.githubusercontent.com/19269911/289698782-470dee63-a6ea-4c83-bcf1-cf81f291c01c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTgwOTIsIm5iZiI6MTc5NDc5Nzc5MiwicGF0aCI6Ii8xOTI2OTkxMS8yODk2OTg3ODItNDcwZGVlNjMtYTZlYS00YzgzLWJjZjEtY2Y4MWYyOTFjMDFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyNTYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyZTNhOGJiOTg3YTUxZjlkNDgzNmI4YjVjZjZkMmE2ZTI5NmY0MDE5ZmI3YzVkNTAwNTY4NjFiNmQyNDcyZDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.f5UcSOiD116WI6DEufzp5M4Qr_8_4ZThzWp9YZ4_8Y0 |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| December 11, 2023 23:18 | https://github.com/clerk/javascript/pull/2314#event-11216883331 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 11, 2023 | https://github.com/clerk/javascript/pull/2314#event-11216883353 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Dec 11, 2023 | https://github.com/clerk/javascript/pull/2314#issuecomment-1851049600 |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
| 92300ed | https://github.com/clerk/javascript/commit/92300ed673516978525e9690d0c47e175e205166 |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/elef/fix-custom-types-for-ts-v5?filename=.changeset/mighty-hounds-attend.md&value=---%0A%22%40clerk%2Ftypes%22%3A%20patch%0A---%0A%0Afix(types)%3A%20Typescript%20v5%20cannot%20infer%20custom%20role%20types%20correctly%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
types
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Atypes |
| Dec 11, 2023 | https://github.com/clerk/javascript/pull/2314#event-11216884826 |
|
| https://github.com/panteliselef |
| fix(types): Typescript v5 cannot infer types correctly | https://github.com/clerk/javascript/pull/2314/commits/92300ed673516978525e9690d0c47e175e205166 |
| 92300ed | https://github.com/clerk/javascript/pull/2314/commits/92300ed673516978525e9690d0c47e175e205166 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| force-pushed | https://github.com/clerk/javascript/compare/7e2bf3001b597e28b4d6820c4f286186b41d325b..92300ed673516978525e9690d0c47e175e205166 |
| 7e2bf30 | https://github.com/clerk/javascript/commit/7e2bf3001b597e28b4d6820c4f286186b41d325b |
| 92300ed | https://github.com/clerk/javascript/commit/92300ed673516978525e9690d0c47e175e205166 |
|
Compare
| https://github.com/clerk/javascript/compare/7e2bf3001b597e28b4d6820c4f286186b41d325b..92300ed673516978525e9690d0c47e175e205166 |
| December 11, 2023 23:25 | https://github.com/clerk/javascript/pull/2314#event-11216923901 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| December 11, 2023 23:25 | https://github.com/clerk/javascript/pull/2314#event-11216924684 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2314#pullrequestreview-1776393280 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2314/files/92300ed673516978525e9690d0c47e175e205166 |
| https://github.com/tmilewski |
| tmilewski | https://github.com/tmilewski |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2314#issuecomment-1851115832 |
| #2312 | https://github.com/clerk/javascript/pull/2312 |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
| https://github.com/brkalow |
| brkalow | https://github.com/brkalow |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2314#event-11218209429 |
| 70bbca7 | https://github.com/clerk/javascript/commit/70bbca74c079a5979c630a788ca40aed3bd1de3f |
| Dec 12, 2023 | https://github.com/clerk/javascript/pull/2314#event-11218239453 |
| https://github.com/brkalow |
| brkalow | https://github.com/brkalow |
| December 12, 2023 03:43 | https://github.com/clerk/javascript/pull/2314#event-11218239531 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
|
Dec 12, 2023
| https://github.com/clerk/javascript/pull/2314#ref-pullrequest-2036425982 |
|
fix(clerk-react): Fix build process not catching type errors [SDK-1065]
#2312
| https://github.com/clerk/javascript/pull/2312 |
|
fix(types): Update MembershipRole and OrganizationPermissionKey to not resolve to any
#2318
| https://github.com/clerk/javascript/pull/2318 |
|
feat(nextjs,shared,backend,clerk-react): Introduce Protect for authorization (#2170)
#2309
| https://github.com/clerk/javascript/pull/2309 |
| octoper | https://github.com/octoper |
|
Dec 13, 2023
| https://github.com/clerk/javascript/pull/2314#ref-commit-963d4b4 |
|
| https://github.com/panteliselef |
|
| https://github.com/octoper |
| fix(types): Typescript v5 cannot infer types correctly ( | https://github.com/clerk/javascript/commit/963d4b46302d7e321f3265b8f848c95ef16b6602 |
| #2314 | https://github.com/clerk/javascript/pull/2314 |
| ) | https://github.com/clerk/javascript/commit/963d4b46302d7e321f3265b8f848c95ef16b6602 |
| 963d4b4 | https://github.com/clerk/javascript/commit/963d4b46302d7e321f3265b8f848c95ef16b6602 |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2314 |
|
| https://github.com/tmilewski |
|
tmilewski
| https://github.com/tmilewski |
|
| https://github.com/clerk/javascript/pull/2314/files/92300ed673516978525e9690d0c47e175e205166 |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
|
| https://github.com/panteliselef |
|
panteliselef
| https://github.com/panteliselef |
|
types
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Atypes |
| Please reload this page | https://github.com/clerk/javascript/pull/2314 |
|
| https://github.com/panteliselef |
|
| https://github.com/tmilewski |
|
| https://github.com/brkalow |
|
| https://github.com/clerk-cookie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |