| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a94a99e6-1f1b-db07-0b78-543cc4514a4b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECD6:3E915:1D4045D:28CB02D:6AFA6B8A |
| html-safe-nonce | 889e7d963f6e91d21d030321fbf5ba8f64244da7cca45071ea01c36dda1ac113 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Q2OjNFOTE1OjFENDA0NUQ6MjhDQjAyRDo2QUZBNkI4QSIsInZpc2l0b3JfaWQiOiI2NDcwNjM3Mjc1ODU2MzcyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6908d9c1890173b1c511e5b4f8069564c892ffe0f3d3f41a75b3b1fd60e7534a |
| hovercard-subject-tag | pull_request:1623379742 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/2240/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e076828df12d78582ea722405250af321d819a8b01904af1babee40c9364bb64/clerk/javascript/pull/2240 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e076828df12d78582ea722405250af321d819a8b01904af1babee40c9364bb64/clerk/javascript/pull/2240 |
| og:image:alt | Description
Users that are missing the org:sys_domains:manage should not be able to see the Add Domain button.
The route for adding a domain is already protected :)
Before
After
Checklist
npm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | panteliselef |
| hostname | github.com |
| expected-hostname | github.com |
| None | 612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7 |
| turbo-cache-control | no-cache |
| go-import | github.com/clerk/javascript git https://github.com/clerk/javascript.git |
| octolytics-dimension-user_id | 49538330 |
| octolytics-dimension-user_login | clerk |
| octolytics-dimension-repository_id | 438331492 |
| octolytics-dimension-repository_nwo | clerk/javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 438331492 |
| octolytics-dimension-repository_network_root_nwo | clerk/javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 072e34035c13c31543fba9f025cbbbda4210dae4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/clerk/javascript/pull/2240#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2240 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2240 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript |
| Reload | https://github.com/clerk/javascript/pull/2240 |
| Reload | https://github.com/clerk/javascript/pull/2240 |
| Reload | https://github.com/clerk/javascript/pull/2240 |
| clerk | https://github.com/clerk |
| javascript | https://github.com/clerk/javascript |
| Code | https://github.com/clerk/javascript |
| Issues44 (44) | https://github.com/clerk/javascript/issues |
| Pull requests109 (109) | https://github.com/clerk/javascript/pulls |
| Discussions | https://github.com/clerk/javascript/discussions |
| Actions | https://github.com/clerk/javascript/actions |
| Security and quality6 (6) | https://github.com/clerk/javascript/security |
| Insights | https://github.com/clerk/javascript/pulse |
| https://github.com/clerk/javascript |
| panteliselef | https://github.com/panteliselef |
| main | https://github.com/clerk/javascript/tree/main |
| elef/core-1007-add-domain-hide | https://github.com/clerk/javascript/tree/elef/core-1007-add-domain-hide |
| Conversation | https://github.com/clerk/javascript/pull/2240 |
| Commits1 (1) | https://github.com/clerk/javascript/pull/2240/commits |
| Checks | https://github.com/clerk/javascript/pull/2240/checks |
| Files changed | https://github.com/clerk/javascript/pull/2240/files |
| fix(clerk-js): Hide Add domain button when user is missing org:sys_domains:manage | https://github.com/clerk/javascript/pull/2240#top |
| panteliselef | https://github.com/panteliselef |
| main | https://github.com/clerk/javascript/tree/main |
| elef/core-1007-add-domain-hide | https://github.com/clerk/javascript/tree/elef/core-1007-add-domain-hide |
|
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Nov 30, 2023 | https://github.com/clerk/javascript/pull/2240#issue-2018307769 |
| https://private-user-images.githubusercontent.com/19269911/286893600-412418f6-80b6-43d2-b0cc-039167525b55.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTY3MjcsIm5iZiI6MTc5NDc5NjQyNywicGF0aCI6Ii8xOTI2OTkxMS8yODY4OTM2MDAtNDEyNDE4ZjYtODBiNi00M2QyLWIwY2MtMDM5MTY3NTI1YjU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyMzM0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTExY2EzZThjOTA2OWViODZjN2Y2N2IzNThlYWJkM2IyZTRhMGY5MDA1OTNjN2U1YmU3ZGE4ODJhODY3ZThkNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.ZN8kglTOxjfpsqHR0VthZxtIrYIsryP58v7IUDoowuA |
| https://private-user-images.githubusercontent.com/19269911/286893886-b485c3fa-fd98-4be5-903e-ffab76edc957.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ3OTY3MjcsIm5iZiI6MTc5NDc5NjQyNywicGF0aCI6Ii8xOTI2OTkxMS8yODY4OTM4ODYtYjQ4NWMzZmEtZmQ5OC00YmU1LTkwM2UtZmZhYjc2ZWRjOTU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDAyMzM0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmNjU0YTIwODVjNTBlZjI1YjZkMmZlY2IzNzE0YmFlYWJkOTNhNTBhOTA0Yzg0MGY1ODE5YzI0ZGQxNjIxMTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.x_WRI_5oEqHZyJWJ1j3-x3xSV1c-iGeaTU6mjkaffRQ |
| JSDoc comments | https://jsdoc.app/about-getting-started.html |
| Documentation | https://github.com/clerk/clerk-docs |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
| https://github.com/apps/changeset-bot |
| changeset-bot | https://github.com/apps/changeset-bot |
| Nov 30, 2023 | https://github.com/clerk/javascript/pull/2240#issuecomment-1833464207 |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
| ee3110f | https://github.com/clerk/javascript/commit/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| Click here to learn what changesets are | https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md |
| Click here if you're a maintainer who wants to add another changeset to this PR | https://github.com/clerk/javascript/new/elef/core-1007-add-domain-hide?filename=.changeset/five-toes-hang.md&value=---%0A%22%40clerk%2Fclerk-js%22%3A%20patch%0A---%0A%0Afix(clerk-js)%3A%20Hide%20Add%20domain%20button%20when%20user%20is%20missing%20%60org%3Asys_domains%3Amanage%60%0A |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Nov 30, 2023 | https://github.com/clerk/javascript/pull/2240#event-11106882569 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| November 30, 2023 10:13 | https://github.com/clerk/javascript/pull/2240#event-11106883178 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 30, 2023 | https://github.com/clerk/javascript/pull/2240#issuecomment-1833464455 |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
|
retheme
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aretheme |
| Nov 30, 2023 | https://github.com/clerk/javascript/pull/2240#event-11106884659 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Hide Add domain button when user is missing `org:sys_d… | https://github.com/clerk/javascript/pull/2240/commits/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| ee3110f | https://github.com/clerk/javascript/pull/2240/commits/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| force-pushed | https://github.com/clerk/javascript/compare/de597b0b286a08349c13b87805314d9013d63d6b..ee3110f443f345365a6bcd01cde2bc31abcab430 |
| de597b0 | https://github.com/clerk/javascript/commit/de597b0b286a08349c13b87805314d9013d63d6b |
| ee3110f | https://github.com/clerk/javascript/commit/ee3110f443f345365a6bcd01cde2bc31abcab430 |
|
Compare
| https://github.com/clerk/javascript/compare/de597b0b286a08349c13b87805314d9013d63d6b..ee3110f443f345365a6bcd01cde2bc31abcab430 |
| November 30, 2023 10:22 | https://github.com/clerk/javascript/pull/2240#event-11106987601 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| chanioxaris | https://github.com/chanioxaris |
| November 30, 2023 16:19 | https://github.com/clerk/javascript/pull/2240#event-11111212418 |
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#pullrequestreview-1761924953 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2240/files/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| https://github.com/dimkl |
| dimkl | https://github.com/dimkl |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#pullrequestreview-1761926972 |
|
View reviewed changes
| https://github.com/clerk/javascript/pull/2240/files/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| ...erk-js/src/ui.retheme/components/OrganizationProfile/__tests__/OrganizationSettings.test.tsx | https://github.com/clerk/javascript/pull/2240/files/ee3110f443f345365a6bcd01cde2bc31abcab430#diff-4d37c2e61adf9a9eb7400af5df239e30b3933d11d1e12afe05cb24229c646384 |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| Dec 4, 2023 | https://github.com/clerk/javascript/pull/2240#event-11136489649 |
| 920c9e1 | https://github.com/clerk/javascript/commit/920c9e1b5d091472bce0ff00e410b3d79c88d930 |
| Dec 4, 2023 | https://github.com/clerk/javascript/pull/2240#event-11136578556 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
| December 4, 2023 09:50 | https://github.com/clerk/javascript/pull/2240#event-11136578883 |
| https://github.com/clerk-cookie |
| clerk-cookie | https://github.com/clerk-cookie |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#ref-pullrequest-2018141117 |
|
Version Packages (alpha-v5)
#2238
| https://github.com/clerk/javascript/pull/2238 |
| panteliselef | https://github.com/panteliselef |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#ref-commit-2686e19 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Hide Add domain button when user is missing `org:sys_d… | https://github.com/clerk/javascript/commit/2686e193af68eb36b06fc9a461496ad3d4e09229 |
| 2686e19 | https://github.com/clerk/javascript/commit/2686e193af68eb36b06fc9a461496ad3d4e09229 |
| #2240 | https://github.com/clerk/javascript/pull/2240 |
| https://github.com/panteliselef |
| panteliselef | https://github.com/panteliselef |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#ref-pullrequest-2023448983 |
|
fix(clerk-js): Hide Add domain button when user is missing org:sys_domains:manage (#2240)
#2250
| https://github.com/clerk/javascript/pull/2250 |
| github-merge-queue | https://github.com/apps/github-merge-queue |
|
Dec 4, 2023
| https://github.com/clerk/javascript/pull/2240#ref-commit-e0c4364 |
|
| https://github.com/panteliselef |
| fix(clerk-js): Hide Add domain button when user is missing `org:sys_d… | https://github.com/clerk/javascript/commit/e0c43640229bc690d938c305a51ca3f7b7383caa |
| e0c4364 | https://github.com/clerk/javascript/commit/e0c43640229bc690d938c305a51ca3f7b7383caa |
| #2240 | https://github.com/clerk/javascript/pull/2240 |
| #2250 | https://github.com/clerk/javascript/pull/2250 |
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
|
Mar 13, 2024
| https://github.com/clerk/javascript/pull/2240#ref-pullrequest-2183445819 |
|
fix(themes): Add tslib and @clerk/types as dependencies to @clerk/themes (#2665)
#2987
| https://github.com/clerk/javascript/pull/2987 |
| https://github.com/LekoArts |
| LekoArts | https://github.com/LekoArts |
|
Aug 2, 2024
| https://github.com/clerk/javascript/pull/2240#ref-pullrequest-2444224984 |
|
chore(repo): Correct changeset
#3883
| https://github.com/clerk/javascript/pull/3883 |
| https://github.co/hiddenchars |
| https://github.com/clerk/javascript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2240 |
|
| https://github.com/chanioxaris |
|
chanioxaris
| https://github.com/chanioxaris |
|
| https://github.com/dimkl |
|
dimkl
| https://github.com/dimkl |
|
| https://github.com/clerk/javascript/pull/2240/files/ee3110f443f345365a6bcd01cde2bc31abcab430 |
|
| https://github.com/LekoArts |
|
LekoArts
| https://github.com/LekoArts |
|
| https://github.com/clerk/javascript/pull/2240/files/ee3110f443f345365a6bcd01cde2bc31abcab430 |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
|
| https://github.com/panteliselef |
|
panteliselef
| https://github.com/panteliselef |
|
clerk-js
| https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aclerk-js |
| Please reload this page | https://github.com/clerk/javascript/pull/2240 |
|
| https://github.com/panteliselef |
|
| https://github.com/dimkl |
|
| https://github.com/LekoArts |
|
| https://github.com/clerk-cookie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |