René's URL Explorer Experiment


Title: chore(types,clerk-react): Make `routerPush` / `routerReplace` both required or both optional by dimkl · Pull Request #2227 · clerk/javascript · GitHub

Open Graph Title: chore(types,clerk-react): Make `routerPush` / `routerReplace` both required or both optional by dimkl · Pull Request #2227 · clerk/javascript

X Title: chore(types,clerk-react): Make `routerPush` / `routerReplace` both required or both optional by dimkl · Pull Request #2227 · clerk/javascript

Description: Official JavaScript repository for Clerk authentication - chore(types,clerk-react): Make `routerPush` / `routerReplace` both required or both optional by dimkl · Pull Request #2227 · clerk/javascript

Open Graph Description: Description Changes (review per commit for more info): Use Without generic to resolve issues with Omit and complex types Make routerPush and routerReplace options both required or both optional Im...

X Description: Description Changes (review per commit for more info): Use Without generic to resolve issues with Omit and complex types Make routerPush and routerReplace options both required or both optional Im...

Opengraph URL: https://github.com/clerk/javascript/pull/2227

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dbbd4e3f-05f6-4aa5-0b40-997518229586
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC118:387B0D:1E0D473:29D6C49:6AFA6BA5
html-safe-noncec0dd171664e855053dce3a6fcae832205500fe02d3749fd84fa31fd845d72625
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTE4OjM4N0IwRDoxRTBENDczOjI5RDZDNDk6NkFGQTZCQTUiLCJ2aXNpdG9yX2lkIjoiNjc1MDQ4MzI4NTg0NDU4NTM4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac296d31016d1cc62dc886409583256e8ffd55f4ea52bff2cc6146a7f354266daa
hovercard-subject-tagpull_request:1620835347
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/clerk/javascript/2227/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5f9e088e496075b91e331fe60ffd816b86c2736d88032ed94c661af9a49212f0/clerk/javascript/pull/2227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f9e088e496075b91e331fe60ffd816b86c2736d88032ed94c661af9a49212f0/clerk/javascript/pull/2227
og:image:altDescription Changes (review per commit for more info): Use Without generic to resolve issues with Omit and complex types Make routerPush and routerReplace options both required or both optional Im...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedimkl
hostnamegithub.com
expected-hostnamegithub.com
None612d3e6ffd693e7ea8d9fcf452370995872baef31d825b1fedef704cd3d24ac7
turbo-cache-controlno-cache
go-importgithub.com/clerk/javascript git https://github.com/clerk/javascript.git
octolytics-dimension-user_id49538330
octolytics-dimension-user_loginclerk
octolytics-dimension-repository_id438331492
octolytics-dimension-repository_nwoclerk/javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id438331492
octolytics-dimension-repository_network_root_nwoclerk/javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release072e34035c13c31543fba9f025cbbbda4210dae4
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/clerk/javascript/pull/2227#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2227
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2227
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=clerk%2Fjavascript
Reloadhttps://github.com/clerk/javascript/pull/2227
Reloadhttps://github.com/clerk/javascript/pull/2227
Reloadhttps://github.com/clerk/javascript/pull/2227
clerkhttps://github.com/clerk
javascripthttps://github.com/clerk/javascript
Codehttps://github.com/clerk/javascript
Issues44 (44)https://github.com/clerk/javascript/issues
Pull requests109 (109)https://github.com/clerk/javascript/pulls
Discussionshttps://github.com/clerk/javascript/discussions
Actionshttps://github.com/clerk/javascript/actions
Security and quality6 (6)https://github.com/clerk/javascript/security
Insightshttps://github.com/clerk/javascript/pulse
https://github.com/clerk/javascript
dimklhttps://github.com/dimkl
mainhttps://github.com/clerk/javascript/tree/main
sdk-683-router-optionshttps://github.com/clerk/javascript/tree/sdk-683-router-options
Conversationhttps://github.com/clerk/javascript/pull/2227
Commits6 (6)https://github.com/clerk/javascript/pull/2227/commits
Checkshttps://github.com/clerk/javascript/pull/2227/checks
Files changedhttps://github.com/clerk/javascript/pull/2227/files
chore(types,clerk-react): Make routerPush / routerReplace both required or both optionalhttps://github.com/clerk/javascript/pull/2227#top
dimklhttps://github.com/dimkl
mainhttps://github.com/clerk/javascript/tree/main
sdk-683-router-optionshttps://github.com/clerk/javascript/tree/sdk-683-router-options
https://github.com/dimkl
dimklhttps://github.com/dimkl
Nov 28, 2023https://github.com/clerk/javascript/pull/2227#issue-2015461254
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
JSDoc commentshttps://jsdoc.app/about-getting-started.html
Documentationhttps://github.com/clerk/clerk-docs
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/dimkl
dimklhttps://github.com/dimkl
v5-release https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Av5-release
Nov 28, 2023https://github.com/clerk/javascript/pull/2227#event-11089636869
https://github.com/dimkl
dimklhttps://github.com/dimkl
Nov 28, 2023https://github.com/clerk/javascript/pull/2227#event-11089636920
https://github.com/apps/changeset-bot
changeset-bothttps://github.com/apps/changeset-bot
Nov 28, 2023https://github.com/clerk/javascript/pull/2227#issuecomment-1830890031
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
495c3ebhttps://github.com/clerk/javascript/commit/495c3eb8a01e21ae8a6159be56e77395599b5cc2
Click here to learn what changesets arehttps://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md
Click here if you're a maintainer who wants to add another changeset to this PRhttps://github.com/clerk/javascript/new/sdk-683-router-options?filename=.changeset/rude-suits-crash.md&value=---%0A%22%40clerk%2Fclerk-react%22%3A%20patch%0A%22%40clerk%2Ftypes%22%3A%20patch%0A---%0A%0Achore(types%2Cclerk-react)%3A%20Make%20%60routerPush%60%20%2F%20%60routerReplace%60%20both%20required%20or%20both%20optional%0A
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/dimkl
dimklhttps://github.com/dimkl
desiprisghttps://github.com/desiprisg
nikosdouvlishttps://github.com/nikosdouvlis
panteliselefhttps://github.com/panteliselef
panteliselefhttps://github.com/panteliselef
November 28, 2023 22:57https://github.com/clerk/javascript/pull/2227#event-11089637634
https://github.com/clerk-cookie
clerk-cookiehttps://github.com/clerk-cookie
types https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Atypes
react https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Areact
Nov 28, 2023https://github.com/clerk/javascript/pull/2227#event-11089638323
https://github.com/dimkl
dimklhttps://github.com/dimkl
force-pushedhttps://github.com/clerk/javascript/compare/123c4238aa464ecae39464d5b97e503cacd819cc..2b242718336a347590cf250a90f0efd1d42bd09b
123c423https://github.com/clerk/javascript/commit/123c4238aa464ecae39464d5b97e503cacd819cc
2b24271https://github.com/clerk/javascript/commit/2b242718336a347590cf250a90f0efd1d42bd09b
Compare https://github.com/clerk/javascript/compare/123c4238aa464ecae39464d5b97e503cacd819cc..2b242718336a347590cf250a90f0efd1d42bd09b
November 29, 2023 13:13https://github.com/clerk/javascript/pull/2227#event-11096256523
https://github.com/clerk-cookie
clerk-cookiehttps://github.com/clerk-cookie
retheme https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aretheme
actions https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aactions
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11096258394
https://github.com/clerk
clerkhttps://github.com/clerk
github-actionshttps://github.com/apps/github-actions
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11096314094
https://github.com/dimkl
dimklhttps://github.com/dimkl
force-pushedhttps://github.com/clerk/javascript/compare/0988485672ea6b5667dc9e277cafd7e647af010e..2b242718336a347590cf250a90f0efd1d42bd09b
0988485https://github.com/clerk/javascript/commit/0988485672ea6b5667dc9e277cafd7e647af010e
2b24271https://github.com/clerk/javascript/commit/2b242718336a347590cf250a90f0efd1d42bd09b
Compare https://github.com/clerk/javascript/compare/0988485672ea6b5667dc9e277cafd7e647af010e..2b242718336a347590cf250a90f0efd1d42bd09b
November 29, 2023 13:19https://github.com/clerk/javascript/pull/2227#event-11096318060
https://github.com/clerk-cookie
clerk-cookiehttps://github.com/clerk-cookie
actions https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aactions
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11096319974
dimklhttps://github.com/dimkl
November 29, 2023 15:20https://github.com/clerk/javascript/pull/2227#commits-pushed-77f7291
https://github.com/dimkl
chore(types): Use Without generic to resolve issues with Omit and…https://github.com/clerk/javascript/pull/2227/commits/77f729160d972719932db16fe6f6923437947762
77f7291https://github.com/clerk/javascript/pull/2227/commits/77f729160d972719932db16fe6f6923437947762
https://github.com/dimkl
chore(types): Make routerPush and routerReplace options both requ…https://github.com/clerk/javascript/pull/2227/commits/638e388f8af9aebd0f5c118c6650a0b5a577a9e4
638e388https://github.com/clerk/javascript/pull/2227/commits/638e388f8af9aebd0f5c118c6650a0b5a577a9e4
https://github.com/dimkl
chore(repo): Ignore test runner files and CHANGELOG.md from formattinghttps://github.com/clerk/javascript/pull/2227/commits/63f0310365dcf8071580b652edb3586f05aa4f03
63f0310https://github.com/clerk/javascript/pull/2227/commits/63f0310365dcf8071580b652edb3586f05aa4f03
https://github.com/dimkl
chore(repo): Add changesethttps://github.com/clerk/javascript/pull/2227/commits/69b3cff9926df4b53e3a53d330890de6f6dd46ab
69b3cffhttps://github.com/clerk/javascript/pull/2227/commits/69b3cff9926df4b53e3a53d330890de6f6dd46ab
https://github.com/dimkl
dimklhttps://github.com/dimkl
force-pushedhttps://github.com/clerk/javascript/compare/2b242718336a347590cf250a90f0efd1d42bd09b..69b3cff9926df4b53e3a53d330890de6f6dd46ab
2b24271https://github.com/clerk/javascript/commit/2b242718336a347590cf250a90f0efd1d42bd09b
69b3cffhttps://github.com/clerk/javascript/commit/69b3cff9926df4b53e3a53d330890de6f6dd46ab
Compare https://github.com/clerk/javascript/compare/2b242718336a347590cf250a90f0efd1d42bd09b..69b3cff9926df4b53e3a53d330890de6f6dd46ab
November 29, 2023 13:21https://github.com/clerk/javascript/pull/2227#event-11096340409
https://github.com/dimkl
chore(repo): Update ui-retheme-changes-reminder to notify for files w…https://github.com/clerk/javascript/pull/2227/commits/fb6e3218934b85e3ecdf649bc0d07a3549609c17
fb6e321https://github.com/clerk/javascript/pull/2227/commits/fb6e3218934b85e3ecdf649bc0d07a3549609c17
https://github.com/clerk-cookie
clerk-cookiehttps://github.com/clerk-cookie
actions https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aactions
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11096368640
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#issuecomment-1831890167
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/anagstef
anagstefhttps://github.com/anagstef
Nov 29, 2023 https://github.com/clerk/javascript/pull/2227#pullrequestreview-1755259380
View reviewed changes https://github.com/clerk/javascript/pull/2227/files/fb6e3218934b85e3ecdf649bc0d07a3549609c17
.github/workflows/ui-retheme-changes-reminder.ymlhttps://github.com/clerk/javascript/pull/2227/files/fb6e3218934b85e3ecdf649bc0d07a3549609c17#diff-ff53e3297e10d725b473d4b62ec7fa491d85568e2a03a3fca304abc8209c7b2f
anagstefhttps://github.com/anagstef
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#discussion_r1409277605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/LekoArts
LekoArtshttps://github.com/LekoArts
Nov 29, 2023 https://github.com/clerk/javascript/pull/2227#pullrequestreview-1755272041
View reviewed changes https://github.com/clerk/javascript/pull/2227/files/fb6e3218934b85e3ecdf649bc0d07a3549609c17
.changeset/tiny-forks-sit.mdhttps://github.com/clerk/javascript/pull/2227/files/fb6e3218934b85e3ecdf649bc0d07a3549609c17#diff-b63549fd0ce10a8249b9c72df53042cd3cca03e3961fc52b0988f38c6378cf08
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/dimkl
https://github.com/LekoArts
Update .changeset/tiny-forks-sit.mdhttps://github.com/clerk/javascript/pull/2227/commits/495c3eb8a01e21ae8a6159be56e77395599b5cc2
495c3ebhttps://github.com/clerk/javascript/pull/2227/commits/495c3eb8a01e21ae8a6159be56e77395599b5cc2
https://github.com/LekoArts
LekoArtshttps://github.com/LekoArts
Nov 29, 2023 https://github.com/clerk/javascript/pull/2227#pullrequestreview-1755277618
View reviewed changes https://github.com/clerk/javascript/pull/2227/files/495c3eb8a01e21ae8a6159be56e77395599b5cc2
https://github.com/dimkl
dimklhttps://github.com/dimkl
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11096983531
d6a7ea6https://github.com/clerk/javascript/commit/d6a7ea61a8ae64c93877ec117e54fc48b1c86f16
Nov 29, 2023https://github.com/clerk/javascript/pull/2227#event-11097054400
https://github.com/dimkl
dimklhttps://github.com/dimkl
November 29, 2023 14:18https://github.com/clerk/javascript/pull/2227#event-11097054678
https://github.com/clerk-cookie
clerk-cookiehttps://github.com/clerk-cookie
Nov 29, 2023 https://github.com/clerk/javascript/pull/2227#ref-pullrequest-2015371221
Version Packages (alpha-v5) #2224 https://github.com/clerk/javascript/pull/2224
https://github.co/hiddenchars
https://github.com/clerk/javascript/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fclerk%2Fjavascript%2Fpull%2F2227
https://github.com/nikosdouvlis
nikosdouvlis https://github.com/nikosdouvlis
https://github.com/panteliselef
panteliselef https://github.com/panteliselef
https://github.com/desiprisg
desiprisg https://github.com/desiprisg
https://github.com/anagstef
anagstef https://github.com/anagstef
https://github.com/clerk/javascript/pull/2227/files/fb6e3218934b85e3ecdf649bc0d07a3549609c17
https://github.com/LekoArts
LekoArts https://github.com/LekoArts
https://github.com/clerk/javascript/pull/2227/files/495c3eb8a01e21ae8a6159be56e77395599b5cc2
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/dimkl
dimkl https://github.com/dimkl
actions https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Aactions
react https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Areact
types https://github.com/clerk/javascript/issues?q=state%3Aopen%20label%3Atypes
Please reload this pagehttps://github.com/clerk/javascript/pull/2227
https://github.com/dimkl
https://github.com/anagstef
https://github.com/LekoArts
https://github.com/clerk-cookie
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.