René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support `CelOptions` to disable string conversion and list/string concatenation","articleBody":"**Feature request checklist**\n\n- [x] There are no issues that match the desired change\n- [ ] The change is large enough it can't be addressed with a simple Pull Request\n- [x] If this is a bug, please file a [Bug Report](./ISSUE_TEMPLATE).\n\n**Change**\nTo make CEL environment setup consistent across CEL implementations, I propose to add equivalent runtime options that control string conversion and list/string concatenation equivalent to those found in CEL-cpp:\n\n```cpp\n// Enable string() overloads.\nbool enable_string_conversion = true;\n\n// Enable string concatenation overload.\nbool enable_string_concat = true;\n\n// Enable list concatenation overload.\nbool enable_list_concat = true;\n```\n\n**Example**\n```java\nCelCompiler CEL_COMPILER = CelCompilerFactory.standardCelCompilerBuilder()\n    .setResultType(SimpleType.BOOL)\n    .build();\n\n@Test\npublic void cel_stringConversionDisabled() throws Exception {\n  CelRuntime CEL_RUNTIME = CelRuntimeFactory.standardCelRuntimeBuilder()\n      .setOptions(CelOptions.current().enableStringConversion(false).build())\n      .build();\n\n  // TODO: verify conversions to all types.\n  String expr = \"string(3.14) == '3.14'\";\n  CelRuntime.Program program = CEL_RUNTIME.createProgram(CEL_COMPILER.compile(expr).getAst());\n  CelEvaluationException celErr = assertThrows(CelEvaluationException.class, program::eval);\n  assertThat(celErr.getErrorCode()).isEqualTo(CelErrorCode.OVERLOAD_NOT_FOUND);\n}\n\n@Test\npublic void cel_stringConcatDisabled() throws Exception {\n  CelRuntime CEL_RUNTIME = CelRuntimeFactory.standardCelRuntimeBuilder()\n      .setOptions(CelOptions.current().enableStringConcat(false).build())\n      .build();\n\n  String expr = \"'ab' + 'cd' == 'abcd'\";\n  CelRuntime.Program program = CEL_RUNTIME.createProgram(CEL_COMPILER.compile(expr).getAst());\n  CelEvaluationException celErr = assertThrows(CelEvaluationException.class, program::eval);\n  assertThat(celErr.getErrorCode()).isEqualTo(CelErrorCode.OVERLOAD_NOT_FOUND);\n}\n\n@Test\npublic void cel_listConcatDisabled() throws Exception {\n  CelRuntime CEL_RUNTIME = CelRuntimeFactory.standardCelRuntimeBuilder()\n      .setOptions(CelOptions.current().enableListConcat(false).build())\n      .build();\n\n  String expr = \"size([1, 2] + [3, 4]) == 4\";\n  CelRuntime.Program program = CEL_RUNTIME.createProgram(CEL_COMPILER.compile(expr).getAst());\n  CelEvaluationException celErr = assertThrows(CelEvaluationException.class, program::eval);\n  assertThat(celErr.getErrorCode()).isEqualTo(CelErrorCode.OVERLOAD_NOT_FOUND);\n}\n```\n\n**Related**\n* Corresponding cel-go request: google/cel-go#1078\n* Internal ref: go/grpc-cel-integration\n","author":{"url":"https://github.com/sergiitk","@type":"Person","name":"sergiitk"},"datePublished":"2024-11-25T18:09:34.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/502/cel-java/issues/502"}