René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support `CelOptions.enableComprehension(boolean)` for feature parity with CEL-Cpp","articleBody":"**Feature request checklist**\n\n- [x] There are no issues that match the desired change\n- [ ] The change is large enough it can't be addressed with a simple Pull Request\n- [x] If this is a bug, please file a [Bug Report](./ISSUE_TEMPLATE).\n\n**Change**\nTo make CEL environment setup consistent across CEL implementations, I propose to add a runtime option equivalent to CEL-cpp `InterpreterOptions.enable_comprehension` to CEL-Java and CEL-Go (corresponding ticket google/cel-go#1050).\n\n`CelOptions.enableComprehension` is `true` by default. Setting it to false will disable comprehension expressions (e.g. `exists()`, `all()` -- except `has()`). Under-the-hood it may simply call `comprehensionMaxIterations(0)` to disable comprehension expressions, and reset it to the default value to enable them.\n\n**Example**\n```java\nprivate static final CelRuntime CEL_RUNTIME = CelRuntimeFactory\n    .standardCelRuntimeBuilder()\n    .setOptions(CelOptions.current().enableComprehension(false).build())\n    .build();\n```\n\n```java\n@Test\npublic void macros_comprehensionsDisabled() throws Exception {\n  CelCompiler CEL_COMPILER = CelCompilerFactory.standardCelCompilerBuilder()\n    .addVar(\"request\", SimpleType.ANY)\n    .setResultType(SimpleType.BOOL)\n    .setStandardMacros(CelStandardMacro.STANDARD_MACROS)\n    .build();\n\n  String expr = \"size(['foo', 'bar'].map(x, request[x])) == 2\";\n  CelRuntime.Program program = CEL_RUNTIME.createProgram(CEL_COMPILER.compile(expr).getAst());\n\n  Map\u003cString, ?\u003e input = ImmutableMap.of(\"request\", ImmutableMap.of(\"foo\", \"f\", \"bar\", \"b\"));\n  CelEvaluationException celErr = assertThrows(CelEvaluationException.class, () -\u003e program.eval(input));\n\n  assertThat(celErr.getErrorCode()).isEqualTo(CelErrorCode.ITERATION_BUDGET_EXCEEDED);\n}\n```\n\n**Related**\nInternal ref: go/grpc-cel-integration","author":{"url":"https://github.com/sergiitk","@type":"Person","name":"sergiitk"},"datePublished":"2024-10-24T01:08:26.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/484/cel-java/issues/484"}