René's URL Explorer Experiment


Title: eds: Style cleanup and simplification, warning fixes by acolomb · Pull Request #675 · canopen-python/canopen · GitHub

Open Graph Title: eds: Style cleanup and simplification, warning fixes by acolomb · Pull Request #675 · canopen-python/canopen

X Title: eds: Style cleanup and simplification, warning fixes by acolomb · Pull Request #675 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: This should not result in any functional behavior changes. It mainly fixes some of the clumsy code in eds.py and avoids type checker errors in the process. See individual commit messages for more ...

X Description: This should not result in any functional behavior changes. It mainly fixes some of the clumsy code in eds.py and avoids type checker errors in the process. See individual commit messages for more ...

Opengraph URL: https://github.com/canopen-python/canopen/pull/675

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:92817323-590b-a66a-c293-8d98b5712847
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8288:12D89D:32FB81C:42CCE0F:6A5CE9DE
html-safe-nonce52b707f2dc5b3e1dfe2fcd6926478de433a869ed16a50337551484c2a18e560f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mjg4OjEyRDg5RDozMkZCODFDOjQyQ0NFMEY6NkE1Q0U5REUiLCJ2aXNpdG9yX2lkIjoiNTQ5Mjg2MjE4NjYzMTc4NDkyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1f8492a3944cc3deb8ca682ad3a34c9be3c197198fb29511b9c309b2b5025796
hovercard-subject-tagpull_request:3949070776
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/675/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7369387e78d8d965fe244ec3fd96df440b33bffd87e8a32147e697d7128267e3/canopen-python/canopen/pull/675
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7369387e78d8d965fe244ec3fd96df440b33bffd87e8a32147e697d7128267e3/canopen-python/canopen/pull/675
og:image:altThis should not result in any functional behavior changes. It mainly fixes some of the clumsy code in eds.py and avoids type checker errors in the process. See individual commit messages for more ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/675#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F675
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F675
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/675
Reloadhttps://github.com/canopen-python/canopen/pull/675
Reloadhttps://github.com/canopen-python/canopen/pull/675
Please reload this pagehttps://github.com/canopen-python/canopen/pull/675
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:cleanup-edshttps://github.com/acolomb/canopen/tree/cleanup-eds
Conversationhttps://github.com/canopen-python/canopen/pull/675
Commits11 (11)https://github.com/canopen-python/canopen/pull/675/commits
Checkshttps://github.com/canopen-python/canopen/pull/675/checks
Files changedhttps://github.com/canopen-python/canopen/pull/675/files
eds: Style cleanup and simplification, warning fixeshttps://github.com/canopen-python/canopen/pull/675#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:cleanup-edshttps://github.com/acolomb/canopen/tree/cleanup-eds
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 27, 2026https://github.com/canopen-python/canopen/pull/675#issue-4760109387
Please reload this pagehttps://github.com/canopen-python/canopen/pull/675
acolombhttps://github.com/acolomb
June 27, 2026 23:38https://github.com/canopen-python/canopen/pull/675#commits-pushed-241154b
https://github.com/acolomb
No else after return.https://github.com/canopen-python/canopen/pull/675/commits/241154be0cdd49f5741e6c71fa709d32e32c0593
241154bhttps://github.com/canopen-python/canopen/pull/675/commits/241154be0cdd49f5741e6c71fa709d32e32c0593
https://github.com/acolomb
Move regex definitions outside of loop, precompiled.https://github.com/canopen-python/canopen/pull/675/commits/45630163dd8fa22c8797d8b0570b3e37b10b7406
4563016https://github.com/canopen-python/canopen/pull/675/commits/45630163dd8fa22c8797d8b0570b3e37b10b7406
https://github.com/acolomb
Avoid getattr() on attributes defined by constructor.https://github.com/canopen-python/canopen/pull/675/commits/09c81cef34489bddbb6877969aba1762742c5fc6
09c81cehttps://github.com/canopen-python/canopen/pull/675/commits/09c81cef34489bddbb6877969aba1762742c5fc6
https://github.com/acolomb
Refactor string conversion with exception handling.https://github.com/canopen-python/canopen/pull/675/commits/37c988fa9cd4f72d1e3328f55ee38c303d87647f
37c988fhttps://github.com/canopen-python/canopen/pull/675/commits/37c988fa9cd4f72d1e3328f55ee38c303d87647f
https://github.com/acolomb
Collapse has_option() and get() calls.https://github.com/canopen-python/canopen/pull/675/commits/9b016e791e4bdf461ddb169e2cf10b657f6add08
9b016e7https://github.com/canopen-python/canopen/pull/675/commits/9b016e791e4bdf461ddb169e2cf10b657f6add08
https://github.com/acolomb
Ignore type checker error for custom attribute.https://github.com/canopen-python/canopen/pull/675/commits/37ac2c3cf7c47d96b34fe3c00c024bfe904c0adb
37ac2c3https://github.com/canopen-python/canopen/pull/675/commits/37ac2c3cf7c47d96b34fe3c00c024bfe904c0adb
https://github.com/acolomb
Fix shadowed "list" built-in.https://github.com/canopen-python/canopen/pull/675/commits/792aa320f17e5903f67b5dac77eaaaeeb235578e
792aa32https://github.com/canopen-python/canopen/pull/675/commits/792aa320f17e5903f67b5dac77eaaaeeb235578e
https://github.com/acolomb
Simplify and reformat DeviceInfo section parsing.https://github.com/canopen-python/canopen/pull/675/commits/9694edd524b7d470dd41cb0744163d40cbd8861f
9694eddhttps://github.com/canopen-python/canopen/pull/675/commits/9694edd524b7d470dd41cb0744163d40cbd8861f
https://github.com/acolomb
Fix type checker errors around optionxform.https://github.com/canopen-python/canopen/pull/675/commits/7327199d011b03351d2d7b70d52ac3579a5cb08a
7327199https://github.com/canopen-python/canopen/pull/675/commits/7327199d011b03351d2d7b70d52ac3579a5cb08a
https://github.com/acolomb
Add type guard for ODArray in CompactSubObj handling.https://github.com/canopen-python/canopen/pull/675/commits/2efa12cd5937695cab53814c1ca8bf80a0e6780e
2efa12chttps://github.com/canopen-python/canopen/pull/675/commits/2efa12cd5937695cab53814c1ca8bf80a0e6780e
https://github.com/acolomb
Document "section" parameter in build_variable() docstring.https://github.com/canopen-python/canopen/pull/675/commits/196580238ede5a0e9b0bf19285bbe704aca32705
1965802https://github.com/canopen-python/canopen/pull/675/commits/196580238ede5a0e9b0bf19285bbe704aca32705
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 27, 2026https://github.com/canopen-python/canopen/pull/675#issuecomment-4822252950
Codecovhttps://app.codecov.io/gh/canopen-python/canopen/pull/675?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Files with missing lineshttps://app.codecov.io/gh/canopen-python/canopen/pull/675?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
canopen/objectdictionary/eds.pyhttps://app.codecov.io/gh/canopen-python/canopen/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python#diff-Y2Fub3Blbi9vYmplY3RkaWN0aW9uYXJ5L2Vkcy5weQ==
3 Missing and 3 partials ⚠️ https://app.codecov.io/gh/canopen-python/canopen/pull/675?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/canopen-python/canopen/pull/675
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 27, 2026https://github.com/canopen-python/canopen/pull/675#issuecomment-4822319879
this branchhttps://github.com/acolomb/canopen/tree/eds-strict-mode
Please reload this pagehttps://github.com/canopen-python/canopen/pull/675
https://github.com/acolomb
acolombhttps://github.com/acolomb
code-quality https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Acode-quality
Jun 27, 2026https://github.com/canopen-python/canopen/pull/675#event-27289428513
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F675
code-quality https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Acode-quality
Please reload this pagehttps://github.com/canopen-python/canopen/pull/675
https://github.com/acolomb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.