| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf26bf4b-953c-dbb5-cb33-5f3eec6150ff |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E39C:3081D4:4120D17:55A542F:6A5D6069 |
| html-safe-nonce | f37c4b7091919733ecfb036b8d81efd41e18724feaa6a215207460e151d15194 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzlDOjMwODFENDo0MTIwRDE3OjU1QTU0MkY6NkE1RDYwNjkiLCJ2aXNpdG9yX2lkIjoiNTEyODg4MjQ0NzIzODEyNzcyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 20b2140dfa4428be55214977ee4c72bdc4b50626d708125da337ab9d98ff356c |
| hovercard-subject-tag | pull_request:3806024180 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/673/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/cd765d9fcab26ccf5f77a14bfe16af3a7d8954266f91f9b516472669b529dd30/canopen-python/canopen/pull/673 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cd765d9fcab26ccf5f77a14bfe16af3a7d8954266f91f9b516472669b529dd30/canopen-python/canopen/pull/673 |
| og:image:alt | The Variable.phys property docstring mentions "Non integers will be
passed as is." That is correct, but not reflected in the type hints
for the associated ODVariable.encode_phys() / .dec... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | acolomb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git |
| octolytics-dimension-user_id | 200581454 |
| octolytics-dimension-user_login | canopen-python |
| octolytics-dimension-repository_id | 68737600 |
| octolytics-dimension-repository_nwo | canopen-python/canopen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68737600 |
| octolytics-dimension-repository_network_root_nwo | canopen-python/canopen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/canopen-python/canopen/pull/673#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F673 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F673 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen |
| Reload | https://github.com/canopen-python/canopen/pull/673 |
| Reload | https://github.com/canopen-python/canopen/pull/673 |
| Reload | https://github.com/canopen-python/canopen/pull/673 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
|
canopen-python
| https://github.com/canopen-python |
| canopen | https://github.com/canopen-python/canopen |
|
Notifications
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Fork
359
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Star
560
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
53
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
20
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
0
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:phys-passthrough | https://github.com/acolomb/canopen/tree/phys-passthrough |
| Conversation | https://github.com/canopen-python/canopen/pull/673 |
| Commits8 (8) | https://github.com/canopen-python/canopen/pull/673/commits |
| Checks | https://github.com/canopen-python/canopen/pull/673/checks |
| Files changed | https://github.com/canopen-python/canopen/pull/673/files |
| od: Extend physical conversion to integer factors, fix typing | https://github.com/canopen-python/canopen/pull/673#top |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:phys-passthrough | https://github.com/acolomb/canopen/tree/phys-passthrough |
|
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 4, 2026 | https://github.com/canopen-python/canopen/pull/673#issue-4592192958 |
| #651 (comment) | https://github.com/canopen-python/canopen/pull/651#issuecomment-4386512596 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| acolomb | https://github.com/acolomb |
| June 4, 2026 22:48 | https://github.com/canopen-python/canopen/pull/673#commits-pushed-4ed62ae |
|
| https://github.com/acolomb |
| Fix type handling for physical variable representation. | https://github.com/canopen-python/canopen/pull/673/commits/4ed62aebeb1f1af219670243fcc4b72da7836e57 |
| 4ed62ae | https://github.com/canopen-python/canopen/pull/673/commits/4ed62aebeb1f1af219670243fcc4b72da7836e57 |
|
| https://github.com/acolomb |
| Extend physical conversion to float types. | https://github.com/canopen-python/canopen/pull/673/commits/5aec9612b4549eadeb8d6bc98154d8a3c77e1f81 |
| 5aec961 | https://github.com/canopen-python/canopen/pull/673/commits/5aec9612b4549eadeb8d6bc98154d8a3c77e1f81 |
|
| https://github.com/acolomb |
| Allow integer factors for physical representation. | https://github.com/canopen-python/canopen/pull/673/commits/af462c99549de92b15541d10a621f10b59e559ad |
| af462c9 | https://github.com/canopen-python/canopen/pull/673/commits/af462c99549de92b15541d10a621f10b59e559ad |
|
| https://github.com/acolomb |
| Accept integer Factor= settings from EDS. | https://github.com/canopen-python/canopen/pull/673/commits/aa8a166c551e20eb49df59ae92a86f5a87cea142 |
| aa8a166 | https://github.com/canopen-python/canopen/pull/673/commits/aa8a166c551e20eb49df59ae92a86f5a87cea142 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Jun 4, 2026 | https://github.com/canopen-python/canopen/pull/673#issuecomment-4626126364 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| Codecov | https://app.codecov.io/gh/canopen-python/canopen/pull/673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python |
| Let us know! | https://github.com/codecov/feedback/issues/255 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| acolomb | https://github.com/acolomb |
| June 4, 2026 23:17 | https://github.com/canopen-python/canopen/pull/673#commits-pushed-9ad88a7 |
|
| https://github.com/acolomb |
| Test integer factors. | https://github.com/canopen-python/canopen/pull/673/commits/9ad88a74baf71075480d19a677c63a2566bc5118 |
| 9ad88a7 | https://github.com/canopen-python/canopen/pull/673/commits/9ad88a74baf71075480d19a677c63a2566bc5118 |
|
| https://github.com/acolomb |
| Test integer factor in EDS. | https://github.com/canopen-python/canopen/pull/673/commits/b556966662fc63cdd2f256446934f44ac734c23d |
| b556966 | https://github.com/canopen-python/canopen/pull/673/commits/b556966662fc63cdd2f256446934f44ac734c23d |
|
| https://github.com/acolomb |
| Test real32 and pass-through of non-numeric variables. | https://github.com/canopen-python/canopen/pull/673/commits/eb8563475625062221c93d010d8ee2e71e3cf16d |
| eb85634 | https://github.com/canopen-python/canopen/pull/673/commits/eb8563475625062221c93d010d8ee2e71e3cf16d |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| June 4, 2026 21:36 | https://github.com/canopen-python/canopen/pull/673#event-26358155278 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
typing
| https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Atyping |
| Jun 14, 2026 | https://github.com/canopen-python/canopen/pull/673#event-26732273222 |
| https://github.com/bizfsc |
| bizfsc | https://github.com/bizfsc |
|
Jun 24, 2026
| https://github.com/canopen-python/canopen/pull/673#pullrequestreview-4560166611 |
|
View reviewed changes
| https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d |
| bizfsc | https://github.com/bizfsc |
| https://github.com/canopen-python/canopen/pull/673#pullrequestreview-4560166611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| test/test_od.py | https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d#diff-0067197268d72b1ee379b0df2f36d1bcd4633e9bde7a9e42660074513ffdb28a |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| canopen/objectdictionary/eds.py | https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| canopen/objectdictionary/__init__.py | https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f |
| bizfsc | https://github.com/bizfsc |
| Jun 24, 2026 | https://github.com/canopen-python/canopen/pull/673#discussion_r3465470698 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| canopen/objectdictionary/__init__.py | https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f |
| bizfsc | https://github.com/bizfsc |
| Jun 24, 2026 | https://github.com/canopen-python/canopen/pull/673#discussion_r3465636910 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| acolomb | https://github.com/acolomb |
| Jun 25, 2026 | https://github.com/canopen-python/canopen/pull/673#discussion_r3477189039 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
|
| https://github.com/bizfsc |
| suggested changes from review | https://github.com/canopen-python/canopen/pull/673/commits/f1838f35566df218af4d47fec603401050f02243 |
| f1838f3 | https://github.com/canopen-python/canopen/pull/673/commits/f1838f35566df218af4d47fec603401050f02243 |
| https://github.co/hiddenchars |
| https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F673 |
|
| https://github.com/friederschueler |
|
friederschueler
| https://github.com/friederschueler |
|
| https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d |
|
| https://github.com/bizfsc |
|
bizfsc
| https://github.com/bizfsc |
|
| https://github.com/canopen-python/canopen/pull/673/files/eb8563475625062221c93d010d8ee2e71e3cf16d |
|
typing
| https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Atyping |
| Please reload this page | https://github.com/canopen-python/canopen/pull/673 |
|
| https://github.com/acolomb |
|
| https://github.com/friederschueler |
|
| https://github.com/bizfsc |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |