René's URL Explorer Experiment


Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen · GitHub

Open Graph Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen

X Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen

Description: Fix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Extend unit tests around import and export functions. Note that these are still a bit convoluted because the EDS import is tested through the generic, format-agnostic OD API. This is still much easier than splitting tests between generic and format-specific though. If ever someone adds unit tests covering the EPF import, that might need some refactoring.

Open Graph Description: Fix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...

X Description: Fix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...

Opengraph URL: https://github.com/canopen-python/canopen/pull/669

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:83478fba-fcff-f9b3-fea2-0e921860b279
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8DE:3CD7D9:8E779C1:C1E91B1:6A5EA40E
html-safe-nonce30a3ae4b099b77cf6d6d3971e93d9d681b4ce09a05fedbe0793b73c7024abaff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOERFOjNDRDdEOTo4RTc3OUMxOkMxRTkxQjE6NkE1RUE0MEUiLCJ2aXNpdG9yX2lkIjoiNzY4MDg4NjM5NjAxMTA2MjI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb416d6c122075d9cc864213fb92861c66413359c2f79ec1b71a14927c5d021f7
hovercard-subject-tagpull_request:3748934086
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/canopen-python/canopen/pull/669/files
twitter:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
og:image:altFix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/669/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F669%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F669%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/669/files
Reloadhttps://github.com/canopen-python/canopen/pull/669/files
Reloadhttps://github.com/canopen-python/canopen/pull/669/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669/files
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 561 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:fix-od-typing-filelikehttps://github.com/acolomb/canopen/tree/fix-od-typing-filelike
Conversation 6 https://github.com/canopen-python/canopen/pull/669
Commits 12 https://github.com/canopen-python/canopen/pull/669/commits
Checks 5 https://github.com/canopen-python/canopen/pull/669/checks
Files changed https://github.com/canopen-python/canopen/pull/669/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669/files
od: Robust path handling without type errors https://github.com/canopen-python/canopen/pull/669/files#top
Show all changes 12 commits https://github.com/canopen-python/canopen/pull/669/files
ef4ed96 od: Track export destination without type checker errors. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/ef4ed9655aa2d64de64362422cd3f34c1e5deec1
950edc0 export_od: Accept os.PathLike with robust suffix handling. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/950edc022c221a425f2efd4be8a273dce2c76d09
32d4d37 import_od: Accept os.PathLike with robust suffix handling. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/32d4d3731bf873976ca46bbd7cdbe3ca15b3005a
e0da0a8 Comment cosmetics acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/e0da0a8a9da5614d0199c117784be1d826b6e120
3406616 test_eds: Cover pathlib and StringIO as example inputs. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/340661699d24e288c7b279a20178486439e5e960
306da34 test_eds: Make sure export_eds() closes only internal fds. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/306da3454fd9dfe555b9147e699b0680c5b6ef3d
0f2115f Test import_od() on empty object. acolomb May 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/0f2115f245612e144f8a7c1dc9c26468f0dcb59f
47394c5 Move dest=None handling to generic function export_od(). acolomb Jun 26, 2026 https://github.com/canopen-python/canopen/pull/669/commits/47394c58a6157f5cfddd2d53c89afec54eef4b95
fb2b4f3 Fix auto-closing tests to test result, not implementation. acolomb Jun 28, 2026 https://github.com/canopen-python/canopen/pull/669/commits/fb2b4f31f98c4eb4ed761f11301089fcac3af9e8
3169821 Merge branch 'master' into fix-od-typing-filelike acolomb Jun 28, 2026 https://github.com/canopen-python/canopen/pull/669/commits/316982110a390ced2deca1e4f7c4e6cd43fb02ca
87a7f4a Add positive test for pathlib argument, remove object() arg test. acolomb Jun 28, 2026 https://github.com/canopen-python/canopen/pull/669/commits/87a7f4a10dc32d1b46b009f2f6e86ad6699dda16
c6d259e top-level imports for all tests acolomb Jun 28, 2026 https://github.com/canopen-python/canopen/pull/669/commits/c6d259e6c1932892b7a17349a6bbe7caeb0f0156
Clear filters https://github.com/canopen-python/canopen/pull/669/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669/files
__init__.py https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
eds.py https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
test_eds.py https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
canopen/objectdictionary/__init__.pyhttps://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
View file https://github.com/canopen-python/canopen/blob/c6d259e6c1932892b7a17349a6bbe7caeb0f0156/canopen/objectdictionary/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/669/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/669/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
canopen/objectdictionary/eds.pyhttps://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
View file https://github.com/canopen-python/canopen/blob/c6d259e6c1932892b7a17349a6bbe7caeb0f0156/canopen/objectdictionary/eds.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/669/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com/canopen-python/canopen/pull/669/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
test/test_eds.pyhttps://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
View file https://github.com/canopen-python/canopen/blob/c6d259e6c1932892b7a17349a6bbe7caeb0f0156/test/test_eds.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/669/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
https://github.com/canopen-python/canopen/pull/669/files#diff-339c7b9661df8e48adc88d28d953a955f16dae569fe46c3e027181fe533e0bbf
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.