René's URL Explorer Experiment


Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen · GitHub

Open Graph Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen

X Title: od: Robust path handling without type errors by acolomb · Pull Request #669 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Fix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...

X Description: Fix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...

Opengraph URL: https://github.com/canopen-python/canopen/pull/669

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2e934f96-b940-c164-9e7a-57b2d629e1ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9A2:1D4E56:39D7DEB:4D3BAC2:6A5D51B3
html-safe-nonce23ee9af6452c3a7c43ac7a8f58f22ae466e729c7c9608d2e3c35ed05ddb1b0a5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUEyOjFENEU1NjozOUQ3REVCOjREM0JBQzI6NkE1RDUxQjMiLCJ2aXNpdG9yX2lkIjoiNDg5NzE5ODM1MDk2MDc2NzIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5d78076d9a133d760c020f881f6ec6018675e1dfd3ad62ac4bb1a18c6b0e3b4e
hovercard-subject-tagpull_request:3748934086
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/669/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/805b82c63a58f8a3d003855ab22fcdc301b42060bba10c1a9bdd4e06116d1f8b/canopen-python/canopen/pull/669
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/805b82c63a58f8a3d003855ab22fcdc301b42060bba10c1a9bdd4e06116d1f8b/canopen-python/canopen/pull/669
og:image:altFix the union-attr errors squelched in #651 properly. In the process, extend import_od() to gracefully handle some edge cases around missing file names and non-str paths in the source argument. Ex...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/669#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F669
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F669
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/669
Reloadhttps://github.com/canopen-python/canopen/pull/669
Reloadhttps://github.com/canopen-python/canopen/pull/669
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:fix-od-typing-filelikehttps://github.com/acolomb/canopen/tree/fix-od-typing-filelike
Conversationhttps://github.com/canopen-python/canopen/pull/669
Commits12 (12)https://github.com/canopen-python/canopen/pull/669/commits
Checkshttps://github.com/canopen-python/canopen/pull/669/checks
Files changedhttps://github.com/canopen-python/canopen/pull/669/files
od: Robust path handling without type errorshttps://github.com/canopen-python/canopen/pull/669#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:fix-od-typing-filelikehttps://github.com/acolomb/canopen/tree/fix-od-typing-filelike
https://github.com/acolomb
acolombhttps://github.com/acolomb
May 26, 2026https://github.com/canopen-python/canopen/pull/669#issue-4525095051
#651https://github.com/canopen-python/canopen/pull/651
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
acolombhttps://github.com/acolomb
May 26, 2026 14:19https://github.com/canopen-python/canopen/pull/669#commits-pushed-ef4ed96
https://github.com/acolomb
od: Track export destination without type checker errors.https://github.com/canopen-python/canopen/pull/669/commits/ef4ed9655aa2d64de64362422cd3f34c1e5deec1
ef4ed96https://github.com/canopen-python/canopen/pull/669/commits/ef4ed9655aa2d64de64362422cd3f34c1e5deec1
https://github.com/acolomb
export_od: Accept os.PathLike with robust suffix handling.https://github.com/canopen-python/canopen/pull/669/commits/950edc022c221a425f2efd4be8a273dce2c76d09
950edc0https://github.com/canopen-python/canopen/pull/669/commits/950edc022c221a425f2efd4be8a273dce2c76d09
https://github.com/acolomb
import_od: Accept os.PathLike with robust suffix handling.https://github.com/canopen-python/canopen/pull/669/commits/32d4d3731bf873976ca46bbd7cdbe3ca15b3005a
32d4d37https://github.com/canopen-python/canopen/pull/669/commits/32d4d3731bf873976ca46bbd7cdbe3ca15b3005a
https://github.com/acolomb
Comment cosmeticshttps://github.com/canopen-python/canopen/pull/669/commits/e0da0a8a9da5614d0199c117784be1d826b6e120
e0da0a8https://github.com/canopen-python/canopen/pull/669/commits/e0da0a8a9da5614d0199c117784be1d826b6e120
https://github.com/acolomb
test_eds: Cover pathlib and StringIO as example inputs.https://github.com/canopen-python/canopen/pull/669/commits/340661699d24e288c7b279a20178486439e5e960
3406616https://github.com/canopen-python/canopen/pull/669/commits/340661699d24e288c7b279a20178486439e5e960
https://github.com/acolomb
test_eds: Make sure export_eds() closes only internal fds.https://github.com/canopen-python/canopen/pull/669/commits/306da3454fd9dfe555b9147e699b0680c5b6ef3d
306da34https://github.com/canopen-python/canopen/pull/669/commits/306da3454fd9dfe555b9147e699b0680c5b6ef3d
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 26, 2026https://github.com/canopen-python/canopen/pull/669#issuecomment-4545275976
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
Codecovhttps://app.codecov.io/gh/canopen-python/canopen/pull/669?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Files with missing lineshttps://app.codecov.io/gh/canopen-python/canopen/pull/669?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
canopen/objectdictionary/__init__.pyhttps://app.codecov.io/gh/canopen-python/canopen/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python#diff-Y2Fub3Blbi9vYmplY3RkaWN0aW9uYXJ5L19faW5pdF9fLnB5
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/canopen-python/canopen/pull/669?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/acolomb
Test import_od() on empty object.https://github.com/canopen-python/canopen/pull/669/commits/0f2115f245612e144f8a7c1dc9c26468f0dcb59f
0f2115fhttps://github.com/canopen-python/canopen/pull/669/commits/0f2115f245612e144f8a7c1dc9c26468f0dcb59f
https://github.com/bizfsc
bizfschttps://github.com/bizfsc
Jun 24, 2026 https://github.com/canopen-python/canopen/pull/669#pullrequestreview-4560665666
View reviewed changes https://github.com/canopen-python/canopen/pull/669/files/0f2115f245612e144f8a7c1dc9c26468f0dcb59f
bizfschttps://github.com/bizfsc
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/canopen-python/canopen/pull/669#pullrequestreview-4560665666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 25, 2026https://github.com/canopen-python/canopen/pull/669#issuecomment-4804071811
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 26, 2026https://github.com/canopen-python/canopen/pull/669#issuecomment-4813250112
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
acolombhttps://github.com/acolomb
June 26, 2026 22:45https://github.com/canopen-python/canopen/pull/669#commits-pushed-47394c5
https://github.com/acolomb
Move dest=None handling to generic function export_od().https://github.com/canopen-python/canopen/pull/669/commits/47394c58a6157f5cfddd2d53c89afec54eef4b95
47394c5https://github.com/canopen-python/canopen/pull/669/commits/47394c58a6157f5cfddd2d53c89afec54eef4b95
https://github.com/acolomb
Fix auto-closing tests to test result, not implementation.https://github.com/canopen-python/canopen/pull/669/commits/fb2b4f31f98c4eb4ed761f11301089fcac3af9e8
fb2b4f3https://github.com/canopen-python/canopen/pull/669/commits/fb2b4f31f98c4eb4ed761f11301089fcac3af9e8
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 28, 2026https://github.com/canopen-python/canopen/pull/669#issuecomment-4827424017
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
acolombhttps://github.com/acolomb
June 28, 2026 23:19https://github.com/canopen-python/canopen/pull/669#commits-pushed-3169821
https://github.com/acolomb
Merge branch 'master' into fix-od-typing-filelikehttps://github.com/canopen-python/canopen/pull/669/commits/316982110a390ced2deca1e4f7c4e6cd43fb02ca
3169821https://github.com/canopen-python/canopen/pull/669/commits/316982110a390ced2deca1e4f7c4e6cd43fb02ca
https://github.com/acolomb
Add positive test for pathlib argument, remove object() arg test.https://github.com/canopen-python/canopen/pull/669/commits/87a7f4a10dc32d1b46b009f2f6e86ad6699dda16
87a7f4ahttps://github.com/canopen-python/canopen/pull/669/commits/87a7f4a10dc32d1b46b009f2f6e86ad6699dda16
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 28, 2026https://github.com/canopen-python/canopen/pull/669#issuecomment-4827439054
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/acolomb
top-level imports for all testshttps://github.com/canopen-python/canopen/pull/669/commits/c6d259e6c1932892b7a17349a6bbe7caeb0f0156
c6d259ehttps://github.com/canopen-python/canopen/pull/669/commits/c6d259e6c1932892b7a17349a6bbe7caeb0f0156
https://github.com/acolomb
acolombhttps://github.com/acolomb
typing https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Atyping
Jun 29, 2026https://github.com/canopen-python/canopen/pull/669#event-27347918275
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F669
https://github.com/bizfsc
bizfsc https://github.com/bizfsc
https://github.com/canopen-python/canopen/pull/669/files/0f2115f245612e144f8a7c1dc9c26468f0dcb59f
typing https://github.com/canopen-python/canopen/issues?q=state%3Aopen%20label%3Atyping
Please reload this pagehttps://github.com/canopen-python/canopen/pull/669
https://github.com/acolomb
https://github.com/bizfsc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.