René's URL Explorer Experiment


Title: eds: Fix signed integer limit parsing for all bit widths, log errors by friederschueler · Pull Request #658 · canopen-python/canopen · GitHub

Open Graph Title: eds: Fix signed integer limit parsing for all bit widths, log errors by friederschueler · Pull Request #658 · canopen-python/canopen

X Title: eds: Fix signed integer limit parsing for all bit widths, log errors by friederschueler · Pull Request #658 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Fixes incomplete and incorrect signed integer handling for LowLimit/HighLimit in EDS parsing and export, as noted in #352. Changes _calc_bit_length — extended to all SIGNED_TYPES The existing funct...

X Description: Fixes incomplete and incorrect signed integer handling for LowLimit/HighLimit in EDS parsing and export, as noted in #352. Changes _calc_bit_length — extended to all SIGNED_TYPES The existing funct...

Opengraph URL: https://github.com/canopen-python/canopen/pull/658

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3e3ca639-4307-ec07-4395-6a4f935fd94e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2A4:210405:68A8E64:8A033F1:6A5DDB05
html-safe-nonce7b1b90bdee509c605acb4be91ae6a604c6fbad03b45464d7c3e9ed2e2969897e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkE0OjIxMDQwNTo2OEE4RTY0OjhBMDMzRjE6NkE1RERCMDUiLCJ2aXNpdG9yX2lkIjoiNTA3NDk4OTgyODk2ODE0MzYyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb64cfb6f89616215482bbd94eb5564f1588cffe28933ce3d23ea7a5f459514af
hovercard-subject-tagpull_request:3636854685
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/canopen-python/canopen/pull/658/commits
twitter:imagehttps://opengraph.githubassets.com/473f343dc5d6d374161530e9a97bc01b4ca825ac9106b8393b94b71b3d890a5f/canopen-python/canopen/pull/658
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/473f343dc5d6d374161530e9a97bc01b4ca825ac9106b8393b94b71b3d890a5f/canopen-python/canopen/pull/658
og:image:altFixes incomplete and incorrect signed integer handling for LowLimit/HighLimit in EDS parsing and export, as noted in #352. Changes _calc_bit_length — extended to all SIGNED_TYPES The existing funct...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefriederschueler
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/658/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F658%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F658%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/658/commits
Reloadhttps://github.com/canopen-python/canopen/pull/658/commits
Reloadhttps://github.com/canopen-python/canopen/pull/658/commits
Please reload this pagehttps://github.com/canopen-python/canopen/pull/658/commits
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
friederschueler:fix/eds-limit-parsinghttps://github.com/friederschueler/canopen/tree/fix/eds-limit-parsing
Conversationhttps://github.com/canopen-python/canopen/pull/658
Commits14 (14)https://github.com/canopen-python/canopen/pull/658/commits
Checkshttps://github.com/canopen-python/canopen/pull/658/checks
Files changedhttps://github.com/canopen-python/canopen/pull/658/files
eds: Fix signed integer limit parsing for all bit widths, log errorshttps://github.com/canopen-python/canopen/pull/658/commits#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
friederschueler:fix/eds-limit-parsinghttps://github.com/friederschueler/canopen/tree/fix/eds-limit-parsing
eds: fix LowLimit/HighLimit parsing for all signed integer typeshttps://github.com/canopen-python/canopen/pull/658/commits/bf972c1a9e14ac442aae19764e9b50528ad935ee
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
bf972c1https://github.com/canopen-python/canopen/pull/658/commits/bf972c1a9e14ac442aae19764e9b50528ad935ee
https://github.com/canopen-python/canopen/tree/bf972c1a9e14ac442aae19764e9b50528ad935ee
eds: revert LowLimit/HighLimit parse error to silent pass, remove warning testhttps://github.com/canopen-python/canopen/pull/658/commits/f65a1fb148b398b7d7ab181746eef9fccdac7245
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
f65a1fbhttps://github.com/canopen-python/canopen/pull/658/commits/f65a1fb148b398b7d7ab181746eef9fccdac7245
https://github.com/canopen-python/canopen/tree/f65a1fb148b398b7d7ab181746eef9fccdac7245
add back and add more exception handling via warning instead of silent passhttps://github.com/canopen-python/canopen/pull/658/commits/4ed45ddbfbaed93a691d75a91b4ceb5df835c5ce
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
4ed45ddhttps://github.com/canopen-python/canopen/pull/658/commits/4ed45ddbfbaed93a691d75a91b4ceb5df835c5ce
https://github.com/canopen-python/canopen/tree/4ed45ddbfbaed93a691d75a91b4ceb5df835c5ce
eds: use eds.get() in warning for DefaultValue/ParameterValue (mypy fix)https://github.com/canopen-python/canopen/pull/658/commits/4319d4af947a9b7f64153885c787645bd5be55f9
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
4319d4ahttps://github.com/canopen-python/canopen/pull/658/commits/4319d4af947a9b7f64153885c787645bd5be55f9
https://github.com/canopen-python/canopen/tree/4319d4af947a9b7f64153885c787645bd5be55f9
eds: support decimal and hex literals for signed LowLimit/HighLimithttps://github.com/canopen-python/canopen/pull/658/commits/2382b96a02646ce2b285c52abe015c8d52830f35
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
2382b96https://github.com/canopen-python/canopen/pull/658/commits/2382b96a02646ce2b285c52abe015c8d52830f35
https://github.com/canopen-python/canopen/tree/2382b96a02646ce2b285c52abe015c8d52830f35
Consistent logic with early return / raise.https://github.com/canopen-python/canopen/pull/658/commits/28c7d26b42197521e742d1aafe31bd609279726c
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
28c7d26https://github.com/canopen-python/canopen/pull/658/commits/28c7d26b42197521e742d1aafe31bd609279726c
https://github.com/canopen-python/canopen/tree/28c7d26b42197521e742d1aafe31bd609279726c
eds: address review open pointshttps://github.com/canopen-python/canopen/pull/658/commits/3d1d2d4df4b13dff4eeaa320e90f1b63e3bf8ad6
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
3d1d2d4https://github.com/canopen-python/canopen/pull/658/commits/3d1d2d4df4b13dff4eeaa320e90f1b63e3bf8ad6
https://github.com/canopen-python/canopen/tree/3d1d2d4df4b13dff4eeaa320e90f1b63e3bf8ad6
Merge branch 'master' into fix/eds-limit-parsinghttps://github.com/canopen-python/canopen/pull/658/commits/aa5257a0a52dfd837137ef626a6ed5bc5412b08d
https://github.com/friederschueler
friederschuelerhttps://github.com/canopen-python/canopen/commits?author=friederschueler
aa5257ahttps://github.com/canopen-python/canopen/pull/658/commits/aa5257a0a52dfd837137ef626a6ed5bc5412b08d
https://github.com/canopen-python/canopen/tree/aa5257a0a52dfd837137ef626a6ed5bc5412b08d
test to cover added warning logshttps://github.com/canopen-python/canopen/pull/658/commits/cb00c3ba42af1be34f40842a03fa4f98c7de70cb
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
cb00c3bhttps://github.com/canopen-python/canopen/pull/658/commits/cb00c3ba42af1be34f40842a03fa4f98c7de70cb
https://github.com/canopen-python/canopen/tree/cb00c3ba42af1be34f40842a03fa4f98c7de70cb
missing importhttps://github.com/canopen-python/canopen/pull/658/commits/417ace5e5ef8281330b157aa100b97ae983169e0
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
417ace5https://github.com/canopen-python/canopen/pull/658/commits/417ace5e5ef8281330b157aa100b97ae983169e0
https://github.com/canopen-python/canopen/tree/417ace5e5ef8281330b157aa100b97ae983169e0
Test to cover _revert_variable() branches (without default_raw).https://github.com/canopen-python/canopen/pull/658/commits/2b900a9d9b910ae590d523c7466f57043dbc0ce2
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
2b900a9https://github.com/canopen-python/canopen/pull/658/commits/2b900a9d9b910ae590d523c7466f57043dbc0ce2
https://github.com/canopen-python/canopen/tree/2b900a9d9b910ae590d523c7466f57043dbc0ce2
cosmetics, make black happierhttps://github.com/canopen-python/canopen/pull/658/commits/e6d10745cd10cc44532abf3f6e447f13757ce2e6
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
e6d1074https://github.com/canopen-python/canopen/pull/658/commits/e6d10745cd10cc44532abf3f6e447f13757ce2e6
https://github.com/canopen-python/canopen/tree/e6d10745cd10cc44532abf3f6e447f13757ce2e6
renamed _convert_variable → _decode_from_eds and _revert_variable → _encode_to_edshttps://github.com/canopen-python/canopen/pull/658/commits/f757937867433c410eba3e6a29f7a9dfb7d9e7d1
https://github.com/bizfsc
bizfschttps://github.com/canopen-python/canopen/commits?author=bizfsc
f757937https://github.com/canopen-python/canopen/pull/658/commits/f757937867433c410eba3e6a29f7a9dfb7d9e7d1
https://github.com/canopen-python/canopen/tree/f757937867433c410eba3e6a29f7a9dfb7d9e7d1
Remove leftover type check in _encode_to_eds().https://github.com/canopen-python/canopen/pull/658/commits/c653378fd2e7481db7c4c83cdc3815f73337c628
https://github.com/acolomb
acolombhttps://github.com/canopen-python/canopen/commits?author=acolomb
c653378https://github.com/canopen-python/canopen/pull/658/commits/c653378fd2e7481db7c4c83cdc3815f73337c628
https://github.com/canopen-python/canopen/tree/c653378fd2e7481db7c4c83cdc3815f73337c628
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.