René's URL Explorer Experiment


Title: Gracefully handle readonly entries in PdoMap.save() (fixes #541) by acolomb · Pull Request #593 · canopen-python/canopen · GitHub

Open Graph Title: Gracefully handle readonly entries in PdoMap.save() (fixes #541) by acolomb · Pull Request #593 · canopen-python/canopen

X Title: Gracefully handle readonly entries in PdoMap.save() (fixes #541) by acolomb · Pull Request #593 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: For PDO communication or mapping parameters which are read-only on a node, the PdoMap.save() method currently aborts with an SDO exception. However, individual parameters may simply not support con...

X Description: For PDO communication or mapping parameters which are read-only on a node, the PdoMap.save() method currently aborts with an SDO exception. However, individual parameters may simply not support con...

Opengraph URL: https://github.com/canopen-python/canopen/pull/593

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0b4a61ec-e121-a4ea-975e-d4f64d1436e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD74:3FD786:246C710:309E494:6A5D839A
html-safe-nonce9d37ebf7d4097dd9737e5dd5927a4e19651650bf03230112bc8b18a157cf6a38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDc0OjNGRDc4NjoyNDZDNzEwOjMwOUU0OTQ6NkE1RDgzOUEiLCJ2aXNpdG9yX2lkIjoiODIwMTUyNDAwMjM3NDM4NjU4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd042a8ab3e9816984ff9cf240b80359fdf660f04e9c0828972549903692c8b1d
hovercard-subject-tagpull_request:2599547951
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/593/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8851f741e84d7d184ec1cf5b5dc02c4079673d1d1eeadc040eb2cc50b631c65e/canopen-python/canopen/pull/593
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8851f741e84d7d184ec1cf5b5dc02c4079673d1d1eeadc040eb2cc50b631c65e/canopen-python/canopen/pull/593
og:image:altFor PDO communication or mapping parameters which are read-only on a node, the PdoMap.save() method currently aborts with an SDO exception. However, individual parameters may simply not support con...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/593#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F593
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F593
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/593
Reloadhttps://github.com/canopen-python/canopen/pull/593
Reloadhttps://github.com/canopen-python/canopen/pull/593
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:gracefully-handle-pdo-save-readonlyhttps://github.com/acolomb/canopen/tree/gracefully-handle-pdo-save-readonly
Conversationhttps://github.com/canopen-python/canopen/pull/593
Commits10 (10)https://github.com/canopen-python/canopen/pull/593/commits
Checkshttps://github.com/canopen-python/canopen/pull/593/checks
Files changedhttps://github.com/canopen-python/canopen/pull/593/files
Gracefully handle readonly entries in PdoMap.save() (fixes #541)https://github.com/canopen-python/canopen/pull/593#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:gracefully-handle-pdo-save-readonlyhttps://github.com/acolomb/canopen/tree/gracefully-handle-pdo-save-readonly
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 17, 2025https://github.com/canopen-python/canopen/pull/593#issue-3154318377
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
erlend-aaslandhttps://github.com/erlend-aasland
June 17, 2025 19:56https://github.com/canopen-python/canopen/pull/593#commits-pushed-7f8ab9f
https://github.com/erlend-aasland
https://github.com/acolomb
Skip saving and log read-only PDO parameters.https://github.com/canopen-python/canopen/pull/593/commits/7f8ab9f94f8bca755d555b33aad5526a0c13f142
7f8ab9fhttps://github.com/canopen-python/canopen/pull/593/commits/7f8ab9f94f8bca755d555b33aad5526a0c13f142
https://github.com/acolomb
Cosmetics [black].https://github.com/canopen-python/canopen/pull/593/commits/160c81b8e6435c353e1ea4fa5e68b6cc190b9c1b
160c81bhttps://github.com/canopen-python/canopen/pull/593/commits/160c81b8e6435c353e1ea4fa5e68b6cc190b9c1b
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 17, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2981313416
#542https://github.com/canopen-python/canopen/pull/542
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 17, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2981314193
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
Codecovhttps://app.codecov.io/gh/canopen-python/canopen/pull/593?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Files with missing lineshttps://app.codecov.io/gh/canopen-python/canopen/pull/593?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
canopen/pdo/base.pyhttps://app.codecov.io/gh/canopen-python/canopen/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python#diff-Y2Fub3Blbi9wZG8vYmFzZS5weQ==
1 Missing ⚠️ https://app.codecov.io/gh/canopen-python/canopen/pull/593?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 17, 2025 https://github.com/canopen-python/canopen/pull/593#ref-pullrequest-2500862182
TPDO mappings may be read-only #542 https://github.com/canopen-python/canopen/pull/542
acolombhttps://github.com/acolomb
June 17, 2025 20:00https://github.com/canopen-python/canopen/pull/593#commits-pushed-848b03f
https://github.com/acolomb
Remove leftover type import.https://github.com/canopen-python/canopen/pull/593/commits/848b03f2b69fd07b2c912d51a81b33a5ea3c47de
848b03fhttps://github.com/canopen-python/canopen/pull/593/commits/848b03f2b69fd07b2c912d51a81b33a5ea3c47de
https://github.com/acolomb
Fix iteration, correct writable attribute.https://github.com/canopen-python/canopen/pull/593/commits/44d302eea29fa375c01c3d4f769be411cde1a93b
44d302ehttps://github.com/canopen-python/canopen/pull/593/commits/44d302eea29fa375c01c3d4f769be411cde1a93b
https://github.com/acolomb
Switch to a LocalNode in TestPDO to not require a network.https://github.com/canopen-python/canopen/pull/593/commits/880c4de667f8d5c7aa63a66e5bff87e6fc9117e4
880c4dehttps://github.com/canopen-python/canopen/pull/593/commits/880c4de667f8d5c7aa63a66e5bff87e6fc9117e4
https://github.com/acolomb
Test PdoMap.save() skipping readonly entries.https://github.com/canopen-python/canopen/pull/593/commits/022ebe05d9fcf12873742a5ff8f4b3ad72c8982f
022ebe0https://github.com/canopen-python/canopen/pull/593/commits/022ebe05d9fcf12873742a5ff8f4b3ad72c8982f
https://github.com/acolomb
Merge branch 'master' into gracefully-handle-pdo-save-readonlyhttps://github.com/canopen-python/canopen/pull/593/commits/406392eb380f6f918552089f26b0ae0addfec100
406392ehttps://github.com/canopen-python/canopen/pull/593/commits/406392eb380f6f918552089f26b0ae0addfec100
https://github.com/acolomb
Specify parameters to have the test not skip them.https://github.com/canopen-python/canopen/pull/593/commits/12096e493718337232f93c4b5dbc1b3a22666b5e
12096e4https://github.com/canopen-python/canopen/pull/593/commits/12096e493718337232f93c4b5dbc1b3a22666b5e
https://github.com/acolomb
Fix and duplicate test, one writable and the other not.https://github.com/canopen-python/canopen/pull/593/commits/e74899cb6bc086858ead10744353794412e43fef
e74899chttps://github.com/canopen-python/canopen/pull/593/commits/e74899cb6bc086858ead10744353794412e43fef
https://github.com/acolomb
Test read-only mapping array entry as well.https://github.com/canopen-python/canopen/pull/593/commits/c9cbc566eb1d4f225c3d174de54c87e492ed018b
c9cbc56https://github.com/canopen-python/canopen/pull/593/commits/c9cbc566eb1d4f225c3d174de54c87e492ed018b
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 17, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2981548241
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
v2.4.0https://github.com/canopen-python/canopen/milestone/9
Jun 18, 2025https://github.com/canopen-python/canopen/pull/593#event-18214071483
https://github.com/sveinse
sveinsehttps://github.com/sveinse
Jun 22, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2994326288
sansiohttps://sans-io.readthedocs.io/
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 22, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2994416388
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/sveinse
sveinsehttps://github.com/sveinse
Jun 22, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2994417354
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/sveinse
sveinsehttps://github.com/sveinse
Jun 22, 2025 https://github.com/canopen-python/canopen/pull/593#pullrequestreview-2948320082
View reviewed changes https://github.com/canopen-python/canopen/pull/593/files/c9cbc566eb1d4f225c3d174de54c87e492ed018b
sveinsehttps://github.com/sveinse
https://github.com/canopen-python/canopen/pull/593#pullrequestreview-2948320082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 22, 2025https://github.com/canopen-python/canopen/pull/593#issuecomment-2994426576
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
09f6e9ehttps://github.com/canopen-python/canopen/commit/09f6e9e8e9497108790328aed9839f2552acdbae
Jun 22, 2025https://github.com/canopen-python/canopen/pull/593#event-18262584449
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
acolombhttps://github.com/acolomb
June 22, 2025 20:17https://github.com/canopen-python/canopen/pull/593#event-18262585885
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F593
https://github.com/sveinse
sveinse https://github.com/sveinse
https://github.com/canopen-python/canopen/pull/593/files/c9cbc566eb1d4f225c3d174de54c87e492ed018b
v2.4.0 https://github.com/canopen-python/canopen/milestone/9
Please reload this pagehttps://github.com/canopen-python/canopen/pull/593
https://github.com/acolomb
https://github.com/sveinse
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.