René's URL Explorer Experiment


Title: Avoid truncating unknown types in SDO upload (fixes #436) by acolomb · Pull Request #591 · canopen-python/canopen · GitHub

Open Graph Title: Avoid truncating unknown types in SDO upload (fixes #436) by acolomb · Pull Request #591 · canopen-python/canopen

X Title: Avoid truncating unknown types in SDO upload (fixes #436) by acolomb · Pull Request #591 · canopen-python/canopen

Description: When an OD entry is found in SdoClient.upload(), the truncation is currently skipped only for those types explicitly listed as variable length data (domain, strings). That causes unknown types to be truncated to whatever their length indicates, which is usually one byte. Invert the condition to check all types with an explicitly known size, a.k.a. those listed in STRUCT_TYPES where the required length can be deduced from the structure format. Factor out the condition to a new fixed_size property, which is easier to override when adding custom data types. Re-enable the unit tests which were skipped based on the previously buggy behavior.

Open Graph Description: When an OD entry is found in SdoClient.upload(), the truncation is currently skipped only for those types explicitly listed as variable length data (domain, strings). That causes unknown types to ...

X Description: When an OD entry is found in SdoClient.upload(), the truncation is currently skipped only for those types explicitly listed as variable length data (domain, strings). That causes unknown types to ...

Opengraph URL: https://github.com/canopen-python/canopen/pull/591

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:738f175c-52d6-93c3-f9ef-c34c59276172
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B88:32DBD9:4C713:656B1:6A5ECC7D
html-safe-nonce4518188c7b066d7a66ea46ecdcd43fdbc7defc1e443ecfc319e153f6cd377382
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qjg4OjMyREJEOTo0QzcxMzo2NTZCMTo2QTVFQ0M3RCIsInZpc2l0b3JfaWQiOiIzNDI3NTkwNTczNTIzOTEzODUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac69d225f103e4234759dcf5f580535252c9a190997b6db6ce6a4fc204a0891bfd
hovercard-subject-tagpull_request:2593794624
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/canopen-python/canopen/pull/591/files
twitter:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
og:image:altWhen an OD entry is found in SdoClient.upload(), the truncation is currently skipped only for those types explicitly listed as variable length data (domain, strings). That causes unknown types to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9bd00899c80f8b6ea4e7a96c99290af4722b0befdf9e021b19232cbd6f993660
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9996307881fdf9017d864a20b3dfe5aae4dddd3e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/591/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F591%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F591%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/591/files
Reloadhttps://github.com/canopen-python/canopen/pull/591/files
Reloadhttps://github.com/canopen-python/canopen/pull/591/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/591/files
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 561 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:sdo-truncate-only-known-lengthhttps://github.com/acolomb/canopen/tree/sdo-truncate-only-known-length
Conversation 4 https://github.com/canopen-python/canopen/pull/591
Commits 1 https://github.com/canopen-python/canopen/pull/591/commits
Checks 5 https://github.com/canopen-python/canopen/pull/591/checks
Files changed https://github.com/canopen-python/canopen/pull/591/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/591/files
Avoid truncating unknown types in SDO upload (fixes #436) https://github.com/canopen-python/canopen/pull/591/files#top
Show all changes 1 commit https://github.com/canopen-python/canopen/pull/591/files
66d0bb2 Avoid truncating unknown types in SDO upload. acolomb Jun 15, 2025 https://github.com/canopen-python/canopen/pull/591/commits/66d0bb286150498cc503f7466b2618b46c458f57
Clear filters https://github.com/canopen-python/canopen/pull/591/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/591/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/591/files
__init__.py https://github.com/canopen-python/canopen/pull/591/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
client.py https://github.com/canopen-python/canopen/pull/591/files#diff-cb4f45260d53f5f205337bab89507514dfb2a3966190b0caa7b0c05b8e8e1a6d
test_sdo.py https://github.com/canopen-python/canopen/pull/591/files#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
canopen/objectdictionary/__init__.pyhttps://github.com/canopen-python/canopen/pull/591/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
View file https://github.com/acolomb/canopen/blob/66d0bb286150498cc503f7466b2618b46c458f57/canopen/objectdictionary/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/591/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/591/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
https://github.com/canopen-python/canopen/pull/591/files#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
canopen/sdo/client.pyhttps://github.com/canopen-python/canopen/pull/591/files#diff-cb4f45260d53f5f205337bab89507514dfb2a3966190b0caa7b0c05b8e8e1a6d
View file https://github.com/acolomb/canopen/blob/66d0bb286150498cc503f7466b2618b46c458f57/canopen/sdo/client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/591/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/591/files#diff-cb4f45260d53f5f205337bab89507514dfb2a3966190b0caa7b0c05b8e8e1a6d
https://github.com/canopen-python/canopen/pull/591/files#diff-cb4f45260d53f5f205337bab89507514dfb2a3966190b0caa7b0c05b8e8e1a6d
test/test_sdo.pyhttps://github.com/canopen-python/canopen/pull/591/files#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
View file https://github.com/acolomb/canopen/blob/66d0bb286150498cc503f7466b2618b46c458f57/test/test_sdo.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/591/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/591/files#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
https://github.com/canopen-python/canopen/pull/591/files#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
https://github.com/canopen-python/canopen/pull/591/files#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
Please reload this pagehttps://github.com/canopen-python/canopen/pull/591/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.