René's URL Explorer Experiment


Title: Fix check for retransmission of discarded block segments by samsamfire · Pull Request #546 · canopen-python/canopen · GitHub

Open Graph Title: Fix check for retransmission of discarded block segments by samsamfire · Pull Request #546 · canopen-python/canopen

X Title: Fix check for retransmission of discarded block segments by samsamfire · Pull Request #546 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Hi, I noticed this issue whilst working on another canopen package. The block upload retransmit does not work correctly. On the event that a client does not properly receive a sub-block, it sends a...

X Description: Hi, I noticed this issue whilst working on another canopen package. The block upload retransmit does not work correctly. On the event that a client does not properly receive a sub-block, it sends a...

Opengraph URL: https://github.com/canopen-python/canopen/pull/546

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:db58339a-5bce-c139-64df-11137ebd4b7a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB3A:1712DC:A67F798:DFF179D:6A5E9877
html-safe-noncebf49b102c2bec1e5c08bc0ba03a46e342d757bfd9782163c4247cc1174967bd5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjNBOjE3MTJEQzpBNjdGNzk4OkRGRjE3OUQ6NkE1RTk4NzciLCJ2aXNpdG9yX2lkIjoiOTgyMzQxNTA3MjI2NzAzOTkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5ce596717b40b542f27c296d78ea35945eee97a3cd5b210917961341aa52960f
hovercard-subject-tagpull_request:2166108613
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/546/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/911de1ceab34f3c882a711dfd70d18bab8aca34a819e1c0a0bb5c05914f679b3/canopen-python/canopen/pull/546
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/911de1ceab34f3c882a711dfd70d18bab8aca34a819e1c0a0bb5c05914f679b3/canopen-python/canopen/pull/546
og:image:altHi, I noticed this issue whilst working on another canopen package. The block upload retransmit does not work correctly. On the event that a client does not properly receive a sub-block, it sends a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesamsamfire
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/546#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F546
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F546
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/546
Reloadhttps://github.com/canopen-python/canopen/pull/546
Reloadhttps://github.com/canopen-python/canopen/pull/546
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 561 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
samsamfire:sdo-block-upload-retransmit-fixhttps://github.com/samsamfire/canopen/tree/sdo-block-upload-retransmit-fix
Conversationhttps://github.com/canopen-python/canopen/pull/546
Commits12 (12)https://github.com/canopen-python/canopen/pull/546/commits
Checkshttps://github.com/canopen-python/canopen/pull/546/checks
Files changedhttps://github.com/canopen-python/canopen/pull/546/files
Fix check for retransmission of discarded block segmentshttps://github.com/canopen-python/canopen/pull/546#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
samsamfire:sdo-block-upload-retransmit-fixhttps://github.com/samsamfire/canopen/tree/sdo-block-upload-retransmit-fix
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Nov 6, 2024https://github.com/canopen-python/canopen/pull/546#issue-2639259049
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
Fixed : retransmission of discarded segments starts at beginning of n…https://github.com/canopen-python/canopen/pull/546/commits/1a74fb64ea04a6662667ad6653aede296f22ce99
1a74fb6https://github.com/canopen-python/canopen/pull/546/commits/1a74fb64ea04a6662667ad6653aede296f22ce99
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Nov 6, 2024https://github.com/canopen-python/canopen/pull/546#issuecomment-2460813487
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1ODQ2MTIsIm5iZiI6MTc4NDU4NDMxMiwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQyMTUxNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMTAzZjQxMDhiZDk3OTIwMzE0OTlhZjk0NTE3YjYyODNhMTUyZDZjZGRmYWE0ZTdlMDBhOTFiZGZhNTY2NjVjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.tEuN7wliOjNfRYLCD0VxKNubq6ewcglGhXsU8vg9et4
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(ffbd10f)https://app.codecov.io/gh/christiansandberg/canopen/commit/ffbd10f44da89e407622c82b8587fcc64e3f2f49?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(ab4d150)https://app.codecov.io/gh/christiansandberg/canopen/commit/ab4d1501ea95fa6e400acc201037dd07632006b6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Files with missing lineshttps://app.codecov.io/gh/christiansandberg/canopen/pull/546?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/sdo/client.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/546?src=pr&el=tree&filepath=canopen%2Fsdo%2Fclient.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9zZG8vY2xpZW50LnB5
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Nov 26, 2024https://github.com/canopen-python/canopen/pull/546#issuecomment-2500068560
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
acolombhttps://github.com/acolomb
Nov 26, 2024https://github.com/canopen-python/canopen/pull/546#issuecomment-2500256165
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jan 13, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2587305108
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Jan 13, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2588273815
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
force-pushedhttps://github.com/canopen-python/canopen/compare/47259725ecc0b1616e9fbab2385143141514fa7e..534114250cc660df4db58cf8f8d1497003062627
4725972https://github.com/canopen-python/canopen/commit/47259725ecc0b1616e9fbab2385143141514fa7e
5341142https://github.com/canopen-python/canopen/commit/534114250cc660df4db58cf8f8d1497003062627
Compare https://github.com/canopen-python/canopen/compare/47259725ecc0b1616e9fbab2385143141514fa7e..534114250cc660df4db58cf8f8d1497003062627
January 15, 2025 10:41https://github.com/canopen-python/canopen/pull/546#event-15938301231
https://github.com/samsamfire
Test : add a block retransmit test. This test passes with this implem…https://github.com/canopen-python/canopen/pull/546/commits/33aa620cda234f72c710079979a78db06172f3dc
33aa620https://github.com/canopen-python/canopen/pull/546/commits/33aa620cda234f72c710079979a78db06172f3dc
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
force-pushedhttps://github.com/canopen-python/canopen/compare/534114250cc660df4db58cf8f8d1497003062627..33aa620cda234f72c710079979a78db06172f3dc
5341142https://github.com/canopen-python/canopen/commit/534114250cc660df4db58cf8f8d1497003062627
33aa620https://github.com/canopen-python/canopen/commit/33aa620cda234f72c710079979a78db06172f3dc
Compare https://github.com/canopen-python/canopen/compare/534114250cc660df4db58cf8f8d1497003062627..33aa620cda234f72c710079979a78db06172f3dc
January 15, 2025 10:52https://github.com/canopen-python/canopen/pull/546#event-15938432001
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Jan 15, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2592323793
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
samsamfirehttps://github.com/samsamfire
January 15, 2025 11:57https://github.com/canopen-python/canopen/pull/546#commits-pushed-7fe2c71
https://github.com/samsamfire
Comment : fixed wrong value in commenthttps://github.com/canopen-python/canopen/pull/546/commits/7fe2c7181a1767c53d86b96c256e1b00591646e6
7fe2c71https://github.com/canopen-python/canopen/pull/546/commits/7fe2c7181a1767c53d86b96c256e1b00591646e6
https://github.com/samsamfire
Comment : better comments on the different steps of the blockhttps://github.com/canopen-python/canopen/pull/546/commits/ab4d1501ea95fa6e400acc201037dd07632006b6
ab4d150https://github.com/canopen-python/canopen/pull/546/commits/ab4d1501ea95fa6e400acc201037dd07632006b6
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Feb 25, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2681397045
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/friederschueler
friederschuelerhttps://github.com/friederschueler
Feb 25, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2682124343
@acolombhttps://github.com/acolomb
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
acolombhttps://github.com/acolomb
Feb 25, 2025 https://github.com/canopen-python/canopen/pull/546#pullrequestreview-2642452191
View reviewed changes https://github.com/canopen-python/canopen/pull/546/files/ab4d1501ea95fa6e400acc201037dd07632006b6
acolombhttps://github.com/acolomb
https://github.com/canopen-python/canopen/pull/546#pullrequestreview-2642452191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
test/test_sdo.pyhttps://github.com/canopen-python/canopen/pull/546/files/ab4d1501ea95fa6e400acc201037dd07632006b6#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
canopen/sdo/client.pyhttps://github.com/canopen-python/canopen/pull/546/files/ab4d1501ea95fa6e400acc201037dd07632006b6#diff-cb4f45260d53f5f205337bab89507514dfb2a3966190b0caa7b0c05b8e8e1a6d
acolombhttps://github.com/acolomb
Feb 25, 2025https://github.com/canopen-python/canopen/pull/546#discussion_r1970578861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
acolombhttps://github.com/acolomb
Jun 9, 2025https://github.com/canopen-python/canopen/pull/546#discussion_r2136282865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@samsamfirehttps://github.com/samsamfire
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Feb 26, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2684847782
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
acolombhttps://github.com/acolomb
Apr 27, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2833648076
@samsamfirehttps://github.com/samsamfire
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
acolombhttps://github.com/acolomb
June 9, 2025 20:50https://github.com/canopen-python/canopen/pull/546#commits-pushed-2692989
https://github.com/acolomb
Fix docstring.https://github.com/canopen-python/canopen/pull/546/commits/2692989549da0d1ca347ad922e0a829a9cbc1c90
2692989https://github.com/canopen-python/canopen/pull/546/commits/2692989549da0d1ca347ad922e0a829a9cbc1c90
https://github.com/acolomb
Fix quoting style to match surrounding code.https://github.com/canopen-python/canopen/pull/546/commits/43e93773b26e0f92a1e03979746a5ed87d253a33
43e9377https://github.com/canopen-python/canopen/pull/546/commits/43e93773b26e0f92a1e03979746a5ed87d253a33
https://github.com/acolomb
Use test framework assertion instead of plain assert.https://github.com/canopen-python/canopen/pull/546/commits/ff12cb4d35bbd1deab4495be1e19d4c34232b771
ff12cb4https://github.com/canopen-python/canopen/pull/546/commits/ff12cb4d35bbd1deab4495be1e19d4c34232b771
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 9, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2956669359
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
@samsamfirehttps://github.com/samsamfire
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
Merge branch 'canopen-python:master' into sdo-block-upload-retransmit…https://github.com/canopen-python/canopen/pull/546/commits/7822ca498b43dae7c2354e96b0169ea2d5d89f72
7822ca4https://github.com/canopen-python/canopen/pull/546/commits/7822ca498b43dae7c2354e96b0169ea2d5d89f72
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 10, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2960581689
Codecovhttps://app.codecov.io/gh/canopen-python/canopen/pull/546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=canopen-python
Let us know!https://github.com/codecov/feedback/issues/255
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
samsamfirehttps://github.com/samsamfire
June 10, 2025 23:19https://github.com/canopen-python/canopen/pull/546#commits-pushed-df4af56
https://github.com/samsamfire
Fixed : moved comments up (wrong line)https://github.com/canopen-python/canopen/pull/546/commits/df4af569e345b67b14c66b5a04a67157583d358b
df4af56https://github.com/canopen-python/canopen/pull/546/commits/df4af569e345b67b14c66b5a04a67157583d358b
https://github.com/samsamfire
Changed : replace double x34 with x34/x33 to make it clearer that the…https://github.com/canopen-python/canopen/pull/546/commits/37c6e4b945161e502f0c6a751029f2eb437983e5
37c6e4bhttps://github.com/canopen-python/canopen/pull/546/commits/37c6e4b945161e502f0c6a751029f2eb437983e5
https://github.com/samsamfire
Changed : reset _ackseq every blockhttps://github.com/canopen-python/canopen/pull/546/commits/a0a40b82217080cbfaddde7df6edf8149596b04d
a0a40b8https://github.com/canopen-python/canopen/pull/546/commits/a0a40b82217080cbfaddde7df6edf8149596b04d
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Jun 10, 2025https://github.com/canopen-python/canopen/pull/546#issuecomment-2960658263
@acolombhttps://github.com/acolomb
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 11, 2025 https://github.com/canopen-python/canopen/pull/546#pullrequestreview-2915972249
View reviewed changes https://github.com/canopen-python/canopen/pull/546/files/a0a40b82217080cbfaddde7df6edf8149596b04d
acolombhttps://github.com/acolomb
https://github.com/canopen-python/canopen/pull/546#pullrequestreview-2915972249
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
test/test_sdo.pyhttps://github.com/canopen-python/canopen/pull/546/files/a0a40b82217080cbfaddde7df6edf8149596b04d#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/acolomb
Update test/test_sdo.pyhttps://github.com/canopen-python/canopen/pull/546/commits/93ed50b81b4342631e7e7315fa4b3cb2e1f27f6f
93ed50bhttps://github.com/canopen-python/canopen/pull/546/commits/93ed50b81b4342631e7e7315fa4b3cb2e1f27f6f
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 11, 2025https://github.com/canopen-python/canopen/pull/546#event-18088797443
https://github.com/acolomb
acolombhttps://github.com/acolomb
7ddb19bhttps://github.com/canopen-python/canopen/commit/7ddb19b2ca7b7a85b9cef3090249b00293dd4b4a
Jun 11, 2025https://github.com/canopen-python/canopen/pull/546#event-18088883696
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F546
https://github.com/acolomb
acolomb https://github.com/acolomb
https://github.com/canopen-python/canopen/pull/546/files/a0a40b82217080cbfaddde7df6edf8149596b04d
Please reload this pagehttps://github.com/canopen-python/canopen/pull/546
https://github.com/samsamfire
https://github.com/codecov-commenter
https://github.com/acolomb
https://github.com/friederschueler
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.