| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:63be15cd-d24d-6a61-a79b-99e24d416433 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E648:3B1D59:9234FBA:C6D1130:6A5EB695 |
| html-safe-nonce | 16782c513604d650186fefd22cc874896edad9ee343c4cd3c30d191c5af81289 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjQ4OjNCMUQ1OTo5MjM0RkJBOkM2RDExMzA6NkE1RUI2OTUiLCJ2aXNpdG9yX2lkIjoiNjE4NDAzMDc2MDgxMzM3NzE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 878cb346ea132d0813a186f5eadcca0d2d46aa04a2cd074a379275ee312ca4cd |
| hovercard-subject-tag | pull_request:2024111363 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/539/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7e49cacd76014d917867bf9dd38a443e30138f4e9f3d29d53d1cb3980b416b31/canopen-python/canopen/pull/539 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7e49cacd76014d917867bf9dd38a443e30138f4e9f3d29d53d1cb3980b416b31/canopen-python/canopen/pull/539 |
| og:image:alt | As requested in #538, this will show where the current SdoRecord length / iteration behavior is inconsistent. Some other tests related to SdoArray length and iteration added as well, for symmetry. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | acolomb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4990f88333a33a06a52a934a8f17d4aeb5f4fb5c1d6b3729cb8cdad98dcd3982 |
| turbo-cache-control | no-cache |
| go-import | github.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git |
| octolytics-dimension-user_id | 200581454 |
| octolytics-dimension-user_login | canopen-python |
| octolytics-dimension-repository_id | 68737600 |
| octolytics-dimension-repository_nwo | canopen-python/canopen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68737600 |
| octolytics-dimension-repository_network_root_nwo | canopen-python/canopen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 34c11453111be06b0fea288e6ddc744b8409f8df |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/canopen-python/canopen/pull/539#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F539 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F539 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen |
| Reload | https://github.com/canopen-python/canopen/pull/539 |
| Reload | https://github.com/canopen-python/canopen/pull/539 |
| Reload | https://github.com/canopen-python/canopen/pull/539 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
|
canopen-python
| https://github.com/canopen-python |
| canopen | https://github.com/canopen-python/canopen |
|
Notifications
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Fork
359
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Star
561
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
53
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
20
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
0
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:test-sdo-variables | https://github.com/acolomb/canopen/tree/test-sdo-variables |
| Conversation | https://github.com/canopen-python/canopen/pull/539 |
| Commits7 (7) | https://github.com/canopen-python/canopen/pull/539/commits |
| Checks | https://github.com/canopen-python/canopen/pull/539/checks |
| Files changed | https://github.com/canopen-python/canopen/pull/539/files |
| Tests: Verify some basic SDO record and array assumptions | https://github.com/canopen-python/canopen/pull/539#top |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:test-sdo-variables | https://github.com/acolomb/canopen/tree/test-sdo-variables |
|
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Aug 17, 2024 | https://github.com/canopen-python/canopen/pull/539#issue-2471639200 |
| #538 | https://github.com/canopen-python/canopen/pull/538 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| acolomb | https://github.com/acolomb |
| August 17, 2024 21:15 | https://github.com/canopen-python/canopen/pull/539#commits-pushed-e5d78b7 |
|
| https://github.com/acolomb |
| Remove one of the sub-objects in a record for testing. | https://github.com/canopen-python/canopen/pull/539/commits/e5d78b7503524cd2ad2a04a6c3b44cadb91fed5e |
| e5d78b7 | https://github.com/canopen-python/canopen/pull/539/commits/e5d78b7503524cd2ad2a04a6c3b44cadb91fed5e |
|
| https://github.com/acolomb |
| Flesh out the Pre-defined error field object in sample.eds. | https://github.com/canopen-python/canopen/pull/539/commits/86c3350937f07e5e6baf2dfd0784167c54f66e5d |
| 86c3350 | https://github.com/canopen-python/canopen/pull/539/commits/86c3350937f07e5e6baf2dfd0784167c54f66e5d |
|
| https://github.com/acolomb |
| Add test for SdoArray dynamically generated member variables. | https://github.com/canopen-python/canopen/pull/539/commits/daf8ca68f5712673b03a7cb6b35e138a8424a1ee |
| daf8ca6 | https://github.com/canopen-python/canopen/pull/539/commits/daf8ca68f5712673b03a7cb6b35e138a8424a1ee |
|
| https://github.com/acolomb |
| Add test for SdoArray length and iteration count. | https://github.com/canopen-python/canopen/pull/539/commits/5cbb00ef9129643be462ef5feab271e701947802 |
| 5cbb00e | https://github.com/canopen-python/canopen/pull/539/commits/5cbb00ef9129643be462ef5feab271e701947802 |
|
| https://github.com/acolomb |
| Add test for SdoRecord length and iteration count. | https://github.com/canopen-python/canopen/pull/539/commits/30c407127b12bcdfc7afce2449aa3811e8da3e0c |
| 30c4071 | https://github.com/canopen-python/canopen/pull/539/commits/30c407127b12bcdfc7afce2449aa3811e8da3e0c |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Aug 17, 2024 | https://github.com/canopen-python/canopen/pull/539#issuecomment-2294949862 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1OTIzMjEsIm5iZiI6MTc4NDU5MjAyMSwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMVQwMDAwMjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YWNiZTA2NGViY2FhNTAyOTcwNDAyMzU5YWJmYTZhZjQzN2I4NTZkZGI4NTE0NzlkNDZhYmI0ODkwN2E2OWEwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ._caY2Zu1tv0LxW9cQD6gc986bztbsFkxyainzDtaPxg |
| Codecov | https://app.codecov.io/gh/christiansandberg/canopen/pull/539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| (210374a) | https://app.codecov.io/gh/christiansandberg/canopen/commit/210374a857b8afbb9fb2bf2a93d374f4e0f70563?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| (d38377c) | https://app.codecov.io/gh/christiansandberg/canopen/commit/d38377c6dea60f15c7316ba3e0d576b7082afe74?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| Codecov GitHub app | https://github.com/apps/codecov/installations/select_target |
| https://app.codecov.io/gh/christiansandberg/canopen/pull/539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| see 1 file with indirect coverage changes | https://app.codecov.io/gh/christiansandberg/canopen/pull/539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Aug 17, 2024 | https://github.com/canopen-python/canopen/pull/539#issuecomment-2294949901 |
| 5cbb00e | https://github.com/canopen-python/canopen/commit/5cbb00ef9129643be462ef5feab271e701947802 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Aug 17, 2024 | https://github.com/canopen-python/canopen/pull/539#issuecomment-2294950345 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| 30c4071 | https://github.com/canopen-python/canopen/commit/30c407127b12bcdfc7afce2449aa3811e8da3e0c |
| #538 | https://github.com/canopen-python/canopen/pull/538 |
| 36150d7 | https://github.com/canopen-python/canopen/commit/36150d7ecf41c3acc7b720611b0660ab9f4cef4f |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
Aug 17, 2024
| https://github.com/canopen-python/canopen/pull/539#ref-pullrequest-2469624175 |
|
Skip the "highest subindex" entry when iterating over SdoRecord
#538
| https://github.com/canopen-python/canopen/pull/538 |
|
| https://github.com/acolomb |
| Fix docstring quotes. | https://github.com/canopen-python/canopen/pull/539/commits/76d16e72b77506f3e22513e2590a8d5b4707491e |
| 76d16e7 | https://github.com/canopen-python/canopen/pull/539/commits/76d16e72b77506f3e22513e2590a8d5b4707491e |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Aug 17, 2024
| https://github.com/canopen-python/canopen/pull/539#pullrequestreview-2244150613 |
|
View reviewed changes
| https://github.com/canopen-python/canopen/pull/539/files/76d16e72b77506f3e22513e2590a8d5b4707491e |
| test/test_sdo.py | https://github.com/canopen-python/canopen/pull/539/files/76d16e72b77506f3e22513e2590a8d5b4707491e#diff-f7ddc6aed14d14aab3d58fefd9ddb6c58214bd2009591e9bcc5bd2ea5d8b7740 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
|
| https://github.com/acolomb |
|
| https://github.com/erlend-aasland |
| Expect failure | https://github.com/canopen-python/canopen/pull/539/commits/d38377c6dea60f15c7316ba3e0d576b7082afe74 |
| d38377c | https://github.com/canopen-python/canopen/pull/539/commits/d38377c6dea60f15c7316ba3e0d576b7082afe74 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Aug 17, 2024
| https://github.com/canopen-python/canopen/pull/539#pullrequestreview-2244150796 |
|
View reviewed changes
| https://github.com/canopen-python/canopen/pull/539/files/d38377c6dea60f15c7316ba3e0d576b7082afe74 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| 273bab1 | https://github.com/canopen-python/canopen/commit/273bab17400f0eb14c5e9e7714fa88de3fce2e7f |
| Aug 17, 2024 | https://github.com/canopen-python/canopen/pull/539#event-13920576112 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| August 17, 2024 21:00 | https://github.com/canopen-python/canopen/pull/539#event-13920576415 |
| https://github.co/hiddenchars |
| https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F539 |
|
| https://github.com/erlend-aasland |
|
erlend-aasland
| https://github.com/erlend-aasland |
|
| https://github.com/canopen-python/canopen/pull/539/files/d38377c6dea60f15c7316ba3e0d576b7082afe74 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/539 |
|
| https://github.com/acolomb |
|
| https://github.com/codecov-commenter |
|
| https://github.com/erlend-aasland |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |