René's URL Explorer Experiment


Title: Make Network.notifier timeouts customizable (fixes #530) by acolomb · Pull Request #536 · canopen-python/canopen · GitHub

Open Graph Title: Make Network.notifier timeouts customizable (fixes #530) by acolomb · Pull Request #536 · canopen-python/canopen

X Title: Make Network.notifier timeouts customizable (fixes #530) by acolomb · Pull Request #536 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Move the hard-coded 1 second maximum cycle duration passed during can.Notifier construction to a class variable NOTIFIER_CYCLE. Explicitly specify the timeout to stop the notifier in another class ...

X Description: Move the hard-coded 1 second maximum cycle duration passed during can.Notifier construction to a class variable NOTIFIER_CYCLE. Explicitly specify the timeout to stop the notifier in another class ...

Opengraph URL: https://github.com/canopen-python/canopen/pull/536

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ec4b3d1e-9373-f15c-cadf-6e0abc3367d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE57E:2F3AB6:4B93938:634108C:6A5D7576
html-safe-nonce9f8ec0997e7b9b2d7ed37c67a37f8bf928bee02958abffac6233753d03acf7f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTdFOjJGM0FCNjo0QjkzOTM4OjYzNDEwOEM6NkE1RDc1NzYiLCJ2aXNpdG9yX2lkIjoiNDI3NjQ2MjgwMDU1Njg4MTI3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe8595e816e8647e214ba87958c172fc9b4ba06e60954fc1587f8ffd331e6737
hovercard-subject-tagpull_request:2018942782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/536/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f32392b3ddf526fb5a2f91c32ee2278e62705ea18b5fd338f6b5dbca3d5defa5/canopen-python/canopen/pull/536
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f32392b3ddf526fb5a2f91c32ee2278e62705ea18b5fd338f6b5dbca3d5defa5/canopen-python/canopen/pull/536
og:image:altMove the hard-coded 1 second maximum cycle duration passed during can.Notifier construction to a class variable NOTIFIER_CYCLE. Explicitly specify the timeout to stop the notifier in another class ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/536#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F536
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F536
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/536
Reloadhttps://github.com/canopen-python/canopen/pull/536
Reloadhttps://github.com/canopen-python/canopen/pull/536
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:shutdown-customizable-waithttps://github.com/acolomb/canopen/tree/shutdown-customizable-wait
Conversationhttps://github.com/canopen-python/canopen/pull/536
Commits3 (3)https://github.com/canopen-python/canopen/pull/536/commits
Checkshttps://github.com/canopen-python/canopen/pull/536/checks
Files changedhttps://github.com/canopen-python/canopen/pull/536/files
Make Network.notifier timeouts customizable (fixes #530)https://github.com/canopen-python/canopen/pull/536#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:shutdown-customizable-waithttps://github.com/acolomb/canopen/tree/shutdown-customizable-wait
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#issue-2465432804
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
acolombhttps://github.com/acolomb
August 14, 2024 12:02https://github.com/canopen-python/canopen/pull/536#commits-pushed-559297b
https://github.com/acolomb
Add configurable timeouts for Network.notifier.https://github.com/canopen-python/canopen/pull/536/commits/559297b98b891792ac35bb12bb27de75473c7b45
559297bhttps://github.com/canopen-python/canopen/pull/536/commits/559297b98b891792ac35bb12bb27de75473c7b45
https://github.com/acolomb
Do not wait for notifier thread shutdown during tests.https://github.com/canopen-python/canopen/pull/536/commits/94059a9f5c790918ca084e7d83ed964cc90723f9
94059a9https://github.com/canopen-python/canopen/pull/536/commits/94059a9f5c790918ca084e7d83ed964cc90723f9
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#issuecomment-2288371825
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1MTAxMTUsIm5iZiI6MTc4NDUwOTgxNSwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQwMTEwMTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNmRiNGJmNDJmNjQwMWNiMzZmMjU4ZTQyOTZjYWY5MDkxNDg3NDNlZTk4MDIzMzgwODdkZGMzZTJmZTAxNzBjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.PaMAIS47x9wpQk-h475wPyfOmpaT0m4NBaxoX4RIURg
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/536?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(932c621)https://app.codecov.io/gh/christiansandberg/canopen/commit/932c6212bf077596dbfec91fd6ca66308142b972?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(64a1d6f)https://app.codecov.io/gh/christiansandberg/canopen/commit/64a1d6f698a0fb2601a0544e97fb3d1072ffd030?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Fileshttps://app.codecov.io/gh/christiansandberg/canopen/pull/536?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/network.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/536?src=pr&el=tree&filepath=canopen%2Fnetwork.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9uZXR3b3JrLnB5
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#issuecomment-2288375561
@erlend-aaslandhttps://github.com/erlend-aasland
#535https://github.com/canopen-python/canopen/pull/535
#535https://github.com/canopen-python/canopen/pull/535
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 14, 2024 https://github.com/canopen-python/canopen/pull/536#ref-pullrequest-2465166230
Tests: force disconnect from virtual busses on tearDown() (fixes #530) #535 https://github.com/canopen-python/canopen/pull/535
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#event-13877766139
Reduce network shutdown latency #530 https://github.com/canopen-python/canopen/issues/530
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#event-13877767769
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#issuecomment-2288398155
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 14, 2024 https://github.com/canopen-python/canopen/pull/536#pullrequestreview-2237771098
View reviewed changes https://github.com/canopen-python/canopen/pull/536/files/94059a9f5c790918ca084e7d83ed964cc90723f9
canopen/network.pyhttps://github.com/canopen-python/canopen/pull/536/files/94059a9f5c790918ca084e7d83ed964cc90723f9#diff-8631eecc701917a730fe862f1650e0568fb120b60e965184923ebdbb2d2b4816
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 14, 2024 https://github.com/canopen-python/canopen/pull/536#pullrequestreview-2237771516
View reviewed changes https://github.com/canopen-python/canopen/pull/536/files/94059a9f5c790918ca084e7d83ed964cc90723f9
https://github.com/acolomb
https://github.com/erlend-aasland
Update canopen/network.pyhttps://github.com/canopen-python/canopen/pull/536/commits/64a1d6f698a0fb2601a0544e97fb3d1072ffd030
64a1d6fhttps://github.com/canopen-python/canopen/pull/536/commits/64a1d6f698a0fb2601a0544e97fb3d1072ffd030
https://github.com/acolomb
acolombhttps://github.com/acolomb
6ef4f5ehttps://github.com/canopen-python/canopen/commit/6ef4f5e35d84a7d776d1758842bc8138215e9715
Aug 14, 2024https://github.com/canopen-python/canopen/pull/536#event-13878110101
https://github.com/acolomb
acolombhttps://github.com/acolomb
August 14, 2024 10:49https://github.com/canopen-python/canopen/pull/536#event-13878135430
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F536
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/canopen-python/canopen/pull/536/files/94059a9f5c790918ca084e7d83ed964cc90723f9
Reduce network shutdown latency https://github.com/canopen-python/canopen/issues/530
Please reload this pagehttps://github.com/canopen-python/canopen/pull/536
https://github.com/acolomb
https://github.com/codecov-commenter
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.