René's URL Explorer Experiment


Title: Fix some type checker errors in network module by acolomb · Pull Request #534 · canopen-python/canopen · GitHub

Open Graph Title: Fix some type checker errors in network module by acolomb · Pull Request #534 · canopen-python/canopen

X Title: Fix some type checker errors in network module by acolomb · Pull Request #534 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Contains fixes from #512 as well, but with a slightly simpler approach.

X Description: Contains fixes from #512 as well, but with a slightly simpler approach.

Opengraph URL: https://github.com/canopen-python/canopen/pull/534

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:dad84ca3-3008-1e1b-cda6-de70d76e9efc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC112:20DA71:6CF3394:93DBA2F:6A5E2B26
html-safe-nonce87f63076557e48b84c79a4f21f09ca4acb51171f9b5c87fc1036204f0b499f10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTEyOjIwREE3MTo2Q0YzMzk0OjkzREJBMkY6NkE1RTJCMjYiLCJ2aXNpdG9yX2lkIjoiMzMwNzgwNjQ5OTczMzkwODI2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb5ef3c88efd92344404db3a55c7896dd8d9317e5b229016e0fd49d1aee0f6cb1
hovercard-subject-tagpull_request:2015252027
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/534/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e11cb0cc60a24423b041cce3533faca90033ce7c66a982d9fe4189870f417f5/canopen-python/canopen/pull/534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e11cb0cc60a24423b041cce3533faca90033ce7c66a982d9fe4189870f417f5/canopen-python/canopen/pull/534
og:image:altContains fixes from #512 as well, but with a slightly simpler approach.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None621588b5bccbeb4b6fab0bb72b5de86200d5e6df07dbdabbdb667c8649f6e38d
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14f1e1fce2dc2d662cbf7ef602c59756c2283f9e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/534#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F534
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F534
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/534
Reloadhttps://github.com/canopen-python/canopen/pull/534
Reloadhttps://github.com/canopen-python/canopen/pull/534
Please reload this pagehttps://github.com/canopen-python/canopen/pull/534
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:typing/networkhttps://github.com/acolomb/canopen/tree/typing/network
Conversationhttps://github.com/canopen-python/canopen/pull/534
Commits3 (3)https://github.com/canopen-python/canopen/pull/534/commits
Checkshttps://github.com/canopen-python/canopen/pull/534/checks
Files changedhttps://github.com/canopen-python/canopen/pull/534/files
Fix some type checker errors in network modulehttps://github.com/canopen-python/canopen/pull/534#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:typing/networkhttps://github.com/acolomb/canopen/tree/typing/network
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 12, 2024https://github.com/canopen-python/canopen/pull/534#issue-2461198122
#512https://github.com/canopen-python/canopen/pull/512
Please reload this pagehttps://github.com/canopen-python/canopen/pull/534
acolombhttps://github.com/acolomb
August 12, 2024 16:34https://github.com/canopen-python/canopen/pull/534#commits-pushed-d87b865
https://github.com/acolomb
Annotate PeriodicMessageTask in NmtMaster and NmtSlave.https://github.com/canopen-python/canopen/pull/534/commits/d87b865e22ae597c2dcb57406c173f4c9042dfe5
d87b865https://github.com/canopen-python/canopen/pull/534/commits/d87b865e22ae597c2dcb57406c173f4c9042dfe5
https://github.com/acolomb
Type annotate Network.notifier.https://github.com/canopen-python/canopen/pull/534/commits/c82f646a02784c791775b2b50c0f6eba899d2088
c82f646https://github.com/canopen-python/canopen/pull/534/commits/c82f646a02784c791775b2b50c0f6eba899d2088
https://github.com/acolomb
Remove duplicate initialization of PeriodicMessageTask._task.https://github.com/canopen-python/canopen/pull/534/commits/b8187cda7baaad7ad49155ff69fbb98e69ba3d00
b8187cdhttps://github.com/canopen-python/canopen/pull/534/commits/b8187cda7baaad7ad49155ff69fbb98e69ba3d00
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Aug 12, 2024https://github.com/canopen-python/canopen/pull/534#issuecomment-2284181489
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1NTY2MjcsIm5iZiI6MTc4NDU1NjMyNywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQxNDA1MjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MzY4MGU4ODhhMWY2N2E4MTM1MDgyZWIyZDBiMDA1ZmQ1YzcxYzAyMzY4MWVhOTE2ZTExYWQ0YmZhYjM1ZDUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.MZRZQEySRtP3O3USTNAEQi_13iNH9rJp4o6B3eogt5o
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(83594ac)https://app.codecov.io/gh/christiansandberg/canopen/commit/83594ac89ee8f07d3bf346f3ceeab3b52d954625?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(b8187cd)https://app.codecov.io/gh/christiansandberg/canopen/commit/b8187cda7baaad7ad49155ff69fbb98e69ba3d00?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Fileshttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/nmt.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?src=pr&el=tree&filepath=canopen%2Fnmt.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9ubXQucHk=
1 Missing and 1 partial ⚠️ https://app.codecov.io/gh/christiansandberg/canopen/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Fileshttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/network.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?src=pr&el=tree&filepath=canopen%2Fnetwork.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9uZXR3b3JrLnB5
canopen/nmt.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/534?src=pr&el=tree&filepath=canopen%2Fnmt.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9ubXQucHk=
Please reload this pagehttps://github.com/canopen-python/canopen/pull/534
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 12, 2024 https://github.com/canopen-python/canopen/pull/534#ref-pullrequest-2400441070
Add mypy support and fixup project to give no errors #512 https://github.com/canopen-python/canopen/pull/512
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 14, 2024 https://github.com/canopen-python/canopen/pull/534#pullrequestreview-2238067634
View reviewed changes https://github.com/canopen-python/canopen/pull/534/files/b8187cda7baaad7ad49155ff69fbb98e69ba3d00
https://github.com/acolomb
acolombhttps://github.com/acolomb
1b7c06fhttps://github.com/canopen-python/canopen/commit/1b7c06f57ba8a46afbddfa2b4ca29196e63a465d
Aug 14, 2024https://github.com/canopen-python/canopen/pull/534#event-13887526682
https://github.com/acolomb
acolombhttps://github.com/acolomb
August 14, 2024 21:19https://github.com/canopen-python/canopen/pull/534#event-13887544999
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F534
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/canopen-python/canopen/pull/534/files/b8187cda7baaad7ad49155ff69fbb98e69ba3d00
Please reload this pagehttps://github.com/canopen-python/canopen/pull/534
https://github.com/acolomb
https://github.com/codecov-commenter
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.