René's URL Explorer Experiment


Title: Tests: improve coverage of NodeScanner by erlend-aasland · Pull Request #517 · canopen-python/canopen · GitHub

Open Graph Title: Tests: improve coverage of NodeScanner by erlend-aasland · Pull Request #517 · canopen-python/canopen

X Title: Tests: improve coverage of NodeScanner by erlend-aasland · Pull Request #517 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Opengraph URL: https://github.com/canopen-python/canopen/pull/517

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0690c042-3283-7b22-e461-906aaca10c71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA0A:300F93:4676BA1:5D63323:6A5D864F
html-safe-nonce85c3118a338d079f178287746307922d4bf349800e5f9dfa0304f039b4b10043
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTBBOjMwMEY5Mzo0Njc2QkExOjVENjMzMjM6NkE1RDg2NEYiLCJ2aXNpdG9yX2lkIjoiNTIwNTEzMzMyMDkyNjM2NTI2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac24130ab636543c23511873f7a6dd4e7cdf2d3d5eef8672219fd2a0139ca8e1a1
hovercard-subject-tagpull_request:1963905641
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/517/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5b35feb0a1c9914ca956faf8e428e1a204e03e2084c0396c5c758a1afb527b0c/canopen-python/canopen/pull/517
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5b35feb0a1c9914ca956faf8e428e1a204e03e2084c0396c5c758a1afb527b0c/canopen-python/canopen/pull/517
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/517#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F517
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F517
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/517
Reloadhttps://github.com/canopen-python/canopen/pull/517
Reloadhttps://github.com/canopen-python/canopen/pull/517
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
erlend-aasland:test/scanner-coveragehttps://github.com/erlend-aasland/canopen/tree/test/scanner-coverage
Conversationhttps://github.com/canopen-python/canopen/pull/517
Commits4 (4)https://github.com/canopen-python/canopen/pull/517/commits
Checkshttps://github.com/canopen-python/canopen/pull/517/checks
Files changedhttps://github.com/canopen-python/canopen/pull/517/files
Tests: improve coverage of NodeScannerhttps://github.com/canopen-python/canopen/pull/517#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
erlend-aasland:test/scanner-coveragehttps://github.com/erlend-aasland/canopen/tree/test/scanner-coverage
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 11, 2024https://github.com/canopen-python/canopen/pull/517#issue-2402464329
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
Tests: improve coverage of canopen.network.NodeScannerhttps://github.com/canopen-python/canopen/pull/517/commits/22a5ba17b98d451470575cf113f88591ebbb768b
22a5ba1https://github.com/canopen-python/canopen/pull/517/commits/22a5ba17b98d451470575cf113f88591ebbb768b
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jul 11, 2024https://github.com/canopen-python/canopen/pull/517#issuecomment-2222229645
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1MTQ0MjgsIm5iZiI6MTc4NDUxNDEyOCwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQwMjIyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iOTRhYWYxMmYxNmNjMWE4N2MyZTUwYjk0MjA1NzM1NjAwODExZjJiNWFkMDE4OTFlMjI4MGU5ZjcyZThjNTE0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.w7DAWNgpuUKWySd33JoToiFYkn7mS3IAUqU53ZPyNyA
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/517?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(a196e1e)https://app.codecov.io/gh/christiansandberg/canopen/commit/a196e1e3b62bddcfd62cea9fc5293efe8a8cc0a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(e6921a4)https://app.codecov.io/gh/christiansandberg/canopen/commit/e6921a4015bcf13a80feada5bec724729b634020?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
see 1 file with indirect coverage changeshttps://app.codecov.io/gh/christiansandberg/canopen/pull/517/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 11, 2024https://github.com/canopen-python/canopen/pull/517#event-13467499721
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 11, 2024 https://github.com/canopen-python/canopen/pull/517#ref-issue-2401820395
Improve test coverage #514 https://github.com/canopen-python/canopen/issues/514
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 11, 2024 https://github.com/canopen-python/canopen/pull/517#pullrequestreview-2171490424
View reviewed changes https://github.com/canopen-python/canopen/pull/517/files/22a5ba17b98d451470575cf113f88591ebbb768b
test/test_network.pyhttps://github.com/canopen-python/canopen/pull/517/files/22a5ba17b98d451470575cf113f88591ebbb768b#diff-10fe312e1c49d9c7e182d7edec94eb93f665ab08ef17d77c11354a01e16f895f
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
erlend-aaslandhttps://github.com/erlend-aasland
July 11, 2024 12:12https://github.com/canopen-python/canopen/pull/517#commits-pushed-ceb6036
https://github.com/erlend-aasland
Remove duplicate linehttps://github.com/canopen-python/canopen/pull/517/commits/ceb60366a14b44a37007afafc1338611fe1fb3c7
ceb6036https://github.com/canopen-python/canopen/pull/517/commits/ceb60366a14b44a37007afafc1338611fe1fb3c7
https://github.com/erlend-aasland
Use existing scanner instead of creating a new onehttps://github.com/canopen-python/canopen/pull/517/commits/c822e00de1f45ade10a0fdde13d39821f4f5d6a2
c822e00https://github.com/canopen-python/canopen/pull/517/commits/c822e00de1f45ade10a0fdde13d39821f4f5d6a2
https://github.com/erlend-aasland
Simplifyhttps://github.com/canopen-python/canopen/pull/517/commits/e6921a4015bcf13a80feada5bec724729b634020
e6921a4https://github.com/canopen-python/canopen/pull/517/commits/e6921a4015bcf13a80feada5bec724729b634020
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 6, 2024 https://github.com/canopen-python/canopen/pull/517#pullrequestreview-2222151210
View reviewed changes https://github.com/canopen-python/canopen/pull/517/files/e6921a4015bcf13a80feada5bec724729b634020
acolombhttps://github.com/acolomb
https://github.com/canopen-python/canopen/pull/517#pullrequestreview-2222151210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/acolomb
acolombhttps://github.com/acolomb
d1c28e5https://github.com/canopen-python/canopen/commit/d1c28e51b93c7d45fce40187672e7ab7a0616cac
Aug 6, 2024https://github.com/canopen-python/canopen/pull/517#event-13783451230
https://github.com/acolomb
acolombhttps://github.com/acolomb
Aug 6, 2024https://github.com/canopen-python/canopen/pull/517#issuecomment-2272069773
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
@erlend-aaslandhttps://github.com/erlend-aasland
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 6, 2024https://github.com/canopen-python/canopen/pull/517#issuecomment-2272089328
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
August 6, 2024 21:58https://github.com/canopen-python/canopen/pull/517#event-13784367511
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 6, 2024https://github.com/canopen-python/canopen/pull/517#issuecomment-2272248854
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Aug 9, 2024 https://github.com/canopen-python/canopen/pull/517#ref-pullrequest-2458717900
Make node scanner tests more deterministic #526 https://github.com/canopen-python/canopen/pull/526
acolombhttps://github.com/acolomb
Aug 11, 2024 https://github.com/canopen-python/canopen/pull/517#ref-commit-d75c5f0
https://github.com/erlend-aasland
Make node scanner tests more deterministic (https://github.com/canopen-python/canopen/commit/d75c5f09b11b1ffee200bd8813efac5c8f0127e8
#526https://github.com/canopen-python/canopen/pull/526
)https://github.com/canopen-python/canopen/commit/d75c5f09b11b1ffee200bd8813efac5c8f0127e8
d75c5f0https://github.com/canopen-python/canopen/commit/d75c5f09b11b1ffee200bd8813efac5c8f0127e8
#517https://github.com/canopen-python/canopen/pull/517
d1c28e5https://github.com/canopen-python/canopen/commit/d1c28e51b93c7d45fce40187672e7ab7a0616cac
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F517
https://github.com/acolomb
acolomb https://github.com/acolomb
https://github.com/canopen-python/canopen/pull/517/files/e6921a4015bcf13a80feada5bec724729b634020
Please reload this pagehttps://github.com/canopen-python/canopen/pull/517
https://github.com/erlend-aasland
https://github.com/codecov-commenter
https://github.com/acolomb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.