| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8e5d2d8c-9a7e-7f49-4b98-81ab1e951027 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F78:10A28F:C8C2F9:108D6DB:6A5EDB66 |
| html-safe-nonce | c279b3b4556561833a68e050f13355cd270bc1c46e2ae3aa22fee59d4807e436 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjc4OjEwQTI4RjpDOEMyRjk6MTA4RDZEQjo2QTVFREI2NiIsInZpc2l0b3JfaWQiOiI3Nzg5OTUyNTIwNjQ3NzkzNTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d74e8de5e138831f57e7e01c4f110b954ad40da934e3e1d80052a8158a235542 |
| hovercard-subject-tag | pull_request:1962207302 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/513/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4f86259ccddb806f69a94dee4ec0d083e313daaf3b7d1d299c8381b8c23f5bf3/canopen-python/canopen/pull/513 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4f86259ccddb806f69a94dee4ec0d083e313daaf3b7d1d299c8381b8c23f5bf3/canopen-python/canopen/pull/513 |
| og:image:alt | With reference to #511 this PR properly annotates all uses of Network and adds runtime checks for the usage of Network instances. In very many classes self.network is Optional[Network] with default... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sveinse |
| hostname | github.com |
| expected-hostname | github.com |
| None | 82d0004a35927bdb00c652a57f456c55aa0eda4ade1bc7956d7510fdea6e454b |
| turbo-cache-control | no-cache |
| go-import | github.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git |
| octolytics-dimension-user_id | 200581454 |
| octolytics-dimension-user_login | canopen-python |
| octolytics-dimension-repository_id | 68737600 |
| octolytics-dimension-repository_nwo | canopen-python/canopen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68737600 |
| octolytics-dimension-repository_network_root_nwo | canopen-python/canopen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d2d913dd727d2d7ac189fb4d05b10bc34ecd03ee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/canopen-python/canopen/pull/513#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F513 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F513 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen |
| Reload | https://github.com/canopen-python/canopen/pull/513 |
| Reload | https://github.com/canopen-python/canopen/pull/513 |
| Reload | https://github.com/canopen-python/canopen/pull/513 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
|
canopen-python
| https://github.com/canopen-python |
| canopen | https://github.com/canopen-python/canopen |
|
Notifications
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Fork
359
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Star
562
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
53
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
20
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
0
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
| sveinse | https://github.com/sveinse |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| sveinse:feature-network-annotation-and-handling | https://github.com/sveinse/canopen-asyncio/tree/feature-network-annotation-and-handling |
| Conversation | https://github.com/canopen-python/canopen/pull/513 |
| Commits1 (1) | https://github.com/canopen-python/canopen/pull/513/commits |
| Checks | https://github.com/canopen-python/canopen/pull/513/checks |
| Files changed | https://github.com/canopen-python/canopen/pull/513/files |
| Annotate Network and check usage of it runtime | https://github.com/canopen-python/canopen/pull/513#top |
| sveinse | https://github.com/sveinse |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| sveinse:feature-network-annotation-and-handling | https://github.com/sveinse/canopen-asyncio/tree/feature-network-annotation-and-handling |
|
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
| Jul 10, 2024 | https://github.com/canopen-python/canopen/pull/513#issue-2400551368 |
| #511 | https://github.com/canopen-python/canopen/issues/511 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
|
| https://github.com/sveinse |
| Annotate and check usage of Network | https://github.com/canopen-python/canopen/pull/513/commits/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98 |
| 76e3729 | https://github.com/canopen-python/canopen/pull/513/commits/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Jul 10, 2024 | https://github.com/canopen-python/canopen/pull/513#issuecomment-2220313639 |
| https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ2MDE3NDYsIm5iZiI6MTc4NDYwMTQ0NiwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMVQwMjM3MjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMjkxNmU4YzAyM2YzNmFjMWIzM2IxODRjYjAwYTUyZTAxNzVkMzhjZWU1MDQ2Yjk2NmJjNmU5ZDRjODUzNGNmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.JFXRVi_H9vfHHUJcY96yRxoEg9quYEyjWglbFdSv9Jg |
| Codecov | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| (3aa509d) | https://app.codecov.io/gh/christiansandberg/canopen/commit/3aa509db9fea8094516e5eb717be3df182f0751a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| (76e3729) | https://app.codecov.io/gh/christiansandberg/canopen/commit/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| Codecov GitHub app | https://github.com/apps/codecov/installations/select_target |
| https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| Files | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| canopen/network.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fnetwork.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9uZXR3b3JrLnB5 |
| canopen/node/base.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fnode%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9ub2RlL2Jhc2UucHk= |
| canopen/objectdictionary/eds.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fobjectdictionary%2Feds.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9vYmplY3RkaWN0aW9uYXJ5L2Vkcy5weQ== |
| canopen/sdo/base.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fsdo%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9zZG8vYmFzZS5weQ== |
| canopen/sdo/client.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fsdo%2Fclient.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9zZG8vY2xpZW50LnB5 |
| canopen/sdo/server.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fsdo%2Fserver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9zZG8vc2VydmVyLnB5 |
| canopen/sync.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fsync.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9zeW5jLnB5 |
| canopen/timestamp.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Ftimestamp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi90aW1lc3RhbXAucHk= |
| canopen/lss.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Flss.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9sc3MucHk= |
| canopen/node/local.py | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree&filepath=canopen%2Fnode%2Flocal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9ub2RlL2xvY2FsLnB5 |
| 4 more | https://app.codecov.io/gh/christiansandberg/canopen/pull/513?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
|
Jul 10, 2024
| https://github.com/canopen-python/canopen/pull/513#ref-issue-2400288588 |
|
Network instance is optional in many classes, which requires lot of checking
#511
| https://github.com/canopen-python/canopen/issues/511 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| Jul 10, 2024 | https://github.com/canopen-python/canopen/pull/513#issuecomment-2220498652 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
|
Jul 10, 2024
| https://github.com/canopen-python/canopen/pull/513#ref-issue-1641128270 |
|
Type annotations in canopen
#358
| https://github.com/canopen-python/canopen/issues/358 |
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
| Jul 10, 2024 | https://github.com/canopen-python/canopen/pull/513#issuecomment-2220683457 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
Aug 6, 2024
| https://github.com/canopen-python/canopen/pull/513#pullrequestreview-2222222286 |
|
View reviewed changes
| https://github.com/canopen-python/canopen/pull/513/files/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98 |
| canopen/network.py | https://github.com/canopen-python/canopen/pull/513/files/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98#diff-8631eecc701917a730fe862f1650e0568fb120b60e965184923ebdbb2d2b4816 |
| acolomb | https://github.com/acolomb |
| Aug 6, 2024 | https://github.com/canopen-python/canopen/pull/513#discussion_r1706100791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| canopen/network.py | https://github.com/canopen-python/canopen/pull/513/files/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98#diff-8631eecc701917a730fe862f1650e0568fb120b60e965184923ebdbb2d2b4816 |
| acolomb | https://github.com/acolomb |
| Aug 6, 2024 | https://github.com/canopen-python/canopen/pull/513#discussion_r1706101254 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Aug 6, 2024 | https://github.com/canopen-python/canopen/pull/513#issuecomment-2272158459 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
Aug 7, 2024
| https://github.com/canopen-python/canopen/pull/513#ref-pullrequest-2452840094 |
|
Add a dummy object to designate "uninitialized" networks (fixes #511)
#525
| https://github.com/canopen-python/canopen/pull/525 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Oct 17, 2024 | https://github.com/canopen-python/canopen/pull/513#issuecomment-2420381540 |
| #525 | https://github.com/canopen-python/canopen/pull/525 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Oct 17, 2024 | https://github.com/canopen-python/canopen/pull/513#event-14704581384 |
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
| October 17, 2024 19:40 | https://github.com/canopen-python/canopen/pull/513#event-14704596663 |
| https://github.co/hiddenchars |
| https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F513 |
|
| https://github.com/acolomb |
|
acolomb
| https://github.com/acolomb |
|
| https://github.com/canopen-python/canopen/pull/513/files/76e3729bbc5204f5a340ceb0b2fed56f01a1ad98 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/513 |
|
| https://github.com/sveinse |
|
| https://github.com/codecov-commenter |
|
| https://github.com/erlend-aasland |
|
| https://github.com/acolomb |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |