René's URL Explorer Experiment


Title: Save the passed node ID to the resulting OD in `import_od()` by erlend-aasland · Pull Request #484 · canopen-python/canopen · GitHub

Open Graph Title: Save the passed node ID to the resulting OD in `import_od()` by erlend-aasland · Pull Request #484 · canopen-python/canopen

X Title: Save the passed node ID to the resulting OD in `import_od()` by erlend-aasland · Pull Request #484 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Fixes #478

X Description: Fixes #478

Opengraph URL: https://github.com/canopen-python/canopen/pull/484

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0812a06a-535c-a873-a03f-53ff57168174
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC20E:12D7DC:584B93F:73BDF43:6A5DA7A0
html-safe-nonce65face524b1c7209294c4e866a2b7bee2e059eb67df083165a4a925ee48f39db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjBFOjEyRDdEQzo1ODRCOTNGOjczQkRGNDM6NkE1REE3QTAiLCJ2aXNpdG9yX2lkIjoiMTU2OTM3NDkxODUyOTYyMzk2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac031337a664f8bac7bee712dfc12229899de9acf9915523b3d0b7c8469005202e
hovercard-subject-tagpull_request:1949642647
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/484/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0de67477a102fe0e8cb3d77efa0212b552da17737a65bee9124fa263f2591656/canopen-python/canopen/pull/484
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0de67477a102fe0e8cb3d77efa0212b552da17737a65bee9124fa263f2591656/canopen-python/canopen/pull/484
og:image:altFixes #478
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/484#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F484
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F484
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/484
Reloadhttps://github.com/canopen-python/canopen/pull/484
Reloadhttps://github.com/canopen-python/canopen/pull/484
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
erlend-aasland:import-with-node-idhttps://github.com/erlend-aasland/canopen/tree/import-with-node-id
Conversationhttps://github.com/canopen-python/canopen/pull/484
Commits6 (6)https://github.com/canopen-python/canopen/pull/484/commits
Checkshttps://github.com/canopen-python/canopen/pull/484/checks
Files changedhttps://github.com/canopen-python/canopen/pull/484/files
Save the passed node ID to the resulting OD in import_od()https://github.com/canopen-python/canopen/pull/484#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
erlend-aasland:import-with-node-idhttps://github.com/erlend-aasland/canopen/tree/import-with-node-id
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/484#issue-2386410377
#478https://github.com/canopen-python/canopen/issues/478
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
erlend-aaslandhttps://github.com/erlend-aasland
July 2, 2024 16:22https://github.com/canopen-python/canopen/pull/484#commits-pushed-1b2cf65
https://github.com/erlend-aasland
Alt 1https://github.com/canopen-python/canopen/pull/484/commits/1b2cf657bf1a751ebf0eb344255b18261340801c
1b2cf65https://github.com/canopen-python/canopen/pull/484/commits/1b2cf657bf1a751ebf0eb344255b18261340801c
https://github.com/erlend-aasland
Alt 2https://github.com/canopen-python/canopen/pull/484/commits/e4cfa6ecc3b906d61c40268cf0325866b6451ba8
e4cfa6ehttps://github.com/canopen-python/canopen/pull/484/commits/e4cfa6ecc3b906d61c40268cf0325866b6451ba8
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/484#event-13367092804
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jul 2, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2203362586
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1MjI5NTcsIm5iZiI6MTc4NDUyMjY1NywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQwNDQ0MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03N2Q3OGRhZjYxZjliZmUxMjhjZTA1NGM5YmRjNzg3YzdjZWRmMjdhYjAyMjhjZTU3ZTk3YzZhZGI0NGMzNWQwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.afehioemPTViOTLIZuB2u9L79LW2n98qjZNPrlVEdpM
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/484?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(cc37aee)https://app.codecov.io/gh/christiansandberg/canopen/commit/cc37aee4e172a5a83f9f9dc956cc66d82bd1a8b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(ac79a35)https://app.codecov.io/gh/christiansandberg/canopen/commit/ac79a35c792fc60bb0fabad56e60f4d659747a1b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Fileshttps://app.codecov.io/gh/christiansandberg/canopen/pull/484?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/objectdictionary/eds.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/484?src=pr&el=tree&filepath=canopen%2Fobjectdictionary%2Feds.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9vYmplY3RkaWN0aW9uYXJ5L2Vkcy5weQ==
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2203365476
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
Pull in mainhttps://github.com/canopen-python/canopen/pull/484/commits/8c4cb85d8769a98ceb52bf7227ec891f87decce7
8c4cb85https://github.com/canopen-python/canopen/pull/484/commits/8c4cb85d8769a98ceb52bf7227ec891f87decce7
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024 https://github.com/canopen-python/canopen/pull/484#ref-pullrequest-2381979909
Expose and improve the docstrings of export_od and import_id #473 https://github.com/canopen-python/canopen/pull/473
https://github.com/erlend-aasland
Pull in mainhttps://github.com/canopen-python/canopen/pull/484/commits/fd97945ce9d360df09033a559a1b5ed456e3ae58
fd97945https://github.com/canopen-python/canopen/pull/484/commits/fd97945ce9d360df09033a559a1b5ed456e3ae58
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024 https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157129079
View reviewed changes https://github.com/canopen-python/canopen/pull/484/files/fd97945ce9d360df09033a559a1b5ed456e3ae58
acolombhttps://github.com/acolomb
https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157129079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207225263
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207248849
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
Address review: load node_id from EDS if it's not providedhttps://github.com/canopen-python/canopen/pull/484/commits/8a22e7ed329afbda46ac629c7c6974223477c0c2
8a22e7ehttps://github.com/canopen-python/canopen/pull/484/commits/8a22e7ed329afbda46ac629c7c6974223477c0c2
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024 https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157421340
View reviewed changes https://github.com/canopen-python/canopen/pull/484/files/8a22e7ed329afbda46ac629c7c6974223477c0c2
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207281646
8a22e7ehttps://github.com/canopen-python/canopen/commit/8a22e7ed329afbda46ac629c7c6974223477c0c2
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207301218
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207303114
#484 (comment)https://github.com/canopen-python/canopen/pull/484#issuecomment-2207281646
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207304259
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207306316
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024 https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157463568
View reviewed changes https://github.com/canopen-python/canopen/pull/484/files/8a22e7ed329afbda46ac629c7c6974223477c0c2
canopen/objectdictionary/eds.pyhttps://github.com/canopen-python/canopen/pull/484/files/8a22e7ed329afbda46ac629c7c6974223477c0c2#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207332128
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
Add fallback for edge casehttps://github.com/canopen-python/canopen/pull/484/commits/ac79a35c792fc60bb0fabad56e60f4d659747a1b
ac79a35https://github.com/canopen-python/canopen/pull/484/commits/ac79a35c792fc60bb0fabad56e60f4d659747a1b
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024 https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157523637
View reviewed changes https://github.com/canopen-python/canopen/pull/484/files/ac79a35c792fc60bb0fabad56e60f4d659747a1b
canopen/objectdictionary/eds.pyhttps://github.com/canopen-python/canopen/pull/484/files/ac79a35c792fc60bb0fabad56e60f4d659747a1b#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 3, 2024 https://github.com/canopen-python/canopen/pull/484#pullrequestreview-2157556885
View reviewed changes https://github.com/canopen-python/canopen/pull/484/files/ac79a35c792fc60bb0fabad56e60f4d659747a1b
https://github.com/acolomb
acolombhttps://github.com/acolomb
6a4ca11https://github.com/canopen-python/canopen/commit/6a4ca1184e219c64768fbb0eb8434b04320d4803
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#event-13386869370
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
July 3, 2024 22:26https://github.com/canopen-python/canopen/pull/484#event-13387013918
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 3, 2024https://github.com/canopen-python/canopen/pull/484#issuecomment-2207411097
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F484
https://github.com/acolomb
acolomb https://github.com/acolomb
https://github.com/canopen-python/canopen/pull/484/files/ac79a35c792fc60bb0fabad56e60f4d659747a1b
The node_id parameter of import_od is not saved to the resulting OD object https://github.com/canopen-python/canopen/issues/478
Please reload this pagehttps://github.com/canopen-python/canopen/pull/484
https://github.com/erlend-aasland
https://github.com/codecov-commenter
https://github.com/acolomb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.