René's URL Explorer Experiment


Title: Ensure proper close after open in export_od by sveinse · Pull Request #469 · canopen-python/canopen · GitHub

Open Graph Title: Ensure proper close after open in export_od by sveinse · Pull Request #469 · canopen-python/canopen

X Title: Ensure proper close after open in export_od by sveinse · Pull Request #469 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: This PR increases the robustness on file open in export_od(). It ensures that if the function opens a file, it will close it. PS! The buried import is itching to be fixed, but let's not do that...

X Description: This PR increases the robustness on file open in export_od(). It ensures that if the function opens a file, it will close it. PS! The buried import is itching to be fixed, but let's not do ...

Opengraph URL: https://github.com/canopen-python/canopen/pull/469

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:746cbde3-8b25-808e-f3cc-763262c01c45
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED70:A0835:4E12DC0:663B5A6:6A5D759D
html-safe-nonce00bef1c3a74d0482b01dd9bdd73127e2ec6b264f45a13aa74c04c386b1686f73
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDcwOkEwODM1OjRFMTJEQzA6NjYzQjVBNjo2QTVENzU5RCIsInZpc2l0b3JfaWQiOiI0MTIxNDE1NzUyNDgxNjAwOTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac42410c3b227aa5c3cbda5c3c51ca47d6c182f0fb25626bbcf13af735320f487b
hovercard-subject-tagpull_request:1930675716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/469/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4e84a16ccb64d316ed84f4470efa6daf540b0d190d5e61467a1141fa88f38bd5/canopen-python/canopen/pull/469
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4e84a16ccb64d316ed84f4470efa6daf540b0d190d5e61467a1141fa88f38bd5/canopen-python/canopen/pull/469
og:image:altThis PR increases the robustness on file open in export_od(). It ensures that if the function opens a file, it will close it. PS! The buried import is itching to be fixed, but let's not do that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesveinse
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/469#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F469
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F469
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/469
Reloadhttps://github.com/canopen-python/canopen/pull/469
Reloadhttps://github.com/canopen-python/canopen/pull/469
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
sveinse:fix-close-after-openhttps://github.com/sveinse/canopen-asyncio/tree/fix-close-after-open
Conversationhttps://github.com/canopen-python/canopen/pull/469
Commits3 (3)https://github.com/canopen-python/canopen/pull/469/commits
Checkshttps://github.com/canopen-python/canopen/pull/469/checks
Files changedhttps://github.com/canopen-python/canopen/pull/469/files
Ensure proper close after open in export_odhttps://github.com/canopen-python/canopen/pull/469#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
sveinse:fix-close-after-openhttps://github.com/sveinse/canopen-asyncio/tree/fix-close-after-open
https://github.com/sveinse
sveinsehttps://github.com/sveinse
Jun 20, 2024https://github.com/canopen-python/canopen/pull/469#issue-2364509404
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://github.com/sveinse
Ensure proper close after openhttps://github.com/canopen-python/canopen/pull/469/commits/9274b4a715fdeeca4bc5173fb807a3c652a673ff
9274b4ahttps://github.com/canopen-python/canopen/pull/469/commits/9274b4a715fdeeca4bc5173fb807a3c652a673ff
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jun 20, 2024https://github.com/canopen-python/canopen/pull/469#issuecomment-2180766581
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODQ1MTAxNTMsIm5iZiI6MTc4NDUwOTg1MywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNzIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDcyMFQwMTEwNTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mYmE2MDY0YTk0MWZkOTJkOTNjZGIwNWU0YzJhMjE4YTA1NDMyZWIzZWRlMjQyMzVjZTYzNTA0NjQ0MjljODZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.fH3o4FrLeHOSTSg7LT0sVK0yN3ftaNpZ79FyQxJjcg4
Codecovhttps://app.codecov.io/gh/christiansandberg/canopen/pull/469?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(e40d862)https://app.codecov.io/gh/christiansandberg/canopen/commit/e40d8627de2b5740a3201a040085064015644e72?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
(4364d89)https://app.codecov.io/gh/christiansandberg/canopen/commit/4364d8944604d89e5529da5a73edb6f6b45da160?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/christiansandberg/canopen/pull/469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
Fileshttps://app.codecov.io/gh/christiansandberg/canopen/pull/469?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg
canopen/objectdictionary/__init__.pyhttps://app.codecov.io/gh/christiansandberg/canopen/pull/469?src=pr&el=tree&filepath=canopen%2Fobjectdictionary%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Sandberg#diff-Y2Fub3Blbi9vYmplY3RkaWN0aW9uYXJ5L19faW5pdF9fLnB5
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://github.com/sveinse
Add tests to add code coverage of export_odhttps://github.com/canopen-python/canopen/pull/469/commits/76574cd510833679c07e01c69771908984087d9d
76574cdhttps://github.com/canopen-python/canopen/pull/469/commits/76574cd510833679c07e01c69771908984087d9d
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 20, 2024 https://github.com/canopen-python/canopen/pull/469#pullrequestreview-2131422801
View reviewed changes https://github.com/canopen-python/canopen/pull/469/files/76574cd510833679c07e01c69771908984087d9d
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 27, 2024 https://github.com/canopen-python/canopen/pull/469#pullrequestreview-2146546437
View reviewed changes https://github.com/canopen-python/canopen/pull/469/files/76574cd510833679c07e01c69771908984087d9d
canopen/objectdictionary/__init__.pyhttps://github.com/canopen-python/canopen/pull/469/files/76574cd510833679c07e01c69771908984087d9d#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://github.com/sveinse
https://github.com/erlend-aasland
Update canopen/objectdictionary/__init__.pyhttps://github.com/canopen-python/canopen/pull/469/commits/4364d8944604d89e5529da5a73edb6f6b45da160
4364d89https://github.com/canopen-python/canopen/pull/469/commits/4364d8944604d89e5529da5a73edb6f6b45da160
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 30, 2024 https://github.com/canopen-python/canopen/pull/469#pullrequestreview-2150073422
View reviewed changes https://github.com/canopen-python/canopen/pull/469/files/4364d8944604d89e5529da5a73edb6f6b45da160
https://github.com/acolomb
acolombhttps://github.com/acolomb
5db5913https://github.com/canopen-python/canopen/commit/5db59130423948e1e8034a67983ca00afd0269d8
Jun 30, 2024https://github.com/canopen-python/canopen/pull/469#event-13342573553
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 1, 2024 https://github.com/canopen-python/canopen/pull/469#pullrequestreview-2152365087
View reviewed changes https://github.com/canopen-python/canopen/pull/469/files/4364d8944604d89e5529da5a73edb6f6b45da160
canopen/objectdictionary/__init__.pyhttps://github.com/canopen-python/canopen/pull/469/files/4364d8944604d89e5529da5a73edb6f6b45da160#diff-69b2a4d11d72cfc4d3666514a69b5297dc82d81ea45ccc0923d3c7361cd68c5f
erlend-aaslandhttps://github.com/erlend-aasland
Jul 1, 2024https://github.com/canopen-python/canopen/pull/469#discussion_r1661613953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
sveinsehttps://github.com/sveinse
Jul 2, 2024https://github.com/canopen-python/canopen/pull/469#discussion_r1661921599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/469#discussion_r1662018129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/469#discussion_r1662028771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#475https://github.com/canopen-python/canopen/issues/475
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024https://github.com/canopen-python/canopen/pull/469#discussion_r1662099960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://github.com/sveinse
sveinsehttps://github.com/sveinse
July 2, 2024 06:42https://github.com/canopen-python/canopen/pull/469#event-13360511604
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 2, 2024 https://github.com/canopen-python/canopen/pull/469#ref-issue-2385529196
Consider using ObjectDictionaryError iso. NotImplementedError in export/import OD APIs #475 https://github.com/canopen-python/canopen/issues/475
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F469
https://github.com/acolomb
acolomb https://github.com/acolomb
https://github.com/canopen-python/canopen/pull/469/files/4364d8944604d89e5529da5a73edb6f6b45da160
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/canopen-python/canopen/pull/469/files/4364d8944604d89e5529da5a73edb6f6b45da160
Please reload this pagehttps://github.com/canopen-python/canopen/pull/469
https://github.com/sveinse
https://github.com/codecov-commenter
https://github.com/acolomb
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.