René's URL Explorer Experiment


Title: Modernize type annotations and fix some discrepancies by acolomb · Pull Request #451 · canopen-python/canopen · GitHub

Open Graph Title: Modernize type annotations and fix some discrepancies by acolomb · Pull Request #451 · canopen-python/canopen

X Title: Modernize type annotations and fix some discrepancies by acolomb · Pull Request #451 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Clarify that each SDO object has its corresponding OD entry linked in the .od attribute, not the whole ObjectDictionary. __iter__() should return Iterator like in Mapping, not Iterable. Use pos...

X Description: Clarify that each SDO object has its corresponding OD entry linked in the .od attribute, not the whole ObjectDictionary. __iter__() should return Iterator like in Mapping, not Iterable. Use pos...

Opengraph URL: https://github.com/canopen-python/canopen/pull/451

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b870b9f-077b-dde3-9a07-91e157c16634
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA94:53774:2FEB9B9:406883B:6A5DB896
html-safe-nonce0de73e574dfa55cb5541b31fc263d53882fe5b240c12b58a5a69ffe0139f8acd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTk0OjUzNzc0OjJGRUI5Qjk6NDA2ODgzQjo2QTVEQjg5NiIsInZpc2l0b3JfaWQiOiIxNzgxNzQwOTM3OTg0OTgxMTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1e872b34e0d8d5e0769ecc5f5cbef4a3135a1023f8a48461dd223ed0f3f6b24e
hovercard-subject-tagpull_request:1902303941
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/451/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/855c6a6f1ca65723dbe859aeffb7ca15b02746050cac6b2122d97f87a8081e91/canopen-python/canopen/pull/451
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/855c6a6f1ca65723dbe859aeffb7ca15b02746050cac6b2122d97f87a8081e91/canopen-python/canopen/pull/451
og:image:altClarify that each SDO object has its corresponding OD entry linked in the .od attribute, not the whole ObjectDictionary. __iter__() should return Iterator like in Mapping, not Iterable. Use pos...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameacolomb
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/451#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/451
Reloadhttps://github.com/canopen-python/canopen/pull/451
Reloadhttps://github.com/canopen-python/canopen/pull/451
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 560 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:sdo-typing-fixeshttps://github.com/acolomb/canopen/tree/sdo-typing-fixes
Conversationhttps://github.com/canopen-python/canopen/pull/451
Commits8 (8)https://github.com/canopen-python/canopen/pull/451/commits
Checkshttps://github.com/canopen-python/canopen/pull/451/checks
Files changedhttps://github.com/canopen-python/canopen/pull/451/files
Modernize type annotations and fix some discrepancieshttps://github.com/canopen-python/canopen/pull/451#top
acolombhttps://github.com/acolomb
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:sdo-typing-fixeshttps://github.com/acolomb/canopen/tree/sdo-typing-fixes
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 4, 2024https://github.com/canopen-python/canopen/pull/451#issue-2332755628
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
acolombhttps://github.com/acolomb
June 4, 2024 09:18https://github.com/canopen-python/canopen/pull/451#commits-pushed-81c6b00
https://github.com/acolomb
Fix type hints on SDO classes.https://github.com/canopen-python/canopen/pull/451/commits/81c6b00368d827ebddbcd2855af0b0f198eb8bde
81c6b00https://github.com/canopen-python/canopen/pull/451/commits/81c6b00368d827ebddbcd2855af0b0f198eb8bde
https://github.com/acolomb
Fix __iter__() return type annotation in PDO classes.https://github.com/canopen-python/canopen/pull/451/commits/9c033d0b2b3f54d95abda8cb4067b069811af466
9c033d0https://github.com/canopen-python/canopen/pull/451/commits/9c033d0b2b3f54d95abda8cb4067b069811af466
https://github.com/acolomb
Fix __iter__() return type annotation in Network and OD classes.https://github.com/canopen-python/canopen/pull/451/commits/9880489701b6963c5895909e76c4d39c4dffc5d1
9880489https://github.com/canopen-python/canopen/pull/451/commits/9880489701b6963c5895909e76c4d39c4dffc5d1
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 4, 2024https://github.com/canopen-python/canopen/pull/451#issuecomment-2146803152
#446https://github.com/canopen-python/canopen/pull/446
@friederschuelerhttps://github.com/friederschueler
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
https://github.com/acolomb
More __future__.annotations fixes.https://github.com/canopen-python/canopen/pull/451/commits/04c02e1bcd2a862de3aa9362af89db2662f1ab6a
04c02e1https://github.com/canopen-python/canopen/pull/451/commits/04c02e1bcd2a862de3aa9362af89db2662f1ab6a
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 4, 2024 https://github.com/canopen-python/canopen/pull/451#ref-pullrequest-2318661664
pdo: Skip saving if no COB-ID was set (fixes #445) #446 https://github.com/canopen-python/canopen/pull/446
acolombhttps://github.com/acolomb
June 4, 2024 14:32https://github.com/canopen-python/canopen/pull/451#commits-pushed-9220fd7
https://github.com/acolomb
Annotate PdoVariable.pdo_parent type.https://github.com/canopen-python/canopen/pull/451/commits/9220fd7b3b41f07b90f0e5de49a6f4c54872e1b3
9220fd7https://github.com/canopen-python/canopen/pull/451/commits/9220fd7b3b41f07b90f0e5de49a6f4c54872e1b3
https://github.com/acolomb
Remove unnecessary variable initialization.https://github.com/canopen-python/canopen/pull/451/commits/2a6049ddabc18583986a3df820ac54e8c02bbe17
2a6049dhttps://github.com/canopen-python/canopen/pull/451/commits/2a6049ddabc18583986a3df820ac54e8c02bbe17
https://github.com/bizfsc
https://github.com/acolomb
More __future__.annotations fixes and type hints for PDO code.https://github.com/canopen-python/canopen/pull/451/commits/bda53bba53446ecb51e0958137f5151ca59658c7
bda53bbhttps://github.com/canopen-python/canopen/pull/451/commits/bda53bba53446ecb51e0958137f5151ca59658c7
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 4, 2024https://github.com/canopen-python/canopen/pull/451#issuecomment-2148416299
#446https://github.com/canopen-python/canopen/pull/446
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
https://github.com/acolomb
Merge branch 'master' into sdo-typing-fixeshttps://github.com/canopen-python/canopen/pull/451/commits/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c
49c7bcbhttps://github.com/canopen-python/canopen/pull/451/commits/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 10, 2024https://github.com/canopen-python/canopen/pull/451#issuecomment-2159256656
@friederschuelerhttps://github.com/friederschueler
@sveinsehttps://github.com/sveinse
#455https://github.com/canopen-python/canopen/issues/455
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
https://github.com/acolomb
acolombhttps://github.com/acolomb
christiansandberghttps://github.com/christiansandberg
June 10, 2024 20:47https://github.com/canopen-python/canopen/pull/451#event-13107255875
https://github.com/acolomb
acolombhttps://github.com/acolomb
v2.3.0https://github.com/canopen-python/canopen/milestone/7
Jun 10, 2024https://github.com/canopen-python/canopen/pull/451#event-13107486870
https://github.com/sveinse
sveinsehttps://github.com/sveinse
Jun 10, 2024 https://github.com/canopen-python/canopen/pull/451#pullrequestreview-2108919855
View reviewed changes https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c
sveinsehttps://github.com/sveinse
https://github.com/canopen-python/canopen/pull/451#pullrequestreview-2108919855
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@acolombhttps://github.com/acolomb
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
canopen/pdo/base.pyhttps://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c#diff-d62a41e4e9731bf76223d66a600a1c3e6ff6130926cee6cc92c2c2f160c2b24e
sveinsehttps://github.com/sveinse
Jun 10, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1633944610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
acolombhttps://github.com/acolomb
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1634271794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#446 (comment)https://github.com/canopen-python/canopen/pull/446#discussion_r1615969558
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
friederschuelerhttps://github.com/friederschueler
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1634356321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
sveinsehttps://github.com/sveinse
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1635112516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
acolombhttps://github.com/acolomb
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1635361613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
canopen/sdo/base.pyhttps://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c#diff-a1846971546e90425222348abe3023b6b79a57214a15623630e5965d8868d140
sveinsehttps://github.com/sveinse
Jun 10, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1633974167
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
acolombhttps://github.com/acolomb
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#discussion_r1634274673
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#event-13111451944
https://github.com/acolomb
acolombhttps://github.com/acolomb
31de70chttps://github.com/canopen-python/canopen/commit/31de70c871f38fce6e07cf90f2d1b3ee2dca20ce
Jun 11, 2024https://github.com/canopen-python/canopen/pull/451#event-13111476962
https://github.com/acolomb
acolombhttps://github.com/acolomb
June 11, 2024 06:45https://github.com/canopen-python/canopen/pull/451#event-13111546971
https://github.com/acolomb
acolombhttps://github.com/acolomb
Jul 10, 2024 https://github.com/canopen-python/canopen/pull/451#ref-issue-1641128270
Type annotations in canopen #358 https://github.com/canopen-python/canopen/issues/358
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451
https://github.com/friederschueler
friederschueler https://github.com/friederschueler
https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c
https://github.com/sveinse
sveinse https://github.com/sveinse
https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c
https://github.com/christiansandberg
christiansandberg https://github.com/christiansandberg
v2.3.0 https://github.com/canopen-python/canopen/milestone/7
Please reload this pagehttps://github.com/canopen-python/canopen/pull/451
https://github.com/acolomb
https://github.com/friederschueler
https://github.com/sveinse
https://github.com/bizfsc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.