| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2b870b9f-077b-dde3-9a07-91e157c16634 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EA94:53774:2FEB9B9:406883B:6A5DB896 |
| html-safe-nonce | 0de73e574dfa55cb5541b31fc263d53882fe5b240c12b58a5a69ffe0139f8acd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTk0OjUzNzc0OjJGRUI5Qjk6NDA2ODgzQjo2QTVEQjg5NiIsInZpc2l0b3JfaWQiOiIxNzgxNzQwOTM3OTg0OTgxMTQyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1e872b34e0d8d5e0769ecc5f5cbef4a3135a1023f8a48461dd223ed0f3f6b24e |
| hovercard-subject-tag | pull_request:1902303941 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/451/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/855c6a6f1ca65723dbe859aeffb7ca15b02746050cac6b2122d97f87a8081e91/canopen-python/canopen/pull/451 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/855c6a6f1ca65723dbe859aeffb7ca15b02746050cac6b2122d97f87a8081e91/canopen-python/canopen/pull/451 |
| og:image:alt | Clarify that each SDO object has its corresponding OD entry linked in the .od attribute, not the whole ObjectDictionary.
__iter__() should return Iterator like in Mapping, not Iterable.
Use pos... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | acolomb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git |
| octolytics-dimension-user_id | 200581454 |
| octolytics-dimension-user_login | canopen-python |
| octolytics-dimension-repository_id | 68737600 |
| octolytics-dimension-repository_nwo | canopen-python/canopen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68737600 |
| octolytics-dimension-repository_network_root_nwo | canopen-python/canopen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/canopen-python/canopen/pull/451#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen |
| Reload | https://github.com/canopen-python/canopen/pull/451 |
| Reload | https://github.com/canopen-python/canopen/pull/451 |
| Reload | https://github.com/canopen-python/canopen/pull/451 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
|
canopen-python
| https://github.com/canopen-python |
| canopen | https://github.com/canopen-python/canopen |
|
Notifications
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Fork
359
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Star
560
| https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
53
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
20
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
0
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
|
Code
| https://github.com/canopen-python/canopen |
|
Issues
| https://github.com/canopen-python/canopen/issues |
|
Pull requests
| https://github.com/canopen-python/canopen/pulls |
|
Discussions
| https://github.com/canopen-python/canopen/discussions |
|
Actions
| https://github.com/canopen-python/canopen/actions |
|
Projects
| https://github.com/canopen-python/canopen/projects |
|
Security and quality
| https://github.com/canopen-python/canopen/security |
|
Insights
| https://github.com/canopen-python/canopen/pulse |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:sdo-typing-fixes | https://github.com/acolomb/canopen/tree/sdo-typing-fixes |
| Conversation | https://github.com/canopen-python/canopen/pull/451 |
| Commits8 (8) | https://github.com/canopen-python/canopen/pull/451/commits |
| Checks | https://github.com/canopen-python/canopen/pull/451/checks |
| Files changed | https://github.com/canopen-python/canopen/pull/451/files |
| Modernize type annotations and fix some discrepancies | https://github.com/canopen-python/canopen/pull/451#top |
| acolomb | https://github.com/acolomb |
| canopen-python:master | https://github.com/canopen-python/canopen/tree/master |
| acolomb:sdo-typing-fixes | https://github.com/acolomb/canopen/tree/sdo-typing-fixes |
|
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 4, 2024 | https://github.com/canopen-python/canopen/pull/451#issue-2332755628 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| acolomb | https://github.com/acolomb |
| June 4, 2024 09:18 | https://github.com/canopen-python/canopen/pull/451#commits-pushed-81c6b00 |
|
| https://github.com/acolomb |
| Fix type hints on SDO classes. | https://github.com/canopen-python/canopen/pull/451/commits/81c6b00368d827ebddbcd2855af0b0f198eb8bde |
| 81c6b00 | https://github.com/canopen-python/canopen/pull/451/commits/81c6b00368d827ebddbcd2855af0b0f198eb8bde |
|
| https://github.com/acolomb |
| Fix __iter__() return type annotation in PDO classes. | https://github.com/canopen-python/canopen/pull/451/commits/9c033d0b2b3f54d95abda8cb4067b069811af466 |
| 9c033d0 | https://github.com/canopen-python/canopen/pull/451/commits/9c033d0b2b3f54d95abda8cb4067b069811af466 |
|
| https://github.com/acolomb |
| Fix __iter__() return type annotation in Network and OD classes. | https://github.com/canopen-python/canopen/pull/451/commits/9880489701b6963c5895909e76c4d39c4dffc5d1 |
| 9880489 | https://github.com/canopen-python/canopen/pull/451/commits/9880489701b6963c5895909e76c4d39c4dffc5d1 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 4, 2024 | https://github.com/canopen-python/canopen/pull/451#issuecomment-2146803152 |
| #446 | https://github.com/canopen-python/canopen/pull/446 |
| @friederschueler | https://github.com/friederschueler |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
|
| https://github.com/acolomb |
| More __future__.annotations fixes. | https://github.com/canopen-python/canopen/pull/451/commits/04c02e1bcd2a862de3aa9362af89db2662f1ab6a |
| 04c02e1 | https://github.com/canopen-python/canopen/pull/451/commits/04c02e1bcd2a862de3aa9362af89db2662f1ab6a |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
Jun 4, 2024
| https://github.com/canopen-python/canopen/pull/451#ref-pullrequest-2318661664 |
|
pdo: Skip saving if no COB-ID was set (fixes #445)
#446
| https://github.com/canopen-python/canopen/pull/446 |
| acolomb | https://github.com/acolomb |
| June 4, 2024 14:32 | https://github.com/canopen-python/canopen/pull/451#commits-pushed-9220fd7 |
|
| https://github.com/acolomb |
| Annotate PdoVariable.pdo_parent type. | https://github.com/canopen-python/canopen/pull/451/commits/9220fd7b3b41f07b90f0e5de49a6f4c54872e1b3 |
| 9220fd7 | https://github.com/canopen-python/canopen/pull/451/commits/9220fd7b3b41f07b90f0e5de49a6f4c54872e1b3 |
|
| https://github.com/acolomb |
| Remove unnecessary variable initialization. | https://github.com/canopen-python/canopen/pull/451/commits/2a6049ddabc18583986a3df820ac54e8c02bbe17 |
| 2a6049d | https://github.com/canopen-python/canopen/pull/451/commits/2a6049ddabc18583986a3df820ac54e8c02bbe17 |
|
| https://github.com/bizfsc |
|
| https://github.com/acolomb |
| More __future__.annotations fixes and type hints for PDO code. | https://github.com/canopen-python/canopen/pull/451/commits/bda53bba53446ecb51e0958137f5151ca59658c7 |
| bda53bb | https://github.com/canopen-python/canopen/pull/451/commits/bda53bba53446ecb51e0958137f5151ca59658c7 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 4, 2024 | https://github.com/canopen-python/canopen/pull/451#issuecomment-2148416299 |
| #446 | https://github.com/canopen-python/canopen/pull/446 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
|
| https://github.com/acolomb |
| Merge branch 'master' into sdo-typing-fixes | https://github.com/canopen-python/canopen/pull/451/commits/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c |
| 49c7bcb | https://github.com/canopen-python/canopen/pull/451/commits/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 10, 2024 | https://github.com/canopen-python/canopen/pull/451#issuecomment-2159256656 |
| @friederschueler | https://github.com/friederschueler |
| @sveinse | https://github.com/sveinse |
| #455 | https://github.com/canopen-python/canopen/issues/455 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| christiansandberg | https://github.com/christiansandberg |
| June 10, 2024 20:47 | https://github.com/canopen-python/canopen/pull/451#event-13107255875 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| v2.3.0 | https://github.com/canopen-python/canopen/milestone/7 |
| Jun 10, 2024 | https://github.com/canopen-python/canopen/pull/451#event-13107486870 |
| https://github.com/sveinse |
| sveinse | https://github.com/sveinse |
|
Jun 10, 2024
| https://github.com/canopen-python/canopen/pull/451#pullrequestreview-2108919855 |
|
View reviewed changes
| https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c |
| sveinse | https://github.com/sveinse |
| https://github.com/canopen-python/canopen/pull/451#pullrequestreview-2108919855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @acolomb | https://github.com/acolomb |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| canopen/pdo/base.py | https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c#diff-d62a41e4e9731bf76223d66a600a1c3e6ff6130926cee6cc92c2c2f160c2b24e |
| sveinse | https://github.com/sveinse |
| Jun 10, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1633944610 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| acolomb | https://github.com/acolomb |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1634271794 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #446 (comment) | https://github.com/canopen-python/canopen/pull/446#discussion_r1615969558 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| friederschueler | https://github.com/friederschueler |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1634356321 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| sveinse | https://github.com/sveinse |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1635112516 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| acolomb | https://github.com/acolomb |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1635361613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| canopen/sdo/base.py | https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c#diff-a1846971546e90425222348abe3023b6b79a57214a15623630e5965d8868d140 |
| sveinse | https://github.com/sveinse |
| Jun 10, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1633974167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| acolomb | https://github.com/acolomb |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#discussion_r1634274673 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#event-13111451944 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| 31de70c | https://github.com/canopen-python/canopen/commit/31de70c871f38fce6e07cf90f2d1b3ee2dca20ce |
| Jun 11, 2024 | https://github.com/canopen-python/canopen/pull/451#event-13111476962 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
| June 11, 2024 06:45 | https://github.com/canopen-python/canopen/pull/451#event-13111546971 |
| https://github.com/acolomb |
| acolomb | https://github.com/acolomb |
|
Jul 10, 2024
| https://github.com/canopen-python/canopen/pull/451#ref-issue-1641128270 |
|
Type annotations in canopen
#358
| https://github.com/canopen-python/canopen/issues/358 |
| https://github.co/hiddenchars |
| https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F451 |
|
| https://github.com/friederschueler |
|
friederschueler
| https://github.com/friederschueler |
|
| https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c |
|
| https://github.com/sveinse |
|
sveinse
| https://github.com/sveinse |
|
| https://github.com/canopen-python/canopen/pull/451/files/49c7bcb1d52a7f9bb7c14b7c94ee130c43b3081c |
|
| https://github.com/christiansandberg |
|
christiansandberg
| https://github.com/christiansandberg |
|
v2.3.0
| https://github.com/canopen-python/canopen/milestone/7 |
| Please reload this page | https://github.com/canopen-python/canopen/pull/451 |
|
| https://github.com/acolomb |
|
| https://github.com/friederschueler |
|
| https://github.com/sveinse |
|
| https://github.com/bizfsc |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |