René's URL Explorer Experiment


Title: Check data length sdo server by samsamfire · Pull Request #338 · canopen-python/canopen · GitHub

Open Graph Title: Check data length sdo server by samsamfire · Pull Request #338 · canopen-python/canopen

X Title: Check data length sdo server by samsamfire · Pull Request #338 · canopen-python/canopen

Description: CANopen for Python. Contribute to canopen-python/canopen development by creating an account on GitHub.

Open Graph Description: Currently, if writing a value with the wrong size inside object dictionary, no errors are raised. This can cause all sorts of problem : for example when sending PDO frames, the frame could be great...

X Description: Currently, if writing a value with the wrong size inside object dictionary, no errors are raised. This can cause all sorts of problem : for example when sending PDO frames, the frame could be great...

Opengraph URL: https://github.com/canopen-python/canopen/pull/338

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6ea5d6bc-3333-e8a1-f725-91071aeae4b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC524:43F78:A5289B4:DE0A5E4:6A5E9DB9
html-safe-nonce7b1daaec369c1c33b66f246a181e2f4b5444b766d3804dd52b2f6c1cbc760a14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTI0OjQzRjc4OkE1Mjg5QjQ6REUwQTVFNDo2QTVFOURCOSIsInZpc2l0b3JfaWQiOiI5MjAyNzcwMDgxMjQ3ODI5NDMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9c63f7eb3c60f54ea478e1c7d43ac8b1acbad68410da349920d0850c82e76311
hovercard-subject-tagpull_request:1153813241
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/canopen-python/canopen/338/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97deee3df4faa2bfe2944e51df10f710f10e336f49f436a91b80aad47ace5e86/canopen-python/canopen/pull/338
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97deee3df4faa2bfe2944e51df10f710f10e336f49f436a91b80aad47ace5e86/canopen-python/canopen/pull/338
og:image:altCurrently, if writing a value with the wrong size inside object dictionary, no errors are raised. This can cause all sorts of problem : for example when sending PDO frames, the frame could be great...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesamsamfire
hostnamegithub.com
expected-hostnamegithub.com
None7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d
turbo-cache-controlno-cache
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2d2ac9bdd71d5f53f2b731c9330677e38624e301
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/338#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F338
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F338
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/338
Reloadhttps://github.com/canopen-python/canopen/pull/338
Reloadhttps://github.com/canopen-python/canopen/pull/338
Please reload this pagehttps://github.com/canopen-python/canopen/pull/338
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 561 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
christiansandberghttps://github.com/christiansandberg
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
samsamfire:masterhttps://github.com/samsamfire/canopen/tree/master
Conversationhttps://github.com/canopen-python/canopen/pull/338
Commits5 (5)https://github.com/canopen-python/canopen/pull/338/commits
Checkshttps://github.com/canopen-python/canopen/pull/338/checks
Files changedhttps://github.com/canopen-python/canopen/pull/338/files
Check data length sdo serverhttps://github.com/canopen-python/canopen/pull/338#top
christiansandberghttps://github.com/christiansandberg
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
samsamfire:masterhttps://github.com/samsamfire/canopen/tree/master
https://github.com/samsamfire
samsamfirehttps://github.com/samsamfire
Dec 8, 2022https://github.com/canopen-python/canopen/pull/338#issue-1484325193
Please reload this pagehttps://github.com/canopen-python/canopen/pull/338
samsamfirehttps://github.com/samsamfire
August 6, 2022 14:16https://github.com/canopen-python/canopen/pull/338#commits-pushed-be271ba
https://github.com/samsamfire
- Added retransmit functionnality to sdo block downloadhttps://github.com/canopen-python/canopen/pull/338/commits/be271ba5e3bc647b1fc94575dbf040692bdfbbd9
be271bahttps://github.com/canopen-python/canopen/pull/338/commits/be271ba5e3bc647b1fc94575dbf040692bdfbbd9
https://github.com/samsamfire
- changed from a retransmit_counter to boolhttps://github.com/canopen-python/canopen/pull/338/commits/658ae66aa9dc7d6d1717a94ddcdf53959235dade
658ae66https://github.com/canopen-python/canopen/pull/338/commits/658ae66aa9dc7d6d1717a94ddcdf53959235dade
https://github.com/samsamfire
- removed unnecessary list copy, and removed sdo abort that should on…https://github.com/canopen-python/canopen/pull/338/commits/af3d8e12de579645be5674dfac9968c18651cc08
af3d8e1https://github.com/canopen-python/canopen/pull/338/commits/af3d8e12de579645be5674dfac9968c18651cc08
https://github.com/samsamfire
- Added check in sdo server for the expected length of a downloaded v…https://github.com/canopen-python/canopen/pull/338/commits/bdbbc31d83a024350964c1bb89a9cf68365f0dc0
bdbbc31https://github.com/canopen-python/canopen/pull/338/commits/bdbbc31d83a024350964c1bb89a9cf68365f0dc0
https://github.com/samsamfire
Merge branch 'christiansandberg:master' into masterhttps://github.com/canopen-python/canopen/pull/338/commits/f049f0951fc2891187d0c3a0265ecca31293926f
f049f09https://github.com/canopen-python/canopen/pull/338/commits/f049f0951fc2891187d0c3a0265ecca31293926f
https://github.com/christiansandberg
christiansandberghttps://github.com/christiansandberg
Dec 9, 2022 https://github.com/canopen-python/canopen/pull/338#pullrequestreview-1212186790
View reviewed changes https://github.com/canopen-python/canopen/pull/338/files/f049f0951fc2891187d0c3a0265ecca31293926f
christiansandberghttps://github.com/christiansandberg
https://github.com/canopen-python/canopen/pull/338#pullrequestreview-1212186790
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/canopen-python/canopen/pull/338
https://github.com/acolomb
acolombhttps://github.com/acolomb
Dec 10, 2022 https://github.com/canopen-python/canopen/pull/338#pullrequestreview-1212551688
View reviewed changes https://github.com/canopen-python/canopen/pull/338/files/f049f0951fc2891187d0c3a0265ecca31293926f
https://github.com/acolomb
acolombhttps://github.com/acolomb
Dec 10, 2022https://github.com/canopen-python/canopen/pull/338#issuecomment-1345233151
Please reload this pagehttps://github.com/canopen-python/canopen/pull/338
https://github.com/christiansandberg
christiansandberghttps://github.com/christiansandberg
45c7cafhttps://github.com/canopen-python/canopen/commit/45c7caf8e72d4f3c07a20efe677095000c470a43
Dec 11, 2022https://github.com/canopen-python/canopen/pull/338#event-8008324268
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F338
https://github.com/christiansandberg
christiansandberg https://github.com/christiansandberg
https://github.com/canopen-python/canopen/pull/338/files/f049f0951fc2891187d0c3a0265ecca31293926f
https://github.com/acolomb
acolomb https://github.com/acolomb
https://github.com/canopen-python/canopen/pull/338/files/f049f0951fc2891187d0c3a0265ecca31293926f
Please reload this pagehttps://github.com/canopen-python/canopen/pull/338
https://github.com/samsamfire
https://github.com/acolomb
https://github.com/christiansandberg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.