René's URL Explorer Experiment


Title: eds: Fix exception in comment parsing with hexadecimal line count. by acolomb · Pull Request #279 · canopen-python/canopen · GitHub

Open Graph Title: eds: Fix exception in comment parsing with hexadecimal line count. by acolomb · Pull Request #279 · canopen-python/canopen

X Title: eds: Fix exception in comment parsing with hexadecimal line count. by acolomb · Pull Request #279 · canopen-python/canopen

Description: This fixes a bug introduced in #254, which immediately broke parsing of my EDS files. Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefixed with 0x. The ConfigParser.getint() method however does not support such a format. Switch to the default int() constructor with a base=0 argument to enable auto-detection of this condition. The same is done for basically every other numeric value in the EDS importer.

Open Graph Description: This fixes a bug introduced in #254, which immediately broke parsing of my EDS files. Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefi...

X Description: This fixes a bug introduced in #254, which immediately broke parsing of my EDS files. Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number p...

Opengraph URL: https://github.com/canopen-python/canopen/pull/279

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:770c0ba1-dd6a-0e6f-ee6a-5e0b83211ad4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id989C:2B893D:3312A5:446BF0:6A5ED911
html-safe-noncec7302266249ba8a657e4a21fae651d5726fc2d9edf32e338135f3bcb6bae44e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODlDOjJCODkzRDozMzEyQTU6NDQ2QkYwOjZBNUVEOTExIiwidmlzaXRvcl9pZCI6IjU0NzAwODU0NDI0ODUyNzg5OTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceec7ed02cc6177b1728815544e83935b23ad3c5af93bb4f30853d765c5b0ea3b
hovercard-subject-tagpull_request:776657676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/canopen-python/canopen/pull/279/files
twitter:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6996887?s=400&v=4
og:image:altThis fixes a bug introduced in #254, which immediately broke parsing of my EDS files. Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None82d0004a35927bdb00c652a57f456c55aa0eda4ade1bc7956d7510fdea6e454b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git
octolytics-dimension-user_id200581454
octolytics-dimension-user_logincanopen-python
octolytics-dimension-repository_id68737600
octolytics-dimension-repository_nwocanopen-python/canopen
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id68737600
octolytics-dimension-repository_network_root_nwocanopen-python/canopen
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released2d913dd727d2d7ac189fb4d05b10bc34ecd03ee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/canopen-python/canopen/pull/279/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F279%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcanopen-python%2Fcanopen%2Fpull%2F279%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=canopen-python%2Fcanopen
Reloadhttps://github.com/canopen-python/canopen/pull/279/files
Reloadhttps://github.com/canopen-python/canopen/pull/279/files
Reloadhttps://github.com/canopen-python/canopen/pull/279/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/279/files
canopen-python https://github.com/canopen-python
canopenhttps://github.com/canopen-python/canopen
Notifications https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Fork 359 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Star 562 https://github.com/login?return_to=%2Fcanopen-python%2Fcanopen
Code https://github.com/canopen-python/canopen
Issues 53 https://github.com/canopen-python/canopen/issues
Pull requests 20 https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality 0 https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Code https://github.com/canopen-python/canopen
Issues https://github.com/canopen-python/canopen/issues
Pull requests https://github.com/canopen-python/canopen/pulls
Discussions https://github.com/canopen-python/canopen/discussions
Actions https://github.com/canopen-python/canopen/actions
Projects https://github.com/canopen-python/canopen/projects
Security and quality https://github.com/canopen-python/canopen/security
Insights https://github.com/canopen-python/canopen/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fcanopen-python%2Fcanopen%2Fissues%2Fnew%2Fchoose
af-silvahttps://github.com/af-silva
canopen-python:masterhttps://github.com/canopen-python/canopen/tree/master
acolomb:fix-eds-linecount-crashhttps://github.com/acolomb/canopen/tree/fix-eds-linecount-crash
Conversation 2 https://github.com/canopen-python/canopen/pull/279
Commits 1 https://github.com/canopen-python/canopen/pull/279/commits
Checks 0 https://github.com/canopen-python/canopen/pull/279/checks
Files changed 1 https://github.com/canopen-python/canopen/pull/279/files
eds: Fix exception in comment parsing with hexadecimal line count. https://github.com/canopen-python/canopen/pull/279/files#top
Show all changes 1 commit https://github.com/canopen-python/canopen/pull/279/files
fba4fc9 eds: Fix exception in comment parsing with hexadecimal line count. acolomb Nov 9, 2021 https://github.com/canopen-python/canopen/pull/279/commits/fba4fc987574d74bc3815b121194c2473fee3f03
Clear filters https://github.com/canopen-python/canopen/pull/279/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/279/files
Please reload this pagehttps://github.com/canopen-python/canopen/pull/279/files
canopen/objectdictionary/eds.pyhttps://github.com/canopen-python/canopen/pull/279/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
View file https://github.com/acolomb/canopen/blob/fba4fc987574d74bc3815b121194c2473fee3f03/canopen/objectdictionary/eds.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/canopen-python/canopen/pull/279/{{ revealButtonHref }}
https://github.com/canopen-python/canopen/pull/279/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com/canopen-python/canopen/pull/279/files#diff-65e16349104aac0db9004b6c4f118415792a9f44defe3f38c635c781d4d94b71
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.