René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"LssMaster accumulates data with external LSS master","articleBody":"As #574 was closed there is a specific issue with `LssMaster` in the current implementation:\n\nIf this library is together with another LSS master present on the physical bus, the input queue of `LssMaster` will be filled up with CAN messages, eventually leading to memory overload. It is only emptied when the `LssMaster` is actively used to send LSS commands. This is because `Network` creates an `LssMaster` instance and activates the subscription to the LSS messages.\n\nhttps://github.com/canopen-python/canopen/blob/f1a71da20b918760ace20c62297f41132cd6618c/canopen/network.py#L53-L55\n\nhttps://github.com/canopen-python/canopen/blob/f1a71da20b918760ace20c62297f41132cd6618c/canopen/lss.py#L396-L397\n\nI think the simplest solution would be not to activate the subscription callback until `LssMaster.__send_command()` is called. It is also draining the queue at this point:\n\nhttps://github.com/canopen-python/canopen/blob/f1a71da20b918760ace20c62297f41132cd6618c/canopen/lss.py#L377-L379\n","author":{"url":"https://github.com/sveinse","@type":"Person","name":"sveinse"},"datePublished":"2025-04-27T21:45:42.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/577/canopen/issues/577"}