Title: Improve test coverage · Issue #514 · canopen-python/canopen · GitHub
Open Graph Title: Improve test coverage · Issue #514 · canopen-python/canopen
X Title: Improve test coverage · Issue #514 · canopen-python/canopen
Description: I'd like to raise the test suite cover more of the code base, as a part of the preparations for #358. Currently, coverage.py reports 73% code coverage when run locally: Name Stmts Miss Cover ----------------------------------------------...
Open Graph Description: I'd like to raise the test suite cover more of the code base, as a part of the preparations for #358. Currently, coverage.py reports 73% code coverage when run locally: Name Stmts Miss Cover ------...
X Description: I'd like to raise the test suite cover more of the code base, as a part of the preparations for #358. Currently, coverage.py reports 73% code coverage when run locally: Name Stmts Miss Cover --...
Opengraph URL: https://github.com/canopen-python/canopen/issues/514
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve test coverage","articleBody":"I'd like to raise the test suite cover more of the code base, as a part of the preparations for #358.\n\nCurrently, `coverage.py` reports 73% code coverage when run locally:\n\n```\nName Stmts Miss Cover\n-----------------------------------------------------------\ncanopen/__init__.py 12 2 83%\ncanopen/_version.py 11 2 82%\ncanopen/emcy.py 71 19 73%\ncanopen/lss.py 181 106 41%\ncanopen/network.py 165 21 87%\ncanopen/nmt.py 133 2 98%\ncanopen/node/__init__.py 2 0 100%\ncanopen/node/base.py 9 0 100%\ncanopen/node/local.py 81 10 88%\ncanopen/node/remote.py 81 37 54%\ncanopen/objectdictionary/__init__.py 306 37 88%\ncanopen/objectdictionary/datatypes.py 82 8 90%\ncanopen/objectdictionary/eds.py 349 38 89%\ncanopen/objectdictionary/epf.py 81 81 0%\ncanopen/pdo/__init__.py 36 8 78%\ncanopen/pdo/base.py 374 108 71%\ncanopen/profiles/__init__.py 0 0 100%\ncanopen/profiles/p402.py 277 176 36%\ncanopen/sdo/__init__.py 5 0 100%\ncanopen/sdo/base.py 93 20 78%\ncanopen/sdo/client.py 461 92 80%\ncanopen/sdo/constants.py 27 0 100%\ncanopen/sdo/exceptions.py 14 5 64%\ncanopen/sdo/server.py 127 9 93%\ncanopen/sync.py 19 7 63%\ncanopen/timestamp.py 15 0 100%\ncanopen/utils.py 13 1 92%\ncanopen/variable.py 98 42 57%\n-----------------------------------------------------------\nTOTAL 3123 831 73%\n```\n\n73% is very promising; getting up to 80% is the next milestone.\n\nIn #504, I raised the coverage of `canopen/nmt.py` to 98%. I'm going to continue with `canopen/network.py` (anticipate PR in a day or two). Feel free to join!\n\nI'll update this list as progress is made:\n\n- [x] `canopen/emcy.py`: WIP\n- [x] `canopen/lss.py`\n- [x] `canopen/network.py`:\n - #515\n - #517\n- [x] `canopen/nmt.py`: #504\n- [x] `canopen/node/base.py`\n- [x] `canopen/node/local.py`\n- [ ] `canopen/node/remote.py`\n- [ ] `canopen/objectdictionary/__init__.py`\n- [ ] `canopen/objectdictionary/datatypes.py`\n- [x] `canopen/objectdictionary/eds.py`\n- [ ] `canopen/objectdictionary/epf.py`\n- [ ] `canopen/pdo/__init__.py`\n- [ ] `canopen/pdo/base.py`\n- [ ] `canopen/profiles/p402.py`\n- [ ] `canopen/sdo/base.py`\n- [ ] `canopen/sdo/client.py`\n- [x] `canopen/sdo/constants.py`\n- [ ] `canopen/sdo/exceptions.py`\n- [ ] `canopen/sdo/server.py`\n- [x] `canopen/sync.py`: WIP\n- [x] `canopen/timestamp.py`\n- [ ] `canopen/utils.py`\n- [ ] `canopen/variable.py`","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2024-07-10T22:07:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/514/canopen/issues/514"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:86770516-31d4-8dce-a38b-2bbda9f5e902 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 901A:2658D0:6D05F28:957BD94:6A5EAA2E |
| html-safe-nonce | fe4dd652e044b3250eb0956caa6c4ed7cbb045167df720ba3c25415d5bf2734f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDFBOjI2NThEMDo2RDA1RjI4Ojk1N0JEOTQ6NkE1RUFBMkUiLCJ2aXNpdG9yX2lkIjoiMTg1OTE5MzM0NTk1NDE5NjAxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37a6f85871d3e8e1ee4d08cdc93cd0d6886532e9b85e6c1faa9bcec9a32eacab |
| hovercard-subject-tag | issue:2401820395 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/canopen-python/canopen/514/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cbf47c7b94b02e81f2f1f4e811fa6d75969e7ad1539d554a9641c6aec1756cce/canopen-python/canopen/issues/514 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cbf47c7b94b02e81f2f1f4e811fa6d75969e7ad1539d554a9641c6aec1756cce/canopen-python/canopen/issues/514 |
| og:image:alt | I'd like to raise the test suite cover more of the code base, as a part of the preparations for #358. Currently, coverage.py reports 73% code coverage when run locally: Name Stmts Miss Cover ------... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erlend-aasland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7c7e31acb6a895494e518b880f5ccf39604f7fa9a8f2f3c64145efc3b776256d |
| turbo-cache-control | no-preview |
| go-import | github.com/canopen-python/canopen git https://github.com/canopen-python/canopen.git |
| octolytics-dimension-user_id | 200581454 |
| octolytics-dimension-user_login | canopen-python |
| octolytics-dimension-repository_id | 68737600 |
| octolytics-dimension-repository_nwo | canopen-python/canopen |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 68737600 |
| octolytics-dimension-repository_network_root_nwo | canopen-python/canopen |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d2ac9bdd71d5f53f2b731c9330677e38624e301 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width