René's URL Explorer Experiment

Title: Saving dynamic/empty PDOs: TypeError: unsupported operand type(s) for |: 'NoneType' and 'int' · Issue #445 · canopen-python/canopen · GitHub

Open Graph Title: Saving dynamic/empty PDOs: TypeError: unsupported operand type(s) for |: 'NoneType' and 'int' · Issue #445 · canopen-python/canopen

X Title: Saving dynamic/empty PDOs: TypeError: unsupported operand type(s) for |: 'NoneType' and 'int' · Issue #445 · canopen-python/canopen

Description: Currently, if you have dynamic PDOs, which are only defined but not configured in the EDS-File, you can not save them, because they are initialized with cob_id = None, which can not be compared in this loc in pdo/base.py:376 self.com_rec...

Open Graph Description: Currently, if you have dynamic PDOs, which are only defined but not configured in the EDS-File, you can not save them, because they are initialized with cob_id = None, which can not be compared in ...

X Description: Currently, if you have dynamic PDOs, which are only defined but not configured in the EDS-File, you can not save them, because they are initialized with cob_id = None, which can not be compared in ...

Opengraph URL: https://github.com/canopen-python/canopen/issues/445

X: @github

direct link

Domain: github.com

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Saving dynamic/empty PDOs: TypeError: unsupported operand type(s) for |: 'NoneType' and 'int'","articleBody":"Currently, if you have dynamic PDOs, which are only defined but not configured in the EDS-File, you can not save them, because they are initialized with cob_id = None, which can not be compared in this loc in pdo/base.py:376\r\n\r\n`self.com_record[1].raw = self.cob_id | PDO_NOT_VALID | (RTR_NOT_ALLOWED if not self.rtr_allowed else 0x0)`\r\n     \r\nAlso, map is initilized with [], but the save-check checks for None, which is never the case, so all pdo will be saved, even if they are empty.\r\n\r\nTest to reproduce:\r\n\r\n```\r\n    def test_save_pdo(self):\r\n        node = canopen.Node(1, EDS_PATH)\r\n        node.tpdo.save()\r\n        node.rpdo.save()\r\n```","author":{"url":"https://github.com/friederschueler","@type":"Person","name":"friederschueler"},"datePublished":"2024-05-27T08:50:18.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/445/canopen/issues/445"}

Links:

Viewport: width=device-width