René's URL Explorer Experiment


Title: Make the rate limiters follow DateTime::setTestNow() by dereuromark · Pull Request #19799 · cakephp/cakephp · GitHub

Open Graph Title: Make the rate limiters follow DateTime::setTestNow() by dereuromark · Pull Request #19799 · cakephp/cakephp

X Title: Make the rate limiters follow DateTime::setTestNow() by dereuromark · Pull Request #19799 · cakephp/cakephp

Description: CakePHP: The Rapid Development Framework for PHP - Official Repository - Make the rate limiters follow DateTime::setTestNow() by dereuromark · Pull Request #19799 · cakephp/cakephp

Open Graph Description: Fixes #19798. FixedWindowRateLimiter and SlidingWindowRateLimiter read the time with time(), TokenBucketRateLimiter with microtime(true), and RateLimitMiddleware used time() for Retry-After. DateTi...

X Description: Fixes #19798. FixedWindowRateLimiter and SlidingWindowRateLimiter read the time with time(), TokenBucketRateLimiter with microtime(true), and RateLimitMiddleware used time() for Retry-After. DateTi...

Opengraph URL: https://github.com/cakephp/cakephp/pull/19799

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2e54e94a-a98c-8b82-28b2-510bc11c0d23
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD69A:9E9AB:5A8905:7CA2C8:6AFD3D4D
html-safe-nonce63d198138ae27d1b68aae7fe10079a0acee76aa189aa31b1b19175692973cb80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjlBOjlFOUFCOjVBODkwNTo3Q0EyQzg6NkFGRDNENEQiLCJ2aXNpdG9yX2lkIjoiMjA0NzU2MTQzMzIyMjAzNjgxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0f171d0dc630036852cab0809f556c7da034018ca0033aa83f7cdbad1ea690fe
hovercard-subject-tagpull_request:5277733030
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cakephp/cakephp/19799/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/393de0311bc612dc66a9446125f6a66a06940531bd259a440858a7a390ea9694/cakephp/cakephp/pull/19799
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/393de0311bc612dc66a9446125f6a66a06940531bd259a440858a7a390ea9694/cakephp/cakephp/pull/19799
og:image:altFixes #19798. FixedWindowRateLimiter and SlidingWindowRateLimiter read the time with time(), TokenBucketRateLimiter with microtime(true), and RateLimitMiddleware used time() for Retry-After. DateTi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedereuromark
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-cache
go-importgithub.com/cakephp/cakephp git https://github.com/cakephp/cakephp.git
octolytics-dimension-user_id23666
octolytics-dimension-user_logincakephp
octolytics-dimension-repository_id656494
octolytics-dimension-repository_nwocakephp/cakephp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id656494
octolytics-dimension-repository_network_root_nwocakephp/cakephp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/cakephp/cakephp/pull/19799#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cakephp%2Fcakephp
Reloadhttps://github.com/cakephp/cakephp/pull/19799
Reloadhttps://github.com/cakephp/cakephp/pull/19799
Reloadhttps://github.com/cakephp/cakephp/pull/19799
cakephphttps://github.com/cakephp
cakephphttps://github.com/cakephp/cakephp
Codehttps://github.com/cakephp/cakephp
Issues13 (13)https://github.com/cakephp/cakephp/issues
Pull requests16 (16)https://github.com/cakephp/cakephp/pulls
Actionshttps://github.com/cakephp/cakephp/actions
Projectshttps://github.com/cakephp/cakephp/projects
Wikihttps://github.com/cakephp/cakephp/wiki
Security and quality6 (6)https://github.com/cakephp/cakephp/security
Insightshttps://github.com/cakephp/cakephp/insights
https://github.com/cakephp/cakephp
dereuromarkhttps://github.com/dereuromark
5.xhttps://github.com/cakephp/cakephp/tree/5.x
5.x-rate-limit-test-nowhttps://github.com/cakephp/cakephp/tree/5.x-rate-limit-test-now
Conversationhttps://github.com/cakephp/cakephp/pull/19799
Commits4 (4)https://github.com/cakephp/cakephp/pull/19799/commits
Checkshttps://github.com/cakephp/cakephp/pull/19799/checks
Files changedhttps://github.com/cakephp/cakephp/pull/19799/files
Make the rate limiters follow DateTime::setTestNow()https://github.com/cakephp/cakephp/pull/19799#top
dereuromarkhttps://github.com/dereuromark
5.xhttps://github.com/cakephp/cakephp/tree/5.x
5.x-rate-limit-test-nowhttps://github.com/cakephp/cakephp/tree/5.x-rate-limit-test-now
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
Nov 12, 2026https://github.com/cakephp/cakephp/pull/19799#issue-6350202699
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
#19798https://github.com/cakephp/cakephp/issues/19798
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/dereuromark
Read the clock from DateTime::now() in the rate limitershttps://github.com/cakephp/cakephp/pull/19799/commits/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14
e1e2fb2https://github.com/cakephp/cakephp/pull/19799/commits/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
5.4.5https://github.com/cakephp/cakephp/milestone/362
Nov 12, 2026https://github.com/cakephp/cakephp/pull/19799#event-35913383630
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
testing https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Atesting
middleware https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware
Nov 12, 2026https://github.com/cakephp/cakephp/pull/19799#event-35913383683
https://github.com/othercorey
othercoreyhttps://github.com/othercorey
Nov 12, 2026 https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5880956590
View reviewed changes https://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14
src/Http/Middleware/RateLimitMiddleware.phphttps://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14#diff-6e09dba788b742e0010c694b0dfe4b7d336f423710f54eea18c751be0e86806f
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/dereuromark
Require cakephp/i18n in the http packagehttps://github.com/cakephp/cakephp/pull/19799/commits/3014ecb696eb59abea30c416086a08854127d161
3014ecbhttps://github.com/cakephp/cakephp/pull/19799/commits/3014ecb696eb59abea30c416086a08854127d161
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
Nov 12, 2026 https://github.com/cakephp/cakephp/pull/19799#ref-issue-6358266213
Split packages use other packages they do not declare #19802 https://github.com/cakephp/cakephp/issues/19802
https://github.com/ADmad
ADmadhttps://github.com/ADmad
Nov 13, 2026https://github.com/cakephp/cakephp/pull/19799#issuecomment-6844241191
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/othercorey
othercoreyhttps://github.com/othercorey
Nov 13, 2026https://github.com/cakephp/cakephp/pull/19799#issuecomment-6845117142
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/ADmad
ADmadhttps://github.com/ADmad
Nov 13, 2026https://github.com/cakephp/cakephp/pull/19799#issuecomment-6846492430
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
Nov 13, 2026https://github.com/cakephp/cakephp/pull/19799#issuecomment-6851786282
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/dereuromark
Use the test clock only when cakephp/i18n is installedhttps://github.com/cakephp/cakephp/pull/19799/commits/698ab9f8b2eb1991b4652f4030f943b87068cec0
698ab9fhttps://github.com/cakephp/cakephp/pull/19799/commits/698ab9f8b2eb1991b4652f4030f943b87068cec0
https://github.com/ADmad
ADmadhttps://github.com/ADmad
Nov 13, 2026 https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5890399509
View reviewed changes https://github.com/cakephp/cakephp/pull/19799/files/698ab9f8b2eb1991b4652f4030f943b87068cec0
Make cakephp/i18n optional for Response and the CSRF middlewares #19804 https://github.com/cakephp/cakephp/pull/19804
List optional Cake packages under suggest in the split packages #19806 https://github.com/cakephp/cakephp/pull/19806
https://github.com/dereuromark
Collapse the clock fallback into one expressionhttps://github.com/cakephp/cakephp/pull/19799/commits/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f
6eba52ahttps://github.com/cakephp/cakephp/pull/19799/commits/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f
https://github.com/markstory
markstoryhttps://github.com/markstory
Nov 14, 2026 https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5901619988
View reviewed changes https://github.com/cakephp/cakephp/pull/19799/files/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f
https://github.com/LordSimal
LordSimalhttps://github.com/LordSimal
Nov 17, 2026https://github.com/cakephp/cakephp/pull/19799#issuecomment-6958767179
@dereuromarkhttps://github.com/dereuromark
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.co/hiddenchars
https://github.com/cakephp/cakephp/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799
https://github.com/markstory
markstory https://github.com/markstory
https://github.com/cakephp/cakephp/pull/19799/files/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f
https://github.com/ADmad
ADmad https://github.com/ADmad
https://github.com/cakephp/cakephp/pull/19799/files/698ab9f8b2eb1991b4652f4030f943b87068cec0
https://github.com/othercorey
othercorey https://github.com/othercorey
https://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
middleware https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware
testing https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Atesting
5.4.5 https://github.com/cakephp/cakephp/milestone/362
RateLimit: rate limiters use time(), so DateTime::setTestNow() can't freeze them https://github.com/cakephp/cakephp/issues/19798
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19799
https://github.com/dereuromark
https://github.com/ADmad
https://github.com/othercorey
https://github.com/LordSimal
https://github.com/markstory
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.