| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2e54e94a-a98c-8b82-28b2-510bc11c0d23 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D69A:9E9AB:5A8905:7CA2C8:6AFD3D4D |
| html-safe-nonce | 63d198138ae27d1b68aae7fe10079a0acee76aa189aa31b1b19175692973cb80 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjlBOjlFOUFCOjVBODkwNTo3Q0EyQzg6NkFGRDNENEQiLCJ2aXNpdG9yX2lkIjoiMjA0NzU2MTQzMzIyMjAzNjgxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0f171d0dc630036852cab0809f556c7da034018ca0033aa83f7cdbad1ea690fe |
| hovercard-subject-tag | pull_request:5277733030 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cakephp/cakephp/19799/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/393de0311bc612dc66a9446125f6a66a06940531bd259a440858a7a390ea9694/cakephp/cakephp/pull/19799 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/393de0311bc612dc66a9446125f6a66a06940531bd259a440858a7a390ea9694/cakephp/cakephp/pull/19799 |
| og:image:alt | Fixes #19798.
FixedWindowRateLimiter and SlidingWindowRateLimiter read the time with time(), TokenBucketRateLimiter with microtime(true), and RateLimitMiddleware used time() for Retry-After. DateTi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dereuromark |
| hostname | github.com |
| expected-hostname | github.com |
| None | bdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474 |
| turbo-cache-control | no-cache |
| go-import | github.com/cakephp/cakephp git https://github.com/cakephp/cakephp.git |
| octolytics-dimension-user_id | 23666 |
| octolytics-dimension-user_login | cakephp |
| octolytics-dimension-repository_id | 656494 |
| octolytics-dimension-repository_nwo | cakephp/cakephp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 656494 |
| octolytics-dimension-repository_network_root_nwo | cakephp/cakephp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 556dd37bb0aceffb25724e151b5d858b3265b40b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/cakephp/cakephp/pull/19799#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cakephp%2Fcakephp |
| Reload | https://github.com/cakephp/cakephp/pull/19799 |
| Reload | https://github.com/cakephp/cakephp/pull/19799 |
| Reload | https://github.com/cakephp/cakephp/pull/19799 |
| cakephp | https://github.com/cakephp |
| cakephp | https://github.com/cakephp/cakephp |
| Code | https://github.com/cakephp/cakephp |
| Issues13 (13) | https://github.com/cakephp/cakephp/issues |
| Pull requests16 (16) | https://github.com/cakephp/cakephp/pulls |
| Actions | https://github.com/cakephp/cakephp/actions |
| Projects | https://github.com/cakephp/cakephp/projects |
| Wiki | https://github.com/cakephp/cakephp/wiki |
| Security and quality6 (6) | https://github.com/cakephp/cakephp/security |
| Insights | https://github.com/cakephp/cakephp/insights |
| https://github.com/cakephp/cakephp |
| dereuromark | https://github.com/dereuromark |
| 5.x | https://github.com/cakephp/cakephp/tree/5.x |
| 5.x-rate-limit-test-now | https://github.com/cakephp/cakephp/tree/5.x-rate-limit-test-now |
| Conversation | https://github.com/cakephp/cakephp/pull/19799 |
| Commits4 (4) | https://github.com/cakephp/cakephp/pull/19799/commits |
| Checks | https://github.com/cakephp/cakephp/pull/19799/checks |
| Files changed | https://github.com/cakephp/cakephp/pull/19799/files |
| Make the rate limiters follow DateTime::setTestNow() | https://github.com/cakephp/cakephp/pull/19799#top |
| dereuromark | https://github.com/dereuromark |
| 5.x | https://github.com/cakephp/cakephp/tree/5.x |
| 5.x-rate-limit-test-now | https://github.com/cakephp/cakephp/tree/5.x-rate-limit-test-now |
|
| https://github.com/dereuromark |
| dereuromark | https://github.com/dereuromark |
| Nov 12, 2026 | https://github.com/cakephp/cakephp/pull/19799#issue-6350202699 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
| #19798 | https://github.com/cakephp/cakephp/issues/19798 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
|
| https://github.com/dereuromark |
| Read the clock from DateTime::now() in the rate limiters | https://github.com/cakephp/cakephp/pull/19799/commits/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14 |
| e1e2fb2 | https://github.com/cakephp/cakephp/pull/19799/commits/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14 |
| https://github.com/dereuromark |
| dereuromark | https://github.com/dereuromark |
| 5.4.5 | https://github.com/cakephp/cakephp/milestone/362 |
| Nov 12, 2026 | https://github.com/cakephp/cakephp/pull/19799#event-35913383630 |
| https://github.com/dereuromark |
| dereuromark | https://github.com/dereuromark |
|
testing
| https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Atesting |
|
middleware
| https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware |
| Nov 12, 2026 | https://github.com/cakephp/cakephp/pull/19799#event-35913383683 |
| https://github.com/othercorey |
| othercorey | https://github.com/othercorey |
|
Nov 12, 2026
| https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5880956590 |
|
View reviewed changes
| https://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14 |
| src/Http/Middleware/RateLimitMiddleware.php | https://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14#diff-6e09dba788b742e0010c694b0dfe4b7d336f423710f54eea18c751be0e86806f |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
|
| https://github.com/dereuromark |
| Require cakephp/i18n in the http package | https://github.com/cakephp/cakephp/pull/19799/commits/3014ecb696eb59abea30c416086a08854127d161 |
| 3014ecb | https://github.com/cakephp/cakephp/pull/19799/commits/3014ecb696eb59abea30c416086a08854127d161 |
| https://github.com/dereuromark |
| dereuromark | https://github.com/dereuromark |
|
Nov 12, 2026
| https://github.com/cakephp/cakephp/pull/19799#ref-issue-6358266213 |
|
Split packages use other packages they do not declare
#19802
| https://github.com/cakephp/cakephp/issues/19802 |
| https://github.com/ADmad |
| ADmad | https://github.com/ADmad |
| Nov 13, 2026 | https://github.com/cakephp/cakephp/pull/19799#issuecomment-6844241191 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
| https://github.com/othercorey |
| othercorey | https://github.com/othercorey |
| Nov 13, 2026 | https://github.com/cakephp/cakephp/pull/19799#issuecomment-6845117142 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
| https://github.com/ADmad |
| ADmad | https://github.com/ADmad |
| Nov 13, 2026 | https://github.com/cakephp/cakephp/pull/19799#issuecomment-6846492430 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
| https://github.com/dereuromark |
| dereuromark | https://github.com/dereuromark |
| Nov 13, 2026 | https://github.com/cakephp/cakephp/pull/19799#issuecomment-6851786282 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
|
| https://github.com/dereuromark |
| Use the test clock only when cakephp/i18n is installed | https://github.com/cakephp/cakephp/pull/19799/commits/698ab9f8b2eb1991b4652f4030f943b87068cec0 |
| 698ab9f | https://github.com/cakephp/cakephp/pull/19799/commits/698ab9f8b2eb1991b4652f4030f943b87068cec0 |
| https://github.com/ADmad |
| ADmad | https://github.com/ADmad |
|
Nov 13, 2026
| https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5890399509 |
|
View reviewed changes
| https://github.com/cakephp/cakephp/pull/19799/files/698ab9f8b2eb1991b4652f4030f943b87068cec0 |
|
Make cakephp/i18n optional for Response and the CSRF middlewares
#19804
| https://github.com/cakephp/cakephp/pull/19804 |
|
List optional Cake packages under suggest in the split packages
#19806
| https://github.com/cakephp/cakephp/pull/19806 |
|
| https://github.com/dereuromark |
| Collapse the clock fallback into one expression | https://github.com/cakephp/cakephp/pull/19799/commits/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f |
| 6eba52a | https://github.com/cakephp/cakephp/pull/19799/commits/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f |
| https://github.com/markstory |
| markstory | https://github.com/markstory |
|
Nov 14, 2026
| https://github.com/cakephp/cakephp/pull/19799#pullrequestreview-5901619988 |
|
View reviewed changes
| https://github.com/cakephp/cakephp/pull/19799/files/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f |
| https://github.com/LordSimal |
| LordSimal | https://github.com/LordSimal |
| Nov 17, 2026 | https://github.com/cakephp/cakephp/pull/19799#issuecomment-6958767179 |
| @dereuromark | https://github.com/dereuromark |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
| https://github.co/hiddenchars |
| https://github.com/cakephp/cakephp/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19799 |
|
| https://github.com/markstory |
|
markstory
| https://github.com/markstory |
|
| https://github.com/cakephp/cakephp/pull/19799/files/6eba52ae3cee5223cb8d52f3ea7b3c1caf20bc0f |
|
| https://github.com/ADmad |
|
ADmad
| https://github.com/ADmad |
|
| https://github.com/cakephp/cakephp/pull/19799/files/698ab9f8b2eb1991b4652f4030f943b87068cec0 |
|
| https://github.com/othercorey |
|
othercorey
| https://github.com/othercorey |
|
| https://github.com/cakephp/cakephp/pull/19799/files/e1e2fb2eaef5f8aa2ba7c913d8b09c95a511dc14 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
|
middleware
| https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware |
|
testing
| https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Atesting |
|
5.4.5
| https://github.com/cakephp/cakephp/milestone/362 |
|
RateLimit: rate limiters use time(), so DateTime::setTestNow() can't freeze them
| https://github.com/cakephp/cakephp/issues/19798 |
| Please reload this page | https://github.com/cakephp/cakephp/pull/19799 |
|
| https://github.com/dereuromark |
|
| https://github.com/ADmad |
|
| https://github.com/othercorey |
|
| https://github.com/LordSimal |
|
| https://github.com/markstory |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |